fenge 0.7.4 → 0.7.6

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # fenge
 
+## 0.7.6
+
+### Patch Changes
+
+- 5c5cbc9: fix: correct exit code
+- Updated dependencies [db50469]
+  - @fenge/eslint-config@0.6.6
+
+## 0.7.5
+
+### Patch Changes
+
+- @fenge/eslint-config@0.6.5
+
 ## 0.7.4
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fenge",
-  "version": "0.7.4",
+  "version": "0.7.6",
   "description": "A CLI tool for code quality",
   "keywords": [
     "cli",
@@ -51,14 +51,14 @@
     "ora": "8.2.0",
     "prettier": "3.5.3",
     "yoctocolors": "2.1.1",
-    "@fenge/eslint-config": "0.6.4",
+    "@fenge/eslint-config": "0.6.6",
     "@fenge/prettier-config": "0.3.0",
     "@fenge/tsconfig": "0.5.0",
-    "@fenge/types": "0.3.0",
-    "prettier-ignore": "0.3.0"
+    "prettier-ignore": "0.3.0",
+    "@fenge/types": "0.3.0"
   },
   "devDependencies": {
-    "@types/node": "22.13.10"
+    "@types/node": "22.14.1"
   },
   "peerDependencies": {
     "typescript": "^5.7.0"

package/src/bin/fenge.cli.js

@@ -1,5 +1,6 @@
 #!/usr/bin/env node
 // @ts-check
+import os from "node:os";
 import process from "node:process";
 import { initAction, setup } from "@fenge/tsconfig/setup";
 import { Command } from "commander";
@@ -9,6 +10,22 @@ import { install } from "../command/install.js";
 import { lint } from "../command/lint.js";
 import { uninstall } from "../command/uninstall.js";
 
+/**
+ * @param {{code: number|null, signal: NodeJS.Signals | null}} param
+ * @returns {never}
+ */
+function exit({ code, signal }) {
+  if (code !== null) {
+    process.exit(code);
+  } else if (signal !== null) {
+    process.exit(128 + os.constants.signals[signal]);
+  } else {
+    throw new Error(
+      "Internal Error. Code and signal should not be null at the same time.",
+    );
+  }
+}
+
 const program = new Command().enablePositionalOptions();
 
 program
@@ -35,11 +52,14 @@ program
   )
   .argument("[paths...]", "dir or file paths to format and lint")
   .action(async (paths, options) => {
-    let code = (await format(paths, options)) || (await lint(paths, options));
-    if (options.fix || options.update) {
-      code ||= await format(paths, options);
+    let result = await format(paths, options);
+    if (result.code === 0) {
+      result = await lint(paths, options);
+      if (result.code === 0) {
+        result = await format(paths, options);
+      }
     }
-    process.exit(code);
+    exit(result);
   });
 
 program
@@ -58,7 +78,7 @@ program
     "print what command will be executed under the hood instead of executing",
   )
   .argument("[paths...]", "dir or file paths to lint")
-  .action(async (paths, options) => process.exit(await lint(paths, options)));
+  .action(async (paths, options) => exit(await lint(paths, options)));
 
 program
   .command("format")
@@ -75,7 +95,7 @@ program
     "print what command will be executed under the hood instead of executing",
   )
   .argument("[paths...]", "dir or file paths to format")
-  .action(async (paths, options) => process.exit(await format(paths, options)));
+  .action(async (paths, options) => exit(await format(paths, options)));
 
 program
   .command("install")

package/src/utils.js

@@ -58,7 +58,7 @@ function getSpentTime(startTime) {
 /**
  * @param {string[]} command
  * @param {{topic: string, dryRun: boolean, env: Record<string, string>}} options
- * @returns {Promise<number>}
+ * @returns {Promise<{code: number|null, signal: NodeJS.Signals | null}>}
  */
 export function execAsync(command, { topic, dryRun, env }) {
   return new Promise((resolve, reject) => {
@@ -70,11 +70,14 @@ export function execAsync(command, { topic, dryRun, env }) {
     }
     if (dryRun) {
       process.stdout.write(`${colors.green(cmd)} ${args.join(" ")};\n\n`);
-      return resolve(0);
+      return resolve({ code: 0, signal: null });
     }
 
     const spinner = ora(`${topic}...`).start();
-    const cp = childProcess.spawn(cmd, args, {
+    /**
+     * @type {childProcess.ChildProcessWithoutNullStreams | undefined}
+     */
+    let cp = childProcess.spawn(cmd, args, {
       env: { FORCE_COLOR: "true", ...process.env, ...env },
     });
     let stdout = Buffer.alloc(0);
@@ -86,18 +89,13 @@ export function execAsync(command, { topic, dryRun, env }) {
       stderr = Buffer.concat([stderr, data]);
     });
     cp.on("error", (err) => {
-      spinner.fail(
-        `${topic} got error in ${colors.yellow(getSpentTime(startTime))}`,
-      );
-      process.stderr.write(err.message);
-      resolve(getExitCode(err));
+      reject(err);
     });
     // Why not listen to the 'exit' event?
     // 1. The 'close' event will always emit after 'exit' was already emitted, or 'error' if the child failed to spawn.
     // 2. The 'exit' event may or may not fire after an error has occurred.
     cp.on("close", (code, signal) => {
-      const exitCode = getExitCode({ code, signal });
-      if (exitCode === 0) {
+      if (code === 0) {
         spinner.succeed(
           `${topic} succeeded in ${colors.yellow(getSpentTime(startTime))}`,
         );
@@ -108,27 +106,17 @@ export function execAsync(command, { topic, dryRun, env }) {
       }
       process.stdout.write(stdout);
       process.stderr.write(stderr);
-      resolve(exitCode);
+      cp = undefined; // When the cp exited, we should clean cp to prevent memory leak.
+      resolve({ code, signal });
     });
-    process.on("SIGINT", () => !cp.killed && cp.kill("SIGINT"));
-    process.on("SIGTERM", () => !cp.killed && cp.kill("SIGTERM"));
-  });
-}
 
-/**
- * @param {object} error
- */
-function getExitCode(error) {
-  if ("signal" in error && error.signal === "SIGINT") {
-    return 2;
-  }
-  if ("signal" in error && error.signal === "SIGTERM") {
-    return 15;
-  }
-  if ("code" in error && typeof error.code === "number") {
-    return error.code;
-  }
-  return 1;
+    /**
+     * @param {NodeJS.Signals} signal
+     */
+    const listener = (signal) => cp && !cp.killed && cp.kill(signal);
+    process.on("SIGINT", listener);
+    process.on("SIGTERM", listener);
+  });
 }
 
 /**