fenge 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # fenge
 
+## 0.5.3
+
+### Patch Changes
+
+- ee96c15: chore: upgrade deps
+- e0456a0: feat(fenge): support `--timing` option for CLI
+- 8de30ed: fix(fenge): fix the problem that eslint messages disappear sometimes when error occurs
+- Updated dependencies [ee96c15]
+- Updated dependencies [67f3677]
+- Updated dependencies [3927795]
+  - @fenge/prettier-config@0.2.2
+  - @fenge/eslint-config@0.5.10
+
 ## 0.5.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fenge",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "A CLI tool for code quality",
   "keywords": [
     "cli",
@@ -49,10 +49,10 @@
     "lilconfig": "3.1.3",
     "lint-staged": "15.4.3",
     "ora": "8.2.0",
-    "prettier": "3.5.2",
+    "prettier": "3.5.3",
     "yoctocolors": "2.1.1",
-    "@fenge/eslint-config": "0.5.9",
-    "@fenge/prettier-config": "0.2.1",
+    "@fenge/eslint-config": "0.5.10",
+    "@fenge/prettier-config": "0.2.2",
     "@fenge/tsconfig": "0.3.2",
     "@fenge/types": "0.2.0",
     "prettier-ignore": "0.2.0"

package/src/bin/fenge.cli.js

@@ -54,6 +54,7 @@ program
     "--default",
     "force to use built-in default config, ignore specified config and local config",
   )
+  .option("--timing", "print timing information")
   .option(
     "-d, --dry-run",
     "print what command will be executed under the hood instead of executing",

package/src/command/lint.js

@@ -5,7 +5,7 @@ import { dir, execAsync, getBinPath } from "../utils.js";
 
 /**
  * @param {Array<string>} paths
- * @param {{update?: boolean, fix?: boolean, dryRun?: boolean, config?: string, default?: boolean}} options
+ * @param {{update?: boolean, fix?: boolean, dryRun?: boolean, config?: string, default?: boolean, timing?: boolean}} options
  */
 export async function lint(paths = [], options = {}) {
   const {
@@ -14,6 +14,7 @@ export async function lint(paths = [], options = {}) {
     dryRun = false,
     config,
     default: useDefaultConfig = false,
+    timing = false,
   } = options;
 
   return execAsync(
@@ -33,6 +34,7 @@ export async function lint(paths = [], options = {}) {
       env: {
         ...(config && { FENGE_CONFIG: config }),
         ...(useDefaultConfig && { FENGE_USE_DEFAULT_CONFIG: "true" }),
+        ...(timing && { TIMING: "1" }),
       },
     },
   );

package/src/utils.js

@@ -8,7 +8,7 @@ import process from "node:process";
 import { fileURLToPath } from "node:url";
 import { lilconfig } from "lilconfig";
 import ora from "ora";
-import colors from "yoctocolors";
+import colors from "yoctocolors"; // TODO: Use [util.styleText](https://nodejs.org/api/util.html#utilstyletextformat-text-options) once we drop support for Node.js < 20.12.0.
 
 /**
  * @param {string} filepath
@@ -89,27 +89,25 @@ export function execAsync(command, { topic, dryRun, env }) {
     const cp = childProcess.spawn(cmd, args, {
       env: { FORCE_COLOR: "true", ...process.env, ...env },
     });
-    let stdout = Buffer.from([]);
-    let stderr = Buffer.from([]);
+    let stdout = Buffer.alloc(0);
+    let stderr = Buffer.alloc(0);
     cp.stdout.on("data", (data) => {
       stdout = Buffer.concat([stdout, data]);
     });
     cp.stderr.on("data", (data) => {
       stderr = Buffer.concat([stderr, data]);
     });
-    // The 'close' event will always emit after 'exit' was already emitted, or 'error' if the child failed to spawn.
-    cp.on("close", () => {
-      process.stdout.write(stdout);
-      process.stderr.write(stderr);
-    });
     cp.on("error", (err) => {
       spinner.fail(
         `${topic} got error in ${colors.yellow(getSpentTime(startTime))}`,
       );
+      process.stderr.write(err.message);
       resolve(getExitCode(err));
     });
-    // The 'exit' event may or may not fire after an error has occurred.
-    cp.on("exit", (code, signal) => {
+    // Why not listen to the 'exit' event?
+    // 1. The 'close' event will always emit after 'exit' was already emitted, or 'error' if the child failed to spawn.
+    // 2. The 'exit' event may or may not fire after an error has occurred.
+    cp.on("close", (code, signal) => {
       const exitCode = getExitCode({ code, signal });
       if (exitCode === 0) {
         spinner.succeed(
@@ -120,6 +118,8 @@ export function execAsync(command, { topic, dryRun, env }) {
           `${topic} failed in ${colors.yellow(getSpentTime(startTime))}`,
         );
       }
+      process.stdout.write(stdout);
+      process.stderr.write(stderr);
       resolve(exitCode);
     });
     process.on("SIGINT", () => !cp.killed && cp.kill("SIGINT"));