feinai 0.7.2 → 0.8.0

package/src/db.ts

@@ -16,7 +16,7 @@ const SCHEMA_STATEMENTS: string[] = [
     id           TEXT PRIMARY KEY,
     numero       INTEGER,
     title        TEXT NOT NULL,
-    status       TEXT NOT NULL DEFAULT 'lista',
+    status       TEXT NOT NULL DEFAULT 'pending',
     content      TEXT,
     pr           TEXT,
     merged_date  TEXT,
@@ -133,6 +133,20 @@ const MIGRATIONS: Array<{ version: number; stmts: string[] }> = [
       `ALTER TABLE tasks ADD COLUMN worktree TEXT`,
     ],
   },
+  {
+    version: 3,
+    stmts: [
+      // Normalize spec status names from Spanish to English.
+      `UPDATE specs SET status = CASE status
+         WHEN 'lista' THEN 'pending'
+         WHEN 'en_progreso' THEN 'in_progress'
+         WHEN 'hecha' THEN 'completed'
+         WHEN 'archivada' THEN 'archived'
+         ELSE status
+       END
+       WHERE status IN ('lista', 'en_progreso', 'hecha', 'archivada')`,
+    ],
+  },
 ];
 
 function applyMigrations(db: DbInstance): void {

package/src/format.ts

@@ -26,10 +26,7 @@ const STATUS_COLOR: Record<string, keyof typeof COLORS> = {
   completed: "green",
   failed: "red",
   deleted: "gray",
-  lista: "yellow",
-  en_progreso: "blue",
-  hecha: "green",
-  archivada: "gray",
+  archived: "gray",
 };
 
 export function formatTask(task: Task, format: OutputFormat): string {

package/src/server-state.ts

@@ -1,5 +1,6 @@
-import { existsSync } from "node:fs";
+import { existsSync, realpathSync } from "node:fs";
 import { spawnSync } from "node:child_process";
+import { resolve } from "node:path";
 import type { DbInstance } from "./db";
 
 export interface ServerState {
@@ -105,17 +106,16 @@ function isPidRunning(pid: number): boolean {
  * Get the port that a specific pid is listening on.
  * Returns the port number or null if the pid has no tcp listeners.
  */
-function portOfPid(pid: number): number | null {
+export function portOfPid(pid: number): number | null {
   try {
-    const result = spawnSync("lsof", ["-iTCP", "-sTCP:LISTEN", "-P", "-n", "-p", String(pid)]);
+    // Use -a so that -p and -i are ANDed together, otherwise lsof returns
+    // all internet listeners OR all files of pid.
+    const result = spawnSync("lsof", ["-a", "-p", String(pid), "-iTCP", "-sTCP:LISTEN", "-P", "-n"]);
     if (result.status !== 0) return null;
-    // Parse lsof output: find "TCP *:{port}" pattern
     const out = result.stdout.toString();
-    const match = out.match(/TCP\s+\*:(\d+)/);
+    // Parse "TCP {host}:{port} (LISTEN)" or "TCP *:{port} (LISTEN)"
+    const match = out.match(/TCP\s+[^\s:]+:(\d+)\s+\(LISTEN\)/);
     if (match) return parseInt(match[1]!, 10);
-    // Alternate format: "LISTEN" followed by port
-    const altMatch = out.match(/:(\d+)\s.*LISTEN/);
-    if (altMatch) return parseInt(altMatch[1]!, 10);
     return null;
   } catch {
     return null;
@@ -178,3 +178,67 @@ export function repairServerState(db: DbInstance): ServerState | null {
   const { valid, record } = validateServerState(db);
   return valid ? record : null;
 }
+
+export interface OrphanKillResult {
+  pid: number;
+  port: number | null;
+}
+
+/**
+ * Kill any TCP-listening processes whose current working directory matches
+ * the project directory, regardless of whether they are recorded in the DB.
+ *
+ * Used by `feinai server --down` to clean up orphan/unregistered servers.
+ * Returns a list of killed pids (and their listening port, when detectable).
+ */
+export function killOrphansByProjectDir(projectDir: string): OrphanKillResult[] {
+  const killed: OrphanKillResult[] = [];
+  const normalizedProject = resolve(projectDir);
+
+  // Collect all pids that are listening on any TCP port.
+  const listenerPids = new Set<number>();
+  try {
+    const result = spawnSync("lsof", ["-t", "-iTCP", "-sTCP:LISTEN", "-P", "-n"]);
+    if (result.status !== 0) return killed;
+    result.stdout
+      .toString()
+      .trim()
+      .split("\n")
+      .forEach((line) => {
+        const pid = parseInt(line.trim(), 10);
+        if (!isNaN(pid)) listenerPids.add(pid);
+      });
+  } catch {
+    return killed;
+  }
+
+  for (const pid of listenerPids) {
+    if (pid === process.pid) continue;
+
+    let cwd: string | null = null;
+    try {
+      if (process.platform === "linux") {
+        cwd = realpathSync(`/proc/${pid}/cwd`, { encoding: "utf8" });
+      } else {
+        const result = spawnSync("lsof", ["-a", "-d", "cwd", "-p", String(pid), "-F", "n"]);
+        if (result.status !== 0) continue;
+        const match = result.stdout.toString().match(/^n(.+)$/m);
+        if (match) cwd = match[1]!;
+      }
+    } catch {
+      continue;
+    }
+
+    if (!cwd) continue;
+    if (resolve(cwd) !== normalizedProject) continue;
+
+    try {
+      process.kill(pid, "SIGTERM");
+      killed.push({ pid, port: portOfPid(pid) });
+    } catch {
+      // Process may have exited between discovery and signal; ignore.
+    }
+  }
+
+  return killed;
+}

package/src/specs.ts

@@ -1,7 +1,7 @@
 import type { DbInstance } from "./db";
 import { recordEvent } from "./db";
 
-export type SpecStatus = "lista" | "en_progreso" | "hecha" | "archivada";
+export type SpecStatus = "pending" | "in_progress" | "completed" | "archived";
 
 export interface Spec {
   id: string;
@@ -51,9 +51,9 @@ export function addSpec(db: DbInstance, input: AddSpecInput, actor: string | nul
   }
 
   db.prepare(
-    `INSERT INTO specs (id, numero, title, content)
-     VALUES (?, ?, ?, ?)`,
-  ).run(input.id, numero ?? null, input.title, input.content ?? null);
+    `INSERT INTO specs (id, numero, title, status, content)
+     VALUES (?, ?, ?, ?, ?)`,
+  ).run(input.id, numero ?? null, input.title, "pending", input.content ?? null);
 
   recordEvent(db, "spec", input.id, "created", { title: input.title }, actor);
 
@@ -63,8 +63,8 @@ export function addSpec(db: DbInstance, input: AddSpecInput, actor: string | nul
 export function startSpec(db: DbInstance, id: string, actor: string | null = null): Spec {
   const upd = db
     .prepare(
-      `UPDATE specs SET status = 'en_progreso', updated_at = datetime('now')
-       WHERE id = ? AND status = 'lista'`,
+      `UPDATE specs SET status = 'in_progress', updated_at = datetime('now')
+       WHERE id = ? AND status = 'pending'`,
     )
     .run(id);
 
@@ -86,7 +86,7 @@ export function doneSpec(
 ): Spec {
   const upd = db
     .prepare(
-      `UPDATE specs SET status = 'hecha',
+      `UPDATE specs SET status = 'completed',
         pr = COALESCE(?, pr),
         merged_date = COALESCE(?, merged_date),
         updated_at = datetime('now')
@@ -228,7 +228,7 @@ export function archiveSpec(
 
   const upd = db
     .prepare(
-      `UPDATE specs SET status = 'archivada', updated_at = datetime('now') WHERE id = ?`,
+      `UPDATE specs SET status = 'archived', updated_at = datetime('now') WHERE id = ?`,
     )
     .run(id);
 
@@ -256,7 +256,7 @@ export function unarchiveSpec(
 
   const upd = db
     .prepare(
-      `UPDATE specs SET status = 'lista', updated_at = datetime('now') WHERE id = ? AND status = 'archivada'`,
+      `UPDATE specs SET status = 'pending', updated_at = datetime('now') WHERE id = ? AND status = 'archived'`,
     )
     .run(id);
 

package/src/tasks.ts

@@ -80,7 +80,7 @@ export function listTasks(db: DbInstance, filter: ListFilter = {}): Task[] {
   }
 
   // Exclude tasks from archived specs so archived work leaves the active task list
-  where.push("(spec_id IS NULL OR spec_id NOT IN (SELECT id FROM specs WHERE status = 'archivada'))");
+  where.push("(spec_id IS NULL OR spec_id NOT IN (SELECT id FROM specs WHERE status = 'archived'))");
 
   const sql =
     `SELECT * FROM tasks` +
@@ -163,7 +163,7 @@ export function takeTask(
 
   if (task.spec_id) {
     const spec = getSpec(db, task.spec_id);
-    if (spec && spec.status === 'lista') {
+    if (spec && spec.status === 'pending') {
       startSpec(db, task.spec_id, owner);
     }
   }