fedipod 1.49.2 → 1.50.2

package/lib/surface/routes/owner.mjs

@@ -5,7 +5,6 @@ import fs from 'node:fs';
 import path from 'node:path';
 import { announceModeration } from '../../core/social.mjs';
 import { addRemoveActivity, publicHandle } from '../../core/wire.mjs';
-import { hashPassword } from '../../client/masto/index.mjs';
 import { tildify } from '../../shared/files.mjs';
 import { AGENT_VERSION } from '../static.mjs';
 
@@ -71,8 +70,6 @@ export async function get(p, ctx, req, res, url) {   // eslint-disable-line no-u
       approveJoins: !!cfg.approveJoins, review: !!cfg.review,
       aliases: cfg.aliases || [],
       autoAcceptFollows: cfg.autoAcceptFollows !== false,
-      // never the record itself
-      hasUiPassword: !!cfg.uiPassword,
       quiescedAt: cfg.quiescedAt || null, movedTo: cfg.movedTo || null,
       // Per-machine, so it comes from the credential file, not pod config —
       // and it is a fact here, not a setting: moving it means moving data,
@@ -172,8 +169,8 @@ export async function post(p, body, ctx, req, res) {   // eslint-disable-line no
       // A user acting here outranks an idle active agent on another device:
       // claim the lease rather than write state that one will clobber.
       await agent.requestTakeover?.();
-      // Merge, never replace: the UI password and anything else set later
-      // must survive an edit that never mentions it.
+      // Merge, never replace: anything set later must survive an edit that
+      // never mentions it.
       const cfg = { ...agent.store.getConfig() };
       if ('name' in body) {
         if (!body.name) return json(res, 400, { error: 'a display name is required' });
@@ -210,12 +207,6 @@ export async function post(p, body, ctx, req, res) {   // eslint-disable-line no
         };
         cfg.moderators = next;
       }
-      if ('password' in body) {
-        // '' clears it. The UI password is what turns the instant OAuth
-        // redirect into a login form; switching that off is a real choice.
-        if (body.password) cfg.uiPassword = hashPassword(body.password);
-        else delete cfg.uiPassword;
-      }
       const republish = WIRE_CONFIG.some(k => k in body);
       agent.store.setConfig(cfg);
       if ('autoAcceptFollows' in body && agent.publisher) {
@@ -257,7 +248,6 @@ export async function post(p, body, ctx, req, res) {   // eslint-disable-line no
           approveJoins: !!cfg.approveJoins, review: !!cfg.review,
           autoAcceptFollows: cfg.autoAcceptFollows !== false,
           ...(isGroup() ? { moderators: cfg.moderators || [] } : {}),
-          hasUiPassword: !!cfg.uiPassword,
         },
       });
     }

package/lib/surface/surface.mjs

@@ -239,8 +239,7 @@ export function buildAdminSurface({ agent, gate, allowed, log = console.log,
       // twice over: a group has statuses (what it carried) and notifications
       // (who joined), and its operator has a bio to edit and a profile they
       // want to see the way everyone else does. The surface this opens is a
-      // login and client tokens, and `passwd` has never had a group carve-out,
-      // so a group can be gated exactly like a person before it is exposed.
+      // login and client tokens, approved at the pod like a person's.
       if (p.startsWith('/api/') || p.startsWith('/oauth/')) {
         if (await masto.handle(req, res, p, url)) return;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fedipod",
-  "version": "1.49.2",
+  "version": "1.50.2",
   "description": "Standalone single-actor ActivityPub agent whose wire face, RDF truth and state all live on a Solid pod (CSS). Bundles a Phanpy UI and a Mastodon client-API facade.",
   "type": "module",
   "license": "MIT",
@@ -55,7 +55,7 @@
     "install-service": "node bin/fedipod.mjs install-service",
     "uninstall-service": "node bin/fedipod.mjs uninstall-service",
     "prepublishOnly": "npm test",
-    "test": "node claude/smoke-tests/agent-smoke.mjs && node claude/smoke-tests/front-hard-test.mjs && node claude/smoke-tests/copy-test.mjs && node claude/smoke-tests/copy-mode-test.mjs && node claude/smoke-tests/hold-test.mjs && node claude/smoke-tests/masto-gateway-test.mjs && node scripts/check-pod-calls.mjs && node scripts/verify-ui.mjs && node --test claude/smoke-tests/forum-signup-form.test.mjs claude/smoke-tests/door-verify.test.mjs claude/smoke-tests/oauth-signin.test.mjs claude/smoke-tests/app-registration.test.mjs claude/smoke-tests/push-signout.test.mjs claude/smoke-tests/token-fetches.test.mjs claude/smoke-tests/signin-hardening.test.mjs claude/smoke-tests/load-fixes.test.mjs && node scripts/check-sizes.mjs && node scripts/test-dependents.mjs && node claude/validation/browser-agent/all.mjs",
+    "test": "node claude/smoke-tests/agent-smoke.mjs && node claude/smoke-tests/front-hard-test.mjs && node claude/smoke-tests/copy-test.mjs && node claude/smoke-tests/copy-mode-test.mjs && node claude/smoke-tests/hold-test.mjs && node claude/smoke-tests/masto-gateway-test.mjs && node scripts/check-pod-calls.mjs && node scripts/verify-ui.mjs && node --test claude/smoke-tests/forum-signup-form.test.mjs claude/smoke-tests/door-verify.test.mjs claude/smoke-tests/oauth-signin.test.mjs claude/smoke-tests/app-registration.test.mjs claude/smoke-tests/push-signout.test.mjs claude/smoke-tests/token-fetches.test.mjs claude/smoke-tests/signin-hardening.test.mjs claude/smoke-tests/load-fixes.test.mjs claude/smoke-tests/unread-docs.test.mjs claude/smoke-tests/post-text-once.test.mjs && node scripts/check-sizes.mjs && node scripts/test-dependents.mjs && node claude/validation/browser-agent/all.mjs",
     "verify-ui": "node scripts/verify-ui.mjs",
     "build:sw": "node scripts/build-app.mjs --entry web/app/sw-src.mjs --out web/app/dist/sw.js",
     "build:boot": "node scripts/build-app.mjs --entry web/app/boot.mjs --out web/app/dist/boot.js",

package/web/admin/index.html

@@ -220,7 +220,7 @@ pre { overflow-x: auto; background: #0001; padding: .6rem; border-radius: .3rem;
      no page there to open. Plain links — a top-level navigation sends no
      Origin, so each agent's own firewall lets it through. -->
 <section id="pane-others" aria-label="Actors on this machine" hidden>
-  <!-- Everything setup cannot work without. The bio, avatar and UI password it
+  <!-- Everything setup cannot work without. The bio and avatar it
        also offers are all changeable afterwards, so they are not asked here —
        the fuller form is what the new actor opens on. -->
   <form id="new-actor-form" hidden>

package/web/admin/record.js

@@ -7,9 +7,6 @@
 // Two rules the routes enforce and this page respects: a write is a MERGE, so a
 // form that never mentions a field cannot delete it; and anything on the wire is
 // not real until the actor is republished, which POST /config does for itself.
-//
-// The UI password is deliberately not here — `fedipod passwd` sets it. It
-// only gates /oauth/authorize, so it does nothing for a loopback-only agent.
 
 let config = null;
 // Held, because render() moves it into a generated row and empties that row's

package/web/app/admin-facade.mjs

@@ -18,7 +18,6 @@ import { publicHandle, webfingerHost } from '../../lib/core/wire.mjs';
 import * as podInbox from '../../lib/pod/inbox.mjs';
 import { normalizeImport, IMPORT_KINDS } from '../../lib/connections/import.mjs';
 import { followActor, followHandle } from '../../lib/core/social.mjs';
-import { hashPassword } from '../../lib/client/masto/index.mjs';
 
 // The identity itself — changing any means a different actor, i.e. a new setup.
 const PERMANENT_CONFIG = ['handle', 'remotePod', 'issuer', 'root', 'kind'];
@@ -121,7 +120,6 @@ export class AdminFacade {
             image: cfg.image || null, fields: cfg.fields || [],
             aliases: cfg.aliases || [],
             autoAcceptFollows: cfg.autoAcceptFollows !== false,
-            hasUiPassword: !!cfg.uiPassword,
             quiescedAt: cfg.quiescedAt || null, movedTo: cfg.movedTo || null,
             mode: a.status().mode,
             // Live from the credential's actual backend on THIS browser (a
@@ -218,10 +216,6 @@ export class AdminFacade {
             .map(f => ({ name: String(f.name).trim(), value: String(f.value ?? '').trim() }));
         }
         if ('autoAcceptFollows' in body) cfg.autoAcceptFollows = !!body.autoAcceptFollows;
-        if ('password' in body) {
-          if (body.password) cfg.uiPassword = hashPassword(body.password);
-          else delete cfg.uiPassword;
-        }
         const republish = WIRE_CONFIG.some(k => k in body);
         a.store.setConfig(cfg);
         if ('autoAcceptFollows' in body && a.publisher) a.publisher.config.autoAcceptFollows = cfg.autoAcceptFollows;

package/web/app/agent.mjs

@@ -516,7 +516,9 @@ export class BrowserAgent {
     let unread = null;
     const fullLoad = () => this.store.load().catch((e) => { unread = e; });
     // Warm: only documents caught mid-write are read again, else a full load.
-    if (this._warm) await this.store.refresh(this._warm.pending).catch(fullLoad);
+    // A kept copy without the container's ETag is one whose last load could
+    // not read everything: what it lacks is still on the pod, unread.
+    if (this._warm && warmFrom.listingEtag) await this.store.refresh(this._warm.pending).catch(fullLoad);
     else await fullLoad();
     // Config: handed in on sign-up, or read from the pod on a returning sign-in.
     const cfg = config || this.store.getConfig();