feature-factory 0.10.2 → 0.10.3

package/agents/backend-builder.md

@@ -106,7 +106,9 @@ Use exactly these field names and exactly this `status` vocabulary. The orchestr
 block to `factory observe --claim`, which compares each field against what it observes itself and
 records every disagreement as a review finding. `completed` is the word the evidence uses; any
 other spelling reads as a disagreement about status and blocks your own slice. `files_changed`
-must list every path, and `tests.exit` must be the real exit code — a claimed zero against an
+must list every path changed since the slice's `base_ref`, not since your last attempt — on a retry
+the observer diffs the whole slice, because that is what merges, and a list of only this attempt's
+edits is a disagreement. `tests.exit` must be the real exit code — a claimed zero against an
 observed failure is the single most important disagreement this mechanism catches.
 
 If the brief is wrong or impossible as written (e.g. the entity doesn't support it), stop, set `status: blocked` with the reason in `blockers`, and report the conflict — do not silently improvise a different design.

package/agents/frontend-builder.md

@@ -114,7 +114,9 @@ Use exactly these field names and exactly this `status` vocabulary. The orchestr
 block to `factory observe --claim`, which compares each field against what it observes itself and
 records every disagreement as a review finding. `completed` is the word the evidence uses; any
 other spelling reads as a disagreement about status and blocks your own slice. `files_changed`
-must list every path, and `tests.exit` must be the real exit code — a claimed zero against an
+must list every path changed since the slice's `base_ref`, not since your last attempt — on a retry
+the observer diffs the whole slice, because that is what merges, and a list of only this attempt's
+edits is a disagreement. `tests.exit` must be the real exit code — a claimed zero against an
 observed failure is the single most important disagreement this mechanism catches.
 
 If the design brief and the brief conflict, or a token/component the design needs doesn't exist, stop, set `status: blocked` with the reason in `blockers`, and report — don't hardcode around it.

package/observe/index.js

@@ -123,10 +123,16 @@ export function runTests(worktree, command, { runner = spawnSync, skipReason = n
   return { cmd: shellCommand ? command : command.join(" "), exit, observed: exit !== null, skipped_reason: null };
 }
 
-// Readiness requires completed, clean, changed, observed-diff evidence and tests
-// observed passing or ratified as explicitly skipped with a reason.
+// Readiness requires completed, clean, changed, observed-diff evidence, no disagreement between
+// the builder's claim and the observation, and tests observed passing or ratified as explicitly
+// skipped with a reason.
 export function deriveReviewReady(evidence) {
   if (evidence.status !== "completed") return false;
+  // Enforcement (false green): a claim that disagrees with observation is itself the finding. It
+  // lives here, not beside the writer, because `readEvidence` recomputes readiness from this
+  // function alone; with the term only at write time, every mismatched record read back as
+  // tampered and wedged its slice where `slice blocked` could never record it.
+  if (evidence.claim_reconciliation?.mismatches?.length > 0) return false;
   // A tree with uncommitted changes cannot produce evidence about the commit it
   // claims, whatever the tests said.
   if (evidence.worktree_clean !== true) return false;
@@ -250,11 +256,8 @@ export function buildEvidence({ subject, runId, attempt, branch, baseRef, worktr
     review_ready: false,
     claim_reconciliation: { claimed: false, mismatches: [] },
   };
-  evidence.review_ready = deriveReviewReady(evidence);
   evidence.claim_reconciliation = reconcileClaim(claim, evidence);
-  // A claim that disagrees with what we observed cannot be review-ready: the
-  // disagreement is itself the finding.
-  if (evidence.claim_reconciliation.mismatches.length > 0) evidence.review_ready = false;
+  evidence.review_ready = deriveReviewReady(evidence);
   return evidence;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "feature-factory",
-  "version": "0.10.2",
+  "version": "0.10.3",
   "description": "Durable, observed control plane for /feature runs. Host-agnostic: no opencode dependency.",
   "type": "module",
   "license": "MIT",