fdeops 3.9.13 → 3.9.15

package/bin/fde.js

@@ -107,9 +107,13 @@ function resolveEngagement(opts = {}) {
   // bind - env, registry, pointer, or in-repo .fde. Basename matching is
   // read-only convenience; writing on a folder-name guess contaminates clients.
   const forWrite = !!opts.forWrite
+  const accept = (p) => acceptEngagementPath(p, { forWrite })
   // 1) explicit env (back-compat: accept old FDEOS_ENGAGEMENT too)
   const env = (process.env.FDEOPS_ENGAGEMENT || process.env.FDEOS_ENGAGEMENT || '').replace(/^~/, HOME).trim()
-  if (env && fs.existsSync(env)) return env
+  if (env) {
+    const ok = accept(env)
+    if (ok) return ok
+  }
   // 2) workspace registry binding (written by resume --init). Match the cwd OR
   // any ancestor of it - FDEs run commands from src/, packages/api/, etc., not
   // just the repo root where they bound. Nearest (deepest) registered ancestor
@@ -122,8 +126,8 @@ function resolveEngagement(opts = {}) {
     .filter(r => cwd === r.workspace || cwd.startsWith(r.workspace + path.sep))
     .sort((a, b) => b.workspace.length - a.workspace.length)[0]
   if (reg) {
-    const p = path.join(ENGAGEMENTS_ROOT, reg.slug, '.fde')
-    if (fs.existsSync(p)) return p
+    const ok = accept(path.join(ENGAGEMENTS_ROOT, reg.slug, '.fde'))
+    if (ok) return ok
   }
   // 3) global pointer file (back-compat: try old FDEOS-CLAUDE.md too)
   for (const ptrName of ['FDEOPS-CLAUDE.md', 'FDEOS-CLAUDE.md']) {
@@ -131,8 +135,8 @@ function resolveEngagement(opts = {}) {
       const ptr = fs.readFileSync(path.join(HOME, '.claude', ptrName), 'utf8')
       const m = ptr.match(/^(?:FDEOPS|FDEOS)_ENGAGEMENT=(.+)$/m)
       if (m) {
-        const p = m[1].trim().replace(/^~/, HOME)
-        if (fs.existsSync(p)) return p
+        const ok = accept(m[1].trim().replace(/^~/, HOME))
+        if (ok) return ok
       }
     } catch (_) {}
   }
@@ -150,14 +154,37 @@ function resolveEngagement(opts = {}) {
       )
       return null
     }
-    process.stderr.write(`⚠ resolved engagement by directory name ("${slugGuess}"), not a saved binding (read-only). If this is the right client, run \`fde resume --init ${slugGuess}\` here to bind it before logging or debriefing.\n`)
-    return guess
+    const ok = accept(guess)
+    if (ok) {
+      process.stderr.write(`⚠ resolved engagement by directory name ("${slugGuess}"), not a saved binding (read-only). If this is the right client, run \`fde resume --init ${slugGuess}\` here to bind it before logging or debriefing.\n`)
+      return ok
+    }
   }
   // 5) in-repo .fde (engagement-approved only)
-  if (fs.existsSync(path.join(cwd, '.fde'))) return path.join(cwd, '.fde')
+  const inRepo = accept(path.join(cwd, '.fde'))
+  if (inRepo) return inRepo
   return null
 }
 
+// Engagement memory must be a directory. A file named .fde used to yield a
+// healthy-looking green TRIAGE then raw ENOTDIR on write - refuse loudly.
+function acceptEngagementPath(p, opts = {}) {
+  if (!p || !fs.existsSync(p)) return null
+  try {
+    const st = fs.statSync(p)
+    if (st.isDirectory()) return p
+    const msg =
+      `engagement path is not a directory (memory missing/broken): ${p}\n` +
+      '  repair: remove that file, then re-run: fde resume --init <name>'
+    console.error(msg)
+    if (opts.forWrite) process.exit(1)
+    return null
+  } catch (e) {
+    if (opts.forWrite) failFs(e, 'open', p)
+    return null
+  }
+}
+
 function templatesDir() {
   for (const c of [path.join(__dirname, '..', 'templates', '.fde'), path.join(__dirname, 'templates', '.fde')]) {
     if (fs.existsSync(c)) return c
@@ -172,11 +199,19 @@ function readEng(eng, f) {
 }
 
 // Redact private notes and template hints from every model-facing read.
+// Also strip terminal control chars so poisoned memory cannot smuggle ANSI
+// into triage/prep/status (C0/C1 except tab/LF/CR).
+function stripControlChars(s) {
+  return String(s || '').replace(/[\u0000-\u0008\u000B\u000C\u000E-\u001F\u007F-\u009F]/g, '')
+}
+
 function stripPrivate(md) {
-  return md
-    .replace(/<private>[\s\S]*?<\/private>/gi, '(private - redacted)')
-    .replace(/<private>[\s\S]*$/i, '(private - redacted)')
-    .replace(/<!--[\s\S]*?-->/g, '')
+  return stripControlChars(
+    String(md || '')
+      .replace(/<private>[\s\S]*?<\/private>/gi, '(private - redacted)')
+      .replace(/<private>[\s\S]*$/i, '(private - redacted)')
+      .replace(/<!--[\s\S]*?-->/g, '')
+  )
 }
 
 // Read + redact in one step - the default way dashboard code should ever touch
@@ -239,6 +274,9 @@ function formatFsError(err, action, target) {
   const code = err && err.code
   const where = path.basename(String(target || '')) || String(target || 'path')
   if (code === 'ENOSPC') return `cannot ${action} ${where} - disk full`
+  if (code === 'ENOTDIR') {
+    return `cannot ${action} ${where} - engagement path is not a directory (memory missing/broken); remove the file and re-run fde resume --init`
+  }
   if (code === 'EACCES' || code === 'EPERM' || code === 'EROFS') {
     return `cannot ${action} ${where} - permission denied (read-only or locked down)`
   }
@@ -392,7 +430,7 @@ function datedEntry(eng, date, text, signal) {
   const bits = [`- [${date}]`]
   if (who) bits.push(`[${who}]`)
   if (signal) bits.push(`[signal:${signal}]`)
-  bits.push(text)
+  bits.push(stripControlChars(text))
   return bits.join(' ')
 }
 
@@ -401,6 +439,7 @@ const {
   memoryDirtyManual,
   commitMemory,
   memoryHead,
+  memoryGitHealthy,
 } = createMemoryApi({ fs, path, gitBinOk, writeOwnerIfMissing, atomicWriteFile })
 
 // Pull the body under a "## Heading" up to the next "##" (or EOF).
@@ -1095,6 +1134,10 @@ function smartProposeText(input) {
     let bare = line
       .replace(/^[-*+]\s+/, '')
       .replace(/^\*\*(decision|risk|delivery|contact|next):?\*\*:?\s*/i, '$1: ')
+    if (/^decided:\s+/i.test(bare)) {
+      out.push(`decision: ${bare.replace(/^decided:\s+/i, '')}`)
+      continue
+    }
     if (/^(decision|risk|delivery|contact|next):\s*/i.test(bare)) {
       let routed = bare.replace(/^(decision|risk|delivery|contact|next):\s*/i, (m, t) => `${t.toLowerCase()}: `)
       if (/^contact:/i.test(routed) && !/\[signal:(red|amber|green)\]/i.test(routed)) {
@@ -1110,7 +1153,7 @@ function smartProposeText(input) {
       out.push(`next: ${next}`)
       continue
     }
-    if (/\b(we (decided|agreed)|decision:|descope|agreed to|agreement was|freeze scope)\b/i.test(bare)) {
+    if (/\b(we (decided|agreed)|decided:|decision:|descope|agreed to|agreement was|freeze scope|freeze prompts)\b/i.test(bare)) {
       out.push(`decision: ${bare}`)
     } else if (/\b(open question|who signs|unclear who|unresolved)\b/i.test(bare)) {
       out.push(`risk: ${bare}`)
@@ -1131,7 +1174,7 @@ function smartProposeText(input) {
 
 function setNextAction(eng, text) {
   ensureMemoryGit(eng)
-  const bullet = `- ${String(text).replace(/^[-*]\s+/, '').trim()}`
+  const bullet = `- ${stripControlChars(String(text).replace(/^[-*]\s+/, '').trim())}`
   const p = path.join(eng, 'context.md')
   let md = readEng(eng, 'context.md')
   if (!md) md = '# Engagement context\n\n'
@@ -1143,6 +1186,24 @@ function setNextAction(eng, text) {
   withFileLock(p, () => { atomicWriteFile(p, md.endsWith('\n') ? md : md + '\n') })
 }
 
+function looksLikeBinaryNoise(text) {
+  const s = String(text || '')
+  if (!s) return false
+  if (s.includes('\0')) return true
+  const sample = s.slice(0, 8192)
+  let ctrl = 0
+  let replacement = 0
+  for (let i = 0; i < sample.length; i++) {
+    const c = sample.charCodeAt(i)
+    if (c === 0xfffd) replacement++
+    if (c === 9 || c === 10 || c === 13) continue
+    if (c < 32 || (c >= 0x7f && c <= 0x9f)) ctrl++
+  }
+  if (!sample.length) return false
+  // Mostly-control or high U+FFFD density = urandom / binary mistyped as text.
+  return (ctrl / sample.length) > 0.05 || (replacement / sample.length) > 0.1
+}
+
 function readDebriefInput(args) {
   let input = ''
   if (args[0]) {
@@ -1155,19 +1216,31 @@ function readDebriefInput(args) {
     }
     let buf
     try { buf = fs.readFileSync(notesPath) } catch (_) { console.error(`cannot read ${args[0]}`); process.exit(1) }
-    if (buf.includes(0)) {
-      console.error(`debrief refused: ${args[0]} looks binary (null bytes). Paste text notes only.`)
+    if (buf.includes(0) || looksLikeBinaryNoise(buf.toString('utf8'))) {
+      console.error(`debrief refused: ${args[0]} looks binary or mostly non-printable. Paste text notes only.`)
       process.exit(1)
     }
     input = buf.toString('utf8')
   } else {
-    try { input = fs.readFileSync(0, 'utf8') } catch (_) {}
-    if (Buffer.byteLength(input, 'utf8') > DEBRIEF_MAX_BYTES) {
+    let buf
+    try { buf = fs.readFileSync(0) } catch (_) { buf = Buffer.alloc(0) }
+    if (Buffer.byteLength(buf) > DEBRIEF_MAX_BYTES) {
       console.error(`debrief refused: stdin is over ${DEBRIEF_MAX_BYTES} bytes. Split the notes.`)
       process.exit(1)
     }
+    if (buf.includes(0) || looksLikeBinaryNoise(buf.toString('utf8'))) {
+      console.error('debrief refused: stdin looks binary or mostly non-printable. Paste text notes only.')
+      process.exit(1)
+    }
+    input = buf.toString('utf8')
   }
-  return input
+  return stripControlChars(input)
+}
+
+function previewLine(text, max = 240) {
+  const t = String(text || '').replace(/\s+/g, ' ').trim()
+  if (t.length <= max) return t
+  return `${t.slice(0, max)}… (${t.length} chars)`
 }
 
 function routeDebriefInput(eng, input, { dry, force }) {
@@ -1191,7 +1264,7 @@ function routeDebriefInput(eng, input, { dry, force }) {
         continue
       }
       if (type === 'next') {
-        if (dry) console.log(`→ context.md ## Next action  - ${body}`)
+        if (dry) console.log(`→ context.md ## Next action  - ${previewLine(body)}`)
         else nextAction = body
         counts.next++
         continue
@@ -1199,7 +1272,7 @@ function routeDebriefInput(eng, input, { dry, force }) {
       const sigInline = (body.match(/\[signal:(red|amber|green)\]/i) || [])[1]
       if (sigInline) body = body.replace(/\[signal:(red|amber|green)\]/i, '').trim()
       const entry = datedEntry(eng, date, body, type === 'contact' && sigInline ? sigInline.toLowerCase() : '')
-      if (dry) console.log(`→ ${LOG_FILES[type]}  ${entry}`)
+      if (dry) console.log(`→ ${LOG_FILES[type]}  ${previewLine(entry)}`)
       else appendLogEntry(eng, type, entry, { skipCommit: true })
       counts[type]++
     } else {
@@ -1213,7 +1286,7 @@ function routeDebriefInput(eng, input, { dry, force }) {
   if (nextAction && !dry) setNextAction(eng, nextAction)
   if (ctxLines.length) {
     const stamp = `${date} ${String(d.getHours()).padStart(2, '0')}:${String(d.getMinutes()).padStart(2, '0')}`
-    if (dry) ctxLines.forEach(l => console.log(`→ context.md  - ${l}`))
+    if (dry) ctxLines.forEach(l => console.log(`→ context.md  - ${previewLine(l)}`))
     else lockedAppendFile(path.join(eng, 'context.md'), `\n## Debrief - ${stamp}\n${ctxLines.map(l => `- ${l}`).join('\n')}\n`)
   }
   return { counts, ctxLines, date, nextAction }
@@ -1239,7 +1312,7 @@ function cmdDebrief(args) {
 
   let input = ''
   if (apply && !smart && !args[0]) {
-    try { input = fs.readFileSync(path.join(eng, DEBRIEF_PROPOSE), 'utf8') } catch (_) {
+    try { input = stripControlChars(fs.readFileSync(path.join(eng, DEBRIEF_PROPOSE), 'utf8')) } catch (_) {
       console.error('nothing to apply - run: fde debrief --smart <notes.md>   then   fde debrief --apply')
       process.exit(1)
     }
@@ -1308,9 +1381,22 @@ function cmdReceipts(args) {
   }
   const agreed = collect(AGREEMENTS)
   const claimed = collect(CLAIMS)
+  const dirty = memoryDirtyManual(eng)
+  const dirtySet = new Set(dirty)
+  const dirtyAgreedHits = [...new Set(
+    agreed.map(h => (h.match(/^\s*([^:]+):/) || [])[1]).filter(f => f && dirtySet.has(f))
+  )]
   if (agreed.length) {
     console.log('ON RECORD (dated - defensible):')
-    agreed.forEach(h => console.log(h))
+    agreed.forEach(h => {
+      const file = (h.match(/^\s*([^:]+):/) || [])[1]
+      console.log(h + (file && dirtySet.has(file) ? '  ⚠ dirty file' : ''))
+    })
+    if (dirtyAgreedHits.length) {
+      console.log(
+        `⚠ memory dirty (uncommitted manual edits: ${dirtyAgreedHits.join(', ')}) - dated lines above may not match the tamper-evident ledger until reviewed`
+      )
+    }
   }
   if (claimed.length) {
     if (agreed.length) console.log('')
@@ -1493,7 +1579,18 @@ function collectDoctorIssues(eng) {
   }
   if (s.stale) issues.push(`trust signal is STALE (${s.signalAge}d) - reconfirm with fde log contact ... --signal`)
   if (!readOwner(eng)) issues.push('no .owner - run any write or: fde owner set you@firm.com')
-  if (!fs.existsSync(path.join(eng, '.git'))) issues.push('memory not git-versioned - next write will init, or re-run resume --init')
+  const gitHealth = memoryGitHealthy(eng)
+  if (!gitHealth.ok) {
+    if (gitHealth.reason === 'broken') {
+      issues.push(
+        'memory git is BROKEN (UNVERSIONED) - receipts are not tamper-evident; repair: mv .fde/.git .fde/.git.broken && re-run any fde write (or resume --init) to re-init the ledger'
+      )
+    } else if (gitHealth.reason === 'no-git-bin') {
+      issues.push('git binary missing - engagement memory cannot be versioned (receipts stay dated, not tamper-evident)')
+    } else {
+      issues.push('memory not git-versioned - next write will init, or re-run resume --init')
+    }
+  }
   const success = readClean(eng, 'success.md')
   if (!firstLine(success, 80)) issues.push('success.md has no stated done-definition - fill before plan/build')
   if (!sectionBody(readClean(eng, 'context.md'), 'Next action')) {
@@ -1731,10 +1828,24 @@ function cmdGarden(args) {
   const apply = args.includes('--apply')
   const eng = resolveEngagement({ forWrite: apply })
   if (!eng) { console.error('no engagement - run: fde resume --init <name>'); process.exit(2) }
+  const gitHealth = memoryGitHealthy(eng)
   // Gardener contract (from Rowboat note_curation): no new facts, no deleted substance,
-  // reversible via git, confirm before apply. Mechanical only - no LLM rewrite.
-  console.log('GARDEN (contract: no new facts · no deleted substance · reversible via memory git)')
+  // reversible via git when healthy, confirm before apply. Mechanical only - no LLM rewrite.
+  if (gitHealth.ok) {
+    console.log('GARDEN (contract: no new facts · no deleted substance · reversible via memory git)')
+  } else if (gitHealth.reason === 'broken') {
+    console.log('GARDEN (contract: no new facts · no deleted substance · ⚠ memory git BROKEN — NOT reversible until ledger is repaired)')
+  } else {
+    console.log('GARDEN (contract: no new facts · no deleted substance · ⚠ memory not git-versioned — NOT reversible)')
+  }
   console.log(resumeTriage(eng))
+  if (!gitHealth.ok) {
+    console.log(
+      gitHealth.reason === 'broken'
+        ? '\n⚠ ledger is UNVERSIONED (corrupt .git). Repair before trusting garden apply: mv .fde/.git .fde/.git.broken && run any fde write to re-init.'
+        : '\n⚠ no memory git — garden apply cannot create a reversible commit until the ledger exists.'
+    )
+  }
   const proposals = []
   const s = computeSignals(eng)
   if (s.stale) {
@@ -1744,6 +1855,16 @@ function cmdGarden(args) {
       text: `Reconfirm stale ${s.trust} signal (${s.signalAge}d): fde log contact "…" --signal`,
     })
   }
+  const dupes = findDuplicateOpenRisks(eng)
+  if (dupes.length) {
+    const sample = (dupes[0][0] || '').replace(/\s+/g, ' ').trim().slice(0, 50)
+    proposals.push({
+      id: 'dedupe-risks',
+      kind: 'apply',
+      text: `Consolidate ${dupes.length} duplicate open-risk cluster(s) (e.g. "${sample}${sample.length >= 50 ? '…' : ''}") — keep first, retire echoes`,
+      clusters: dupes,
+    })
+  }
   const ctx = readEng(eng, 'context.md')
   const sessionBlocks = []
   const lines = ctx.split('\n')
@@ -1769,12 +1890,26 @@ function cmdGarden(args) {
   proposals.forEach((p, i) => console.log(`  ${i + 1}. [${p.kind}] ${p.text}`))
   if (!apply) {
     console.log('\nApply mechanical items only:  fde garden --apply')
-    console.log('Manual items stay yours. Every apply commits to memory git.')
+    console.log('Manual items stay yours. Every apply commits to memory git when the ledger is healthy.')
     return
   }
+  if (!gitHealth.ok && gitHealth.reason === 'broken') {
+    console.error('refusing garden --apply while memory git is broken - repair the ledger first')
+    process.exit(1)
+  }
   ensureMemoryGit(eng)
   let applied = 0
+  const touched = new Set()
   for (const p of proposals) {
+    if (p.id === 'dedupe-risks') {
+      const n = applyRiskDedupe(eng, p.clusters)
+      if (n > 0) {
+        applied++
+        touched.add('risks.md')
+        console.log(`applied: retired ${n} duplicate open-risk echo(s) → ## Retired`)
+      }
+      continue
+    }
     if (p.id !== 'archive-sessions') continue
     const cutDates = new Set(p.sessionBlocks.map(b => b.date))
     const keep = []
@@ -1808,13 +1943,61 @@ function cmdGarden(args) {
       atomicWriteFile(path.join(eng, 'context.md'), keep.join('\n').replace(/\n*$/, '\n'))
     })
     applied++
+    touched.add('context.md')
+    touched.add('context-archive.md')
     console.log(`applied: archived ${p.sessionBlocks.length} old session-end blocks → context-archive.md`)
   }
-  const hash = commitMemory(eng, 'garden', { files: ['context.md', 'context-archive.md'] })
+  const hash = commitMemory(eng, 'garden', { files: [...touched] })
   if (!applied) console.log('no mechanical proposals applied (manual items remain)')
   else console.log(`garden done${hash ? ` @${hash}` : ''}`)
 }
 
+// Keep the first open-risk bullet per fingerprint; move later echoes under ## Retired.
+function applyRiskDedupe(eng, clusters) {
+  const p = path.join(eng, 'risks.md')
+  let md = readEng(eng, 'risks.md')
+  if (!md) return 0
+  const echoTexts = new Set()
+  for (const group of clusters) {
+    for (let i = 1; i < group.length; i++) echoTexts.add(group[i])
+  }
+  if (!echoTexts.size) return 0
+  const retiredLines = []
+  const kept = []
+  let inRetired = false
+  let moved = 0
+  for (const raw of md.split('\n')) {
+    const t = raw.trim()
+    if (/^#{1,6}\s+Retired\b/i.test(t)) {
+      inRetired = true
+      kept.push(raw)
+      continue
+    }
+    if (!inRetired) {
+      const m = t.match(/^-\s*\[\d{4}-\d{2}-\d{2}\]\s*(?:\[@[^\]]+\]\s*)?(.*)$/)
+      if (m && echoTexts.has(m[1].trim())) {
+        retiredLines.push(raw)
+        moved++
+        continue
+      }
+    }
+    kept.push(raw)
+  }
+  if (!moved) return 0
+  let out = kept.join('\n')
+  if (!/^#{1,6}\s+Retired\b/im.test(out)) {
+    out = out.replace(/\n*$/, '\n\n## Retired\n')
+  }
+  const stamp = new Date().toISOString().slice(0, 10)
+  const block = retiredLines.map(l => {
+    const body = l.trim().replace(/^-\s*/, '')
+    return `- [${stamp}] (garden dedupe) ${body}`
+  }).join('\n')
+  out = appendUnderSection(out, 'Retired', block)
+  withFileLock(p, () => { atomicWriteFile(p, out.endsWith('\n') ? out : out + '\n') })
+  return moved
+}
+
 function engagementSlugFromPath(eng) {
   return path.basename(path.dirname(eng))
 }

package/bin/lib/memory.js

@@ -151,12 +151,32 @@ function createMemoryApi(deps) {
     } catch (_) { return '' }
   }
 
+  // True only when .git exists AND can resolve HEAD. A corrupt ledger (broken
+  // HEAD / missing objects) still has a .git directory — existsSync alone lied.
+  function memoryGitHealthy(eng) {
+    if (!eng) return { ok: false, reason: 'missing' }
+    if (!fs.existsSync(path.join(eng, '.git'))) return { ok: false, reason: 'missing' }
+    if (!gitBinOk()) return { ok: false, reason: 'no-git-bin' }
+    try {
+      execFileSync('git', ['rev-parse', '--verify', 'HEAD'], {
+        cwd: eng, encoding: 'utf8', timeout: 5000, stdio: ['ignore', 'pipe', 'ignore'],
+      })
+      execFileSync('git', ['status', '--porcelain'], {
+        cwd: eng, encoding: 'utf8', timeout: 10000, stdio: ['ignore', 'pipe', 'ignore'],
+      })
+      return { ok: true, reason: '' }
+    } catch (_) {
+      return { ok: false, reason: 'broken' }
+    }
+  }
+
   return {
     MEMORY_EPHEMERAL,
     memoryPorcelainPaths,
     memoryDirtyManual,
     commitMemory,
     memoryHead,
+    memoryGitHealthy,
     ensureMemoryGit,
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fdeops",
-  "version": "3.9.13",
+  "version": "3.9.15",
   "description": "Field kit for engineers embedded in client work - a real CLI (recon, memory, portfolio), one @fde skill with field judgment on top, and hooks that make it automatic. Claude Code plugin and any agent that loads skills.",
   "bin": {
     "fdeops": "bin/install.js",