fdeops 3.22.2 → 3.24.0

package/bin/fde.js

@@ -25,7 +25,7 @@
  *   fde capture             session-end snapshot → context.md (hooks use this)
  *   fde preserve            pre-compaction context snapshot (hook-internal; hooks use this)
  *   fde status [--all]      value ledger first, then trust (pass --all for portfolio)
- *   fde dashboard [--all]   current engagement fieldbook (default) or all (--all)
+ *   fde dashboard [--all] [--open] [--out <path>]  bound fieldbook, or all (--all)
  *   fde vault               derived Obsidian vault of the fieldbook (disposable; --redacted)
  */
 const fs = require('fs')
@@ -58,6 +58,26 @@ function sh(cmd, cwd) {
   } catch (_) { return '' }
 }
 
+// Hex hashes only - never a shell. True when olderHash is an ancestor of newerHash.
+function gitIsAncestor(eng, olderHash, newerHash) {
+  if (!olderHash || !newerHash || olderHash === newerHash) return false
+  if (!/^[0-9a-f]{7,64}$/i.test(olderHash) || !/^[0-9a-f]{7,64}$/i.test(newerHash)) return false
+  try {
+    execFileSync('git', ['merge-base', '--is-ancestor', olderHash, newerHash], {
+      cwd: eng, stdio: 'ignore', timeout: 15000,
+    })
+    return true
+  } catch (_) { return false }
+}
+
+function gitLogHash(eng, args) {
+  try {
+    return execFileSync('git', ['log', '-1', '--format=%H', ...args], {
+      cwd: eng, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'], timeout: 15000,
+    }).trim()
+  } catch (_) { return '' }
+}
+
 function slugify(name) {
   return String(name).toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '') || 'engagement'
 }
@@ -779,7 +799,7 @@ function firstLine(md, maxLen) {
 // not carry Working theory / Evidence / Differs from brief, do not scrape a
 // first line that might be the inherited brief and label it truth.
 function parseReality(md, maxLen) {
-  const theory = (md.match(/\*\*Working theory:\*\*\s*(.*)/i) || [])[1]
+  const theory = (md.match(/\*\*Working theory:\*\*[^\S\r\n]*(.*)/i) || [])[1]
   const hasSchema = /\*\*(Working theory|Evidence|Differs from brief how):\*\*/i.test(md)
   const theoryText = (theory || '').trim()
   if (theoryText) {
@@ -941,6 +961,7 @@ function colIndex(headers, rx) { return headers.findIndex(h => rx.test(h)) }
 const {
   personFromSignalText,
   signalSubjectKey,
+  isSignalNameNoise,
   nextActionLine,
   computeSignals,
   resumeTriage,
@@ -983,10 +1004,14 @@ function displayNameFromSignalText(text) {
   const person = personFromSignalText(text)
   if (person) return person
   const t = String(text).trim()
-  const proper = t.match(/^([A-Z][a-z]+(?:\s+[A-Z][a-z]+)?)/)
-  if (proper) return proper[1]
-  const word = t.split(/\s+/).find(w => w && !/^(dr|mr|mrs|ms)\.?$/i.test(w))
-  return word ? word.replace(/[^A-Za-z0-9.-]/g, '') : t.slice(0, 24)
+  const words = t.split(/\s+/).filter(w => {
+    const bare = w.replace(/[^A-Za-z0-9.-]/g, '')
+    return bare.length >= 2 && !isSignalNameNoise(bare) && !/^(dr|mr|mrs|ms)\.?$/i.test(bare)
+  })
+  if (!words.length) return ''
+  const proper = words.find(w => /^[A-Z][a-z]+(?:\s+[A-Z][a-z]+)?$/.test(w) || /^[A-Z]{2,}$/.test(w))
+  if (proper && !isSignalNameNoise(proper)) return proper.replace(/[^A-Za-z0-9. -]/g, '')
+  return words.slice(0, 2).join(' ').replace(/[^A-Za-z0-9. -]/g, '')
 }
 
 // Stakeholders for prep/dashboard: table rows PLUS people who only appear in
@@ -1043,8 +1068,10 @@ function extractStakeholders(eng) {
       const cur = byKey.get(key)
       byKey.set(key, { ...cur, signal: h.signal, note: cur.note || h.text.slice(0, 80) })
     } else {
+      const name = displayNameFromSignalText(h.text)
+      if (!name || isSignalNameNoise(name)) continue
       byKey.set(key, {
-        name: displayNameFromSignalText(h.text),
+        name,
         role: '',
         note: h.text.slice(0, 80),
         signal: h.signal,
@@ -1781,6 +1808,101 @@ function writeProposal(eng, text) {
   return { proposePath, clean, blocks }
 }
 
+function approvedStamp(text) {
+  const m = String(text || '').match(/\[approved:\s*([^\]]+)\]/i)
+  return m ? m[1].trim() : ''
+}
+
+function stripApprovedStamp(text) {
+  return String(text || '').replace(/\s*\[approved:\s*[^\]]+\]/i, '').trim()
+}
+
+// One screen a human can confirm in two minutes. The file-by-file routing
+// still prints after this - agents edit prefixes; people read this.
+function printDebriefReview(text) {
+  const buckets = { decided: [], asked: [], open: [], next: [], signer: [] }
+  for (const raw of String(text || '').split('\n')) {
+    const line = raw.trim().replace(/^[-*+]\s+/, '')
+    if (!line) continue
+    const m = line.match(/^(decision|risk|delivery|contact|next|signer):\s*(.+)$/i)
+    if (!m) continue
+    const type = m[1].toLowerCase()
+    const body = m[2]
+    if (type === 'decision') {
+      const who = approvedStamp(body)
+      const core = previewLine(stripApprovedStamp(body), 90)
+      buckets.decided.push(who ? `${core}  (approved ${who})` : `${core}  (unconfirmed)`)
+    } else if (type === 'delivery') {
+      buckets.asked.push(previewLine(body, 100))
+    } else if (type === 'risk') {
+      buckets.open.push(previewLine(body, 100))
+    } else if (type === 'next') {
+      buckets.next.push(previewLine(body, 100))
+    } else if (type === 'signer') {
+      buckets.signer.push(previewLine(body, 80))
+    }
+  }
+  console.log('REVIEW (one screen - confirm once, then apply)\n')
+  const order = [
+    ['decided', buckets.decided],
+    ['asked', buckets.asked],
+    ['open', buckets.open],
+    ['next', buckets.next],
+    ['signer', buckets.signer],
+  ]
+  let any = false
+  for (const [label, items] of order) {
+    if (!items.length) continue
+    any = true
+    console.log(`  ${label}:`)
+    for (const item of items) console.log(`    - ${item}`)
+  }
+  if (!any) console.log('  (nothing prefixed yet - edit .debrief-propose, then apply)')
+  console.log('')
+}
+
+function latestDatedDecision(md) {
+  let latest = { date: '', line: '' }
+  for (const raw of String(md || '').split('\n')) {
+    const t = raw.trim()
+    const m = t.match(/^[-*]\s*\[(\d{4}-\d{2}-\d{2})\]/)
+    if (!m) continue
+    if (m[1] >= latest.date) latest = { date: m[1], line: t }
+  }
+  return latest
+}
+
+function formatDecisionRecord(line) {
+  const raw = String(line || '').trim().replace(/^[-*]\s*/, '')
+  const who = approvedStamp(raw)
+  const core = stripApprovedStamp(raw)
+  const stamp = who ? `(approved ${who})` : '(unconfirmed)'
+  return previewLine(`${core}  ${stamp}`, 110)
+}
+
+function changeReviewIssues(eng) {
+  const issues = []
+  const del = latestDeliveryEntry(readClean(eng, 'delivery.md'))
+  const dec = latestDatedDecision(readClean(eng, 'decisions.md'))
+  const delHash = del.line
+    ? sh(`git log -1 --format=%H -S${JSON.stringify(del.line)} -- delivery.md`, eng)
+    : ''
+  if (del.date && dec.date && dec.date > del.date && delHash) {
+    issues.push(
+      'a decision landed after the last delivery line - review whether what you are shipping still matches'
+    )
+  }
+  if (claimedValueRows(eng).claimed && delHash) {
+    const sigHash = gitLogHash(eng, ['-GStakeholder who signs off|also named:', '--', 'success.md'])
+    if (sigHash && gitIsAncestor(eng, delHash, sigHash)) {
+      issues.push(
+        'the signer line changed while a measured number is still unaccepted - pending acceptance may need a new yes'
+      )
+    }
+  }
+  return issues
+}
+
 function readSealCount(eng) {
   try {
     const n = parseInt(fs.readFileSync(path.join(eng, DEBRIEF_SEAL), 'utf8').trim(), 10)
@@ -1904,7 +2026,9 @@ function cmdDebrief(args) {
     if (smart) {
     const { proposePath, clean, blocks } = writeProposal(eng, smartProposeText(input))
     console.log('SMART PROPOSE (heuristic - review before apply; no new facts invented beyond line rewrites)\n')
+    printDebriefReview(clean)
     console.log('Prefix vocabulary (lines that route): decision:  risk:  delivery:  contact:  next:  signer:')
+    console.log('Optional on a decision: [approved: Name YYYY-MM-DD]. Missing means unconfirmed.')
     console.log('Everything else → context.md. Keep the prefixes; the preview gate stays.\n')
     routeDebriefInput(eng, clean, { dry: true, force, sealed: blocks })
     if (!apply) {
@@ -2046,6 +2170,7 @@ function cmdIngest(args) {
     }
     const { proposePath, clean, blocks } = writeProposal(eng, smartProposeText(input))
     console.log(`INGEST PROPOSE from ${path.basename(item)} (via:${source})\n`)
+    printDebriefReview(clean)
     routeDebriefInput(eng, clean, { dry: true, force: false, sealed: blocks })
     console.log(`\nproposal saved → ${proposePath}`)
     console.log('confirm:  fde ingest apply')
@@ -2516,6 +2641,7 @@ function collectDoctorIssues(eng) {
   }
   const reality = parseReality(readClean(eng, 'reality.md'), 220)
   if (reality.missing) issues.push(reality.missing)
+  issues.push(...changeReviewIssues(eng))
   return issues
 }
 
@@ -2566,7 +2692,8 @@ function findAmbiguousStakeholders(eng) {
   for (const name of forms) {
     const key = signalSubjectKey(name)
     if (!key || key.startsWith('anon:')) continue
-    const norm = name.replace(/\s+/g, ' ').trim().toLowerCase()
+    const norm = name.replace(/\([^)]*\)/g, '').replace(/\s+/g, ' ').trim().toLowerCase()
+    if (!norm || norm.length < 2) continue
     if (!byKey.has(key)) byKey.set(key, new Set())
     byKey.get(key).add(norm)
   }
@@ -2654,6 +2781,7 @@ function parseValueLedger(eng) {
     promised: colIndex(table.headers, /promised/i),
     measured: colIndex(table.headers, /measured/i),
     accepted: colIndex(table.headers, /accept/i),
+    evidence: colIndex(table.headers, /evidence/i),
   }
   const cell = (row, i) => (i === -1 ? '' : String(row[i] || '').trim())
   const rows = []
@@ -2668,7 +2796,8 @@ function parseValueLedger(eng) {
     let state = 'unmeasured'
     if (!measuredPending && acceptedPending) state = 'claimed'
     else if (!measuredPending) state = 'accepted'
-    rows.push({ slice, promised, measured, accepted, state })
+    const evidence = cell(row, idx.evidence)
+    rows.push({ slice, promised, measured, accepted, evidence, evidenceMissing: !evidence || PENDING_CELL_RE.test(evidence), state })
   }
   return { rows, columnMissing: idx.accepted === -1 }
 }
@@ -2768,7 +2897,7 @@ function hygieneTriageLines(eng) {
   const top = issues[0].replace(/\s+/g, ' ').trim().slice(0, 72)
   return [
     `  hygiene: ${issues.length} issue(s) - ${top}${issues[0].length > 72 ? '…' : ''}`,
-    '    → say "@fde clean up the fieldbook" when ready (agent runs fde doctor; nothing auto-rewrites)',
+    '    → say "@fde clean up the fieldbook" when ready (agent runs fde doctor; nothing auto-rewrites), or: fde doctor',
   ]
 }
 
@@ -2798,7 +2927,7 @@ function recordDigest(eng) {
   }
   const decisions = readClean(eng, 'decisions.md').split('\n')
     .filter(l => /^-\s*\[\d{4}-\d{2}-\d{2}\]/.test(l.trim())).slice(-2)
-  for (const d of decisions) lines.push(`  decided: ${d.trim().replace(/^-\s*/, '').slice(0, 110)}`)
+  for (const d of decisions) lines.push(`  decided: ${formatDecisionRecord(d)}`)
   return ['RECORD (read-only - success, delivery, decisions)', ...lines]
 }
 
@@ -3211,6 +3340,7 @@ function cmdDashboard(args) {
   engagements.forEach(e => {
     const ctx = readClean(e.dir, 'context.md')
     e.next = (sectionBody(ctx, 'Next action', { lastNonEmpty: true }).split('\n').find(l => l.trim()) || '').trim()
+    e.next = e.next.replace(/^[-*]\s+/, '')
     e.hasNext = !!e.next
     e.lastSession = firstLine(sectionBody(ctx, 'Current state'), 240)
     // 220, not 140 - now that brief/reality each get their own full-width
@@ -3227,6 +3357,7 @@ function cmdDashboard(args) {
     e.risks = extractRisks(e.dir)
     e.log = extractLog(e.dir)
     e.stats = extractStats(e.dir)
+    e.valueRows = parseValueLedger(e.dir).rows
     e.highRisks = e.risks.filter(r => r.severity === 'high').length
     e.quiet = e.signals.ageDays !== Infinity && e.signals.ageDays >= 3
     e.slug = slugify(e.name)
@@ -3244,10 +3375,11 @@ function cmdDashboard(args) {
       ...e.log.map(g => g.text), ...e.risks.map(r => r.text),
       ...e.stakeholders.map(p => `${p.name} ${p.role} ${p.note}`),
       ...e.moreSections.map(s => s.title),
+      ...e.valueRows.map(r => `${r.slice} ${r.promised} ${r.measured} ${r.accepted} ${r.evidence}`),
     ].join(' ').toLowerCase())
   })
 
-  const html = render.buildFieldbookHtml({ engagements, today })
+  const html = render.buildFieldbookHtml({ engagements, today, generatedAt: new Date().toISOString() })
 
   try {
     fs.mkdirSync(path.dirname(outPath), { recursive: true })
@@ -3614,7 +3746,7 @@ function printUsage() {
   fde log phase <phase>    set engagement phase (land|discover|plan|ship|outcome|close)
   fde log --undo           remove the last CLI log/debrief entry from memory
   fde debrief [file]       meeting notes → memory (prefixed lines; --dry-run; --force)
-  fde debrief --smart      heuristic propose (prints decision:/risk:/delivery:/contact:/next:); --apply after confirm
+  fde debrief --smart      heuristic propose; REVIEW first (decided/asked/open/next/signer); --apply after one confirm
   fde ingest stage …       stage raw pull into <engagement>/.inbox/ (not .fde/)
   fde ingest list          list staged inbox items
   fde ingest propose <id>  smart-propose a staged item → .debrief-propose (confirm before apply)
@@ -3626,7 +3758,7 @@ function printUsage() {
   fde owner [set email]    who keeps this engagement record
   fde receipts <term>      "what did we agree?" with dates
   fde status [--all]       value ledger, then trust (pass --all for full portfolio)
-  fde dashboard [--all]    current engagement fieldbook (pass --all for every client)
+  fde dashboard [--all] [--open] [--out <path>]  bound fieldbook (pass --all for every client)
   fde vault                derived Obsidian vault of every engagement (--current for one, --redacted for a shared screen, --out <dir>)
   hooks call these; you do not: capture (session-end snapshot), preserve (pre-compaction snapshot)
   env FDEOPS_ENGAGEMENTS_ROOT  override ~/fde-engagements (init/status/dashboard/registry)

package/bin/lib/fieldbook-client.js

@@ -0,0 +1,166 @@
+'use strict'
+
+// Embedded verbatim in the offline fieldbook. No imports, network, or record writes.
+module.exports = function fieldbookClient() {
+  const all = selector => Array.from(document.querySelectorAll(selector))
+  const views = all('.fb-view')
+  const nav = all('.fb-nav')
+  const search = document.getElementById('fb-search')
+  const main = document.querySelector('.fb-main')
+  const status = document.getElementById('fb-status')
+  const palette = document.getElementById('fb-palette-dialog')
+  const paletteInput = document.getElementById('fb-palette-input')
+  const items = all('.fb-palette-item')
+  const promptDialog = document.getElementById('fb-prompt-dialog')
+  let returnFocus = null
+  let active = 0
+  const currentId = () => document.querySelector('.fb-view:not([hidden])').id.replace('view-', '')
+  function selectView(id, updateHash = true, focus = false) {
+    if (id === 'fb-main') { id = 'today'; updateHash = false }
+    if (!document.getElementById('view-' + id)) id = 'today'
+    views.forEach(v => { v.hidden = v.id !== 'view-' + id })
+    nav.forEach(n => {
+      const selected = n.dataset.target === id
+      n.classList.toggle('active', selected)
+      if (selected) n.setAttribute('aria-current', 'page')
+      else n.removeAttribute('aria-current')
+    })
+    if (updateHash && location.hash !== '#' + id) location.hash = id
+    main.scrollTop = 0
+    if (focus) document.querySelector('.fb-view:not([hidden]) h1').focus()
+  }
+  const hashId = () => location.hash.slice(1)
+  selectView(hashId() || 'today', false)
+  window.addEventListener('hashchange', () => selectView(hashId(), false))
+  const skip = document.querySelector('.fb-skip')
+  if (skip) skip.addEventListener('click', event => {
+    event.preventDefault()
+    main.focus()
+  })
+  nav.forEach(n => n.addEventListener('click', () => selectView(n.dataset.target, true, true)))
+  all('[data-nav]').forEach(n => n.addEventListener('click', () => selectView(n.dataset.nav, true, true)))
+
+  // Only escaped fragments become markup; engagement strings never become code.
+  const esc = s => s.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;')
+  function snippet(raw, term) {
+    const i = raw.indexOf(term)
+    const start = Math.max(0, i - 24), end = Math.min(raw.length, i + term.length + 40)
+    return (start ? '…' : '') + esc(raw.slice(start, i)) + '<mark>' + esc(raw.slice(i, i + term.length)) + '</mark>' + esc(raw.slice(i + term.length, end)) + (end < raw.length ? '…' : '')
+  }
+  search.addEventListener('input', () => {
+    const term = search.value.trim().toLowerCase()
+    let count = 0
+    nav.filter(n => n.dataset.target !== 'today').forEach(n => {
+      const raw = n.dataset.search || ''
+      const hit = !term || raw.includes(term)
+      n.classList.toggle('hide', !hit)
+      if (hit) count++
+      const reason = n.querySelector('.fb-nav-reason')
+      if (term && hit) reason.innerHTML = snippet(raw, term)
+      else reason.textContent = n.dataset.defaultReason || ''
+      reason.classList.toggle('hide', !reason.textContent)
+    })
+    document.getElementById('fb-search-empty').hidden = !term || count > 0
+    document.getElementById('fb-search-count').textContent = term ? count + ' matching engagement' + (count === 1 ? '' : 's') : ''
+  })
+
+  function toggleTheme() {
+    const next = document.documentElement.dataset.fdeTheme === 'dark' ? 'light' : 'dark'
+    document.documentElement.dataset.fdeTheme = next
+    try { localStorage.setItem('fde-fieldbook-theme', next) } catch (_) {}
+    themeLabel()
+  }
+  function themeLabel() {
+    const dark = document.documentElement.dataset.fdeTheme === 'dark'
+    document.getElementById('fde-theme-btn').textContent = dark ? 'Light theme' : 'Dark theme'
+  }
+  themeLabel()
+  document.getElementById('fde-theme-btn').addEventListener('click', toggleTheme)
+  document.getElementById('fb-print-btn').addEventListener('click', () => window.print())
+
+  function openDialog(dialog) {
+    returnFocus = document.activeElement
+    dialog.showModal()
+  }
+  ;[palette, promptDialog].forEach(dialog => {
+    dialog.addEventListener('close', () => { if (returnFocus) returnFocus.focus() })
+    dialog.addEventListener('click', event => { if (event.target === dialog) dialog.close() })
+    // Native modal dialogs isolate background controls; contain Tab explicitly
+    // so keyboard focus never escapes into browser chrome between controls.
+    dialog.addEventListener('keydown', event => {
+      if (event.key !== 'Tab') return
+      const controls = Array.from(dialog.querySelectorAll('input, textarea, button')).filter(el => !el.hidden && !el.classList.contains('hide'))
+      const first = controls[0], last = controls[controls.length - 1]
+      if (event.shiftKey && document.activeElement === first) { event.preventDefault(); last.focus() }
+      else if (!event.shiftKey && document.activeElement === last) { event.preventDefault(); first.focus() }
+    })
+  })
+  all('[data-close-dialog]').forEach(button => button.addEventListener('click', () => button.closest('dialog').close()))
+  const visibleItems = () => items.filter(it => !it.classList.contains('hide'))
+  function highlight() {
+    const visible = visibleItems()
+    items.forEach(it => it.classList.remove('active'))
+    if (visible[active]) visible[active].classList.add('active')
+  }
+  function filterPalette() {
+    const term = paletteInput.value.trim().toLowerCase()
+    items.forEach(it => it.classList.toggle('hide', !it.textContent.toLowerCase().includes(term)))
+    active = 0
+    highlight()
+    document.getElementById('fb-palette-empty').hidden = visibleItems().length > 0
+  }
+  function openPalette() { openDialog(palette); paletteInput.value = ''; filterPalette(); paletteInput.focus() }
+  function runItem(it) {
+    if (!it) return
+    palette.close()
+    if (it.dataset.target === '__theme__') toggleTheme()
+    else selectView(it.dataset.target, true, true)
+  }
+  document.getElementById('fb-palette-btn').addEventListener('click', openPalette)
+  paletteInput.addEventListener('input', filterPalette)
+  items.forEach(it => it.addEventListener('click', () => runItem(it)))
+  paletteInput.addEventListener('keydown', event => {
+    if (event.key === 'ArrowDown' || event.key === 'ArrowUp') {
+      event.preventDefault()
+      active = Math.max(0, Math.min(visibleItems().length - 1, active + (event.key === 'ArrowDown' ? 1 : -1)))
+      highlight()
+      if (visibleItems()[active]) visibleItems()[active].scrollIntoView({ block: 'nearest' })
+    }
+    if (event.key === 'Enter') { event.preventDefault(); runItem(visibleItems()[active]) }
+  })
+
+  all('[data-prompt]').forEach(button => button.addEventListener('click', async () => {
+    const text = button.dataset.prompt
+    try {
+      await navigator.clipboard.writeText(text)
+      status.textContent = 'Prompt copied. Paste it into your coding agent; review changes before saving.'
+    } catch (_) {
+      const input = document.getElementById('fb-prompt-text')
+      input.value = text
+      openDialog(promptDialog)
+      input.focus(); input.select()
+    }
+  }))
+  document.addEventListener('keydown', event => {
+    if ((event.metaKey || event.ctrlKey) && event.key.toLowerCase() === 'k') {
+      event.preventDefault()
+      if (!promptDialog.open) { if (palette.open) palette.close(); else openPalette() }
+      return
+    }
+    if (palette.open || promptDialog.open || event.metaKey || event.ctrlKey || event.altKey) return
+    const typing = event.target.matches('input, textarea, select') || event.target.isContentEditable
+    if (typing) {
+      if (event.key === 'Escape') { search.value = ''; search.dispatchEvent(new Event('input')); event.target.blur() }
+      return
+    }
+    if (event.target.closest('.fb-table-scroll')) return
+    if (event.key === '/') { event.preventDefault(); search.focus(); return }
+    if (event.key === 'j' || event.key === 'k' || (event.target.closest('.fb-rail') && ['ArrowDown', 'ArrowUp'].includes(event.key))) {
+      event.preventDefault()
+      const ids = nav.filter(n => !n.classList.contains('hide')).map(n => n.dataset.target)
+      const delta = event.key === 'j' || event.key === 'ArrowDown' ? 1 : -1
+      const next = ids[Math.max(0, Math.min(ids.length - 1, ids.indexOf(currentId()) + delta))]
+      if (next) selectView(next)
+    }
+  })
+}