fdeops 3.22.1 → 3.23.0

package/README.md

@@ -34,7 +34,7 @@ One chat. Name the client:
 @fde this is client01
 ```
 
-That creates `~/fde-engagements/client01/.fde/` on your laptop. Paste kickoff notes in the same thread. `@fde` picks what to check. You still decide.
+That creates `~/fde-engagements/client01/.fde/` on your laptop. Paste kickoff notes in the same thread. `@fde` picks what to check. You still decide. After a meeting you get one screen: what changed, new asks, open questions, next actions. Confirm once.
 
 Day to day: [docs/USAGE.md](docs/USAGE.md).
 

package/bin/check.js

@@ -636,6 +636,11 @@ if (apManifest.$schema !== AP_PLUGIN_SCHEMA) {
   fail(`version mismatch package.json ${pkg.version} vs plugin.json ${apManifest.version}`)
 } else ok('agent plugins manifest')
 
+const ingestPkg = JSON.parse(read('mcp/fdeops-ingest/package.json'))
+if (ingestPkg.version !== pkg.version) {
+  fail(`version mismatch package.json ${pkg.version} vs mcp/fdeops-ingest ${ingestPkg.version}`)
+} else ok('ingest package version aligned')
+
 const apMcp = JSON.parse(read('mcp.json'))
 const apServers = apMcp.mcpServers || {}
 if (apMcp.$schema !== AP_MCP_SCHEMA) {

package/bin/fde.js

@@ -58,6 +58,26 @@ function sh(cmd, cwd) {
   } catch (_) { return '' }
 }
 
+// Hex hashes only - never a shell. True when olderHash is an ancestor of newerHash.
+function gitIsAncestor(eng, olderHash, newerHash) {
+  if (!olderHash || !newerHash || olderHash === newerHash) return false
+  if (!/^[0-9a-f]{7,64}$/i.test(olderHash) || !/^[0-9a-f]{7,64}$/i.test(newerHash)) return false
+  try {
+    execFileSync('git', ['merge-base', '--is-ancestor', olderHash, newerHash], {
+      cwd: eng, stdio: 'ignore', timeout: 15000,
+    })
+    return true
+  } catch (_) { return false }
+}
+
+function gitLogHash(eng, args) {
+  try {
+    return execFileSync('git', ['log', '-1', '--format=%H', ...args], {
+      cwd: eng, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'], timeout: 15000,
+    }).trim()
+  } catch (_) { return '' }
+}
+
 function slugify(name) {
   return String(name).toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '') || 'engagement'
 }
@@ -1610,20 +1630,38 @@ function smartProposeText(input) {
   return out.join('\n') + (out.length ? '\n' : '')
 }
 
-// "Priya signs off" is the most expensive sentence in a kickoff and used to land
-// in context.md as a note. signer: fills the success.md line the whole kit
-// keys on, and logs the person as a contact so prep/status can see them.
-const SIGNER_RX = /^(?<who>[A-Z][\w.'-]+(?:\s+[A-Z][\w.'-]+){0,3}(?:\s*\([^)]{1,40}\))?)\s+(?:signs?(?:\s+off)?|approves|has (?:the )?final say|can say yes|owns the decision|is the (?:sponsor|signer|decision[- ]maker))\b/
+// Kickoff English, not only "signer: Priya". "Helena signs off", "Anand Mehta
+// has final say", "Finance controller (Helena) signs off" all have to fill
+// success.md - that is the line Monday's RECORD reads.
+const SIGNER_VERB = '(?:signs?(?:\\s+off)?|approves|has (?:the )?final say|can say yes|owns the decision|is the (?:sponsor|signer|decision[- ]maker))'
+const SIGNER_NAME = '([A-Z][\\w.\'-]+(?:\\s+[A-Z][\\w.\'-]+){0,3})'
+const NOT_A_PERSON = /^(The|This|That|It|We|They|She|He|Staging|Budget|Prod|Production|Nobody|Someone|Everyone|Finance|Legal|Security|Platform|Engineering)\b/
+const ROLE_TOKEN = /\b(VP|SVP|EVP|CTO|CFO|COO|CEO|CISO|Eng|Engineer|Director|Lead|Head|Manager|Controller|Ops|Legal|Finance|Sponsor)\b/i
+
+function looksLikePersonName(s) {
+  const t = String(s || '').trim()
+  if (!t || NOT_A_PERSON.test(t) || ROLE_TOKEN.test(t)) return false
+  return /^[A-Z][\w.'-]+(?:\s+[A-Z][\w.'-]+){0,2}$/.test(t)
+}
 
 function signerFromLine(text) {
-  const t = String(text || '').trim()
-  const m = t.match(SIGNER_RX)
-  if (!m) return ''
-  const who = m.groups.who.trim()
-  // "Staging exists" / "The API is slow" also match "Capital Word + verb"; a
-  // sentence-initial common noun is not a person.
-  if (/^(The|This|That|It|We|They|Staging|Budget|Prod|Production|Nobody|Someone|Everyone)\b/.test(who)) return ''
-  return who
+  const t = String(text || '').replace(/^[-*+]\s+/, '').trim()
+  if (!t) return ''
+  // "Priya (VP Eng) signs off" → Priya. "Finance controller (Helena) signs off" → Helena.
+  const titled = t.match(new RegExp('\\b' + SIGNER_NAME + '\\s+\\(' + SIGNER_NAME + '\\)\\s+' + SIGNER_VERB + '\\b'))
+  if (titled) {
+    const before = titled[1].trim()
+    const inside = titled[2].trim()
+    if (looksLikePersonName(before) && ROLE_TOKEN.test(inside)) return before
+    if (looksLikePersonName(inside)) return inside
+    if (looksLikePersonName(before)) return before
+  }
+  const paren = t.match(new RegExp('\\(' + SIGNER_NAME + '\\)\\s+' + SIGNER_VERB + '\\b'))
+  if (paren && looksLikePersonName(paren[1])) return paren[1].trim()
+  const named = t.match(new RegExp('\\b' + SIGNER_NAME + '\\s+' + SIGNER_VERB + '\\b'))
+  if (!named) return ''
+  const who = named[1].trim()
+  return looksLikePersonName(who) ? who : ''
 }
 
 function setSigner(eng, who) {
@@ -1763,6 +1801,101 @@ function writeProposal(eng, text) {
   return { proposePath, clean, blocks }
 }
 
+function approvedStamp(text) {
+  const m = String(text || '').match(/\[approved:\s*([^\]]+)\]/i)
+  return m ? m[1].trim() : ''
+}
+
+function stripApprovedStamp(text) {
+  return String(text || '').replace(/\s*\[approved:\s*[^\]]+\]/i, '').trim()
+}
+
+// One screen a human can confirm in two minutes. The file-by-file routing
+// still prints after this - agents edit prefixes; people read this.
+function printDebriefReview(text) {
+  const buckets = { decided: [], asked: [], open: [], next: [], signer: [] }
+  for (const raw of String(text || '').split('\n')) {
+    const line = raw.trim().replace(/^[-*+]\s+/, '')
+    if (!line) continue
+    const m = line.match(/^(decision|risk|delivery|contact|next|signer):\s*(.+)$/i)
+    if (!m) continue
+    const type = m[1].toLowerCase()
+    const body = m[2]
+    if (type === 'decision') {
+      const who = approvedStamp(body)
+      const core = previewLine(stripApprovedStamp(body), 90)
+      buckets.decided.push(who ? `${core}  (approved ${who})` : `${core}  (unconfirmed)`)
+    } else if (type === 'delivery') {
+      buckets.asked.push(previewLine(body, 100))
+    } else if (type === 'risk') {
+      buckets.open.push(previewLine(body, 100))
+    } else if (type === 'next') {
+      buckets.next.push(previewLine(body, 100))
+    } else if (type === 'signer') {
+      buckets.signer.push(previewLine(body, 80))
+    }
+  }
+  console.log('REVIEW (one screen - confirm once, then apply)\n')
+  const order = [
+    ['decided', buckets.decided],
+    ['asked', buckets.asked],
+    ['open', buckets.open],
+    ['next', buckets.next],
+    ['signer', buckets.signer],
+  ]
+  let any = false
+  for (const [label, items] of order) {
+    if (!items.length) continue
+    any = true
+    console.log(`  ${label}:`)
+    for (const item of items) console.log(`    - ${item}`)
+  }
+  if (!any) console.log('  (nothing prefixed yet - edit .debrief-propose, then apply)')
+  console.log('')
+}
+
+function latestDatedDecision(md) {
+  let latest = { date: '', line: '' }
+  for (const raw of String(md || '').split('\n')) {
+    const t = raw.trim()
+    const m = t.match(/^[-*]\s*\[(\d{4}-\d{2}-\d{2})\]/)
+    if (!m) continue
+    if (m[1] >= latest.date) latest = { date: m[1], line: t }
+  }
+  return latest
+}
+
+function formatDecisionRecord(line) {
+  const raw = String(line || '').trim().replace(/^[-*]\s*/, '')
+  const who = approvedStamp(raw)
+  const core = stripApprovedStamp(raw)
+  const stamp = who ? `(approved ${who})` : '(unconfirmed)'
+  return previewLine(`${core}  ${stamp}`, 110)
+}
+
+function changeReviewIssues(eng) {
+  const issues = []
+  const del = latestDeliveryEntry(readClean(eng, 'delivery.md'))
+  const dec = latestDatedDecision(readClean(eng, 'decisions.md'))
+  const delHash = del.line
+    ? sh(`git log -1 --format=%H -S${JSON.stringify(del.line)} -- delivery.md`, eng)
+    : ''
+  if (del.date && dec.date && dec.date > del.date && delHash) {
+    issues.push(
+      'a decision landed after the last delivery line - review whether what you are shipping still matches'
+    )
+  }
+  if (claimedValueRows(eng).claimed && delHash) {
+    const sigHash = gitLogHash(eng, ['-GStakeholder who signs off|also named:', '--', 'success.md'])
+    if (sigHash && gitIsAncestor(eng, delHash, sigHash)) {
+      issues.push(
+        'the signer line changed while a measured number is still unaccepted - pending acceptance may need a new yes'
+      )
+    }
+  }
+  return issues
+}
+
 function readSealCount(eng) {
   try {
     const n = parseInt(fs.readFileSync(path.join(eng, DEBRIEF_SEAL), 'utf8').trim(), 10)
@@ -1886,7 +2019,9 @@ function cmdDebrief(args) {
     if (smart) {
     const { proposePath, clean, blocks } = writeProposal(eng, smartProposeText(input))
     console.log('SMART PROPOSE (heuristic - review before apply; no new facts invented beyond line rewrites)\n')
+    printDebriefReview(clean)
     console.log('Prefix vocabulary (lines that route): decision:  risk:  delivery:  contact:  next:  signer:')
+    console.log('Optional on a decision: [approved: Name YYYY-MM-DD]. Missing means unconfirmed.')
     console.log('Everything else → context.md. Keep the prefixes; the preview gate stays.\n')
     routeDebriefInput(eng, clean, { dry: true, force, sealed: blocks })
     if (!apply) {
@@ -2028,6 +2163,7 @@ function cmdIngest(args) {
     }
     const { proposePath, clean, blocks } = writeProposal(eng, smartProposeText(input))
     console.log(`INGEST PROPOSE from ${path.basename(item)} (via:${source})\n`)
+    printDebriefReview(clean)
     routeDebriefInput(eng, clean, { dry: true, force: false, sealed: blocks })
     console.log(`\nproposal saved → ${proposePath}`)
     console.log('confirm:  fde ingest apply')
@@ -2134,7 +2270,7 @@ function cmdReceipts(args) {
     agreed.map(h => (h.match(/^\s*([^:]+):/) || [])[1]).filter(f => f && dirtySet.has(f))
   )]
   if (agreed.length) {
-    console.log('ON RECORD (dated - defensible):')
+    console.log('ON RECORD (dated):')
     agreed.forEach(h => {
       const file = (h.match(/^\s*([^:]+):/) || [])[1]
       console.log(h + (file && dirtySet.has(file) ? '  ⚠ dirty file' : ''))
@@ -2498,6 +2634,7 @@ function collectDoctorIssues(eng) {
   }
   const reality = parseReality(readClean(eng, 'reality.md'), 220)
   if (reality.missing) issues.push(reality.missing)
+  issues.push(...changeReviewIssues(eng))
   return issues
 }
 
@@ -2620,7 +2757,7 @@ function hasValueBucket(eng) {
 // "pending review", "TBD.", "n/a (blocked)" and "..." are all the same thing an
 // FDE means by an empty cell - nagging about them teaches people to ignore doctor.
 const PENDING_CELL_RE =
-  /^(?:pending|tbd|to ?be ?(?:measured|confirmed|determined)|n\s*\/\s*a|na|none|unknown|not measured|\?+|\.{2,}|…|-+|-+|-+)(?:[^\w].*)?$/i
+  /^(?:pending|tbd|to ?be ?(?:measured|confirmed|determined)|n\s*\/\s*a|na|none|unknown|not(?:\s+yet)?\s+measured|unmeasured|awaiting|\?+|\.{2,}|…|-+)(?:[^\w].*)?$/i
 
 function parseValueLedger(eng) {
   // Last section with actual rows, not merely the last non-empty one: a template
@@ -2704,7 +2841,7 @@ function engagementTouchesAI(eng) {
   ].join('\n'))
   // No bare "prompt": "prompt response" / "prompt payment" is ordinary delivery
   // English and would fail every non-AI ship on a missing eval receipt.
-  return /\b(llm|rag|embedding|model card|model output|model drift|agentic|openai|anthropic|vector database|vector db|fine-tun\w*|hallucinat\w*)\b|\bmodel inference\b|\binference (?:api|endpoint|server|engine)\b|\b(?:system|model|user)\s+prompts?\b|\bprompt (?:engineering|injection|template)/i.test(blob)
+  return /\bAI in scope\b|\b(llm|rag|embedding|model card|model output|model drift|agentic|openai|anthropic|vector database|vector db|fine-tun\w*|hallucinat\w*)\b|\bmodel inference\b|\binference (?:api|endpoint|server|engine)\b|\b(?:system|model|user)\s+prompts?\b|\bprompt (?:engineering|injection|template)/i.test(blob)
 }
 
 // The repo says AI even when the record does not. Read-only, capped, local: the
@@ -2750,7 +2887,7 @@ function hygieneTriageLines(eng) {
   const top = issues[0].replace(/\s+/g, ' ').trim().slice(0, 72)
   return [
     `  hygiene: ${issues.length} issue(s) - ${top}${issues[0].length > 72 ? '…' : ''}`,
-    '    → say "@fde clean up the fieldbook" when ready (agent runs fde doctor; nothing auto-rewrites)',
+    '    → say "@fde clean up the fieldbook" when ready (agent runs fde doctor; nothing auto-rewrites), or: fde doctor',
   ]
 }
 
@@ -2780,7 +2917,7 @@ function recordDigest(eng) {
   }
   const decisions = readClean(eng, 'decisions.md').split('\n')
     .filter(l => /^-\s*\[\d{4}-\d{2}-\d{2}\]/.test(l.trim())).slice(-2)
-  for (const d of decisions) lines.push(`  decided: ${d.trim().replace(/^-\s*/, '').slice(0, 110)}`)
+  for (const d of decisions) lines.push(`  decided: ${formatDecisionRecord(d)}`)
   return ['RECORD (read-only - success, delivery, decisions)', ...lines]
 }
 
@@ -3596,7 +3733,7 @@ function printUsage() {
   fde log phase <phase>    set engagement phase (land|discover|plan|ship|outcome|close)
   fde log --undo           remove the last CLI log/debrief entry from memory
   fde debrief [file]       meeting notes → memory (prefixed lines; --dry-run; --force)
-  fde debrief --smart      heuristic propose (prints decision:/risk:/delivery:/contact:/next:); --apply after confirm
+  fde debrief --smart      heuristic propose; REVIEW first (decided/asked/open/next/signer); --apply after one confirm
   fde ingest stage …       stage raw pull into <engagement>/.inbox/ (not .fde/)
   fde ingest list          list staged inbox items
   fde ingest propose <id>  smart-propose a staged item → .debrief-propose (confirm before apply)
@@ -3618,6 +3755,10 @@ function printUsage() {
 }
 
 const [cmd, ...args] = process.argv.slice(2)
+if (args.includes('--help') || args.includes('-h') || cmd === 'help' || cmd === '--help' || cmd === '-h') {
+  printUsage()
+  process.exit(0)
+}
 switch (cmd) {
   case 'demo': cmdDemo(args); break
   case 'scan': cmdScan(); break

package/mcp/fdeops-ingest/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fdeops-ingest-mcp",
-  "version": "3.22.1",
+  "version": "3.23.0",
   "private": true,
   "description": "Thin stdio MCP sink for FDEOps ingest (stage → propose → apply). Zero runtime dependencies.",
   "bin": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fdeops",
-  "version": "3.22.1",
+  "version": "3.23.0",
   "description": "Forward deployed engineering skills for AI coding agents. One @fde skill for the client work around the code: who can say yes, what went live, whether they signed off. Dated markdown on your laptop. You confirm each write.",
   "bin": {
     "fdeops": "bin/install.js",

package/plugin.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json",
   "name": "fdeops",
-  "version": "3.22.1",
+  "version": "3.23.0",
   "description": "Forward deployed engineering skills for AI coding agents. One @fde skill for the client work around the code. You confirm; then it lands in .fde/ on your laptop.",
   "author": {
     "name": "Subash Natarajan",

package/skills/fde/SKILL.md

@@ -28,7 +28,7 @@ A one-line typo or compile error in a file that will not ship. On a bound client
 | **When did we agree?** | Don't argue from memory. Search the record. | `fde receipts <term>` | - |
 | **What's the outcome?** | A number nobody signed is claimed, not delivered. | `fde status` | `references/readout.md` |
 
-After a meeting: `fde debrief --smart` → confirm → `--apply`. Walk-in: `fde prep`. Friday: `fde status`.
+After a meeting: `fde debrief --smart` → one REVIEW screen (decided / asked / open / next / signer) → confirm once → `--apply`. Walk-in: `fde prep`. Friday: `fde status`.
 
 ## Ground loop
 
@@ -65,7 +65,7 @@ Writes need a bind (`FDEOPS_ENGAGEMENT` or registry). Never install fdeops on in
 |----------|---------|
 | where are we | `fde resume` |
 | day-1 look at the repo | `fde scan` |
-| debrief / pasted notes | `fde debrief --smart` → you rewrite prefixes → confirm → `--apply`. `--smart` is a gate, not a brain. `references/debrief.md` |
+| debrief / pasted notes | `fde debrief --smart` → REVIEW → confirm once → `--apply`. `--smart` is a gate, not a brain. `references/debrief.md` |
 | prep me for … | `fde prep "<label>"` |
 | when did we agree | `fde receipts <term>` |
 | sponsor update / the outcome | `fde status` |

package/skills/fde/references/debrief.md

@@ -24,12 +24,13 @@
 2. Run `fde debrief --smart <notes.md>` (or `npx fdeops debrief --smart …`).
 3. Open `.debrief-propose`. If lines lack type prefixes, **rewrite them** before showing the FDE, e.g.:
    - `decision: agreed chargebacks stay phase 2 - Priya`
+   - `decision: freeze the API [approved: Priya 2026-09-08]` (optional; missing means unconfirmed)
    - `risk: legal may reopen scope if we slip the SOW date`
    - `contact: Priya pushed hard on Friday deck [signal:amber]`
    - `signer: Priya` (she can say yes; lands in `success.md`)
    - `next: send one-pager before Thursday 9am`
    - unprefixed lines stay context color only
-4. Show the **proposed** routing in plain language (what would become decisions, risks, contacts, next).
+4. Show the **REVIEW** block first (decided / asked / open / next / signer). That is the one screen to confirm. File routing stays underneath.
 5. On FDE confirm → run `fde debrief --apply`.
 6. On reject → stop; ask what to change; do not apply.