fastify 5.2.0 → 5.2.2

package/test/server.test.js

@@ -2,8 +2,6 @@
 
 const { test } = require('node:test')
 const Fastify = require('..')
-const sget = require('simple-get').concat
-const undici = require('undici')
 
 test('listen should accept null port', async t => {
   const fastify = Fastify()
@@ -13,176 +11,3 @@ test('listen should accept null port', async t => {
     fastify.listen({ port: null })
   )
 })
-
-test('listen should accept undefined port', async t => {
-  const fastify = Fastify()
-  t.after(() => fastify.close())
-
-  await t.assert.doesNotReject(
-    fastify.listen({ port: undefined })
-  )
-})
-
-test('listen should accept stringified number port', async t => {
-  const fastify = Fastify()
-  t.after(() => fastify.close())
-
-  await t.assert.doesNotReject(
-    fastify.listen({ port: '1234' })
-  )
-})
-
-test('listen should accept log text resolution function', async t => {
-  const fastify = Fastify()
-  t.after(() => fastify.close())
-
-  await t.assert.doesNotReject(
-    fastify.listen({
-      host: '127.0.0.1',
-      port: '1234',
-      listenTextResolver: (address) => {
-        t.assert.strictEqual(address, 'http://127.0.0.1:1234')
-        return 'hardcoded text'
-      }
-    })
-  )
-})
-
-test('listen should reject string port', async (t) => {
-  const fastify = Fastify()
-  t.after(() => fastify.close())
-
-  try {
-    await fastify.listen({ port: 'hello-world' })
-  } catch (error) {
-    t.assert.strictEqual(error.code, 'ERR_SOCKET_BAD_PORT')
-  }
-
-  try {
-    await fastify.listen({ port: '1234hello' })
-  } catch (error) {
-    t.assert.strictEqual(error.code, 'ERR_SOCKET_BAD_PORT')
-  }
-})
-
-test('Test for hostname and port', (t, end) => {
-  const app = Fastify()
-  t.after(() => app.close())
-  app.get('/host', (req, res) => {
-    const host = 'localhost:8000'
-    t.assert.strictEqual(req.host, host)
-    t.assert.strictEqual(req.hostname, req.host.split(':')[0])
-    t.assert.strictEqual(req.port, Number(req.host.split(':')[1]))
-    res.send('ok')
-  })
-
-  app.listen({ port: 8000 }, () => {
-    sget('http://localhost:8000/host', () => { end() })
-  })
-})
-
-test('abort signal', async t => {
-  await t.test('listen should not start server', (t, end) => {
-    t.plan(2)
-    function onClose (instance, done) {
-      t.assert.strictEqual(instance, fastify)
-      done()
-      end()
-    }
-    const controller = new AbortController()
-
-    const fastify = Fastify()
-    fastify.addHook('onClose', onClose)
-    fastify.listen({ port: 1234, signal: controller.signal }, (err) => {
-      t.assert.ifError(err)
-    })
-    controller.abort()
-    t.assert.strictEqual(fastify.server.listening, false)
-  })
-
-  await t.test('listen should not start server if already aborted', (t, end) => {
-    t.plan(2)
-    function onClose (instance, done) {
-      t.assert.strictEqual(instance, fastify)
-      done()
-      end()
-    }
-
-    const controller = new AbortController()
-    controller.abort()
-    const fastify = Fastify()
-    fastify.addHook('onClose', onClose)
-    fastify.listen({ port: 1234, signal: controller.signal }, (err) => {
-      t.assert.ifError(err)
-    })
-    t.assert.strictEqual(fastify.server.listening, false)
-  })
-
-  await t.test('listen should throw if received invalid signal', t => {
-    t.plan(2)
-    const fastify = Fastify()
-
-    try {
-      fastify.listen({ port: 1234, signal: {} }, (err) => {
-        t.assert.ifError(err)
-      })
-      t.assert.fail('should throw')
-    } catch (e) {
-      t.assert.strictEqual(e.code, 'FST_ERR_LISTEN_OPTIONS_INVALID')
-      t.assert.strictEqual(e.message, 'Invalid listen options: \'Invalid options.signal\'')
-    }
-  })
-})
-
-test('#5180 - preClose should be called before closing secondary server', async (t) => {
-  t.plan(2)
-  const fastify = Fastify({ forceCloseConnections: true })
-  let flag = false
-  t.after(() => fastify.close())
-
-  fastify.addHook('preClose', () => {
-    flag = true
-  })
-
-  fastify.get('/', async (req, reply) => {
-    // request will be pending for 1 second to simulate a slow request
-    await new Promise((resolve) => { setTimeout(resolve, 1000) })
-    return { hello: 'world' }
-  })
-
-  fastify.listen({ port: 0 }, (err) => {
-    t.assert.ifError(err)
-    const addresses = fastify.addresses()
-    const mainServerAddress = fastify.server.address()
-    let secondaryAddress
-    for (const addr of addresses) {
-      if (addr.family !== mainServerAddress.family) {
-        secondaryAddress = addr
-        secondaryAddress.address = secondaryAddress.family === 'IPv6'
-          ? `[${secondaryAddress.address}]`
-          : secondaryAddress.address
-        break
-      }
-    }
-
-    if (!secondaryAddress) {
-      t.assert.ok(true, 'Secondary address not found')
-      return
-    }
-
-    undici.request(`http://${secondaryAddress.address}:${secondaryAddress.port}/`)
-      .then(
-        () => { t.assert.fail('Request should not succeed') },
-        () => {
-          t.assert.ok(flag)
-        }
-      )
-
-    // Close the server while the slow request is pending
-    setTimeout(fastify.close, 250)
-  })
-
-  // Wait 1000ms to ensure that the test is finished and async operations are
-  // completed
-  await new Promise((resolve) => { setTimeout(resolve, 1000) })
-})

package/test/stream.5.test.js

@@ -1,14 +1,13 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const proxyquire = require('proxyquire')
 const fs = require('node:fs')
 const Readable = require('node:stream').Readable
 const sget = require('simple-get').concat
 const Fastify = require('..')
 
-test('should destroy stream when response is ended', t => {
+test('should destroy stream when response is ended', (t, done) => {
   t.plan(4)
   const stream = require('node:stream')
   const fastify = Fastify()
@@ -17,7 +16,7 @@ test('should destroy stream when response is ended', t => {
     const reallyLongStream = new stream.Readable({
       read: function () { },
       destroy: function (err, callback) {
-        t.ok('called')
+        t.assert.ok('called')
         callback(err)
       }
     })
@@ -26,23 +25,25 @@ test('should destroy stream when response is ended', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     sget(`http://localhost:${fastify.server.address().port}/error`, function (err, response) {
-      t.error(err)
-      t.equal(response.statusCode, 200)
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 200)
+      done()
     })
   })
 })
 
-test('should mark reply as sent before pumping the payload stream into response for async route handler', t => {
+test('should mark reply as sent before pumping the payload stream into response for async route handler', (t, done) => {
   t.plan(3)
+  t.after(() => fastify.close())
 
   const handleRequest = proxyquire('../lib/handleRequest', {
     './wrapThenable': (thenable, reply) => {
       thenable.then(function (payload) {
-        t.equal(reply.sent, true)
+        t.assert.strictEqual(reply.sent, true)
       })
     }
   })
@@ -66,20 +67,20 @@ test('should mark reply as sent before pumping the payload stream into response
     url: '/',
     method: 'GET'
   }, (err, res) => {
-    t.error(err)
-    t.equal(res.payload, fs.readFileSync(__filename, 'utf8'))
-    fastify.close()
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.payload, fs.readFileSync(__filename, 'utf8'))
+    done()
   })
 })
 
-test('reply.send handles aborted requests', t => {
+test('reply.send handles aborted requests', (t, done) => {
   t.plan(2)
 
   const spyLogger = {
     level: 'error',
     fatal: () => { },
     error: () => {
-      t.fail('should not log an error')
+      t.assert.fail('should not log an error')
     },
     warn: () => { },
     info: () => { },
@@ -103,31 +104,31 @@ test('reply.send handles aborted requests', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     const port = fastify.server.address().port
     const http = require('node:http')
     const req = http.get(`http://localhost:${port}`)
       .on('error', (err) => {
-        t.equal(err.code, 'ECONNRESET')
-        fastify.close()
+        t.assert.strictEqual(err.code, 'ECONNRESET')
+        done()
       })
 
     setTimeout(() => {
-      req.abort()
+      req.destroy()
     }, 1)
   })
 })
 
-test('request terminated should not crash fastify', t => {
+test('request terminated should not crash fastify', (t, done) => {
   t.plan(10)
 
   const spyLogger = {
     level: 'error',
     fatal: () => { },
     error: () => {
-      t.fail('should not log an error')
+      t.assert.fail('should not log an error')
     },
     warn: () => { },
     info: () => { },
@@ -156,18 +157,18 @@ test('request terminated should not crash fastify', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     const port = fastify.server.address().port
     const http = require('node:http')
     const req = http.get(`http://localhost:${port}`, function (res) {
       const { statusCode, headers } = res
-      t.equal(statusCode, 200)
-      t.equal(headers['content-type'], 'text/html; charset=utf-8')
-      t.equal(headers['transfer-encoding'], 'chunked')
+      t.assert.strictEqual(statusCode, 200)
+      t.assert.strictEqual(headers['content-type'], 'text/html; charset=utf-8')
+      t.assert.strictEqual(headers['transfer-encoding'], 'chunked')
       res.on('data', function (chunk) {
-        t.equal(chunk.toString(), '<h1>HTML</h1>')
+        t.assert.strictEqual(chunk.toString(), '<h1>HTML</h1>')
       })
 
       setTimeout(() => {
@@ -176,16 +177,17 @@ test('request terminated should not crash fastify', t => {
         // the server is not crash, we can connect it
         http.get(`http://localhost:${port}`, function (res) {
           const { statusCode, headers } = res
-          t.equal(statusCode, 200)
-          t.equal(headers['content-type'], 'text/html; charset=utf-8')
-          t.equal(headers['transfer-encoding'], 'chunked')
+          t.assert.strictEqual(statusCode, 200)
+          t.assert.strictEqual(headers['content-type'], 'text/html; charset=utf-8')
+          t.assert.strictEqual(headers['transfer-encoding'], 'chunked')
           let payload = ''
           res.on('data', function (chunk) {
             payload += chunk.toString()
           })
           res.on('end', function () {
-            t.equal(payload, '<h1>HTML</h1><h1>should display on second stream</h1>')
-            t.pass('should end properly')
+            t.assert.strictEqual(payload, '<h1>HTML</h1><h1>should display on second stream</h1>')
+            t.assert.ok('should end properly')
+            done()
           })
         })
       }, 1)