fastify 5.2.0 → 5.2.1

package/test/nullable-validation.test.js

@@ -1,18 +1,17 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const sget = require('simple-get').concat
 const Fastify = require('..')
 
-test('nullable string', t => {
+test('nullable string', (t, done) => {
   t.plan(3)
   const fastify = Fastify()
   fastify.route({
     method: 'POST',
     url: '/',
     handler: (req, reply) => {
-      t.same(req.body.hello, null)
+      t.assert.strictEqual(req.body.hello, null)
       reply.code(200).send(req.body)
     },
     schema: {
@@ -47,12 +46,13 @@ test('nullable string', t => {
       hello: null
     }
   }, (err, res) => {
-    t.error(err)
-    t.same(res.payload.hello, null)
+    t.assert.ifError(err)
+    t.assert.strictEqual(res.json().hello, null)
+    done()
   })
 })
 
-test('object or null body', t => {
+test('object or null body', (t, done) => {
   t.plan(5)
 
   const fastify = Fastify()
@@ -61,7 +61,7 @@ test('object or null body', t => {
     method: 'POST',
     url: '/',
     handler: (req, reply) => {
-      t.equal(req.body, undefined)
+      t.assert.strictEqual(req.body, undefined)
       reply.code(200).send({ isUndefinedBody: req.body === undefined })
     },
     schema: {
@@ -89,21 +89,22 @@ test('object or null body', t => {
   })
 
   fastify.listen({ port: 0 }, (err) => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => { fastify.close() })
 
     sget({
       method: 'POST',
       url: 'http://localhost:' + fastify.server.address().port
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.same(JSON.parse(body), { isUndefinedBody: true })
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 200)
+      t.assert.deepStrictEqual(JSON.parse(body), { isUndefinedBody: true })
+      done()
     })
   })
 })
 
-test('nullable body', t => {
+test('nullable body', (t, done) => {
   t.plan(5)
 
   const fastify = Fastify()
@@ -112,7 +113,7 @@ test('nullable body', t => {
     method: 'POST',
     url: '/',
     handler: (req, reply) => {
-      t.equal(req.body, undefined)
+      t.assert.strictEqual(req.body, undefined)
       reply.code(200).send({ isUndefinedBody: req.body === undefined })
     },
     schema: {
@@ -141,21 +142,22 @@ test('nullable body', t => {
   })
 
   fastify.listen({ port: 0 }, (err) => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     sget({
       method: 'POST',
       url: 'http://localhost:' + fastify.server.address().port
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.same(JSON.parse(body), { isUndefinedBody: true })
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 200)
+      t.assert.deepStrictEqual(JSON.parse(body), { isUndefinedBody: true })
+      done()
     })
   })
 })
 
-test('Nullable body with 204', t => {
+test('Nullable body with 204', (t, done) => {
   t.plan(5)
 
   const fastify = Fastify()
@@ -164,7 +166,7 @@ test('Nullable body with 204', t => {
     method: 'POST',
     url: '/',
     handler: (req, reply) => {
-      t.equal(req.body, undefined)
+      t.assert.strictEqual(req.body, undefined)
       reply.code(204).send()
     },
     schema: {
@@ -182,16 +184,17 @@ test('Nullable body with 204', t => {
   })
 
   fastify.listen({ port: 0 }, (err) => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     sget({
       method: 'POST',
       url: 'http://localhost:' + fastify.server.address().port
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 204)
-      t.equal(body.length, 0)
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 204)
+      t.assert.strictEqual(body.length, 0)
+      done()
     })
   })
 })

package/test/web-api.test.js

@@ -227,6 +227,50 @@ test('Error when Response.bodyUsed', async (t) => {
   t.assert.strictEqual(body.code, 'FST_ERR_REP_RESPONSE_BODY_CONSUMED')
 })
 
+test('Error when Response.body.locked', async (t) => {
+  t.plan(3)
+
+  const fastify = Fastify()
+
+  fastify.get('/', async function (request, reply) {
+    const stream = Readable.toWeb(fs.createReadStream(__filename))
+    const response = new Response(stream, {
+      status: 200,
+      headers: {
+        hello: 'world'
+      }
+    })
+    stream.getReader()
+    t.assert.strictEqual(stream.locked, true)
+    return reply.send(response)
+  })
+
+  const response = await fastify.inject({ method: 'GET', path: '/' })
+
+  t.assert.strictEqual(response.statusCode, 500)
+  const body = response.json()
+  t.assert.strictEqual(body.code, 'FST_ERR_REP_READABLE_STREAM_LOCKED')
+})
+
+test('Error when ReadableStream.locked', async (t) => {
+  t.plan(3)
+
+  const fastify = Fastify()
+
+  fastify.get('/', async function (request, reply) {
+    const stream = Readable.toWeb(fs.createReadStream(__filename))
+    stream.getReader()
+    t.assert.strictEqual(stream.locked, true)
+    return reply.send(stream)
+  })
+
+  const response = await fastify.inject({ method: 'GET', path: '/' })
+
+  t.assert.strictEqual(response.statusCode, 500)
+  const body = response.json()
+  t.assert.strictEqual(body.code, 'FST_ERR_REP_READABLE_STREAM_LOCKED')
+})
+
 test('allow to pipe with fetch', async (t) => {
   t.plan(2)
   const abortController = new AbortController()

package/.vscode/settings.json

@@ -1,22 +0,0 @@
-{
-  "workbench.colorCustomizations": {
-    "[GitHub Dark]": {
-      "tab.activeBackground": "#0d0d0d",
-      "tab.activeBorder": "#ffff00"
-    },
-    "activityBar.background": "#FBE7B2",
-    "activityBar.foreground": "#52358C",
-    "activityBar.inactiveForeground": "#616161",
-    "activityBar.activeBorder": "#04184d",
-    "activityBar.activeBackground": "#C3B48B",
-    "activityBar.border": "#C3B48B",
-    "titleBar.activeBackground": "#D2BE88",
-    "titleBar.activeForeground": "#52358C",
-    "titleBar.inactiveBackground": "#bdb59c",
-    "titleBar.inactiveForeground": "#616161",
-    "titleBar.border": "#C3B48B",
-    "statusBar.background": "#E9DBB7",
-    "statusBar.foreground": "#52358C",
-    "statusBar.border": "#C3B48B"
-  }
-}

package/test/test-reporter.mjs

@@ -1,68 +0,0 @@
-function colorize (type, text) {
-  if (type === 'pass') {
-    const blackText = `\x1b[30m${text}`
-    const boldblackText = `\x1b[1m${blackText}`
-    // Green background with black text
-    return `\x1b[42m${boldblackText}\x1b[0m`
-  }
-
-  if (type === 'fail') {
-    const whiteText = `\x1b[37m${text}`
-    const boldWhiteText = `\x1b[1m${whiteText}`
-    // Red background with white text
-    return `\x1b[41m${boldWhiteText}\x1b[0m`
-  }
-
-  return text
-}
-
-function formatDiagnosticStr (str) {
-  return str.replace(/^(\w+)(\s*\d*)/i, (_, firstWord, rest) => {
-    return firstWord.charAt(0).toUpperCase() + firstWord.slice(1).toLowerCase() + ':' + rest
-  })
-}
-
-async function * reporter (source) {
-  const failed = new Set()
-  const diagnostics = new Set()
-
-  for await (const event of source) {
-    switch (event.type) {
-      case 'test:pass': {
-        yield `${colorize('pass', 'PASSED')}: ${event.data.file || event.data.name}\n`
-        break
-      }
-
-      case 'test:fail': {
-        failed.add(event.data.name || event.data.file)
-        yield `${colorize('fail', 'FAILED')}: ${event.data.file || event.data.name}\n`
-        break
-      }
-
-      case 'test:diagnostic': {
-        diagnostics.add(`${formatDiagnosticStr(event.data.message)}\n`)
-        break
-      }
-
-      default: {
-        yield ''
-      }
-    }
-  }
-
-  if (failed.size > 0) {
-    yield `\n\n${colorize('fail', 'Failed tests:')}\n`
-    for (const file of failed) {
-      yield `${file}\n`
-    }
-  }
-
-  yield '\n'
-
-  for (const diagnostic of diagnostics) {
-    yield `${diagnostic}`
-  }
-  yield '\n'
-}
-
-export default reporter