fastify 5.1.0 → 5.2.0

package/test/request-header-host.test.js

@@ -72,9 +72,9 @@ test('Return 200 when Host header is empty', (t, done) => {
   t.after(() => fastify.close())
 
   fastify.get('/', async function (request) {
-    t.assert.equal(request.host, '')
-    t.assert.equal(request.hostname, '')
-    t.assert.equal(request.port, null)
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
     return { ok: true }
   })
   fastify.listen({ port: 0 }, err => {
@@ -104,9 +104,9 @@ test('Return 200 when Host header is empty with trust proxy', (t, done) => {
   t.after(() => fastify.close())
 
   fastify.get('/', async function (request) {
-    t.assert.equal(request.host, '')
-    t.assert.equal(request.hostname, '')
-    t.assert.equal(request.port, null)
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
     return { ok: true }
   })
   fastify.listen({ port: 0 }, err => {
@@ -140,9 +140,9 @@ test('Return 200 when Host header is missing and http.requireHostHeader = false'
   t.after(() => fastify.close())
 
   fastify.get('/', async function (request) {
-    t.assert.equal(request.host, '')
-    t.assert.equal(request.hostname, '')
-    t.assert.equal(request.port, null)
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
     return { ok: true }
   })
   fastify.listen({ port: 0 }, err => {
@@ -175,9 +175,9 @@ test('Return 200 when Host header is missing and http.requireHostHeader = false
   t.after(() => fastify.close())
 
   fastify.get('/', async function (request) {
-    t.assert.equal(request.host, '')
-    t.assert.equal(request.hostname, '')
-    t.assert.equal(request.port, null)
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
     return { ok: true }
   })
   fastify.listen({ port: 0 }, err => {
@@ -195,3 +195,145 @@ test('Return 200 when Host header is missing and http.requireHostHeader = false
     })
   })
 })
+
+test('Return 200 when Host header is missing using HTTP/1.0', (t, done) => {
+  t.plan(5)
+  let data = Buffer.alloc(0)
+  const fastify = Fastify({
+    keepAliveTimeout: 10
+  })
+
+  t.after(() => fastify.close())
+
+  fastify.get('/', async function (request) {
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
+    return { ok: true }
+  })
+  fastify.listen({ port: 0 }, err => {
+    t.assert.ifError(err)
+
+    const socket = connect(fastify.server.address().port)
+    socket.write('GET / HTTP/1.0\r\n\r\n')
+    socket.on('data', c => (data = Buffer.concat([data, c])))
+    socket.on('end', () => {
+      t.assert.match(
+        data.toString('utf-8'),
+        /^HTTP\/1.1 200 OK/
+      )
+      done()
+    })
+  })
+})
+
+test('Return 200 when Host header is missing with trust proxy using HTTP/1.0', (t, done) => {
+  t.plan(5)
+  let data = Buffer.alloc(0)
+  const fastify = Fastify({
+    trustProxy: true,
+    keepAliveTimeout: 10
+  })
+
+  t.after(() => fastify.close())
+
+  fastify.get('/', async function (request) {
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
+    return { ok: true }
+  })
+  fastify.listen({ port: 0 }, err => {
+    t.assert.ifError(err)
+
+    const socket = connect(fastify.server.address().port)
+    socket.write('GET / HTTP/1.0\r\n\r\n')
+    socket.on('data', c => (data = Buffer.concat([data, c])))
+    socket.on('end', () => {
+      t.assert.match(
+        data.toString('utf-8'),
+        /^HTTP\/1.1 200 OK/
+      )
+      done()
+    })
+  })
+})
+
+test('Return 200 when Host header is removed by schema', (t, done) => {
+  t.plan(5)
+  let data = Buffer.alloc(0)
+  const fastify = Fastify({
+    keepAliveTimeout: 10
+  })
+
+  t.after(() => fastify.close())
+
+  fastify.get('/', {
+    schema: {
+      headers: {
+        type: 'object',
+        properties: {},
+        additionalProperties: false
+      }
+    }
+  }, async function (request) {
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
+    return { ok: true }
+  })
+  fastify.listen({ port: 0 }, err => {
+    t.assert.ifError(err)
+
+    const socket = connect(fastify.server.address().port)
+    socket.write('GET / HTTP/1.1\r\nHost: localhost\r\n\r\n')
+    socket.on('data', c => (data = Buffer.concat([data, c])))
+    socket.on('end', () => {
+      t.assert.match(
+        data.toString('utf-8'),
+        /^HTTP\/1.1 200 OK/
+      )
+      done()
+    })
+  })
+})
+
+test('Return 200 when Host header is removed by schema with trust proxy', (t, done) => {
+  t.plan(5)
+  let data = Buffer.alloc(0)
+  const fastify = Fastify({
+    trustProxy: true,
+    keepAliveTimeout: 10
+  })
+
+  t.after(() => fastify.close())
+
+  fastify.get('/', {
+    schema: {
+      headers: {
+        type: 'object',
+        properties: {},
+        additionalProperties: false
+      }
+    }
+  }, async function (request) {
+    t.assert.strictEqual(request.host, '')
+    t.assert.strictEqual(request.hostname, '')
+    t.assert.strictEqual(request.port, null)
+    return { ok: true }
+  })
+  fastify.listen({ port: 0 }, err => {
+    t.assert.ifError(err)
+
+    const socket = connect(fastify.server.address().port)
+    socket.write('GET / HTTP/1.1\r\nHost: localhost\r\n\r\n')
+    socket.on('data', c => (data = Buffer.concat([data, c])))
+    socket.on('end', () => {
+      t.assert.match(
+        data.toString('utf-8'),
+        /^HTTP\/1.1 200 OK/
+      )
+      done()
+    })
+  })
+})

package/test/request-id.test.js

@@ -1,10 +1,10 @@
 'use strict'
 
-const t = require('tap')
+const { test } = require('node:test')
 const Fastify = require('..')
 const sget = require('simple-get').concat
 
-t.test('The request id header key can be customized', async (t) => {
+test('The request id header key can be customized', async (t) => {
   t.plan(2)
   const REQUEST_ID = '42'
 
@@ -13,16 +13,16 @@ t.test('The request id header key can be customized', async (t) => {
   })
 
   fastify.get('/', (req, reply) => {
-    t.equal(req.id, REQUEST_ID)
+    t.assert.strictEqual(req.id, REQUEST_ID)
     reply.send({ id: req.id })
   })
 
   const response = await fastify.inject({ method: 'GET', url: '/', headers: { 'my-custom-request-id': REQUEST_ID } })
   const body = await response.json()
-  t.equal(body.id, REQUEST_ID)
+  t.assert.strictEqual(body.id, REQUEST_ID)
 })
 
-t.test('The request id header key can be customized', async (t) => {
+test('The request id header key can be customized', async (t) => {
   t.plan(2)
   const REQUEST_ID = '42'
 
@@ -31,16 +31,16 @@ t.test('The request id header key can be customized', async (t) => {
   })
 
   fastify.get('/', (req, reply) => {
-    t.equal(req.id, REQUEST_ID)
+    t.assert.strictEqual(req.id, REQUEST_ID)
     reply.send({ id: req.id })
   })
 
   const response = await fastify.inject({ method: 'GET', url: '/', headers: { 'MY-CUSTOM-REQUEST-ID': REQUEST_ID } })
   const body = await response.json()
-  t.equal(body.id, REQUEST_ID)
+  t.assert.strictEqual(body.id, REQUEST_ID)
 })
 
-t.test('The request id header key can be customized', (t) => {
+test('The request id header key can be customized', (t, done) => {
   t.plan(4)
   const REQUEST_ID = '42'
 
@@ -49,13 +49,14 @@ t.test('The request id header key can be customized', (t) => {
   })
 
   fastify.get('/', (req, reply) => {
-    t.equal(req.id, REQUEST_ID)
+    t.assert.strictEqual(req.id, REQUEST_ID)
     reply.send({ id: req.id })
   })
 
+  t.after(() => fastify.close())
+
   fastify.listen({ port: 0 }, (err, address) => {
-    t.error(err)
-    t.teardown(() => fastify.close())
+    t.assert.ifError(err)
 
     sget({
       method: 'GET',
@@ -64,13 +65,14 @@ t.test('The request id header key can be customized', (t) => {
         'my-custom-request-id': REQUEST_ID
       }
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(body.toString(), `{"id":"${REQUEST_ID}"}`)
+      t.assert.ifError(err)
+      t.assert.strictEqual(body.toString(), `{"id":"${REQUEST_ID}"}`)
+      done()
     })
   })
 })
 
-t.test('The request id header key can be customized', (t) => {
+test('The request id header key can be customized', (t, done) => {
   t.plan(4)
   const REQUEST_ID = '42'
 
@@ -79,13 +81,14 @@ t.test('The request id header key can be customized', (t) => {
   })
 
   fastify.get('/', (req, reply) => {
-    t.equal(req.id, REQUEST_ID)
+    t.assert.strictEqual(req.id, REQUEST_ID)
     reply.send({ id: req.id })
   })
 
+  t.after(() => fastify.close())
+
   fastify.listen({ port: 0 }, (err, address) => {
-    t.error(err)
-    t.teardown(() => fastify.close())
+    t.assert.ifError(err)
 
     sget({
       method: 'GET',
@@ -94,13 +97,14 @@ t.test('The request id header key can be customized', (t) => {
         'MY-CUSTOM-REQUEST-ID': REQUEST_ID
       }
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(body.toString(), `{"id":"${REQUEST_ID}"}`)
+      t.assert.ifError(err)
+      t.assert.strictEqual(body.toString(), `{"id":"${REQUEST_ID}"}`)
+      done()
     })
   })
 })
 
-t.test('The request id header key can be customized', (t) => {
+test('The request id header key can be customized', (t, done) => {
   t.plan(4)
   const REQUEST_ID = '42'
 
@@ -109,13 +113,14 @@ t.test('The request id header key can be customized', (t) => {
   })
 
   fastify.get('/', (req, reply) => {
-    t.equal(req.id, REQUEST_ID)
+    t.assert.strictEqual(req.id, REQUEST_ID)
     reply.send({ id: req.id })
   })
 
+  t.after(() => fastify.close())
+
   fastify.listen({ port: 0 }, (err, address) => {
-    t.error(err)
-    t.teardown(() => fastify.close())
+    t.assert.ifError(err)
 
     sget({
       method: 'GET',
@@ -124,8 +129,9 @@ t.test('The request id header key can be customized', (t) => {
         'MY-CUSTOM-REQUEST-ID': REQUEST_ID
       }
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(body.toString(), `{"id":"${REQUEST_ID}"}`)
+      t.assert.ifError(err)
+      t.assert.strictEqual(body.toString(), `{"id":"${REQUEST_ID}"}`)
+      done()
     })
   })
 })

package/test/{requestTimeout.test.js → request-timeout.test.js}

@@ -1,31 +1,31 @@
 'use strict'
 
 const http = require('node:http')
-const { test } = require('tap')
-const Fastify = require('../fastify')
+const { test } = require('node:test')
+const Fastify = require('..')
 
 test('requestTimeout passed to server', t => {
   t.plan(5)
 
   try {
     Fastify({ requestTimeout: 500.1 })
-    t.fail('option must be an integer')
+    t.assert.fail('option must be an integer')
   } catch (err) {
-    t.ok(err)
+    t.assert.ok(err)
   }
 
   try {
     Fastify({ requestTimeout: [] })
-    t.fail('option must be an integer')
+    t.assert.fail('option must be an integer')
   } catch (err) {
-    t.ok(err)
+    t.assert.ok(err)
   }
 
   const httpServer = Fastify({ requestTimeout: 1000 }).server
-  t.equal(httpServer.requestTimeout, 1000)
+  t.assert.strictEqual(httpServer.requestTimeout, 1000)
 
   const httpsServer = Fastify({ requestTimeout: 1000, https: true }).server
-  t.equal(httpsServer.requestTimeout, 1000)
+  t.assert.strictEqual(httpsServer.requestTimeout, 1000)
 
   const serverFactory = (handler, _) => {
     const server = http.createServer((req, res) => {
@@ -35,19 +35,19 @@ test('requestTimeout passed to server', t => {
     return server
   }
   const customServer = Fastify({ requestTimeout: 4000, serverFactory }).server
-  t.equal(customServer.requestTimeout, 5000)
+  t.assert.strictEqual(customServer.requestTimeout, 5000)
 })
 
 test('requestTimeout should be set', async (t) => {
   t.plan(1)
 
   const initialConfig = Fastify({ requestTimeout: 5000 }).initialConfig
-  t.same(initialConfig.requestTimeout, 5000)
+  t.assert.strictEqual(initialConfig.requestTimeout, 5000)
 })
 
 test('requestTimeout should 0', async (t) => {
   t.plan(1)
 
   const initialConfig = Fastify().initialConfig
-  t.same(initialConfig.requestTimeout, 0)
+  t.assert.strictEqual(initialConfig.requestTimeout, 0)
 })

package/test/route.3.test.js

@@ -5,7 +5,7 @@ const joi = require('joi')
 const Fastify = require('..')
 
 test('does not mutate joi schemas', (t, done) => {
-  t.plan(4)
+  t.plan(5)
 
   const fastify = Fastify()
   function validatorCompiler ({ schema, method, url, httpPart }) {
@@ -31,7 +31,8 @@ test('does not mutate joi schemas', (t, done) => {
       params: { an_id: joi.number() }
     },
     handler (req, res) {
-      t.assert.deepEqual(req.params, { an_id: 42 })
+      t.assert.strictEqual(Object.keys(req.params).length, 1)
+      t.assert.strictEqual(req.params.an_id, '42')
       res.send({ hello: 'world' })
     }
   })

package/test/route.8.test.js

@@ -1,9 +1,8 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const sget = require('simple-get').concat
-const Fastify = require('../fastify')
+const Fastify = require('..')
 const {
   FST_ERR_INVALID_URL
 } = require('../lib/errors')
@@ -24,9 +23,9 @@ test('Request and Reply share the route options', async t => {
     url: '/',
     config,
     handler: (req, reply) => {
-      t.same(req.routeOptions, reply.routeOptions)
-      t.same(req.routeOptions.config, reply.routeOptions.config)
-      t.match(req.routeOptions.config, config, 'there are url and method additional properties')
+      t.assert.deepStrictEqual(req.routeOptions, reply.routeOptions)
+      t.assert.deepStrictEqual(req.routeOptions.config, reply.routeOptions.config)
+      t.assert.match(req.routeOptions.config, config, 'there are url and method additional properties')
 
       reply.send({ hello: 'world' })
     }
@@ -62,10 +61,10 @@ test('Will not try to re-createprefixed HEAD route if it already exists and expo
 
   await fastify.ready()
 
-  t.ok(true)
+  t.assert.ok(true)
 })
 
-test('route with non-english characters', t => {
+test('route with non-english characters', (t, done) => {
   t.plan(4)
 
   const fastify = Fastify()
@@ -75,16 +74,17 @@ test('route with non-english characters', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => fastify.close())
 
     sget({
       method: 'GET',
       url: getServerUrl(fastify) + encodeURI('/föö')
     }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.equal(body.toString(), 'here /föö')
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.statusCode, 200)
+      t.assert.strictEqual(body.toString(), 'here /föö')
+      done()
     })
   })
 })
@@ -96,7 +96,7 @@ test('invalid url attribute - non string URL', t => {
   try {
     fastify.get(/^\/(donations|skills|blogs)/, () => { })
   } catch (error) {
-    t.equal(error.code, FST_ERR_INVALID_URL().code)
+    t.assert.strictEqual(error.code, FST_ERR_INVALID_URL().code)
   }
 })
 
@@ -117,7 +117,7 @@ test('exposeHeadRoute should not reuse the same route option', async t => {
   })
 
   fastify.addHook('onRoute', function (routeOption) {
-    t.equal(routeOption.onRequest.length, 1)
+    t.assert.strictEqual(routeOption.onRequest.length, 1)
   })
 
   fastify.route({
@@ -140,7 +140,7 @@ test('using fastify.all when a catchall is defined does not degrade performance'
     fastify.all(`/${i}`, async (_, reply) => reply.json({ ok: true }))
   }
 
-  t.pass()
+  t.assert.ok("fastify.all doesn't degrade performance")
 })
 
 test('Adding manually HEAD route after GET with the same path throws Fastify duplicated route instance error', t => {
@@ -164,9 +164,9 @@ test('Adding manually HEAD route after GET with the same path throws Fastify dup
         reply.send({ hello: 'world' })
       }
     })
-    t.fail('Should throw fastify duplicated route declaration')
+    t.assert.fail('Should throw fastify duplicated route declaration')
   } catch (error) {
-    t.equal(error.code, 'FST_ERR_DUPLICATED_ROUTE')
+    t.assert.strictEqual(error.code, 'FST_ERR_DUPLICATED_ROUTE')
   }
 })
 
@@ -198,7 +198,7 @@ test('Will pass onSend hook to HEAD method if exposeHeadRoutes is true /1', asyn
     method: 'HEAD'
   })
 
-  t.equal(result.headers['x-content-type'], 'application/fastify')
+  t.assert.strictEqual(result.headers['x-content-type'], 'application/fastify')
 })
 
 test('Will pass onSend hook to HEAD method if exposeHeadRoutes is true /2', async (t) => {
@@ -229,5 +229,5 @@ test('Will pass onSend hook to HEAD method if exposeHeadRoutes is true /2', asyn
     method: 'HEAD'
   })
 
-  t.equal(result.headers['x-content-type'], 'application/fastify')
+  t.assert.strictEqual(result.headers['x-content-type'], 'application/fastify')
 })