fastify 5.0.0-alpha.2 → 5.0.0-alpha.4

package/test/{search.test.js → http-methods/search.test.js}

@@ -3,7 +3,8 @@
 const t = require('tap')
 const sget = require('simple-get').concat
 const test = t.test
-const fastify = require('..')()
+const fastify = require('../../fastify')()
+fastify.addHttpMethod('SEARCH', { hasBody: true })
 
 const schema = {
   response: {

package/test/{trace.test.js → http-methods/trace.test.js}

@@ -2,7 +2,8 @@
 
 const t = require('tap')
 const test = t.test
-const fastify = require('..')()
+const fastify = require('../../fastify')()
+fastify.addHttpMethod('TRACE')
 
 test('shorthand - trace', t => {
   t.plan(1)

package/test/{unlock.test.js → http-methods/unlock.test.js}

@@ -3,7 +3,8 @@
 const t = require('tap')
 const test = t.test
 const sget = require('simple-get').concat
-const fastify = require('..')()
+const fastify = require('../../fastify')()
+fastify.addHttpMethod('UNLOCK')
 
 test('can be created - unlock', t => {
   t.plan(1)

package/test/internals/all.test.js

@@ -3,19 +3,19 @@
 const t = require('tap')
 const test = t.test
 const Fastify = require('../..')
-const { supportedMethods } = require('../../lib/httpMethods')
 
 test('fastify.all should add all the methods to the same url', t => {
+  const fastify = Fastify()
+
   const requirePayload = [
     'POST',
     'PUT',
     'PATCH'
   ]
 
+  const supportedMethods = fastify.supportedMethods
   t.plan(supportedMethods.length * 2)
 
-  const fastify = Fastify()
-
   fastify.all('/', (req, reply) => {
     reply.send({ method: req.raw.method })
   })

package/test/internals/decorator.test.js

@@ -136,7 +136,7 @@ test('decorate should recognize getter/setter objects', t => {
       this._a = val
     }
   })
-  t.equal(Object.prototype.hasOwnProperty.call(one, 'foo'), true)
+  t.equal(Object.hasOwn(one, 'foo'), true)
   t.equal(one.foo, undefined)
   one.foo = 'a'
   t.equal(one.foo, 'a')
@@ -152,6 +152,6 @@ test('decorate should recognize getter/setter objects', t => {
   decorator.add.call(two, 'foo', {
     getter: () => 'a getter'
   })
-  t.equal(Object.prototype.hasOwnProperty.call(two, 'foo'), true)
+  t.equal(Object.hasOwn(two, 'foo'), true)
   t.equal(two.foo, 'a getter')
 })

package/test/internals/errors.test.js

@@ -5,7 +5,7 @@ const errors = require('../../lib/errors')
 const { readFileSync } = require('node:fs')
 const { resolve } = require('node:path')
 
-test('should expose 84 errors', t => {
+test('should expose 83 errors', t => {
   t.plan(1)
   const exportedKeys = Object.keys(errors)
   let counter = 0
@@ -14,11 +14,11 @@ test('should expose 84 errors', t => {
       counter++
     }
   }
-  t.equal(counter, 84)
+  t.equal(counter, 83)
 })
 
 test('ensure name and codes of Errors are identical', t => {
-  t.plan(84)
+  t.plan(83)
   const exportedKeys = Object.keys(errors)
   for (const key of exportedKeys) {
     if (errors[key].name === 'FastifyError') {
@@ -97,16 +97,6 @@ test('FST_ERR_AJV_CUSTOM_OPTIONS_OPT_NOT_ARR', t => {
   t.ok(error instanceof TypeError)
 })
 
-test('FST_ERR_VERSION_CONSTRAINT_NOT_STR', t => {
-  t.plan(5)
-  const error = new errors.FST_ERR_VERSION_CONSTRAINT_NOT_STR()
-  t.equal(error.name, 'FastifyError')
-  t.equal(error.code, 'FST_ERR_VERSION_CONSTRAINT_NOT_STR')
-  t.equal(error.message, 'Version constraint should be a string.')
-  t.equal(error.statusCode, 500)
-  t.ok(error instanceof TypeError)
-})
-
 test('FST_ERR_CTP_ALREADY_PRESENT', t => {
   t.plan(5)
   const error = new errors.FST_ERR_CTP_ALREADY_PRESENT()
@@ -878,7 +868,7 @@ test('FST_ERR_ERROR_HANDLER_NOT_FN', t => {
 })
 
 test('Ensure that all errors are in Errors.md TOC', t => {
-  t.plan(84)
+  t.plan(83)
   const errorsMd = readFileSync(resolve(__dirname, '../../docs/Reference/Errors.md'), 'utf8')
 
   const exportedKeys = Object.keys(errors)
@@ -890,7 +880,7 @@ test('Ensure that all errors are in Errors.md TOC', t => {
 })
 
 test('Ensure that non-existing errors are not in Errors.md TOC', t => {
-  t.plan(84)
+  t.plan(83)
   const errorsMd = readFileSync(resolve(__dirname, '../../docs/Reference/Errors.md'), 'utf8')
 
   const matchRE = / {4}- \[([A-Z0-9_]+)\]\(#[a-z0-9_]+\)/g
@@ -903,7 +893,7 @@ test('Ensure that non-existing errors are not in Errors.md TOC', t => {
 })
 
 test('Ensure that all errors are in Errors.md documented', t => {
-  t.plan(84)
+  t.plan(83)
   const errorsMd = readFileSync(resolve(__dirname, '../../docs/Reference/Errors.md'), 'utf8')
 
   const exportedKeys = Object.keys(errors)
@@ -915,7 +905,7 @@ test('Ensure that all errors are in Errors.md documented', t => {
 })
 
 test('Ensure that non-existing errors are not in Errors.md documented', t => {
-  t.plan(84)
+  t.plan(83)
   const errorsMd = readFileSync(resolve(__dirname, '../../docs/Reference/Errors.md'), 'utf8')
 
   const matchRE = /<a id="[0-9a-zA-Z_]+">([0-9a-zA-Z_]+)<\/a>/g

package/test/internals/initialConfig.test.js

@@ -38,7 +38,6 @@ test('without options passed to Fastify, initialConfig should expose default val
     caseSensitive: true,
     allowUnsafeRegex: false,
     disableRequestLogging: false,
-    jsonShorthand: true,
     ignoreTrailingSlash: false,
     ignoreDuplicateSlashes: false,
     maxParamLength: 100,
@@ -278,7 +277,6 @@ test('Should not have issues when passing stream options to Pino.js', t => {
       caseSensitive: true,
       allowUnsafeRegex: false,
       disableRequestLogging: false,
-      jsonShorthand: true,
       ignoreTrailingSlash: true,
       ignoreDuplicateSlashes: false,
       maxParamLength: 100,
@@ -362,35 +360,6 @@ test('deepFreezeObject() should not throw on TypedArray', t => {
   }
 })
 
-test('Fastify.initialConfig should accept the deprecated versioning option', t => {
-  t.plan(1)
-
-  function onWarning (warning) {
-    t.equal(warning.code, 'FSTDEP009')
-  }
-
-  process.on('warning', onWarning)
-
-  const versioning = {
-    storage: function () {
-      const versions = {}
-      return {
-        get: (version) => { return versions[version] || null },
-        set: (version, store) => { versions[version] = store }
-      }
-    },
-    deriveVersion: (req, ctx) => {
-      return req.headers.accept
-    }
-  }
-
-  Fastify({ versioning })
-  setImmediate(function () {
-    process.removeListener('warning', onWarning)
-    t.end()
-  })
-})
-
 test('pluginTimeout should be parsed correctly', t => {
   const withDisabledTimeout = Fastify({ pluginTimeout: '0' })
   t.equal(withDisabledTimeout.initialConfig.pluginTimeout, 0)

package/test/internals/reply-serialize.test.js

@@ -50,8 +50,11 @@ function getResponseSchema () {
       content: {
         'application/json': {
           schema: {
-            fullName: { type: 'string' },
-            phone: { type: 'number' }
+            type: 'object',
+            properties: {
+              fullName: { type: 'string' },
+              phone: { type: 'number' }
+            }
           }
         }
       }
@@ -264,8 +267,11 @@ test('Reply#getSerializationFunction', t => {
         '/:id',
         {
           params: {
-            id: {
-              type: 'integer'
+            type: 'object',
+            properites: {
+              id: {
+                type: 'integer'
+              }
             }
           },
           schema: {
@@ -356,8 +362,11 @@ test('Reply#getSerializationFunction', t => {
         '/:id',
         {
           params: {
-            id: {
-              type: 'integer'
+            type: 'object',
+            properites: {
+              id: {
+                type: 'integer'
+              }
             }
           }
         },
@@ -465,8 +474,11 @@ test('Reply#serializeInput', t => {
               content: {
                 'application/json': {
                   schema: {
-                    fullName: { type: 'string' },
-                    phone: { type: 'number' }
+                    type: 'object',
+                    properites: {
+                      fullName: { type: 'string' },
+                      phone: { type: 'number' }
+                    }
                   }
                 }
               }
@@ -525,8 +537,11 @@ test('Reply#serializeInput', t => {
       '/',
       {
         params: {
-          id: {
-            type: 'integer'
+          type: 'object',
+          properites: {
+            id: {
+              type: 'integer'
+            }
           }
         },
         schema: {

package/test/internals/reply.test.js

@@ -5,6 +5,7 @@ const test = t.test
 const sget = require('simple-get').concat
 const http = require('node:http')
 const NotFound = require('http-errors').NotFound
+const Request = require('../../lib/request')
 const Reply = require('../../lib/reply')
 const Fastify = require('../..')
 const { Readable, Writable } = require('node:stream')
@@ -14,12 +15,10 @@ const {
   kReplySerializer,
   kReplyIsError,
   kReplySerializerDefault,
-  kRouteContext,
-  kPublicRouteContext
+  kRouteContext
 } = require('../../lib/symbols')
 const fs = require('node:fs')
 const path = require('node:path')
-const { FSTDEP010, FSTDEP019, FSTDEP021 } = require('../../lib/warnings')
 
 const agent = new http.Agent({ keepAlive: false })
 
@@ -38,8 +37,8 @@ const doGet = function (url) {
 test('Once called, Reply should return an object with methods', t => {
   t.plan(15)
   const response = { res: 'res' }
-  const context = { config: { onSend: [] }, schema: {} }
-  const request = { [kRouteContext]: context, [kPublicRouteContext]: { config: context.config, schema: context.schema } }
+  const context = { config: { onSend: [] }, schema: {}, _parserOptions: {}, server: { hasConstraintStrategy: () => false, initialConfig: {} } }
+  const request = new Request(null, null, null, null, null, context)
   const reply = new Reply(response, request)
   t.equal(typeof reply, 'object')
   t.equal(typeof reply[kReplyIsError], 'boolean')
@@ -52,8 +51,8 @@ test('Once called, Reply should return an object with methods', t => {
   t.equal(typeof reply[kReplyHeaders], 'object')
   t.same(reply.raw, response)
   t.equal(reply[kRouteContext], context)
-  t.equal(reply[kPublicRouteContext].config, context.config)
-  t.equal(reply[kPublicRouteContext].schema, context.schema)
+  t.equal(reply.routeOptions.config, context.config)
+  t.equal(reply.routeOptions.schema, context.schema)
   t.equal(reply.request, request)
   // Aim to not bad property keys (including Symbols)
   t.notOk('undefined' in reply)
@@ -63,7 +62,7 @@ test('reply.send will logStream error and destroy the stream', t => {
   t.plan(1)
   let destroyCalled
   const payload = new Readable({
-    read () {},
+    read () { },
     destroy (err, cb) {
       destroyCalled = true
       cb(err)
@@ -72,16 +71,16 @@ test('reply.send will logStream error and destroy the stream', t => {
 
   const response = new Writable()
   Object.assign(response, {
-    setHeader: () => {},
+    setHeader: () => { },
     hasHeader: () => false,
     getHeader: () => undefined,
-    writeHead: () => {},
-    write: () => {},
+    writeHead: () => { },
+    write: () => { },
     headersSent: true
   })
 
   const log = {
-    warn: () => {}
+    warn: () => { }
   }
 
   const reply = new Reply(response, { [kRouteContext]: { onSend: null } }, log)
@@ -94,12 +93,12 @@ test('reply.send will logStream error and destroy the stream', t => {
 test('reply.send throw with circular JSON', t => {
   t.plan(1)
   const response = {
-    setHeader: () => {},
+    setHeader: () => { },
     hasHeader: () => false,
     getHeader: () => undefined,
-    writeHead: () => {},
-    write: () => {},
-    end: () => {}
+    writeHead: () => { },
+    write: () => { },
+    end: () => { }
   }
   const reply = new Reply(response, { [kRouteContext]: { onSend: [] } })
   t.throws(() => {
@@ -112,12 +111,12 @@ test('reply.send throw with circular JSON', t => {
 test('reply.send returns itself', t => {
   t.plan(1)
   const response = {
-    setHeader: () => {},
+    setHeader: () => { },
     hasHeader: () => false,
     getHeader: () => undefined,
-    writeHead: () => {},
-    write: () => {},
-    end: () => {}
+    writeHead: () => { },
+    write: () => { },
+    end: () => { }
   }
   const reply = new Reply(response, { [kRouteContext]: { onSend: [] } })
   t.equal(reply.send('hello'), reply)
@@ -1119,7 +1118,7 @@ test('reply.hasHeader returns correct values', t => {
     sget({
       method: 'GET',
       url: 'http://127.0.0.1:' + fastify.server.address().port + '/headers'
-    }, () => {})
+    }, () => { })
   })
 })
 
@@ -1151,18 +1150,18 @@ test('reply.getHeader returns correct values', t => {
     sget({
       method: 'GET',
       url: 'http://127.0.0.1:' + fastify.server.address().port + '/headers'
-    }, () => {})
+    }, () => { })
   })
 })
 
 test('reply.getHeader returns raw header if there is not in the reply headers', t => {
   t.plan(1)
   const response = {
-    setHeader: () => {},
+    setHeader: () => { },
     hasHeader: () => true,
     getHeader: () => 'bar',
-    writeHead: () => {},
-    end: () => {}
+    writeHead: () => { },
+    end: () => { }
   }
   const reply = new Reply(response, { onSend: [] }, null)
   t.equal(reply.getHeader('foo'), 'bar')
@@ -1461,108 +1460,17 @@ test('reply.header setting multiple cookies as multiple Set-Cookie headers', t =
   })
 })
 
-test('should emit deprecation warning when trying to modify the reply.sent property', t => {
-  t.plan(4)
-  const fastify = Fastify()
-
-  FSTDEP010.emitted = false
-
-  process.removeAllListeners('warning')
-  process.on('warning', onWarning)
-  function onWarning (warning) {
-    t.equal(warning.name, 'DeprecationWarning')
-    t.equal(warning.code, FSTDEP010.code)
-  }
-
-  fastify.get('/', (req, reply) => {
-    reply.sent = true
-
-    reply.raw.end()
-  })
-
-  fastify.inject('/', (err, res) => {
-    t.error(err)
-    t.pass()
-
-    process.removeListener('warning', onWarning)
-  })
-})
-
-test('should emit deprecation warning when trying to use the reply.context.config property', t => {
-  t.plan(4)
-  const fastify = Fastify()
-
-  FSTDEP019.emitted = false
-
-  process.removeAllListeners('warning')
-  process.on('warning', onWarning)
-  function onWarning (warning) {
-    t.equal(warning.name, 'DeprecationWarning')
-    t.equal(warning.code, FSTDEP019.code)
-  }
-
-  fastify.get('/', (req, reply) => {
-    req.log(reply.context.config)
-  })
-
-  fastify.inject('/', (err, res) => {
-    t.error(err)
-    t.pass()
-
-    process.removeListener('warning', onWarning)
-  })
-})
-
-test('should throw error when passing falsy value to reply.sent', t => {
-  t.plan(4)
-  const fastify = Fastify()
-
-  fastify.get('/', function (req, reply) {
-    try {
-      reply.sent = false
-    } catch (err) {
-      t.equal(err.code, 'FST_ERR_REP_SENT_VALUE')
-      t.equal(err.message, 'The only possible value for reply.sent is true.')
-      reply.send()
-    }
-  })
-
-  fastify.inject('/', (err, res) => {
-    t.error(err)
-    t.pass()
-  })
-})
-
-test('should throw error when attempting to set reply.sent more than once', t => {
+test('should throw when trying to modify the reply.sent property', t => {
   t.plan(3)
   const fastify = Fastify()
 
   fastify.get('/', function (req, reply) {
-    reply.sent = true
     try {
       reply.sent = true
-      t.fail('must throw')
     } catch (err) {
-      t.equal(err.code, 'FST_ERR_REP_ALREADY_SENT')
+      t.ok(err)
+      reply.send()
     }
-    reply.raw.end()
-  })
-
-  fastify.inject('/', (err, res) => {
-    t.error(err)
-    t.pass()
-  })
-})
-
-test('should not throw error when attempting to set reply.sent if the underlining request was sent', t => {
-  t.plan(3)
-  const fastify = Fastify()
-
-  fastify.get('/', function (req, reply) {
-    reply.raw.end()
-    t.doesNotThrow(() => {
-      reply.sent = true
-    })
   })
 
   fastify.inject('/', (err, res) => {
@@ -1843,7 +1751,7 @@ test('cannot set the replySerializer when the server is running', t => {
   fastify.listen({ port: 0 }, err => {
     t.error(err)
     try {
-      fastify.setReplySerializer(() => {})
+      fastify.setReplySerializer(() => { })
       t.fail('this serializer should not be setup')
     } catch (e) {
       t.equal(e.code, 'FST_ERR_INSTANCE_ALREADY_LISTENING')
@@ -1893,7 +1801,7 @@ test('reply should not call the custom serializer for errors and not found', t =
 test('reply.then', t => {
   t.plan(4)
 
-  function request () {}
+  function request () { }
 
   t.test('without an error', t => {
     t.plan(1)
@@ -2022,36 +1930,6 @@ test('redirect to an invalid URL should not crash the server', async t => {
   await fastify.close()
 })
 
-test('redirect with deprecated signature should warn', t => {
-  t.plan(4)
-
-  process.removeAllListeners('warning')
-  process.on('warning', onWarning)
-  function onWarning (warning) {
-    t.equal(warning.name, 'DeprecationWarning')
-    t.equal(warning.code, FSTDEP021.code)
-  }
-
-  const fastify = Fastify()
-
-  fastify.get('/', (req, reply) => {
-    reply.redirect(302, '/new')
-  })
-
-  fastify.get('/new', (req, reply) => {
-    reply.send('new')
-  })
-
-  fastify.inject({ method: 'GET', url: '/' }, (err, res) => {
-    t.error(err)
-    t.pass()
-
-    process.removeListener('warning', onWarning)
-  })
-
-  FSTDEP021.emitted = false
-})
-
 test('invalid response headers should not crash the server', async t => {
   const fastify = Fastify()
   fastify.route({
@@ -2153,7 +2031,7 @@ test('reply.send will intercept ERR_HTTP_HEADERS_SENT and log an error message',
 
   const response = new Writable()
   Object.assign(response, {
-    setHeader: () => {},
+    setHeader: () => { },
     hasHeader: () => false,
     getHeader: () => undefined,
     writeHead: () => {
@@ -2161,7 +2039,7 @@ test('reply.send will intercept ERR_HTTP_HEADERS_SENT and log an error message',
       err.code = 'ERR_HTTP_HEADERS_SENT'
       throw err
     },
-    write: () => {},
+    write: () => { },
     headersSent: true
   })
 

package/test/internals/request-validate.test.js

@@ -16,21 +16,30 @@ const defaultSchema = {
 
 const requestSchema = {
   params: {
-    id: {
-      type: 'integer',
-      minimum: 1
+    type: 'object',
+    properties: {
+      id: {
+        type: 'integer',
+        minimum: 1
+      }
     }
   },
   querystring: {
-    foo: {
-      type: 'string',
-      enum: ['bar']
+    type: 'object',
+    properties: {
+      foo: {
+        type: 'string',
+        enum: ['bar']
+      }
     }
   },
   body: defaultSchema,
   headers: {
-    'x-foo': {
-      type: 'string'
+    type: 'object',
+    properties: {
+      'x-foo': {
+        type: 'string'
+      }
     }
   }
 }
@@ -68,7 +77,7 @@ test('#compileValidationSchema', subtest => {
       const validate = req.compileValidationSchema(defaultSchema)
 
       t.ok(validate({ hello: 'world' }))
-      t.ok(Object.prototype.hasOwnProperty.call(validate, 'errors'))
+      t.ok(Object.hasOwn(validate, 'errors'))
       t.equal(validate.errors, null)
 
       reply.send({ hello: 'world' })
@@ -89,7 +98,7 @@ test('#compileValidationSchema', subtest => {
       const validate = req.compileValidationSchema(defaultSchema)
 
       t.notOk(validate({ world: 'foo' }))
-      t.ok(Object.prototype.hasOwnProperty.call(validate, 'errors'))
+      t.ok(Object.hasOwn(validate, 'errors'))
       t.ok(Array.isArray(validate.errors))
       t.ok(validate.errors.length > 0)
 
@@ -281,7 +290,7 @@ test('#getValidationFunction', subtest => {
       const validate = req.getValidationFunction(defaultSchema)
 
       t.ok(validate({ hello: 'world' }))
-      t.ok(Object.prototype.hasOwnProperty.call(validate, 'errors'))
+      t.ok(Object.hasOwn(validate, 'errors'))
       t.equal(validate.errors, null)
 
       reply.send({ hello: 'world' })
@@ -303,7 +312,7 @@ test('#getValidationFunction', subtest => {
       const validate = req.getValidationFunction(defaultSchema)
 
       t.notOk(validate({ world: 'foo' }))
-      t.ok(Object.prototype.hasOwnProperty.call(validate, 'errors'))
+      t.ok(Object.hasOwn(validate, 'errors'))
       t.ok(Array.isArray(validate.errors))
       t.ok(validate.errors.length > 0)