fastify 4.6.0 → 4.8.0

package/test/internals/validation.test.js

@@ -268,6 +268,21 @@ test('build schema - headers are not lowercased in case of custom object', t =>
   })
 })
 
+test('build schema - headers are not lowercased in case of custom validator provided', t => {
+  t.plan(1)
+
+  class Headers {}
+  const opts = {
+    schema: {
+      headers: new Headers()
+    }
+  }
+  validation.compileSchemasForValidation(opts, ({ schema, method, url, httpPart }) => {
+    t.type(schema, Headers)
+    return () => {}
+  }, true)
+})
+
 test('build schema - uppercased headers are not included', t => {
   t.plan(1)
   const opts = {

package/test/plugin.test.js

@@ -885,7 +885,7 @@ test('pluginTimeout', t => {
   })
 })
 
-test('pluginTimeout - named function', { only: true }, t => {
+test('pluginTimeout - named function', t => {
   t.plan(5)
   const fastify = Fastify({
     pluginTimeout: 10

package/test/reply-code.test.js

@@ -0,0 +1,59 @@
+'use strict'
+
+const t = require('tap')
+const test = t.test
+const Fastify = require('..')
+
+test('code should handle null/undefined/float', t => {
+  t.plan(8)
+
+  const fastify = Fastify()
+
+  fastify.get('/null', function (request, reply) {
+    reply.status(null).send()
+  })
+
+  fastify.get('/undefined', function (request, reply) {
+    reply.status(undefined).send()
+  })
+
+  fastify.get('/404.5', function (request, reply) {
+    reply.status(404.5).send()
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/null'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 500)
+    t.same(res.json(), {
+      statusCode: 500,
+      code: 'FST_ERR_BAD_STATUS_CODE',
+      error: 'Internal Server Error',
+      message: 'Called reply with an invalid status code: null'
+    })
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/undefined'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 500)
+    t.same(res.json(), {
+      statusCode: 500,
+      code: 'FST_ERR_BAD_STATUS_CODE',
+      error: 'Internal Server Error',
+      message: 'Called reply with an invalid status code: undefined'
+    })
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/404.5'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 404)
+  })
+})

package/test/route.test.js

@@ -1464,3 +1464,32 @@ test('invalid url attribute - non string URL', t => {
     t.equal(error.code, FST_ERR_INVALID_URL().code)
   }
 })
+
+test('exposeHeadRoute should not reuse the same route option', async t => {
+  t.plan(2)
+
+  const fastify = Fastify()
+
+  // we update the onRequest hook in onRoute hook
+  // if we reuse the same route option
+  // that means we will append another function inside the array
+  fastify.addHook('onRoute', function (routeOption) {
+    if (Array.isArray(routeOption.onRequest)) {
+      routeOption.onRequest.push(() => {})
+    } else {
+      routeOption.onRequest = [() => {}]
+    }
+  })
+
+  fastify.addHook('onRoute', function (routeOption) {
+    t.equal(routeOption.onRequest.length, 1)
+  })
+
+  fastify.route({
+    method: 'GET',
+    path: '/more-coffee',
+    async handler () {
+      return 'hello world'
+    }
+  })
+})

package/test/router-options.test.js

@@ -1,20 +1,13 @@
 'use strict'
 
 const test = require('tap').test
-const sget = require('simple-get')
 const Fastify = require('../')
-const { FST_ERR_BAD_URL } = require('../lib/errors')
-
-function getUrl (app) {
-  const { address, port } = app.server.address()
-  if (address === '::1') {
-    return `http://[${address}]:${port}`
-  } else {
-    return `http://${address}:${port}`
-  }
-}
+const {
+  FST_ERR_BAD_URL,
+  FST_ERR_ASYNC_CONSTRAINT
+} = require('../lib/errors')
 
-test('Should honor ignoreTrailingSlash option', t => {
+test('Should honor ignoreTrailingSlash option', async t => {
   t.plan(4)
   const fastify = Fastify({
     ignoreTrailingSlash: true
@@ -24,27 +17,16 @@ test('Should honor ignoreTrailingSlash option', t => {
     res.send('test')
   })
 
-  fastify.listen({ port: 0 }, (err) => {
-    t.teardown(() => { fastify.close() })
-    if (err) t.threw(err)
-
-    const baseUrl = getUrl(fastify)
-
-    sget.concat(baseUrl + '/test', (err, res, data) => {
-      if (err) t.threw(err)
-      t.equal(res.statusCode, 200)
-      t.equal(data.toString(), 'test')
-    })
+  let res = await fastify.inject('/test')
+  t.equal(res.statusCode, 200)
+  t.equal(res.payload.toString(), 'test')
 
-    sget.concat(baseUrl + '/test/', (err, res, data) => {
-      if (err) t.threw(err)
-      t.equal(res.statusCode, 200)
-      t.equal(data.toString(), 'test')
-    })
-  })
+  res = await fastify.inject('/test/')
+  t.equal(res.statusCode, 200)
+  t.equal(res.payload.toString(), 'test')
 })
 
-test('Should honor ignoreDuplicateSlashes option', t => {
+test('Should honor ignoreDuplicateSlashes option', async t => {
   t.plan(4)
   const fastify = Fastify({
     ignoreDuplicateSlashes: true
@@ -54,27 +36,16 @@ test('Should honor ignoreDuplicateSlashes option', t => {
     res.send('test')
   })
 
-  fastify.listen({ port: 0 }, (err) => {
-    t.teardown(() => { fastify.close() })
-    if (err) t.threw(err)
-
-    const baseUrl = getUrl(fastify)
-
-    sget.concat(baseUrl + '/test/test/test', (err, res, data) => {
-      if (err) t.threw(err)
-      t.equal(res.statusCode, 200)
-      t.equal(data.toString(), 'test')
-    })
+  let res = await fastify.inject('/test/test/test')
+  t.equal(res.statusCode, 200)
+  t.equal(res.payload.toString(), 'test')
 
-    sget.concat(baseUrl + '/test//test///test', (err, res, data) => {
-      if (err) t.threw(err)
-      t.equal(res.statusCode, 200)
-      t.equal(data.toString(), 'test')
-    })
-  })
+  res = await fastify.inject('/test//test///test')
+  t.equal(res.statusCode, 200)
+  t.equal(res.payload.toString(), 'test')
 })
 
-test('Should honor ignoreTrailingSlash and ignoreDuplicateSlashes options', t => {
+test('Should honor ignoreTrailingSlash and ignoreDuplicateSlashes options', async t => {
   t.plan(4)
   const fastify = Fastify({
     ignoreTrailingSlash: true,
@@ -85,24 +56,13 @@ test('Should honor ignoreTrailingSlash and ignoreDuplicateSlashes options', t =>
     res.send('test')
   })
 
-  fastify.listen({ port: 0 }, (err) => {
-    t.teardown(() => { fastify.close() })
-    if (err) t.threw(err)
-
-    const baseUrl = getUrl(fastify)
-
-    sget.concat(baseUrl + '/test/test/test/', (err, res, data) => {
-      if (err) t.threw(err)
-      t.equal(res.statusCode, 200)
-      t.equal(data.toString(), 'test')
-    })
+  let res = await fastify.inject('/test/test/test/')
+  t.equal(res.statusCode, 200)
+  t.equal(res.payload.toString(), 'test')
 
-    sget.concat(baseUrl + '/test//test///test//', (err, res, data) => {
-      if (err) t.threw(err)
-      t.equal(res.statusCode, 200)
-      t.equal(data.toString(), 'test')
-    })
-  })
+  res = await fastify.inject('/test//test///test//')
+  t.equal(res.statusCode, 200)
+  t.equal(res.payload.toString(), 'test')
 })
 
 test('Should honor maxParamLength option', t => {
@@ -131,12 +91,22 @@ test('Should honor maxParamLength option', t => {
 })
 
 test('Should expose router options via getters on request and reply', t => {
-  t.plan(7)
+  t.plan(10)
   const fastify = Fastify()
+  const expectedSchema = {
+    params: {
+      id: { type: 'integer' }
+    }
+  }
 
-  fastify.get('/test/:id', (req, reply) => {
+  fastify.get('/test/:id', {
+    schema: expectedSchema
+  }, (req, reply) => {
     t.equal(reply.context.config.url, '/test/:id')
     t.equal(reply.context.config.method, 'GET')
+    t.equal(req.routeConfig.url, '/test/:id')
+    t.equal(req.routeConfig.method, 'GET')
+    t.same(req.routeSchema, expectedSchema)
     t.equal(req.routerPath, '/test/:id')
     t.equal(req.routerMethod, 'GET')
     t.equal(req.is404, false)
@@ -170,7 +140,7 @@ test('Should set is404 flag for unmatched paths', t => {
   })
 })
 
-test('Should honor frameworkErrors option', t => {
+test('Should honor frameworkErrors option - FST_ERR_BAD_URL', t => {
   t.plan(3)
   const fastify = Fastify({
     frameworkErrors: function (err, req, res) {
@@ -198,3 +168,54 @@ test('Should honor frameworkErrors option', t => {
     }
   )
 })
+
+test('Should honor frameworkErrors option - FST_ERR_ASYNC_CONSTRAINT', t => {
+  t.plan(3)
+
+  const constraint = {
+    name: 'secret',
+    storage: function () {
+      const secrets = {}
+      return {
+        get: (secret) => { return secrets[secret] || null },
+        set: (secret, store) => { secrets[secret] = store }
+      }
+    },
+    deriveConstraint: (req, ctx, done) => {
+      done(Error('kaboom'))
+    },
+    validate () { return true }
+  }
+
+  const fastify = Fastify({
+    frameworkErrors: function (err, req, res) {
+      if (err instanceof FST_ERR_ASYNC_CONSTRAINT) {
+        t.ok(true)
+      } else {
+        t.fail()
+      }
+      res.send(`${err.message} - ${err.code}`)
+    },
+    constraints: { secret: constraint }
+  })
+
+  fastify.route({
+    method: 'GET',
+    url: '/',
+    constraints: { secret: 'alpha' },
+    handler: (req, reply) => {
+      reply.send({ hello: 'from alpha' })
+    }
+  })
+
+  fastify.inject(
+    {
+      method: 'GET',
+      url: '/'
+    },
+    (err, res) => {
+      t.error(err)
+      t.equal(res.body, 'Unexpected error from async constraint - FST_ERR_ASYNC_CONSTRAINT')
+    }
+  )
+})

package/test/schema-feature.test.js

@@ -1779,3 +1779,28 @@ test('Should return a human-friendly error if response status codes are not spec
     t.match(err.message, 'Failed building the serialization schema for GET: /, due to error response schemas should be nested under a valid status code, e.g { 2xx: { type: "object" } }')
   })
 })
+
+test('setSchemaController: custom validator instance should not mutate headers schema', async t => {
+  t.plan(2)
+  class Headers {}
+  const fastify = Fastify()
+
+  fastify.setSchemaController({
+    compilersFactory: {
+      buildValidator: function () {
+        return ({ schema, method, url, httpPart }) => {
+          t.type(schema, Headers)
+          return () => {}
+        }
+      }
+    }
+  })
+
+  fastify.get('/', {
+    schema: {
+      headers: new Headers()
+    }
+  }, () => {})
+
+  await fastify.ready()
+})

package/test/schema-validation.test.js

@@ -1017,3 +1017,22 @@ test("The same $id in route's schema must not overwrite others", t => {
     t.same(res.payload, 'ok')
   })
 })
+
+test('Custom validator compiler should not mutate schema', async t => {
+  t.plan(2)
+  class Headers {}
+  const fastify = Fastify()
+
+  fastify.setValidatorCompiler(({ schema, method, url, httpPart }) => {
+    t.type(schema, Headers)
+    return () => {}
+  })
+
+  fastify.get('/', {
+    schema: {
+      headers: new Headers()
+    }
+  }, () => {})
+
+  await fastify.ready()
+})

package/test/search.test.js

@@ -1,18 +1,17 @@
 'use strict'
 
 const t = require('tap')
+const sget = require('simple-get').concat
 const test = t.test
 const fastify = require('..')()
 
 const schema = {
-  schema: {
-    response: {
-      '2xx': {
-        type: 'object',
-        properties: {
-          hello: {
-            type: 'string'
-          }
+  response: {
+    '2xx': {
+      type: 'object',
+      properties: {
+        hello: {
+          type: 'string'
         }
       }
     }
@@ -20,35 +19,45 @@ const schema = {
 }
 
 const querySchema = {
-  schema: {
-    querystring: {
-      type: 'object',
-      properties: {
-        hello: {
-          type: 'integer'
-        }
+  querystring: {
+    type: 'object',
+    properties: {
+      hello: {
+        type: 'integer'
       }
     }
   }
 }
 
 const paramsSchema = {
-  schema: {
-    params: {
-      type: 'object',
-      properties: {
-        foo: {
-          type: 'string'
-        },
-        test: {
-          type: 'integer'
-        }
+  params: {
+    type: 'object',
+    properties: {
+      foo: {
+        type: 'string'
+      },
+      test: {
+        type: 'integer'
       }
     }
   }
 }
 
-test('shorthand - search', t => {
+const bodySchema = {
+  body: {
+    type: 'object',
+    properties: {
+      foo: {
+        type: 'string'
+      },
+      test: {
+        type: 'integer'
+      }
+    }
+  }
+}
+
+test('search', t => {
   t.plan(1)
   try {
     fastify.route({
@@ -65,13 +74,13 @@ test('shorthand - search', t => {
   }
 })
 
-test('shorthand - search params', t => {
+test('search, params schema', t => {
   t.plan(1)
   try {
     fastify.route({
       method: 'SEARCH',
       url: '/params/:foo/:test',
-      paramsSchema,
+      schema: paramsSchema,
       handler: function (request, reply) {
         reply.code(200).send(request.params)
       }
@@ -82,13 +91,13 @@ test('shorthand - search params', t => {
   }
 })
 
-test('shorthand - get, querystring schema', t => {
+test('search, querystring schema', t => {
   t.plan(1)
   try {
     fastify.route({
       method: 'SEARCH',
       url: '/query',
-      querySchema,
+      schema: querySchema,
       handler: function (request, reply) {
         reply.code(200).send(request.query)
       }
@@ -98,3 +107,133 @@ test('shorthand - get, querystring schema', t => {
     t.fail()
   }
 })
+
+test('search, body schema', t => {
+  t.plan(1)
+  try {
+    fastify.route({
+      method: 'SEARCH',
+      url: '/body',
+      schema: bodySchema,
+      handler: function (request, reply) {
+        reply.code(200).send(request.body)
+      }
+    })
+    t.pass()
+  } catch (e) {
+    t.fail()
+  }
+})
+
+fastify.listen({ port: 0 }, err => {
+  t.error(err)
+  t.teardown(() => { fastify.close() })
+
+  const url = `http://localhost:${fastify.server.address().port}`
+
+  test('request - search', t => {
+    t.plan(4)
+    sget({
+      method: 'SEARCH',
+      url
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 200)
+      t.equal(response.headers['content-length'], '' + body.length)
+      t.same(JSON.parse(body), { hello: 'world' })
+    })
+  })
+
+  test('request search params schema', t => {
+    t.plan(4)
+    sget({
+      method: 'SEARCH',
+      url: `${url}/params/world/123`
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 200)
+      t.equal(response.headers['content-length'], '' + body.length)
+      t.same(JSON.parse(body), { foo: 'world', test: 123 })
+    })
+  })
+
+  test('request search params schema error', t => {
+    t.plan(3)
+    sget({
+      method: 'SEARCH',
+      url: `${url}/params/world/string`
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 400)
+      t.same(JSON.parse(body), {
+        error: 'Bad Request',
+        message: 'params/test must be integer',
+        statusCode: 400
+      })
+    })
+  })
+
+  test('request search querystring schema', t => {
+    t.plan(4)
+    sget({
+      method: 'SEARCH',
+      url: `${url}/query?hello=123`
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 200)
+      t.equal(response.headers['content-length'], '' + body.length)
+      t.same(JSON.parse(body), { hello: 123 })
+    })
+  })
+
+  test('request search querystring schema error', t => {
+    t.plan(3)
+    sget({
+      method: 'SEARCH',
+      url: `${url}/query?hello=world`
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 400)
+      t.same(JSON.parse(body), {
+        error: 'Bad Request',
+        message: 'querystring/hello must be integer',
+        statusCode: 400
+      })
+    })
+  })
+
+  test('request search body schema', t => {
+    t.plan(4)
+    const replyBody = { foo: 'bar', test: 5 }
+    sget({
+      method: 'SEARCH',
+      url: `${url}/body`,
+      body: JSON.stringify(replyBody),
+      headers: { 'content-type': 'application/json' }
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 200)
+      t.equal(response.headers['content-length'], '' + body.length)
+      t.same(JSON.parse(body), replyBody)
+    })
+  })
+
+  test('request search body schema error', t => {
+    t.plan(4)
+    sget({
+      method: 'SEARCH',
+      url: `${url}/body`,
+      body: JSON.stringify({ foo: 'bar', test: 'test' }),
+      headers: { 'content-type': 'application/json' }
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 400)
+      t.equal(response.headers['content-length'], '' + body.length)
+      t.same(JSON.parse(body), {
+        error: 'Bad Request',
+        message: 'body/test must be integer',
+        statusCode: 400
+      })
+    })
+  })
+})

package/test/server.test.js

@@ -0,0 +1,54 @@
+'use strict'
+
+const t = require('tap')
+const test = t.test
+const Fastify = require('..')
+
+test('listen should accept null port', t => {
+  t.plan(1)
+
+  const fastify = Fastify()
+  t.teardown(fastify.close.bind(fastify))
+  fastify.listen({ port: null }, (err) => {
+    t.error(err)
+  })
+})
+
+test('listen should accept undefined port', t => {
+  t.plan(1)
+
+  const fastify = Fastify()
+  t.teardown(fastify.close.bind(fastify))
+  fastify.listen({ port: undefined }, (err) => {
+    t.error(err)
+  })
+})
+
+test('listen should accept stringified number port', t => {
+  t.plan(1)
+
+  const fastify = Fastify()
+  t.teardown(fastify.close.bind(fastify))
+  fastify.listen({ port: '1234' }, (err) => {
+    t.error(err)
+  })
+})
+
+test('listen should reject string port', async (t) => {
+  t.plan(2)
+
+  const fastify = Fastify()
+  t.teardown(fastify.close.bind(fastify))
+
+  try {
+    await fastify.listen({ port: 'hello-world' })
+  } catch (error) {
+    t.same(error.message, 'options.port should be >= 0 and < 65536. Received hello-world.')
+  }
+
+  try {
+    await fastify.listen({ port: '1234hello' })
+  } catch (error) {
+    t.same(error.message, 'options.port should be >= 0 and < 65536. Received 1234hello.')
+  }
+})