fastify 4.28.0 → 5.0.0-alpha.3

package/test/async-await.test.js

@@ -24,8 +24,28 @@ const opts = {
   }
 }
 
+const optsWithHostnameAndPort = {
+  schema: {
+    response: {
+      '2xx': {
+        type: 'object',
+        properties: {
+          hello: {
+            type: 'string'
+          },
+          hostname: {
+            type: 'string'
+          },
+          port: {
+            type: 'string'
+          }
+        }
+      }
+    }
+  }
+}
 test('async await', t => {
-  t.plan(11)
+  t.plan(13)
   const fastify = Fastify()
   try {
     fastify.get('/', opts, async function awaitMyFunc (req, reply) {
@@ -46,6 +66,16 @@ test('async await', t => {
     t.fail()
   }
 
+  try {
+    fastify.get('/await/hostname_port', optsWithHostnameAndPort, async function awaitMyFunc (req, reply) {
+      await sleep(200)
+      return { hello: 'world', hostname: req.hostname, port: req.port }
+    })
+    t.pass()
+  } catch (e) {
+    t.fail()
+  }
+
   fastify.listen({ port: 0 }, err => {
     t.error(err)
     t.teardown(() => { fastify.close() })
@@ -69,6 +99,20 @@ test('async await', t => {
       t.equal(response.headers['content-length'], '' + body.length)
       t.same(JSON.parse(body), { hello: 'world' })
     })
+
+    t.test('test for hostname and port in request', t => {
+      t.plan(4)
+      sget({
+        method: 'GET',
+        url: 'http://localhost:' + fastify.server.address().port + '/await/hostname_port'
+      }, (err, response, body) => {
+        t.error(err)
+        t.equal(response.statusCode, 200)
+        const parsedBody = JSON.parse(body)
+        t.equal(parsedBody.hostname, 'localhost')
+        t.equal(parseInt(parsedBody.port), fastify.server.address().port)
+      })
+    })
   })
 })
 
@@ -135,7 +179,7 @@ test('server logs an error if reply.send is called and a value is returned via a
   const logger = pino(splitStream)
 
   const fastify = Fastify({
-    logger
+    loggerInstance: logger
   })
 
   fastify.get('/', async (req, reply) => {

package/test/build/error-serializer.test.js

@@ -4,6 +4,7 @@ const t = require('tap')
 const test = t.test
 const fs = require('node:fs')
 const path = require('node:path')
+const { loadESLint } = require('eslint')
 
 const { code } = require('../../build/build-error-serializer')
 
@@ -15,8 +16,9 @@ test('check generated code syntax', async (t) => {
   t.plan(1)
 
   // standard is a esm, we import it like this
-  const { default: standard } = await import('standard')
-  const result = await standard.lintText(code)
+  const Eslint = await loadESLint({ useFlatConfig: true })
+  const eslint = new Eslint()
+  const result = await eslint.lintText(code)
 
   // if there are any invalid syntax
   // fatal count will be greater than 0

package/test/check.test.js

@@ -0,0 +1,225 @@
+'use strict'
+
+const t = require('tap')
+const test = t.test
+const { S } = require('fluent-json-schema')
+const Fastify = require('..')
+const sget = require('simple-get').concat
+
+const BadRequestSchema = S.object()
+  .prop('statusCode', S.number())
+  .prop('error', S.string())
+  .prop('message', S.string())
+
+const InternalServerErrorSchema = S.object()
+  .prop('statusCode', S.number())
+  .prop('error', S.string())
+  .prop('message', S.string())
+
+const NotFoundSchema = S.object()
+  .prop('statusCode', S.number())
+  .prop('error', S.string())
+  .prop('message', S.string())
+
+const options = {
+  schema: {
+    body: {
+      type: 'object',
+      properties: {
+        id: { type: 'string' }
+      }
+    },
+    response: {
+      200: {
+        type: 'object',
+        properties: {
+          id: { type: 'string' }
+        }
+      },
+      400: {
+        description: 'Bad Request',
+        content: {
+          'application/json': {
+            schema: BadRequestSchema.valueOf()
+          }
+        }
+      },
+      404: {
+        description: 'Resource not found',
+        content: {
+          'application/json': {
+            schema: NotFoundSchema.valueOf(),
+            example: {
+              statusCode: 404,
+              error: 'Not Found',
+              message: 'Not Found'
+            }
+          }
+        }
+      },
+      500: {
+        description: 'Internal Server Error',
+        content: {
+          'application/json': {
+            schema: InternalServerErrorSchema.valueOf(),
+            example: {
+              message: 'Internal Server Error'
+            }
+          }
+        }
+      }
+    }
+  }
+}
+
+const handler = (request, reply) => {
+  console.log('in handler')
+  if (request.body.id === '400') {
+    return reply.status(400).send({
+      statusCode: 400,
+      error: 'Bad Request',
+      message: 'Custom message',
+      extra: 'This should not be in the response'
+    })
+  }
+
+  if (request.body.id === '404') {
+    return reply.status(404).send({
+      statusCode: 404,
+      error: 'Not Found',
+      message: 'Custom Not Found',
+      extra: 'This should not be in the response'
+    })
+  }
+
+  if (request.body.id === '500') {
+    reply.status(500).send({
+      statusCode: 500,
+      error: 'Internal Server Error',
+      message: 'Custom Internal Server Error',
+      extra: 'This should not be in the response'
+    })
+  }
+
+  reply.send({
+    id: request.body.id,
+    extra: 'This should not be in the response'
+  })
+}
+
+test('serialize the response for a Bad Request error, as defined on the schema', t => {
+  const fastify = Fastify({})
+
+  t.teardown(fastify.close.bind(fastify))
+
+  fastify.post('/', options, handler)
+
+  fastify.listen({ port: 0 }, err => {
+    t.error(err)
+
+    const url = `http://localhost:${fastify.server.address().port}/`
+
+    sget({
+      method: 'POST',
+      url,
+      json: true
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 400)
+      t.same(body, {
+        statusCode: 400,
+        error: 'Bad Request',
+        message: 'body must be object'
+      })
+      t.end()
+    })
+  })
+})
+
+// test('serialize the response for a Not Found error, as defined on the schema', t => {
+//   const fastify = Fastify({})
+
+//   t.teardown(fastify.close.bind(fastify))
+
+//   fastify.post('/', options, handler)
+
+//   fastify.listen({ port: 0 }, err => {
+//     t.error(err)
+
+//     const url = `http://localhost:${fastify.server.address().port}/`
+
+//     sget({
+//       method: 'POST',
+//       url,
+//       json: true,
+//       body: { id: '404' }
+//     }, (err, response, body) => {
+//       t.error(err)
+//       t.equal(response.statusCode, 404)
+//       t.same(body, {
+//         statusCode: 404,
+//         error: 'Not Found',
+//         message: 'Custom Not Found'
+//       })
+//       t.end()
+//     })
+//   })
+// })
+
+// test('serialize the response for a Internal Server Error error, as defined on the schema', t => {
+//   const fastify = Fastify({})
+
+//   t.teardown(fastify.close.bind(fastify))
+
+//   fastify.post('/', options, handler)
+
+//   fastify.listen({ port: 0 }, err => {
+//     t.error(err)
+
+//     const url = `http://localhost:${fastify.server.address().port}/`
+
+//     sget({
+//       method: 'POST',
+//       url,
+//       json: true,
+//       body: { id: '500' }
+//     }, (err, response, body) => {
+//       t.error(err)
+//       t.equal(response.statusCode, 500)
+//       t.same(body, {
+//         statusCode: 500,
+//         error: 'Internal Server Error',
+//         message: 'Custom Internal Server Error'
+//       })
+//       t.end()
+//     })
+//   })
+// })
+
+// test('serialize the success response, as defined on the schema', t => {
+//   const fastify = Fastify({})
+
+//   t.teardown(fastify.close.bind(fastify))
+
+//   fastify.post('/', options, handler)
+
+//   fastify.listen({ port: 0 }, err => {
+//     t.error(err)
+
+//     const url = `http://localhost:${fastify.server.address().port}/`
+
+//     sget({
+//       method: 'POST',
+//       url,
+//       json: true,
+//       body: { id: 'test' }
+//     }, (err, response, body) => {
+//       t.error(err)
+//       t.equal(response.statusCode, 200)
+//       t.same(body, {
+//         id: 'test'
+//       })
+//       t.end()
+//     })
+//   })
+// })

package/test/close-pipelining.test.js

@@ -4,7 +4,6 @@ const t = require('tap')
 const test = t.test
 const Fastify = require('..')
 const { Client } = require('undici')
-const semver = require('semver')
 
 test('Should return 503 while closing - pipelining', async t => {
   const fastify = Fastify({
@@ -36,46 +35,8 @@ test('Should return 503 while closing - pipelining', async t => {
   await instance.close()
 })
 
-// default enable of idle closing idle connection is accidentally backported to 18.19.0 and fixed in 18.20.3
-// Refs: https://github.com/nodejs/node/releases/tag/v18.20.3
-const isNodeDefaultClosingIdleConnection =
-  (
-    semver.gte(process.version, '18.19.0') &&
-    semver.lt(process.version, '18.20.3')
-  ) ||
-  semver.gte(process.version, '19.0.0')
-test('Should not return 503 while closing - pipelining - return503OnClosing: false, skip when Node default closing idle connection', { skip: isNodeDefaultClosingIdleConnection }, async t => {
-  const fastify = Fastify({
-    return503OnClosing: false,
-    forceCloseConnections: false
-  })
-
-  fastify.get('/', (req, reply) => {
-    fastify.close()
-    reply.send({ hello: 'world' })
-  })
-
-  await fastify.listen({ port: 0 })
-
-  const instance = new Client('http://localhost:' + fastify.server.address().port, {
-    pipelining: 2
-  })
-
-  const codes = [200, 200, 200]
-  const responses = await Promise.all([
-    instance.request({ path: '/', method: 'GET' }),
-    instance.request({ path: '/', method: 'GET' }),
-    instance.request({ path: '/', method: 'GET' })
-  ])
-  const actual = responses.map(r => r.statusCode)
-
-  t.same(actual, codes)
-
-  await instance.close()
-})
-
-test('Should close the socket abruptly - pipelining - return503OnClosing: false, skip when Node not default closing idle connection', { skip: !isNodeDefaultClosingIdleConnection }, async t => {
-  // Since Node v19, we will always invoke server.closeIdleConnections()
+test('Should close the socket abruptly - pipelining - return503OnClosing: false', async t => {
+  // Since Node v20, we will always invoke server.closeIdleConnections()
   // therefore our socket will be closed
   const fastify = Fastify({
     return503OnClosing: false,

package/test/close.test.js

@@ -5,7 +5,6 @@ const http = require('node:http')
 const { test } = require('tap')
 const Fastify = require('..')
 const { Client } = require('undici')
-const semver = require('semver')
 const split = require('split2')
 const { sleep } = require('./helper')
 
@@ -204,46 +203,7 @@ test('Should return error while closing (callback) - injection', t => {
   })
 })
 
-const isNodeVersionGte1819 = semver.gte(process.version, '18.19.0')
-test('Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v18.19.x', { skip: isNodeVersionGte1819 }, t => {
-  const fastify = Fastify({
-    return503OnClosing: false,
-    forceCloseConnections: false
-  })
-
-  fastify.get('/', (req, reply) => {
-    fastify.close()
-    reply.send({ hello: 'world' })
-  })
-
-  fastify.listen({ port: 0 }, err => {
-    t.error(err)
-
-    const port = fastify.server.address().port
-    const client = net.createConnection({ port }, () => {
-      client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
-
-      client.once('data', data => {
-        t.match(data.toString(), /Connection:\s*keep-alive/i)
-        t.match(data.toString(), /200 OK/i)
-
-        client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
-
-        client.once('data', data => {
-          t.match(data.toString(), /Connection:\s*close/i)
-          t.match(data.toString(), /200 OK/i)
-
-          // Test that fastify closes the TCP connection
-          client.once('close', () => {
-            t.end()
-          })
-        })
-      })
-    })
-  })
-})
-
-test('Current opened connection should NOT continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node < v18.19.x', { skip: !isNodeVersionGte1819 }, t => {
+test('Current opened connection should NOT continue to work after closing and return "connection: close" header - return503OnClosing: false', t => {
   t.plan(4)
   const fastify = Fastify({
     return503OnClosing: false,