fastify 4.27.0 → 5.0.0-alpha.2

package/test/listen.5.test.js

@@ -0,0 +1,88 @@
+'use strict'
+
+const { test } = require('tap')
+const net = require('node:net')
+const Fastify = require('../fastify')
+const { once } = require('node:events')
+
+test('same port conflict and success should not fire callback multiple times - callback', async (t) => {
+  t.plan(7)
+  const server = net.createServer()
+  server.listen({ port: 0, host: '127.0.0.1' })
+  await once(server, 'listening')
+  const option = { port: server.address().port, host: server.address().address }
+  let count = 0
+  const fastify = Fastify()
+  function callback (err) {
+    switch (count) {
+      case 6: {
+        // success in here
+        t.error(err)
+        fastify.close((err) => {
+          t.error(err)
+        })
+        break
+      }
+      case 5: {
+        server.close()
+        setTimeout(() => {
+          fastify.listen(option, callback)
+        }, 100)
+        break
+      }
+      default: {
+        // expect error
+        t.equal(err.code, 'EADDRINUSE')
+        setTimeout(() => {
+          fastify.listen(option, callback)
+        }, 100)
+      }
+    }
+    count++
+  }
+  fastify.listen(option, callback)
+})
+
+test('same port conflict and success should not fire callback multiple times - promise', async (t) => {
+  t.plan(5)
+  const server = net.createServer()
+  server.listen({ port: 0, host: '127.0.0.1' })
+  await once(server, 'listening')
+  const option = { port: server.address().port, host: server.address().address }
+  const fastify = Fastify()
+
+  try {
+    await fastify.listen(option)
+  } catch (err) {
+    t.equal(err.code, 'EADDRINUSE')
+  }
+  try {
+    await fastify.listen(option)
+  } catch (err) {
+    t.equal(err.code, 'EADDRINUSE')
+  }
+  try {
+    await fastify.listen(option)
+  } catch (err) {
+    t.equal(err.code, 'EADDRINUSE')
+  }
+  try {
+    await fastify.listen(option)
+  } catch (err) {
+    t.equal(err.code, 'EADDRINUSE')
+  }
+  try {
+    await fastify.listen(option)
+  } catch (err) {
+    t.equal(err.code, 'EADDRINUSE')
+  }
+
+  server.close()
+
+  await once(server, 'close')
+
+  // when ever we can listen, and close properly
+  // which means there is no problem on the callback
+  await fastify.listen()
+  await fastify.close()
+})

package/test/logger/instantiation.test.js

@@ -32,9 +32,9 @@ t.test('logger instantiation', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = require('pino')(stream)
+    const loggerInstance = require('pino')(stream)
 
-    const fastify = Fastify({ logger })
+    const fastify = Fastify({ loggerInstance })
     t.teardown(fastify.close.bind(fastify))
 
     fastify.get('/foo', function (req, reply) {
@@ -203,17 +203,17 @@ t.test('logger instantiation', (t) => {
   t.test('should be able to use a custom logger', (t) => {
     t.plan(7)
 
-    const logger = {
+    const loggerInstance = {
       fatal: (msg) => { t.equal(msg, 'fatal') },
       error: (msg) => { t.equal(msg, 'error') },
       warn: (msg) => { t.equal(msg, 'warn') },
       info: (msg) => { t.equal(msg, 'info') },
       debug: (msg) => { t.equal(msg, 'debug') },
       trace: (msg) => { t.equal(msg, 'trace') },
-      child: () => logger
+      child: () => loggerInstance
     }
 
-    const fastify = Fastify({ logger })
+    const fastify = Fastify({ loggerInstance })
     t.teardown(fastify.close.bind(fastify))
 
     fastify.log.fatal('fatal')
@@ -223,7 +223,7 @@ t.test('logger instantiation', (t) => {
     fastify.log.debug('debug')
     fastify.log.trace('trace')
     const child = fastify.log.child()
-    t.equal(child, logger)
+    t.equal(child, loggerInstance)
   })
 
   t.test('should throw in case a partially matching logger is provided', async (t) => {
@@ -246,7 +246,7 @@ t.test('logger instantiation', (t) => {
     t.plan(lines.length + 1)
 
     const stream = split(JSON.parse)
-    const logger = require('pino')({
+    const loggerInstance = require('pino')({
       level: 'info',
       serializers: {
         req: function (req) {
@@ -258,7 +258,7 @@ t.test('logger instantiation', (t) => {
     }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 

package/test/logger/logging.test.js

@@ -29,10 +29,10 @@ t.test('logging', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'trace' }, stream)
+    const loggerInstance = pino({ level: 'trace' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -229,10 +229,10 @@ t.test('logging', (t) => {
     t.plan(lines.length + 1)
 
     const stream = split(JSON.parse)
-    const logger = pino(stream)
+    const loggerInstance = pino(stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 

package/test/logger/options.test.js

@@ -12,7 +12,7 @@ const { on } = stream
 t.test('logger options', (t) => {
   t.setTimeout(60000)
 
-  t.plan(12)
+  t.plan(16)
 
   t.test('logger can be silenced', (t) => {
     t.plan(17)
@@ -48,10 +48,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'error' }, stream)
+    const loggerInstance = pino({ level: 'error' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -94,10 +94,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'error' }, stream)
+    const loggerInstance = pino({ level: 'error' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -130,10 +130,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'error' }, stream)
+    const loggerInstance = pino({ level: 'error' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -193,9 +193,9 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'info' }, stream)
+    const loggerInstance = pino({ level: 'info' }, stream)
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -252,9 +252,9 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'info' }, stream)
+    const loggerInstance = pino({ level: 'info' }, stream)
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -290,9 +290,9 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'info' }, stream)
+    const loggerInstance = pino({ level: 'info' }, stream)
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -333,10 +333,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'info' }, stream)
+    const loggerInstance = pino({ level: 'info' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -369,10 +369,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'warn' }, stream)
+    const loggerInstance = pino({ level: 'warn' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -404,10 +404,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'warn' }, stream)
+    const loggerInstance = pino({ level: 'warn' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -444,10 +444,10 @@ t.test('logger options', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'error' }, stream)
+    const loggerInstance = pino({ level: 'error' }, stream)
 
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -497,4 +497,85 @@ t.test('logger options', (t) => {
     t.equal(typeof fastify.log.trace, 'function')
     t.equal(typeof fastify.log.child, 'function')
   })
+
+  t.test('Should throw an error if logger instance is passed to `logger`', async (t) => {
+    t.plan(2)
+    const stream = split(JSON.parse)
+
+    const logger = require('pino')(stream)
+
+    try {
+      Fastify({ logger })
+    } catch (err) {
+      t.ok(err)
+      t.equal(err.code, 'FST_ERR_LOG_INVALID_LOGGER_CONFIG')
+    }
+  })
+
+  t.test('Should throw an error if options are passed to `loggerInstance`', async (t) => {
+    t.plan(2)
+    try {
+      Fastify({ loggerInstance: { level: 'log' } })
+    } catch (err) {
+      t.ok(err)
+      t.equal(err.code, 'FST_ERR_LOG_INVALID_LOGGER_INSTANCE')
+    }
+  })
+
+  t.test('If both `loggerInstance` and `logger` are provided, an error should be thrown', async (t) => {
+    t.plan(2)
+    const loggerInstanceStream = split(JSON.parse)
+    const loggerInstance = pino({ level: 'error' }, loggerInstanceStream)
+    const loggerStream = split(JSON.parse)
+    try {
+      Fastify({
+        logger: {
+          stream: loggerStream,
+          level: 'info'
+        },
+        loggerInstance
+      })
+    } catch (err) {
+      t.ok(err)
+      t.equal(err.code, 'FST_ERR_LOG_LOGGER_AND_LOGGER_INSTANCE_PROVIDED')
+    }
+  })
+
+  t.test('`logger` should take pino configuration and create a pino logger', async (t) => {
+    const lines = ['hello', 'world']
+    t.plan(2 * lines.length + 2)
+    const loggerStream = split(JSON.parse)
+    const fastify = Fastify({
+      logger: {
+        stream: loggerStream,
+        level: 'error'
+      }
+    })
+    t.teardown(fastify.close.bind(fastify))
+    fastify.get('/hello', (req, reply) => {
+      req.log.error('hello')
+      reply.code(404).send()
+    })
+
+    fastify.get('/world', (req, reply) => {
+      req.log.error('world')
+      reply.code(201).send()
+    })
+
+    await fastify.ready()
+    {
+      const response = await fastify.inject({ method: 'GET', url: '/hello' })
+      t.equal(response.statusCode, 404)
+    }
+    {
+      const response = await fastify.inject({ method: 'GET', url: '/world' })
+      t.equal(response.statusCode, 201)
+    }
+
+    for await (const [line] of on(loggerStream, 'data')) {
+      t.equal(line.level, 50)
+      t.equal(line.msg, lines.shift())
+      if (lines.length === 0) break
+    }
+  })
 })

package/test/logger/response.test.js

@@ -24,9 +24,9 @@ t.test('response serialization', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({ level: 'info' }, stream)
+    const loggerInstance = pino({ level: 'info' }, stream)
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -70,7 +70,7 @@ t.test('response serialization', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({
+    const loggerInstance = pino({
       level: 'info',
       serializers: {
         test: value => 'X' + value,
@@ -78,7 +78,7 @@ t.test('response serialization', (t) => {
       }
     }, stream)
     const fastify = Fastify({
-      logger
+      loggerInstance
     })
     t.teardown(fastify.close.bind(fastify))
 
@@ -115,14 +115,14 @@ t.test('response serialization', (t) => {
 
     const stream = split(JSON.parse)
 
-    const logger = pino({
+    const loggerInstance = pino({
       level: 'info',
       serializers: {
         test: value => 'X' + value
       }
     }, stream)
 
-    const fastify = Fastify({ logger })
+    const fastify = Fastify({ loggerInstance })
     t.teardown(fastify.close.bind(fastify))
 
     fastify.register(context1, { logSerializers: { test2: value => 'Y' + value } })

package/test/maxRequestsPerSocket.test.js

@@ -2,12 +2,9 @@
 
 const net = require('node:net')
 const { test } = require('tap')
-const semver = require('semver')
 const Fastify = require('../fastify')
 
-const skip = semver.lt(process.versions.node, '16.10.0')
-
-test('maxRequestsPerSocket on node version >= 16.10.0', { skip }, t => {
+test('maxRequestsPerSocket', t => {
   t.plan(8)
 
   const fastify = Fastify({ maxRequestsPerSocket: 2 })
@@ -48,7 +45,7 @@ test('maxRequestsPerSocket on node version >= 16.10.0', { skip }, t => {
   })
 })
 
-test('maxRequestsPerSocket zero should behave same as null', { skip }, t => {
+test('maxRequestsPerSocket zero should behave same as null', t => {
   t.plan(10)
 
   const fastify = Fastify({ maxRequestsPerSocket: 0 })

package/test/method-missing.test.js

@@ -0,0 +1,24 @@
+const http = require('http')
+const { test } = require('tap')
+const Fastify = require('../fastify')
+
+test('missing method from http client', t => {
+  t.plan(2)
+  const fastify = Fastify()
+
+  fastify.listen({ port: 3000 }, (err) => {
+    t.error(err)
+
+    const port = fastify.server.address().port
+    const req = http.request({
+      port,
+      method: 'REBIND',
+      path: '/'
+    }, (res) => {
+      t.equal(res.statusCode, 404)
+      fastify.close()
+    })
+
+    req.end()
+  })
+})

package/test/plugin.1.test.js

@@ -1,7 +1,5 @@
 'use strict'
 
-/* eslint no-prototype-builtins: 0 */
-
 const t = require('tap')
 const test = t.test
 const Fastify = require('../fastify')
@@ -117,8 +115,8 @@ test('fastify.register with fastify-plugin should provide access to external fas
 
     instance.register((i, o, n) => n(), p => {
       t.notOk(p === instance || p === fastify)
-      t.ok(instance.isPrototypeOf(p))
-      t.ok(fastify.isPrototypeOf(p))
+      t.ok(Object.prototype.isPrototypeOf.call(instance, p))
+      t.ok(Object.prototype.isPrototypeOf.call(fastify, p))
       t.ok(p.global)
     })
 

package/test/plugin.2.test.js

@@ -1,7 +1,5 @@
 'use strict'
 
-/* eslint no-prototype-builtins: 0 */
-
 const t = require('tap')
 const test = t.test
 const Fastify = require('../fastify')

package/test/plugin.3.test.js

@@ -1,7 +1,5 @@
 'use strict'
 
-/* eslint no-prototype-builtins: 0 */
-
 const t = require('tap')
 const test = t.test
 const Fastify = require('../fastify')