fastify 4.25.1 → 4.25.2

package/docs/Reference/Server.md

@@ -1532,9 +1532,11 @@ handlers. *async-await* is supported as well.
 If the error `statusCode` is less than 400, Fastify will automatically
 set it to 500 before calling the error handler.
 
-> **Note** 
-> `setErrorHandler` will ***not*** catch any error inside
-> an `onResponse` hook because the response has already been sent to the client.
+`setErrorHandler` will ***not*** catch:
+- errors thrown in an `onResponse` hook because the response has already been
+  sent to the client. Use the `onSend` hook instead.
+- not found (404) errors. Use [`setNotFoundHandler`](#set-not-found-handler)
+  instead.
 
 ```js
 fastify.setErrorHandler(function (error, request, reply) {

package/fastify.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const VERSION = '4.25.1'
+const VERSION = '4.25.2'
 
 const Avvio = require('avvio')
 const http = require('node:http')

package/lib/reply.js

@@ -605,6 +605,10 @@ function onSendEnd (reply, payload) {
     reply.removeHeader('content-length')
     safeWriteHead(reply, statusCode)
     sendTrailer(undefined, res, reply)
+    if (typeof payload.resume === 'function') {
+      payload.on('error', noop)
+      payload.resume()
+    }
     return
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fastify",
-  "version": "4.25.1",
+  "version": "4.25.2",
   "description": "Fast and low overhead web framework, for Node.js",
   "main": "fastify.js",
   "type": "commonjs",
@@ -25,7 +25,7 @@
     "test:report": "npm run lint && npm run unit:report && npm run test:typescript",
     "test:validator:integrity": "npm run build:validation && git diff --quiet --ignore-all-space --ignore-blank-lines --ignore-cr-at-eol lib/error-serializer.js && git diff --quiet --ignore-all-space --ignore-blank-lines --ignore-cr-at-eol lib/configValidator.js",
     "test:typescript": "tsc test/types/import.ts && tsd",
-    "test:watch": "npm run unit -- -w --no-coverage-report -R terse",
+    "test:watch": "npm run unit -- --watch --cov --no-coverage-report --reporter=terse",
     "unit": "c8 tap",
     "unit:junit": "tap-mocha-reporter xunit < out.tap > test/junit-testresults.xml",
     "unit:report": "tap --cov --coverage-report=html --coverage-report=cobertura | tee out.tap",

package/test/reply-code.test.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const t = require('tap')
+const { Readable } = require('stream')
 const test = t.test
 const Fastify = require('..')
 
@@ -59,7 +60,7 @@ test('code should handle null/undefined/float', t => {
 })
 
 test('code should handle 204', t => {
-  t.plan(8)
+  t.plan(13)
 
   const fastify = Fastify()
 
@@ -72,6 +73,18 @@ test('code should handle 204', t => {
     reply.status(204).send({ message: 'hello' })
   })
 
+  fastify.get('/stream/204', function (request, reply) {
+    const stream = new Readable({
+      read () {
+        this.push(null)
+      }
+    })
+    stream.on('end', () => {
+      t.pass('stream ended')
+    })
+    reply.status(204).send(stream)
+  })
+
   fastify.inject({
     method: 'GET',
     url: '/204'
@@ -91,6 +104,16 @@ test('code should handle 204', t => {
     t.equal(res.payload, '')
     t.equal(res.headers['content-length'], undefined)
   })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/stream/204'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 204)
+    t.equal(res.payload, '')
+    t.equal(res.headers['content-length'], undefined)
+  })
 })
 
 test('code should handle onSend hook on 204', t => {