fastify 4.24.3 → 4.25.1

package/lib/warnings.js

@@ -1,42 +1,112 @@
 'use strict'
 
-const warning = require('process-warning')()
-
-/**
- * Deprecation codes:
- *   - FSTDEP005
- */
-
-warning.create('FastifyDeprecation', 'FSTDEP005', 'You are accessing the deprecated "request.connection" property. Use "request.socket" instead.')
-
-warning.create('FastifyDeprecation', 'FSTDEP006', 'You are decorating Request/Reply with a reference type. This reference is shared amongst all requests. Use onRequest hook instead. Property: %s')
-
-warning.create('FastifyDeprecation', 'FSTDEP007', 'You are trying to set a HEAD route using "exposeHeadRoute" route flag when a sibling route is already set. See documentation for more info.')
-
-warning.create('FastifyDeprecation', 'FSTDEP008', 'You are using route constraints via the route { version: "..." } option, use { constraints: { version: "..." } } option instead.')
-
-warning.create('FastifyDeprecation', 'FSTDEP009', 'You are using a custom route versioning strategy via the server { versioning: "..." } option, use { constraints: { version: "..." } } option instead.')
-
-warning.create('FastifyDeprecation', 'FSTDEP010', 'Modifying the "reply.sent" property is deprecated. Use the "reply.hijack()" method instead.')
-
-warning.create('FastifyDeprecation', 'FSTDEP011', 'Variadic listen method is deprecated. Please use ".listen(optionsObject)" instead. The variadic signature will be removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP012', 'request.context property access is deprecated. Please use "request.routeOptions.config" or "request.routeOptions.schema" instead for accessing Route settings. The "request.context" will be removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP013', 'Direct return of "trailers" function is deprecated. Please use "callback" or "async-await" for return value. The support of direct return will removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP014', 'You are trying to set/access the default route. This property is deprecated. Please, use setNotFoundHandler if you want to custom a 404 handler or the wildcard (*) to match all routes.')
-
-warning.create('FastifyDeprecation', 'FSTDEP015', 'You are accessing the deprecated "request.routeSchema" property. Use "request.routeOptions.schema" instead. Property "req.routeSchema" will be removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP016', 'You are accessing the deprecated "request.routeConfig" property. Use "request.routeOptions.config" instead. Property "req.routeConfig" will be removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP017', 'You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP018', 'You are accessing the deprecated "request.routerMethod" property. Use "request.routeOptions.method" instead. Property "req.routerMethod" will be removed in `fastify@5`.')
-
-warning.create('FastifyDeprecation', 'FSTDEP019', 'reply.context property access is deprecated. Please use "reply.routeOptions.config" or "reply.routeOptions.schema" instead for accessing Route settings. The "reply.context" will be removed in `fastify@5`.')
-
-warning.create('FastifyWarning', 'FSTWRN001', 'The %s schema for %s: %s is missing. This may indicate the schema is not well specified.', { unlimited: true })
-
-module.exports = warning
+const { createDeprecation, createWarning } = require('process-warning')
+
+const FSTDEP005 = createDeprecation({
+  code: 'FSTDEP005',
+  message: 'You are accessing the deprecated "request.connection" property. Use "request.socket" instead.'
+})
+
+const FSTDEP006 = createDeprecation({
+  code: 'FSTDEP006',
+  message: 'You are decorating Request/Reply with a reference type. This reference is shared amongst all requests. Use onRequest hook instead. Property: %s'
+})
+
+const FSTDEP007 = createDeprecation({
+  code: 'FSTDEP007',
+  message: 'You are trying to set a HEAD route using "exposeHeadRoute" route flag when a sibling route is already set. See documentation for more info.'
+})
+
+const FSTDEP008 = createDeprecation({
+  code: 'FSTDEP008',
+  message: 'You are using route constraints via the route { version: "..." } option, use { constraints: { version: "..." } } option instead.'
+})
+
+const FSTDEP009 = createDeprecation({
+  code: 'FSTDEP009',
+  message: 'You are using a custom route versioning strategy via the server { versioning: "..." } option, use { constraints: { version: "..." } } option instead.'
+})
+
+const FSTDEP010 = createDeprecation({
+  code: 'FSTDEP010',
+  message: 'Modifying the "reply.sent" property is deprecated. Use the "reply.hijack()" method instead.'
+})
+
+const FSTDEP011 = createDeprecation({
+  code: 'FSTDEP011',
+  message: 'Variadic listen method is deprecated. Please use ".listen(optionsObject)" instead. The variadic signature will be removed in `fastify@5`.'
+})
+
+const FSTDEP012 = createDeprecation({
+  code: 'FSTDEP012',
+  message: 'request.context property access is deprecated. Please use "request.routeOptions.config" or "request.routeOptions.schema" instead for accessing Route settings. The "request.context" will be removed in `fastify@5`.'
+})
+
+const FSTDEP013 = createDeprecation({
+  code: 'FSTDEP013',
+  message: 'Direct return of "trailers" function is deprecated. Please use "callback" or "async-await" for return value. The support of direct return will removed in `fastify@5`.'
+})
+
+const FSTDEP014 = createDeprecation({
+  code: 'FSTDEP014',
+  message: 'You are trying to set/access the default route. This property is deprecated. Please, use setNotFoundHandler if you want to custom a 404 handler or the wildcard (*) to match all routes.'
+})
+
+const FSTDEP015 = createDeprecation({
+  code: 'FSTDEP015',
+  message: 'You are accessing the deprecated "request.routeSchema" property. Use "request.routeOptions.schema" instead. Property "req.routeSchema" will be removed in `fastify@5`.'
+})
+
+const FSTDEP016 = createDeprecation({
+  code: 'FSTDEP016',
+  message: 'You are accessing the deprecated "request.routeConfig" property. Use "request.routeOptions.config" instead. Property "req.routeConfig" will be removed in `fastify@5`.'
+})
+
+const FSTDEP017 = createDeprecation({
+  code: 'FSTDEP017',
+  message: 'You are accessing the deprecated "request.routerPath" property. Use "request.routeOptions.url" instead. Property "req.routerPath" will be removed in `fastify@5`.'
+})
+
+const FSTDEP018 = createDeprecation({
+  code: 'FSTDEP018',
+  message: 'You are accessing the deprecated "request.routerMethod" property. Use "request.routeOptions.method" instead. Property "req.routerMethod" will be removed in `fastify@5`.'
+})
+
+const FSTDEP019 = createDeprecation({
+  code: 'FSTDEP019',
+  message: 'reply.context property access is deprecated. Please use "request.routeOptions.config" or "request.routeOptions.schema" instead for accessing Route settings. The "reply.context" will be removed in `fastify@5`.'
+})
+
+const FSTWRN001 = createWarning({
+  name: 'FastifyWarning',
+  code: 'FSTWRN001',
+  message: 'The %s schema for %s: %s is missing. This may indicate the schema is not well specified.',
+  unlimited: true
+})
+
+const FSTWRN002 = createWarning({
+  name: 'FastifyWarning',
+  code: 'FSTWRN002',
+  message: 'The %s plugin being registered mixes async and callback styles, which will result in an error in `fastify@5`',
+  unlimited: true
+})
+
+module.exports = {
+  FSTDEP005,
+  FSTDEP006,
+  FSTDEP007,
+  FSTDEP008,
+  FSTDEP009,
+  FSTDEP010,
+  FSTDEP011,
+  FSTDEP012,
+  FSTDEP013,
+  FSTDEP014,
+  FSTDEP015,
+  FSTDEP016,
+  FSTDEP017,
+  FSTDEP018,
+  FSTDEP019,
+  FSTWRN001,
+  FSTWRN002
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fastify",
-  "version": "4.24.3",
+  "version": "4.25.1",
   "description": "Fast and low overhead web framework, for Node.js",
   "main": "fastify.js",
   "type": "commonjs",
@@ -197,8 +197,8 @@
     "fast-json-stringify": "^5.8.0",
     "find-my-way": "^7.7.0",
     "light-my-request": "^5.11.0",
-    "pino": "^8.16.0",
-    "process-warning": "^2.2.0",
+    "pino": "^8.17.0",
+    "process-warning": "^3.0.0",
     "proxy-addr": "^2.0.7",
     "rfdc": "^1.3.0",
     "secure-json-parse": "^2.7.0",

package/test/close-pipelining.test.js

@@ -36,8 +36,8 @@ test('Should return 503 while closing - pipelining', async t => {
   await instance.close()
 })
 
-const isVgte19 = semver.gte(process.version, '19.0.0')
-test('Should not return 503 while closing - pipelining - return503OnClosing: false, skip Node >= v19.x', { skip: isVgte19 }, async t => {
+const isNodeVersionGte1819 = semver.gte(process.version, '18.19.0')
+test('Should not return 503 while closing - pipelining - return503OnClosing: false, skip Node >= v18.19.x', { skip: isNodeVersionGte1819 }, async t => {
   const fastify = Fastify({
     return503OnClosing: false,
     forceCloseConnections: false
@@ -67,8 +67,8 @@ test('Should not return 503 while closing - pipelining - return503OnClosing: fal
   await instance.close()
 })
 
-test('Should close the socket abruptly - pipelining - return503OnClosing: false, skip Node < v19.x', { skip: !isVgte19 }, async t => {
-  // Since Node v19, we will always invoke server.closeIdleConnections()
+test('Should close the socket abruptly - pipelining - return503OnClosing: false, skip Node < v18.19.x', { skip: !isNodeVersionGte1819 }, async t => {
+  // Since Node v18, we will always invoke server.closeIdleConnections()
   // therefore our socket will be closed
   const fastify = Fastify({
     return503OnClosing: false,

package/test/close.test.js

@@ -204,8 +204,8 @@ test('Should return error while closing (callback) - injection', t => {
   })
 })
 
-const isV19plus = semver.gte(process.version, '19.0.0')
-test('Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v19.x', { skip: isV19plus }, t => {
+const isNodeVersionGte1819 = semver.gte(process.version, '18.19.0')
+test('Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v18.19.x', { skip: isNodeVersionGte1819 }, t => {
   const fastify = Fastify({
     return503OnClosing: false,
     forceCloseConnections: false
@@ -243,7 +243,7 @@ test('Current opened connection should continue to work after closing and return
   })
 })
 
-test('Current opened connection should NOT continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node < v19.x', { skip: !isV19plus }, t => {
+test('Current opened connection should NOT continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node < v18.19.x', { skip: !isNodeVersionGte1819 }, t => {
   t.plan(4)
   const fastify = Fastify({
     return503OnClosing: false,

package/test/constrained-routes.test.js

@@ -11,7 +11,7 @@ test('Should register a host constrained route', t => {
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
       reply.send({ hello: 'world' })
     }
@@ -21,7 +21,7 @@ test('Should register a host constrained route', t => {
     method: 'GET',
     url: '/',
     headers: {
-      host: 'fastify.io'
+      host: 'fastify.dev'
     }
   }, (err, res) => {
     t.error(err)
@@ -56,9 +56,9 @@ test('Should register the same route with host constraints', t => {
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
-      reply.send('fastify.io')
+      reply.send('fastify.dev')
     }
   })
 
@@ -75,12 +75,12 @@ test('Should register the same route with host constraints', t => {
     method: 'GET',
     url: '/',
     headers: {
-      host: 'fastify.io'
+      host: 'fastify.dev'
     }
   }, (err, res) => {
     t.error(err)
     t.equal(res.statusCode, 200)
-    t.equal(res.payload, 'fastify.io')
+    t.equal(res.payload, 'fastify.dev')
   })
 
   fastify.inject({
@@ -479,7 +479,7 @@ test('The hasConstraintStrategy should return false for default constraints unti
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
       reply.send({ hello: 'from any other domain' })
     }
@@ -533,9 +533,9 @@ test('Should allow registering an unconstrained route after a constrained route'
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
-      reply.send({ hello: 'from fastify.io' })
+      reply.send({ hello: 'from fastify.dev' })
     }
   })
 
@@ -551,11 +551,11 @@ test('Should allow registering an unconstrained route after a constrained route'
     method: 'GET',
     url: '/',
     headers: {
-      host: 'fastify.io'
+      host: 'fastify.dev'
     }
   }, (err, res) => {
     t.error(err)
-    t.same(JSON.parse(res.payload), { hello: 'from fastify.io' })
+    t.same(JSON.parse(res.payload), { hello: 'from fastify.dev' })
     t.equal(res.statusCode, 200)
   })
 
@@ -580,7 +580,7 @@ test('Should allow registering constrained routes in a prefixed plugin', t => {
   fastify.register(async (scope, opts) => {
     scope.route({
       method: 'GET',
-      constraints: { host: 'fastify.io' },
+      constraints: { host: 'fastify.dev' },
       path: '/route',
       handler: (req, reply) => {
         reply.send({ ok: true })
@@ -592,7 +592,7 @@ test('Should allow registering constrained routes in a prefixed plugin', t => {
     method: 'GET',
     url: '/prefix/route',
     headers: {
-      host: 'fastify.io'
+      host: 'fastify.dev'
     }
   }, (err, res) => {
     t.error(err)
@@ -608,7 +608,7 @@ test('Should allow registering a constrained GET route after a constrained HEAD
   fastify.route({
     method: 'HEAD',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
       reply.header('content-type', 'text/plain')
       reply.send('custom HEAD response')
@@ -618,7 +618,7 @@ test('Should allow registering a constrained GET route after a constrained HEAD
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
       reply.send({ hello: 'from any other domain' })
     }
@@ -628,7 +628,7 @@ test('Should allow registering a constrained GET route after a constrained HEAD
     method: 'HEAD',
     url: '/',
     headers: {
-      host: 'fastify.io'
+      host: 'fastify.dev'
     }
   }, (err, res) => {
     t.error(err)
@@ -653,7 +653,7 @@ test('Should allow registering a constrained GET route after an unconstrained HE
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: 'fastify.io' },
+    constraints: { host: 'fastify.dev' },
     handler: (req, reply) => {
       reply.header('content-type', 'text/plain')
       reply.send('Hello from constrains: length is about 41')
@@ -664,7 +664,7 @@ test('Should allow registering a constrained GET route after an unconstrained HE
     method: 'HEAD',
     url: '/',
     headers: {
-      host: 'fastify.io'
+      host: 'fastify.dev'
     }
   }, (err, res) => {
     t.error(err)
@@ -682,7 +682,7 @@ test('Will not try to re-createprefixed HEAD route if it already exists and expo
     scope.route({
       method: 'HEAD',
       path: '/route',
-      constraints: { host: 'fastify.io' },
+      constraints: { host: 'fastify.dev' },
       handler: (req, reply) => {
         reply.header('content-type', 'text/plain')
         reply.send('custom HEAD response')
@@ -691,7 +691,7 @@ test('Will not try to re-createprefixed HEAD route if it already exists and expo
     scope.route({
       method: 'GET',
       path: '/route',
-      constraints: { host: 'fastify.io' },
+      constraints: { host: 'fastify.dev' },
       handler: (req, reply) => {
         reply.send({ ok: true })
       }
@@ -723,7 +723,7 @@ test('allows separate constrained and unconstrained HEAD routes', async (t) => {
     scope.route({
       method: 'HEAD',
       path: '/route',
-      constraints: { host: 'fastify.io' },
+      constraints: { host: 'fastify.dev' },
       handler: (req, reply) => {
         reply.header('content-type', 'text/plain')
         reply.send('constrained HEAD response')
@@ -733,7 +733,7 @@ test('allows separate constrained and unconstrained HEAD routes', async (t) => {
     scope.route({
       method: 'GET',
       path: '/route',
-      constraints: { host: 'fastify.io' },
+      constraints: { host: 'fastify.dev' },
       handler: (req, reply) => {
         reply.send({ ok: true })
       }
@@ -869,7 +869,7 @@ test('Allow regex constraints in routes', t => {
   fastify.route({
     method: 'GET',
     url: '/',
-    constraints: { host: /.*\.fastify\.io/ },
+    constraints: { host: /.*\.fastify\.dev$/ },
     handler: (req, reply) => {
       reply.send({ hello: 'from fastify dev domain' })
     }
@@ -879,7 +879,7 @@ test('Allow regex constraints in routes', t => {
     method: 'GET',
     url: '/',
     headers: {
-      host: 'dev.fastify.io'
+      host: 'dev.fastify.dev'
     }
   }, (err, res) => {
     t.error(err)

package/test/decorator.test.js

@@ -790,31 +790,33 @@ test('decorate* should throw if called after ready', async t => {
 })
 
 test('decorate* should emit warning if an array is passed', t => {
-  t.plan(2)
-  function onWarning (code, name) {
+  t.plan(1)
+
+  function onWarning (name) {
     t.equal(name, 'test_array')
-    t.equal(code, 'FSTDEP006')
-  }
-  const warning = {
-    emit: onWarning
   }
 
-  const decorate = proxyquire('../lib/decorate', { './warnings': warning })
+  const decorate = proxyquire('../lib/decorate', {
+    './warnings': {
+      FSTDEP006: onWarning
+    }
+  })
   const fastify = proxyquire('..', { './lib/decorate.js': decorate })()
   fastify.decorateRequest('test_array', [])
 })
 
 test('decorate* should emit warning if object type is passed', t => {
-  t.plan(2)
-  function onWarning (code, name) {
+  t.plan(1)
+
+  function onWarning (name) {
     t.equal(name, 'test_object')
-    t.equal(code, 'FSTDEP006')
-  }
-  const warning = {
-    emit: onWarning
   }
 
-  const decorate = proxyquire('../lib/decorate', { './warnings': warning })
+  const decorate = proxyquire('../lib/decorate', {
+    './warnings': {
+      FSTDEP006: onWarning
+    }
+  })
   const fastify = proxyquire('..', { './lib/decorate.js': decorate })()
   fastify.decorateRequest('test_object', { foo: 'bar' })
 })
@@ -823,10 +825,12 @@ test('decorate* should not emit warning if object with getter/setter is passed',
   function onWarning (warning) {
     t.fail('Should not call a warn')
   }
-  const warning = {
-    emit: onWarning
-  }
-  const decorate = proxyquire('../lib/decorate', { './warnings': warning })
+
+  const decorate = proxyquire('../lib/decorate', {
+    './warnings': {
+      FSTDEP006: onWarning
+    }
+  })
   const fastify = proxyquire('..', { './lib/decorate.js': decorate })()
 
   fastify.decorateRequest('test_getter_setter', {
@@ -844,11 +848,12 @@ test('decorate* should not emit warning if string,bool,numbers are passed', t =>
   function onWarning (warning) {
     t.fail('Should not call a warn')
   }
-  const warning = {
-    emit: onWarning
-  }
 
-  const decorate = proxyquire('../lib/decorate', { './warnings': warning })
+  const decorate = proxyquire('../lib/decorate', {
+    './warnings': {
+      FSTDEP006: onWarning
+    }
+  })
   const fastify = proxyquire('..', { './lib/decorate.js': decorate })()
 
   fastify.decorateRequest('test_str', 'foo')

package/test/default-route.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const test = t.test
 const Fastify = require('..')
-const warning = require('../lib/warnings')
+const { FSTDEP014 } = require('../lib/warnings')
 
 // Silence the standard warning logs. We will test the messages explicitly.
 process.removeAllListeners('warning')
@@ -18,13 +18,13 @@ test('setDefaultRoute should emit a deprecation warning', t => {
 
   process.on('warning', onWarning)
   function onWarning (warning) {
-    t.equal(warning.name, 'FastifyDeprecation')
-    t.equal(warning.code, 'FSTDEP014')
+    t.equal(warning.name, 'DeprecationWarning')
+    t.equal(warning.code, FSTDEP014.code)
   }
 
   t.teardown(() => {
     process.removeListener('warning', onWarning)
-    warning.emitted.set('FSTDEP014', false)
+    FSTDEP014.emitted = false
   })
 
   fastify.setDefaultRoute(defaultRoute)
@@ -37,13 +37,13 @@ test('getDefaultRoute should emit a deprecation warning', t => {
 
   process.on('warning', onWarning)
   function onWarning (warning) {
-    t.equal(warning.name, 'FastifyDeprecation')
-    t.equal(warning.code, 'FSTDEP014')
+    t.equal(warning.name, 'DeprecationWarning')
+    t.equal(warning.code, FSTDEP014.code)
   }
 
   t.teardown(() => {
     process.removeListener('warning', onWarning)
-    warning.emitted.set('FSTDEP014', false)
+    FSTDEP014.emitted = false
   })
 
   fastify.getDefaultRoute()

package/test/fastify-instance.test.js

@@ -132,6 +132,126 @@ test('childLoggerFactory in plugin should be separate from the external one', as
   t.same(fastify.childLoggerFactory, fastify[kChildLoggerFactory])
 })
 
+test('ready should resolve in order when called multiply times (promises only)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5]
+  const result = []
+
+  const promises = [1, 2, 3, 4, 5]
+    .map((id) => app.ready().then(() => result.push(id)))
+
+  await Promise.all(promises)
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
+test('ready should reject in order when called multiply times (promises only)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5]
+  const result = []
+
+  app.register((instance, opts, done) => {
+    setTimeout(() => done(new Error('test')), 500)
+  })
+
+  const promises = [1, 2, 3, 4, 5]
+    .map((id) => app.ready().catch(() => result.push(id)))
+
+  await Promise.all(promises)
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
+test('ready should reject in order when called multiply times (callbacks only)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5]
+  const result = []
+
+  app.register((instance, opts, done) => {
+    setTimeout(() => done(new Error('test')), 500)
+  })
+
+  expectedOrder.map((id) => app.ready(() => result.push(id)))
+
+  await app.ready().catch(err => {
+    t.equal(err.message, 'test')
+  })
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
+test('ready should resolve in order when called multiply times (callbacks only)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5]
+  const result = []
+
+  expectedOrder.map((id) => app.ready(() => result.push(id)))
+
+  await app.ready()
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
+test('ready should resolve in order when called multiply times (mixed)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5, 6]
+  const result = []
+
+  for (const order of expectedOrder) {
+    if (order % 2) {
+      app.ready(() => result.push(order))
+    } else {
+      app.ready().then(() => result.push(order))
+    }
+  }
+
+  await app.ready()
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
+test('ready should reject in order when called multiply times (mixed)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5, 6]
+  const result = []
+
+  app.register((instance, opts, done) => {
+    setTimeout(() => done(new Error('test')), 500)
+  })
+
+  for (const order of expectedOrder) {
+    if (order % 2) {
+      app.ready(() => result.push(order))
+    } else {
+      app.ready().then(null, () => result.push(order))
+    }
+  }
+
+  await app.ready().catch(err => {
+    t.equal(err.message, 'test')
+  })
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
+test('ready should resolve in order when called multiply times (mixed)', async (t) => {
+  const app = Fastify()
+  const expectedOrder = [1, 2, 3, 4, 5, 6]
+  const result = []
+
+  for (const order of expectedOrder) {
+    if (order % 2) {
+      app.ready().then(() => result.push(order))
+    } else {
+      app.ready(() => result.push(order))
+    }
+  }
+
+  await app.ready()
+
+  t.strictSame(result, expectedOrder, 'Should resolve in order')
+})
+
 test('fastify instance should contains listeningOrigin property (with port and host)', async t => {
   t.plan(1)
   const port = 3000