fastify 4.24.2 → 4.25.0

package/docs/Reference/Reply.md

@@ -86,7 +86,6 @@ object that exposes the following functions and properties:
 - `.log` - The logger instance of the incoming request.
 - `.request` - The incoming request.
 - `.context` - Deprecated, access the [Request's context](./Request.md) property.
-- `.routeOptions` - Access the [Request's routeOptions](./Request.md) property.
 
 ```js
 fastify.get('/', options, function (request, reply) {
@@ -666,8 +665,12 @@ fastify.get('/json', options, function (request, reply) {
 #### Streams
 <a id="send-streams"></a>
 
-*send* can also handle streams by setting the `'Content-Type'` header to
-`'application/octet-stream'`.
+If you are sending a stream and you have not set a `'Content-Type'` header,
+*send* will set it to `'application/octet-stream'`.
+
+As noted above, streams are considered to be pre-serialized, so they will be
+sent unmodified without response validation.
+
 ```js
 fastify.get('/streams', function (request, reply) {
   const fs = require('node:fs')
@@ -691,6 +694,10 @@ fastify.get('/streams', async function (request, reply) {
 
 If you are sending a buffer and you have not set a `'Content-Type'` header,
 *send* will set it to `'application/octet-stream'`.
+
+As noted above, Buffers are considered to be pre-serialized, so they will be 
+sent unmodified without response validation.
+
 ```js
 const fs = require('node:fs')
 fastify.get('/streams', function (request, reply) {
@@ -714,8 +721,12 @@ fastify.get('/streams', async function (request, reply) {
 #### TypedArrays
 <a id="send-typedarrays"></a>
 
-`send` manages TypedArray and sets the `'Content-Type'=application/octet-stream'`
-header if not already set.
+`send` manages TypedArray like a Buffer, and sets the `'Content-Type'`
+header to `'application/octet-stream'` if not already set.
+
+As noted above, TypedArray/Buffers are considered to be pre-serialized, so they 
+will be sent unmodified without response validation.
+
 ```js
 const fs = require('node:fs')
 fastify.get('/streams', function (request, reply) {

package/docs/Reference/Request.md

@@ -161,7 +161,7 @@ for more information on how to compile validation function.
 This function will compile a validation schema and
 return a function that can be used to validate data.
 The function returned (a.k.a. _validation function_) is compiled
-by using the provided [`SchemaControler#ValidationCompiler`](./Server.md#schema-controller).
+by using the provided [`SchemaController#ValidationCompiler`](./Server.md#schema-controller).
 A `WeakMap` is used to cached this, reducing compilation calls.
 
 The optional parameter `httpPart`, if provided, is forwarded directly

package/docs/Reference/Routes.md

@@ -715,9 +715,9 @@ arbitrary host matching.
 fastify.route({
   method: 'GET',
   url: '/',
-  constraints: { host: 'auth.fastify.io' },
+  constraints: { host: 'auth.fastify.dev' },
   handler: function (request, reply) {
-    reply.send('hello world from auth.fastify.io')
+    reply.send('hello world from auth.fastify.dev')
   }
 })
 
@@ -735,10 +735,10 @@ fastify.inject({
   method: 'GET',
   url: '/',
   headers: {
-    'Host': 'auth.fastify.io'
+    'Host': 'auth.fastify.dev'
   }
 }, (err, res) => {
-  // => 'hello world from auth.fastify.io'
+  // => 'hello world from auth.fastify.dev'
 })
 ```
 
@@ -749,7 +749,7 @@ matching wildcard subdomains (or any other pattern):
 fastify.route({
   method: 'GET',
   url: '/',
-  constraints: { host: /.*\.fastify\.io/ }, // will match any subdomain of fastify.io
+  constraints: { host: /.*\.fastify\.io/ }, // will match any subdomain of fastify.dev
   handler: function (request, reply) {
     reply.send('hello world from ' + request.headers.host)
   }

package/docs/Reference/TypeScript.md

@@ -256,7 +256,7 @@ can do it as follows:
 
     const fastify = Fastify().withTypeProvider<TypeBoxTypeProvider>()
 
-    app.post<{ Body: UserType, Reply: UserType }>(
+    fastify.post<{ Body: UserType, Reply: UserType }>(
       '/',
       {
         schema: {

package/docs/Reference/Warnings.md

@@ -0,0 +1,77 @@
+
+<h1 align="center">Fastify</h1>
+
+**Table of contents**
+- [Warnings](#warnings)
+  - [Warnings In Fastify](#warnings-in-fastify)
+  - [Fastify Warning Codes](#fastify-warning-codes)
+    - [FSTWRN001](#FSTWRN001)
+    - [FSTWRN002](#FSTWRN002)
+  - [Fastify Deprecation Codes](#fastify-deprecation-codes)
+    - [FSTDEP005](#FSTDEP005)
+    - [FSTDEP006](#FSTDEP006)
+    - [FSTDEP007](#FSTDEP007)
+    - [FSTDEP008](#FSTDEP008)
+    - [FSTDEP009](#FSTDEP009)
+    - [FSTDEP010](#FSTDEP010)
+    - [FSTDEP011](#FSTDEP011)
+    - [FSTDEP012](#FSTDEP012)
+    - [FSTDEP013](#FSTDEP013)
+    - [FSTDEP014](#FSTDEP014)
+    - [FSTDEP015](#FSTDEP015)
+    - [FSTDEP016](#FSTDEP016)
+    - [FSTDEP017](#FSTDEP017)
+    - [FSTDEP018](#FSTDEP018)
+    - [FSTDEP019](#FSTDEP019)
+
+
+## Warnings
+
+### Warnings In Fastify
+Warnings are enabled by default. They can be disabled by using any
+of the following methods:
+
+- setting the `NODE_NO_WARNINGS` environment variable to `1`
+- passing the `--no-warnings` flag to the node process
+- setting 'no-warnings' in the `NODE_OPTIONS` environment variable
+
+For more information on how to disable warnings, see [node's documentation](https://nodejs.org/api/cli.html).
+
+However, disabling warnings is not recommended as it may cause
+potential problems when upgrading Fastify versions.
+Only experienced users should consider disabling warnings.
+
+### Fastify Warning Codes
+
+| Code | Description | How to solve | Discussion |
+| ---- | ----------- | ------------ | ---------- |
+| <a id="FSTWRN001">FSTWRN001</a> | The specified schema for a route is missing. This may indicate the schema is not well specified. | Check the schema for the route. | [#4647](https://github.com/fastify/fastify/pull/4647) |
+| <a id="FSTWRN002">FSTWRN002</a> | The %s plugin being registered mixes async and callback styles, which will result in an error in `fastify@5`. | Do not mix async and callback style. | [#5139](https://github.com/fastify/fastify/pull/5139) |
+
+
+### Fastify Deprecation Codes
+
+Deprecation codes are further supported by the Node.js CLI options:
+
+- [--no-deprecation](https://nodejs.org/api/cli.html#--no-deprecation)
+- [--throw-deprecation](https://nodejs.org/api/cli.html#--throw-deprecation)
+- [--trace-deprecation](https://nodejs.org/api/cli.html#--trace-deprecation)
+
+
+| Code | Description | How to solve | Discussion |
+| ---- | ----------- | ------------ | ---------- |
+| <a id="FSTDEP005">FSTDEP005</a> | You are accessing the deprecated `request.connection` property. | Use `request.socket`. | [#2594](https://github.com/fastify/fastify/pull/2594) |
+| <a id="FSTDEP006">FSTDEP006</a> | You are decorating Request/Reply with a reference type. This reference is shared amongst all requests. | Do not use Arrays/Objects as values when decorating Request/Reply. | [#2688](https://github.com/fastify/fastify/pull/2688) |
+| <a id="FSTDEP007">FSTDEP007</a> | You are trying to set a HEAD route using `exposeHeadRoute` route flag when a sibling route is already set. | Remove `exposeHeadRoutes` or explicitly set `exposeHeadRoutes` to `false` | [#2700](https://github.com/fastify/fastify/pull/2700) |
+| <a id="FSTDEP008">FSTDEP008</a> | You are using route constraints via the route `{version: "..."}` option.  |  Use `{constraints: {version: "..."}}` option.  | [#2682](https://github.com/fastify/fastify/pull/2682) |
+| <a id="FSTDEP009">FSTDEP009</a> | You are using a custom route versioning strategy via the server `{versioning: "..."}` option. |  Use `{constraints: {version: "..."}}` option.  | [#2682](https://github.com/fastify/fastify/pull/2682) |
+| <a id="FSTDEP010">FSTDEP010</a> | Modifying the `reply.sent` property is deprecated. | Use the `reply.hijack()` method. | [#3140](https://github.com/fastify/fastify/pull/3140) |
+| <a id="FSTDEP011">FSTDEP011</a> | Variadic listen method is deprecated. | Use `.listen(optionsObject)`. | [#3712](https://github.com/fastify/fastify/pull/3712) |
+| <a id="FSTDEP012">FSTDEP012</a> | You are trying to access the deprecated `request.context` property. | Use `request.routeOptions.config` or `request.routeOptions.schema`. | [#4216](https://github.com/fastify/fastify/pull/4216) [#5084](https://github.com/fastify/fastify/pull/5084) |
+| <a id="FSTDEP013">FSTDEP013</a> | Direct return of "trailers" function is deprecated. | Use "callback" or "async-await" for return value. | [#4380](https://github.com/fastify/fastify/pull/4380) |
+| <a id="FSTDEP014">FSTDEP014</a> | You are trying to set/access the default route. This property is deprecated. | Use `setNotFoundHandler` if you want to custom a 404 handler or the wildcard (`*`) to match all routes. | [#4480](https://github.com/fastify/fastify/pull/4480) |
+| <a id="FSTDEP015">FSTDEP015</a> | You are accessing the deprecated `request.routeSchema` property. | Use `request.routeOptions.schema`. | [#4470](https://github.com/fastify/fastify/pull/4470) |
+| <a id="FSTDEP016">FSTDEP016</a> | You are accessing the deprecated `request.routeConfig` property. | Use `request.routeOptions.config`. | [#4470](https://github.com/fastify/fastify/pull/4470) |
+| <a id="FSTDEP017">FSTDEP017</a> | You are accessing the deprecated `request.routerPath` property. | Use `request.routeOptions.url`. | [#4470](https://github.com/fastify/fastify/pull/4470) |
+| <a id="FSTDEP018">FSTDEP018</a> | You are accessing the deprecated `request.routerMethod` property. | Use `request.routeOptions.method`. | [#4470](https://github.com/fastify/fastify/pull/4470) |
+| <a id="FSTDEP019">FSTDEP019</a> | You are accessing the deprecated `reply.context` property. | Use `reply.routeOptions.config` or `reply.routeOptions.schema`. | [#5032](https://github.com/fastify/fastify/pull/5032) [#5084](https://github.com/fastify/fastify/pull/5084) |

package/examples/use-plugin.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fastify = require('../fastify')({ logger: true })
 
 const opts = {

package/fastify.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const VERSION = '4.24.2'
+const VERSION = '4.25.0'
 
 const Avvio = require('avvio')
 const http = require('node:http')
@@ -47,7 +47,7 @@ const { buildRouting, validateBodyLimitOption } = require('./lib/route')
 const build404 = require('./lib/fourOhFour')
 const getSecuredInitialConfig = require('./lib/initialConfigValidation')
 const override = require('./lib/pluginOverride')
-const warning = require('./lib/warnings')
+const { FSTDEP009 } = require('./lib/warnings')
 const noopSet = require('./lib/noop-set')
 const {
   appendStackTrace,
@@ -152,7 +152,7 @@ function fastify (options) {
 
   let constraints = options.constraints
   if (options.versioning) {
-    warning.emit('FSTDEP009')
+    FSTDEP009()
     constraints = {
       ...constraints,
       version: {
@@ -217,7 +217,10 @@ function fastify (options) {
     [kState]: {
       listening: false,
       closing: false,
-      started: false
+      started: false,
+      ready: false,
+      booting: false,
+      readyPromise: null
     },
     [kKeepAliveConnections]: keepAliveConnections,
     [kOptions]: options,
@@ -562,25 +565,43 @@ function fastify (options) {
   }
 
   function ready (cb) {
+    if (this[kState].readyPromise !== null) {
+      if (cb != null) {
+        this[kState].readyPromise.then(() => cb(null, fastify), cb)
+        return
+      }
+
+      return this[kState].readyPromise
+    }
+
     let resolveReady
     let rejectReady
 
     // run the hooks after returning the promise
     process.nextTick(runHooks)
 
+    // Create a promise no matter what
+    // It will work as a barrier for all the .ready() calls (ensuring single hook execution)
+    // as well as a flow control mechanism to chain cbs and further
+    // promises
+    this[kState].readyPromise = new Promise(function (resolve, reject) {
+      resolveReady = resolve
+      rejectReady = reject
+    })
+
     if (!cb) {
-      return new Promise(function (resolve, reject) {
-        resolveReady = resolve
-        rejectReady = reject
-      })
+      return this[kState].readyPromise
+    } else {
+      this[kState].readyPromise.then(() => cb(null, fastify), cb)
     }
 
     function runHooks () {
       // start loading
       fastify[kAvvioBoot]((err, done) => {
-        if (err || fastify[kState].started) {
+        if (err || fastify[kState].started || fastify[kState].ready || fastify[kState].booting) {
           manageErr(err)
         } else {
+          fastify[kState].booting = true
           hookRunnerApplication('onReady', fastify[kAvvioBoot], fastify, manageErr)
         }
         done()
@@ -595,18 +616,14 @@ function fastify (options) {
         ? appendStackTrace(err, new AVVIO_ERRORS_MAP[err.code](err.message))
         : err
 
-      if (cb) {
-        if (err) {
-          cb(err)
-        } else {
-          cb(undefined, fastify)
-        }
-      } else {
-        if (err) {
-          return rejectReady(err)
-        }
-        resolveReady(fastify)
+      if (err) {
+        return rejectReady(err)
       }
+
+      resolveReady(fastify)
+      fastify[kState].booting = false
+      fastify[kState].ready = true
+      fastify[kState].promise = null
     }
   }
 

package/integration/server.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const Fastify = require('../fastify')
 
 const fastify = Fastify()

package/lib/decorate.js

@@ -16,7 +16,7 @@ const {
   FST_ERR_DEC_DEPENDENCY_INVALID_TYPE
 } = require('./errors')
 
-const warning = require('./warnings')
+const { FSTDEP006 } = require('./warnings')
 
 function decorate (instance, name, fn, dependencies) {
   if (Object.prototype.hasOwnProperty.call(instance, name)) {
@@ -58,7 +58,7 @@ function decorateConstructor (konstructor, name, fn, dependencies) {
 
 function checkReferenceType (name, fn) {
   if (typeof fn === 'object' && fn && !(typeof fn.getter === 'function' || typeof fn.setter === 'function')) {
-    warning.emit('FSTDEP006', name)
+    FSTDEP006(name)
   }
 }
 

package/lib/errors.js

@@ -179,7 +179,7 @@ const codes = {
    */
   FST_ERR_MISSING_MIDDLEWARE: createError(
     'FST_ERR_MISSING_MIDDLEWARE',
-    'You must register a plugin for handling middlewares, visit fastify.io/docs/latest/Reference/Middleware/ for more info.',
+    'You must register a plugin for handling middlewares, visit fastify.dev/docs/latest/Reference/Middleware/ for more info.',
     500
   ),
 

package/lib/hooks.js

@@ -331,7 +331,7 @@ function preParsingHookRunner (functions, request, reply, cb) {
       return
     }
 
-    if (typeof newPayload !== 'undefined') {
+    if (newPayload !== undefined) {
       request[kRequestPayloadStream] = newPayload
     }
 

package/lib/pluginUtils.js

@@ -11,6 +11,7 @@ const {
   FST_ERR_PLUGIN_VERSION_MISMATCH,
   FST_ERR_PLUGIN_NOT_PRESENT_IN_INSTANCE
 } = require('./errors')
+const { FSTWRN002 } = require('./warnings.js')
 
 function getMeta (fn) {
   return fn[Symbol.for('plugin-meta')]
@@ -132,10 +133,18 @@ function registerPluginName (fn) {
   const name = meta.name
   if (!name) return
   this[kRegisteredPlugins].push(name)
+  return name
+}
+
+function checkPluginHealthiness (fn, pluginName = 'anonymous') {
+  if (fn.constructor.name === 'AsyncFunction' && fn.length === 3) {
+    FSTWRN002(pluginName)
+  }
 }
 
 function registerPlugin (fn) {
-  registerPluginName.call(this, fn)
+  const pluginName = registerPluginName.call(this, fn)
+  checkPluginHealthiness.call(this, fn, pluginName)
   checkVersion.call(this, fn)
   checkDecorators.call(this, fn)
   checkDependencies.call(this, fn)

package/lib/reply.js

@@ -53,7 +53,7 @@ const {
   FST_ERR_MISSING_SERIALIZATION_FN,
   FST_ERR_MISSING_CONTENTTYPE_SERIALIZATION_FN
 } = require('./errors')
-const warning = require('./warnings')
+const { FSTDEP010, FSTDEP013, FSTDEP019 } = require('./warnings')
 
 function Reply (res, request, log) {
   this.raw = res
@@ -80,7 +80,7 @@ Object.defineProperties(Reply.prototype, {
   // Is temporary to avoid constant conflicts between `next` and `main`
   context: {
     get () {
-      warning.emit('FSTDEP019')
+      FSTDEP019()
       return this.request[kRouteContext]
     }
   },
@@ -96,7 +96,7 @@ Object.defineProperties(Reply.prototype, {
       return (this[kReplyHijacked] || this.raw.writableEnded) === true
     },
     set (value) {
-      warning.emit('FSTDEP010')
+      FSTDEP010()
 
       if (value !== true) {
         throw new FST_ERR_REP_SENT_VALUE()
@@ -164,7 +164,7 @@ Reply.prototype.send = function (payload) {
       if (hasContentType === false) {
         this[kReplyHeaders]['content-type'] = CONTENT_TYPE.OCTET
       }
-      const payloadToSend = Buffer.isBuffer(payload) ? payload : Buffer.from(payload.buffer)
+      const payloadToSend = Buffer.isBuffer(payload) ? payload : Buffer.from(payload.buffer, payload.byteOffset, payload.byteLength)
       onSendHook(this, payloadToSend)
       return this
     }
@@ -748,7 +748,7 @@ function sendTrailer (payload, res, reply) {
       result.then((v) => cb(null, v), cb)
     } else if (result !== null && result !== undefined) {
       // TODO: should be removed in fastify@5
-      warning.emit('FSTDEP013')
+      FSTDEP013()
       cb(null, result)
     }
   }

package/lib/request.js

@@ -2,7 +2,14 @@
 
 const proxyAddr = require('proxy-addr')
 const semver = require('semver')
-const warning = require('./warnings')
+const {
+  FSTDEP005,
+  FSTDEP012,
+  FSTDEP015,
+  FSTDEP016,
+  FSTDEP017,
+  FSTDEP018
+} = require('./warnings')
 const {
   kHasBeenDecorated,
   kSchemaBody,
@@ -166,13 +173,13 @@ Object.defineProperties(Request.prototype, {
   },
   context: {
     get () {
-      warning.emit('FSTDEP012')
+      FSTDEP012()
       return this[kRouteContext]
     }
   },
   routerPath: {
     get () {
-      warning.emit('FSTDEP017')
+      FSTDEP017()
       return this[kRouteContext].config?.url
     }
   },
@@ -208,19 +215,19 @@ Object.defineProperties(Request.prototype, {
   },
   routerMethod: {
     get () {
-      warning.emit('FSTDEP018')
+      FSTDEP018()
       return this[kRouteContext].config?.method
     }
   },
   routeConfig: {
     get () {
-      warning.emit('FSTDEP016')
+      FSTDEP016()
       return this[kRouteContext][kPublicRouteContext]?.config
     }
   },
   routeSchema: {
     get () {
-      warning.emit('FSTDEP015')
+      FSTDEP015()
       return this[kRouteContext][kPublicRouteContext].schema
     }
   },
@@ -233,7 +240,7 @@ Object.defineProperties(Request.prototype, {
     get () {
       /* istanbul ignore next */
       if (semver.gte(process.versions.node, '13.0.0')) {
-        warning.emit('FSTDEP005')
+        FSTDEP005()
       }
       return this.raw.connection
     }

package/lib/route.js

@@ -7,7 +7,11 @@ const { onRequestAbortHookRunner, lifecycleHooks, preParsingHookRunner, onTimeou
 const { supportedMethods } = require('./httpMethods')
 const { normalizeSchema } = require('./schemas')
 const { parseHeadOnSendHandlers } = require('./headRoute')
-const warning = require('./warnings')
+const {
+  FSTDEP007,
+  FSTDEP008,
+  FSTDEP014
+} = require('./warnings')
 
 const {
   compileSchemasForValidation,
@@ -100,11 +104,11 @@ function buildRouting (options) {
     hasRoute,
     prepareRoute,
     getDefaultRoute: function () {
-      warning.emit('FSTDEP014')
+      FSTDEP014()
       return router.defaultRoute
     },
     setDefaultRoute: function (defaultRoute) {
-      warning.emit('FSTDEP014')
+      FSTDEP014()
       if (typeof defaultRoute !== 'function') {
         throw new FST_ERR_DEFAULT_ROUTE_INVALID_TYPE()
       }
@@ -324,7 +328,7 @@ function buildRouting (options) {
       })
 
       if (opts.version) {
-        warning.emit('FSTDEP008')
+        FSTDEP008()
         constraints.version = opts.version
       }
 
@@ -417,7 +421,7 @@ function buildRouting (options) {
         const onSendHandlers = parseHeadOnSendHandlers(headOpts.onSend)
         prepareRoute.call(this, { method: 'HEAD', url: path, options: { ...headOpts, onSend: onSendHandlers }, isFastify: true })
       } else if (hasHEADHandler && exposeHeadRoute) {
-        warning.emit('FSTDEP007')
+        FSTDEP007()
       }
     }
   }

package/lib/server.js

@@ -4,7 +4,7 @@ const http = require('node:http')
 const https = require('node:https')
 const dns = require('node:dns')
 
-const warnings = require('./warnings')
+const { FSTDEP011 } = require('./warnings')
 const { kState, kOptions, kServerBindings } = require('./symbols')
 const { onListenHookRunner } = require('./hooks')
 const {
@@ -36,12 +36,12 @@ function createServer (options, httpHandler) {
     if (arguments.length === 0) {
       listenOptions = normalizeListenArgs([])
     } else if (arguments.length > 0 && (firstArgType !== '[object Object]' && firstArgType !== '[object Function]')) {
-      warnings.emit('FSTDEP011')
+      FSTDEP011()
       listenOptions = normalizeListenArgs(Array.from(arguments))
       cb = listenOptions.cb
     } else if (args.length > 1) {
       // `.listen(obj, a, ..., n, callback )`
-      warnings.emit('FSTDEP011')
+      FSTDEP011()
       // Deal with `.listen(port, host, backlog, [cb])`
       const hostPath = listenOptions.path ? [listenOptions.path] : [listenOptions.port ?? 0, listenOptions.host ?? 'localhost']
       Object.assign(listenOptions, normalizeListenArgs([...hostPath, ...args]))
@@ -163,29 +163,6 @@ function multipleBindings (mainServer, httpHandler, serverOpts, listenOptions, o
               /* istanbul ignore next: the else won't be taken unless listening fails */
               if (!_ignoreErr) {
                 this[kServerBindings].push(secondaryServer)
-                // Due to the nature of the feature is not possible to know
-                // ahead of time the number of bindings that will be made.
-                // For instance, each binding is hooked to be closed at their own
-                // pace through the `onClose` hook.
-                // It also allows them to handle possible connections already
-                // attached to them if any.
-                /* c8 ignore next 20 */
-                this.onClose((instance, done) => {
-                  if (instance[kState].listening) {
-                    // No new TCP connections are accepted
-                    // We swallow any error from the secondary
-                    // server
-                    secondaryServer.close(() => done())
-                    if (serverOpts.forceCloseConnections === 'idle') {
-                      // Not needed in Node 19
-                      secondaryServer.closeIdleConnections()
-                    } else if (typeof secondaryServer.closeAllConnections === 'function' && serverOpts.forceCloseConnections) {
-                      secondaryServer.closeAllConnections()
-                    }
-                  } else {
-                    done()
-                  }
-                })
               }
 
               if (bound === binding) {
@@ -196,7 +173,23 @@ function multipleBindings (mainServer, httpHandler, serverOpts, listenOptions, o
           })
 
           const secondaryServer = getServerInstance(serverOpts, httpHandler)
-          const closeSecondary = () => { secondaryServer.close(() => { }) }
+          const closeSecondary = () => {
+            // To avoid fall into situations where the close of the
+            // secondary server is triggered before the preClose hook
+            // is done running, we better wait until the main server
+            // is closed.
+            // No new TCP connections are accepted
+            // We swallow any error from the secondary
+            // server
+            secondaryServer.close(() => {})
+            if (serverOpts.forceCloseConnections === 'idle') {
+              // Not needed in Node 19
+              secondaryServer.closeIdleConnections()
+            } else if (typeof secondaryServer.closeAllConnections === 'function' && serverOpts.forceCloseConnections) {
+              secondaryServer.closeAllConnections()
+            }
+          }
+
           secondaryServer.on('upgrade', mainServer.emit.bind(mainServer, 'upgrade'))
           mainServer.on('unref', closeSecondary)
           mainServer.on('close', closeSecondary)

package/lib/validation.js

@@ -13,7 +13,7 @@ const {
   FST_ERR_SCH_RESPONSE_SCHEMA_NOT_NESTED_2XX
 } = require('./errors')
 
-const warning = require('./warnings')
+const { FSTWRN001 } = require('./warnings')
 
 function compileSchemasForSerialization (context, compile) {
   if (!context.schema || !context.schema.response) {
@@ -83,25 +83,25 @@ function compileSchemasForValidation (context, compile, isCustom) {
     }
     context[headersSchema] = compile({ schema: headersSchemaLowerCase, method, url, httpPart: 'headers' })
   } else if (Object.prototype.hasOwnProperty.call(schema, 'headers')) {
-    warning.emit('FSTWRN001', 'headers', method, url)
+    FSTWRN001('headers', method, url)
   }
 
   if (schema.body) {
     context[bodySchema] = compile({ schema: schema.body, method, url, httpPart: 'body' })
   } else if (Object.prototype.hasOwnProperty.call(schema, 'body')) {
-    warning.emit('FSTWRN001', 'body', method, url)
+    FSTWRN001('body', method, url)
   }
 
   if (schema.querystring) {
     context[querystringSchema] = compile({ schema: schema.querystring, method, url, httpPart: 'querystring' })
   } else if (Object.prototype.hasOwnProperty.call(schema, 'querystring')) {
-    warning.emit('FSTWRN001', 'querystring', method, url)
+    FSTWRN001('querystring', method, url)
   }
 
   if (schema.params) {
     context[paramsSchema] = compile({ schema: schema.params, method, url, httpPart: 'params' })
   } else if (Object.prototype.hasOwnProperty.call(schema, 'params')) {
-    warning.emit('FSTWRN001', 'params', method, url)
+    FSTWRN001('params', method, url)
   }
 }