fastify 4.22.0 → 4.22.2

package/docs/Guides/Database.md

@@ -308,7 +308,7 @@ async function migrate() {
 
     process.exitCode = 0
   } catch(err) {
-    console.error(error)
+    console.error(err)
     process.exitCode = 1
   }
   

package/docs/Guides/Ecosystem.md

@@ -46,7 +46,7 @@ section.
   Plugin to deal with `diagnostics_channel` on Fastify
 - [`@fastify/early-hints`](https://github.com/fastify/fastify-early-hints) Plugin
   to add HTTP 103 feature based on [RFC
-  8297](https://httpwg.org/specs/rfc8297.html).
+  8297](https://datatracker.ietf.org/doc/html/rfc8297).
 - [`@fastify/elasticsearch`](https://github.com/fastify/fastify-elasticsearch)
   Plugin to share the same ES client.
 - [`@fastify/env`](https://github.com/fastify/fastify-env) Load and check
@@ -121,6 +121,8 @@ section.
 - [`@fastify/swagger`](https://github.com/fastify/fastify-swagger) Plugin for
   serving Swagger/OpenAPI documentation for Fastify, supporting dynamic
   generation.
+- [`@fastify/throttle`](https://github.com/fastify/fastify-throttle) Plugin for
+- throttling the download speed of a request.
 - [`@fastify/type-provider-json-schema-to-ts`](https://github.com/fastify/fastify-type-provider-json-schema-to-ts)
   Fastify
   [type provider](https://www.fastify.io/docs/latest/Reference/Type-Providers/)
@@ -520,6 +522,10 @@ middlewares into Fastify plugins
 - [`fastify-qs`](https://github.com/vanodevium/fastify-qs) A plugin for Fastify
   that adds support for parsing URL query parameters with
   [qs](https://github.com/ljharb/qs).
+- [`fastify-rabbitmq`](https://github.com/Bugs5382/fastify-rabbitmq) Fastify
+  RabbitMQ plugin that uses
+  [node-amqp-connection-manager](https://github.com/jwalton/node-amqp-connection-manager)
+  plugin as a wrapper.
 - [`fastify-racing`](https://github.com/metcoder95/fastify-racing) Fastify's
   plugin that adds support to handle an aborted request asynchronous.
 - [`fastify-ravendb`](https://github.com/nearform/fastify-ravendb) RavenDB

package/docs/Guides/Serverless.md

@@ -487,10 +487,10 @@ with your GitHub account.
 Create your first application and a static workspace: be careful to download the
 API key as an env file, e.g. `yourworkspace.txt`.
 
-Then, you can easily deploy your application with the following commmand:
+Then, you can easily deploy your application with the following command:
 
 ```bash
-platformatic deploy --keys `yuourworkspace.txt`
+platformatic deploy --keys `yourworkspace.txt`
 ```
 
 Check out the [Full Guide](https://blog.platformatic.dev/how-to-migrate-a-fastify-app-to-platformatic-service)

package/docs/Reference/Errors.md

@@ -510,7 +510,7 @@ Impossible to load plugin because the parent (mapped directly from `avvio`)
 #### FST_ERR_PLUGIN_TIMEOUT
 <a id="FST_ERR_PLUGIN_TIMEOUT"></a>
 
-Plugin did not start in time. Default timeout (in millis): `10000`
+Plugin did not start in time. Default timeout (in milliseconds): `10000`
 
 #### FST_ERR_PLUGIN_NOT_PRESENT_IN_INSTANCE
 <a id="FST_ERR_PLUGIN_NOT_PRESENT_IN_INSTANCE"></a>

package/docs/Reference/HTTP2.md

@@ -32,7 +32,8 @@ fastify.get('/', function (request, reply) {
 fastify.listen({ port: 3000 })
 ```
 
-ALPN negotiation allows support for both HTTPS and HTTP/2 over the same socket.
+[ALPN negotiation](https://datatracker.ietf.org/doc/html/rfc7301) allows
+support for both HTTPS and HTTP/2 over the same socket.
 Node core `req` and `res` objects can be either
 [HTTP/1](https://nodejs.org/api/http.html) or
 [HTTP/2](https://nodejs.org/api/http2.html). _Fastify_ supports this out of the

package/docs/Reference/Hooks.md

@@ -80,7 +80,7 @@ hooks, and a stream with the current request payload.
 If it returns a value (via `return` or via the callback function), it must
 return a stream.
 
-For instance, you can uncompress the request body:
+For instance, you can decompress the request body:
 
 ```js
 fastify.addHook('preParsing', (request, reply, payload, done) => {

package/docs/Reference/Server.md

@@ -480,7 +480,7 @@ is not equal to `/Foo`.
 When `false` then routes are case-insensitive.
 
 Please note that setting this option to `false` goes against
-[RFC3986](https://tools.ietf.org/html/rfc3986#section-6.2.2.1).
+[RFC3986](https://datatracker.ietf.org/doc/html/rfc3986#section-6.2.2.1).
 
 By setting `caseSensitive` to `false`, all paths will be matched as lowercase,
 but the route parameters or wildcards will maintain their original letter

package/fastify.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const VERSION = '4.22.0'
+const VERSION = '4.22.2'
 
 const Avvio = require('avvio')
 const http = require('http')

package/lib/contentTypeParser.js

@@ -102,7 +102,7 @@ ContentTypeParser.prototype.getParser = function (contentType) {
   const parsed = safeParseContentType(contentType)
 
   // dummyContentType always the same object
-  // we can use === for the comparsion and return early
+  // we can use === for the comparison and return early
   if (parsed === defaultContentType) {
     return this.customParsers.get('')
   }
@@ -399,7 +399,7 @@ function compareRegExpContentType (contentType, essenceMIMEType, regexp) {
 function ParserListItem (contentType) {
   this.name = contentType
   // we pre-calculate all the needed information
-  // before content-type comparsion
+  // before content-type comparison
   const parsed = safeParseContentType(contentType)
   this.isEssence = contentType.indexOf(';') === -1
   // we should not allow empty string for parser list item

package/lib/handleRequest.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const { validate: validateSchema } = require('./validation')
-const { onPreValidationHookRunner, onPreHandlerHookRunner } = require('./hooks')
+const { preValidationHookRunner, preHandlerHookRunner } = require('./hooks')
 const wrapThenable = require('./wrapThenable')
 const {
   kReplyIsError,
@@ -65,7 +65,7 @@ function handleRequest (err, request, reply) {
 function handler (request, reply) {
   try {
     if (request[kRouteContext].preValidation !== null) {
-      onPreValidationHookRunner(
+      preValidationHookRunner(
         request[kRouteContext].preValidation,
         request,
         reply,
@@ -111,7 +111,7 @@ function validationCompleted (request, reply, validationErr) {
 
   // preHandler hook
   if (request[kRouteContext].preHandler !== null) {
-    onPreHandlerHookRunner(
+    preHandlerHookRunner(
       request[kRouteContext].preHandler,
       request,
       reply,

package/lib/hooks.js

@@ -217,8 +217,8 @@ function onResponseHookIterator (fn, request, reply, next) {
 }
 
 const onResponseHookRunner = hookRunnerGenerator(onResponseHookIterator)
-const onPreValidationHookRunner = hookRunnerGenerator(hookIterator)
-const onPreHandlerHookRunner = hookRunnerGenerator(hookIterator)
+const preValidationHookRunner = hookRunnerGenerator(hookIterator)
+const preHandlerHookRunner = hookRunnerGenerator(hookIterator)
 const onTimeoutHookRunner = hookRunnerGenerator(hookIterator)
 const onRequestHookRunner = hookRunnerGenerator(hookIterator)
 
@@ -267,6 +267,8 @@ function onSendHookRunner (functions, request, reply, payload, cb) {
   next()
 }
 
+const preSerializationHookRunner = onSendHookRunner
+
 function preParsingHookRunner (functions, request, reply, cb) {
   let i = 0
 
@@ -360,11 +362,12 @@ module.exports = {
   preParsingHookRunner,
   onResponseHookRunner,
   onSendHookRunner,
+  preSerializationHookRunner,
   onRequestAbortHookRunner,
   hookIterator,
   hookRunnerApplication,
-  onPreHandlerHookRunner,
-  onPreValidationHookRunner,
+  preHandlerHookRunner,
+  preValidationHookRunner,
   onRequestHookRunner,
   onTimeoutHookRunner,
   lifecycleHooks,

package/lib/logger.js

@@ -144,7 +144,7 @@ function createChildLogger (context, logger, req, reqId, loggerOpts) {
   }
   const child = context.childLoggerFactory.call(context.server, logger, loggerBindings, loggerOpts || {}, req)
 
-  // Optimisation: bypass validation if the factory is our own default factory
+  // Optimization: bypass validation if the factory is our own default factory
   if (context.childLoggerFactory !== defaultChildLoggerFactory) {
     validateLogger(child, true) // throw if the child is not a valid logger
   }

package/lib/reply.js

@@ -23,7 +23,12 @@ const {
   kOptions,
   kRouteContext
 } = require('./symbols.js')
-const { onSendHookRunner, onResponseHookRunner, onPreHandlerHookRunner } = require('./hooks')
+const {
+  onSendHookRunner,
+  onResponseHookRunner,
+  preHandlerHookRunner,
+  preSerializationHookRunner
+} = require('./hooks')
 
 const internals = require('./handleRequest')[Symbol.for('internals')]
 const loggerUtils = require('./logger')
@@ -166,7 +171,7 @@ Reply.prototype.send = function (payload) {
 
   if (this[kReplySerializer] !== null) {
     if (typeof payload !== 'string') {
-      preserializeHook(this, payload)
+      preSerializationHook(this, payload)
       return this
     } else {
       payload = this[kReplySerializer](payload)
@@ -189,7 +194,7 @@ Reply.prototype.send = function (payload) {
       }
     }
     if (typeof payload !== 'string') {
-      preserializeHook(this, payload)
+      preSerializationHook(this, payload)
       return this
     }
   }
@@ -233,7 +238,7 @@ Reply.prototype.header = function (key, value = '') {
   key = key.toLowerCase()
 
   if (this[kReplyHeaders][key] && key === 'set-cookie') {
-    // https://tools.ietf.org/html/rfc7230#section-3.2.2
+    // https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.2
     if (typeof this[kReplyHeaders][key] === 'string') {
       this[kReplyHeaders][key] = [this[kReplyHeaders][key]]
     }
@@ -262,7 +267,7 @@ Reply.prototype.headers = function (headers) {
 }
 
 // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Trailer#directives
-// https://httpwg.org/specs/rfc7230.html#chunked.trailer.part
+// https://datatracker.ietf.org/doc/html/rfc7230.html#chunked.trailer.part
 const INVALID_TRAILERS = new Set([
   'transfer-encoding',
   'content-length',
@@ -476,21 +481,21 @@ Reply.prototype.then = function (fulfilled, rejected) {
   })
 }
 
-function preserializeHook (reply, payload) {
+function preSerializationHook (reply, payload) {
   if (reply[kRouteContext].preSerialization !== null) {
-    onSendHookRunner(
+    preSerializationHookRunner(
       reply[kRouteContext].preSerialization,
       reply.request,
       reply,
       payload,
-      preserializeHookEnd
+      preSerializationHookEnd
     )
   } else {
-    preserializeHookEnd(null, reply.request, reply, payload)
+    preSerializationHookEnd(null, reply.request, reply, payload)
   }
 }
 
-function preserializeHookEnd (err, request, reply, payload) {
+function preSerializationHookEnd (err, request, reply, payload) {
   if (err != null) {
     onErrorHook(reply, err)
     return
@@ -505,7 +510,7 @@ function preserializeHookEnd (err, request, reply, payload) {
       payload = serialize(reply[kRouteContext], payload, reply.raw.statusCode, reply[kReplyHeaders]['content-type'])
     }
   } catch (e) {
-    wrapSeralizationError(e, reply)
+    wrapSerializationError(e, reply)
     onErrorHook(reply, e)
     return
   }
@@ -513,7 +518,7 @@ function preserializeHookEnd (err, request, reply, payload) {
   onSendHook(reply, payload)
 }
 
-function wrapSeralizationError (error, reply) {
+function wrapSerializationError (error, reply) {
   error.serialization = reply[kRouteContext].config
 }
 
@@ -571,7 +576,7 @@ function onSendEnd (reply, payload) {
   }
 
   if (payload === undefined || payload === null) {
-    // according to https://tools.ietf.org/html/rfc7230#section-3.3.2
+    // according to https://datatracker.ietf.org/doc/html/rfc7230#section-3.3.2
     // we cannot send a content-length for 304 and 204, and all status code
     // < 200
     // A sender MUST NOT send a Content-Length header field in any message
@@ -846,7 +851,7 @@ function notFound (reply) {
 
   // preHandler hook
   if (reply[kRouteContext].preHandler !== null) {
-    onPreHandlerHookRunner(
+    preHandlerHookRunner(
       reply[kRouteContext].preHandler,
       reply.request,
       reply,

package/lib/request.js

@@ -51,8 +51,8 @@ function getTrustProxyFn (tp) {
   }
   if (typeof tp === 'string') {
     // Support comma-separated tps
-    const vals = tp.split(',').map(it => it.trim())
-    return proxyAddr.compile(vals)
+    const values = tp.split(',').map(it => it.trim())
+    return proxyAddr.compile(values)
   }
   return proxyAddr.compile(tp)
 }

package/lib/schemas.js

@@ -23,7 +23,7 @@ Schemas.prototype.add = function (inputSchema) {
     : inputSchema
   )
 
-  // devs can add schemas without $id, but with $def instead
+  // developers can add schemas without $id, but with $def instead
   const id = schema.$id
   if (!id) {
     throw new FST_ERR_SCH_MISSING_ID()

package/lib/server.js

@@ -132,7 +132,7 @@ function multipleBindings (mainServer, httpHandler, serverOpts, listenOptions, o
     const isMainServerListening = mainServer.listening && serverOpts.serverFactory
 
     let binding = 0
-    let binded = 0
+    let bound = 0
     if (!isMainServerListening) {
       const primaryAddress = mainServer.address()
       for (const adr of addresses) {
@@ -142,7 +142,7 @@ function multipleBindings (mainServer, httpHandler, serverOpts, listenOptions, o
             host: adr.address,
             port: primaryAddress.port,
             cb: (_ignoreErr) => {
-              binded++
+              bound++
 
               /* istanbul ignore next: the else won't be taken unless listening fails */
               if (!_ignoreErr) {
@@ -172,7 +172,7 @@ function multipleBindings (mainServer, httpHandler, serverOpts, listenOptions, o
                 })
               }
 
-              if (binded === binding) {
+              if (bound === binding) {
                 // regardless of the error, we are done
                 onListen()
               }
@@ -200,7 +200,7 @@ function multipleBindings (mainServer, httpHandler, serverOpts, listenOptions, o
     // to the secondary servers. It is valid only when the user is
     // listening on localhost
     const originUnref = mainServer.unref
-    /* istanbul ignore next */
+    /* c8 ignore next 4 */
     mainServer.unref = function () {
       originUnref.call(mainServer)
       mainServer.emit('unref')

package/lib/validation.js

@@ -69,7 +69,7 @@ function compileSchemasForValidation (context, compile, isCustom) {
     context[headersSchema] = compile({ schema: headers, method, url, httpPart: 'headers' })
   } else if (headers) {
     // The header keys are case insensitive
-    //  https://tools.ietf.org/html/rfc2616#section-4.2
+    //  https://datatracker.ietf.org/doc/html/rfc2616#section-4.2
     const headersSchemaLowerCase = {}
     Object.keys(headers).forEach(k => { headersSchemaLowerCase[k] = headers[k] })
     if (headersSchemaLowerCase.required instanceof Array) {

package/lib/wrapThenable.js

@@ -18,10 +18,7 @@ function wrapThenable (thenable, reply) {
     // the request may be terminated during the reply. in this situation,
     // it require an extra checking of request.aborted to see whether
     // the request is killed by client.
-    // Most of the times aborted will be true when destroyed is true,
-    // however there is a race condition where the request is not
-    // aborted but only destroyed.
-    if (payload !== undefined || (reply.sent === false && reply.raw.headersSent === false && reply.request.raw.aborted === false && reply.request.raw.destroyed === false)) {
+    if (payload !== undefined || (reply.sent === false && reply.raw.headersSent === false && reply.request.raw.aborted === false)) {
       // we use a try-catch internally to avoid adding a catch to another
       // promise, increase promise perf by 10%
       try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fastify",
-  "version": "4.22.0",
+  "version": "4.22.2",
   "description": "Fast and low overhead web framework, for Node.js",
   "main": "fastify.js",
   "type": "commonjs",
@@ -162,7 +162,7 @@
     "joi": "^17.9.2",
     "json-schema-to-ts": "^2.9.1",
     "JSONStream": "^1.3.5",
-    "markdownlint-cli2": "^0.8.1",
+    "markdownlint-cli2": "^0.9.2",
     "proxyquire": "^2.1.3",
     "self-cert": "^2.0.0",
     "send": "^0.18.0",

package/test/build/error-serializer.test.js

@@ -23,9 +23,9 @@ test('check generated code syntax', async (t) => {
   t.equal(result[0].fatalErrorCount, 0)
 })
 
-const isPrebublish = !!process.env.PREPUBLISH
+const isPrepublish = !!process.env.PREPUBLISH
 
-test('ensure the current error serializer is latest', { skip: !isPrebublish }, async (t) => {
+test('ensure the current error serializer is latest', { skip: !isPrepublish }, async (t) => {
   t.plan(1)
 
   const current = await fs.promises.readFile(path.resolve('lib/error-serializer.js'))

package/test/post-empty-body.test.js

@@ -0,0 +1,31 @@
+'use strict'
+
+const { test } = require('tap')
+const fastify = require('../')
+const { request, setGlobalDispatcher, Agent } = require('undici')
+
+setGlobalDispatcher(new Agent({
+  keepAliveTimeout: 10,
+  keepAliveMaxTimeout: 10
+}))
+
+test('post empty body', async t => {
+  const app = fastify()
+  t.teardown(app.close.bind(app))
+
+  app.post('/bug', async (request, reply) => {
+  })
+
+  await app.listen({ port: 0 })
+
+  const res = await request(`http://127.0.0.1:${app.server.address().port}/bug`, {
+    method: 'POST',
+    headers: {
+      'Content-Type': 'application/json'
+    },
+    body: JSON.stringify({ foo: 'bar' })
+  })
+
+  t.equal(res.statusCode, 200)
+  t.equal(await res.body.text(), '')
+})

package/test/wrapThenable.test.js

@@ -27,25 +27,3 @@ test('should reject immediately when reply[kReplyHijacked] is true', t => {
   const thenable = Promise.reject(new Error('Reply sent already'))
   wrapThenable(thenable, reply)
 })
-
-test('should not send the payload if the raw socket was destroyed but not aborted', async t => {
-  const reply = {
-    sent: false,
-    raw: {
-      headersSent: false
-    },
-    request: {
-      raw: {
-        aborted: false,
-        destroyed: true
-      }
-    },
-    send () {
-      t.fail('should not send')
-    }
-  }
-  const thenable = Promise.resolve()
-  wrapThenable(thenable, reply)
-
-  await thenable
-})