fastify 4.15.0 → 4.16.1

package/test/schema-feature.test.js

@@ -6,6 +6,7 @@ const fp = require('fastify-plugin')
 const deepClone = require('rfdc')({ circles: true, proto: false })
 const Ajv = require('ajv')
 const { kSchemaController } = require('../lib/symbols.js')
+const warning = require('../lib/warnings')
 
 const echoParams = (req, reply) => { reply.send(req.params) }
 const echoBody = (req, reply) => { reply.send(req.body) }
@@ -253,88 +254,180 @@ test('Should not change the input schemas', t => {
   })
 })
 
-test('Should throw if the schema body is undefined', t => {
-  t.plan(2)
+test('Should emit warning if the schema headers is undefined', t => {
+  t.plan(4)
   const fastify = Fastify()
 
-  fastify.get('/:id', {
+  process.on('warning', onWarning)
+  function onWarning (warning) {
+    t.equal(warning.name, 'FastifyWarning')
+    t.equal(warning.code, 'FSTWRN001')
+  }
+
+  t.teardown(() => {
+    process.removeListener('warning', onWarning)
+    warning.emitted.set('FSTWRN001', false)
+  })
+
+  fastify.post('/:id', {
     handler: echoParams,
     schema: {
-      body: undefined
+      headers: undefined
     }
   })
 
-  fastify.ready(err => {
-    t.equal(err.code, 'FST_ERR_SCH_VALIDATION_BUILD')
-    t.equal(err.message, 'Failed building the validation schema for GET: /:id, due to error body schema is undefined')
+  fastify.inject({
+    method: 'POST',
+    url: '/123'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 200)
   })
 })
 
-test('Should throw if the schema headers is undefined', t => {
-  t.plan(2)
+test('Should emit warning if the schema body is undefined', t => {
+  t.plan(4)
   const fastify = Fastify()
 
-  fastify.get('/:id', {
+  process.on('warning', onWarning)
+  function onWarning (warning) {
+    t.equal(warning.name, 'FastifyWarning')
+    t.equal(warning.code, 'FSTWRN001')
+  }
+
+  t.teardown(() => {
+    process.removeListener('warning', onWarning)
+    warning.emitted.set('FSTWRN001', false)
+  })
+
+  fastify.post('/:id', {
     handler: echoParams,
     schema: {
-      headers: undefined
+      body: undefined
     }
   })
 
-  fastify.ready(err => {
-    t.equal(err.code, 'FST_ERR_SCH_VALIDATION_BUILD')
-    t.equal(err.message, 'Failed building the validation schema for GET: /:id, due to error headers schema is undefined')
+  fastify.inject({
+    method: 'POST',
+    url: '/123'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 200)
   })
 })
 
-test('Should throw if the schema params is undefined', t => {
-  t.plan(2)
+test('Should emit warning if the schema query is undefined', t => {
+  t.plan(4)
   const fastify = Fastify()
 
-  fastify.get('/:id', {
+  process.on('warning', onWarning)
+  function onWarning (warning) {
+    t.equal(warning.name, 'FastifyWarning')
+    t.equal(warning.code, 'FSTWRN001')
+  }
+
+  t.teardown(() => {
+    process.removeListener('warning', onWarning)
+    warning.emitted.set('FSTWRN001', false)
+  })
+
+  fastify.post('/:id', {
     handler: echoParams,
     schema: {
-      params: undefined
+      querystring: undefined
     }
   })
 
-  fastify.ready(err => {
-    t.equal(err.code, 'FST_ERR_SCH_VALIDATION_BUILD')
-    t.equal(err.message, 'Failed building the validation schema for GET: /:id, due to error params schema is undefined')
+  fastify.inject({
+    method: 'POST',
+    url: '/123'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 200)
   })
 })
 
-test('Should throw if the schema query is undefined', t => {
-  t.plan(2)
+test('Should emit warning if the schema params is undefined', t => {
+  t.plan(4)
   const fastify = Fastify()
 
-  fastify.get('/:id', {
+  process.on('warning', onWarning)
+  function onWarning (warning) {
+    t.equal(warning.name, 'FastifyWarning')
+    t.equal(warning.code, 'FSTWRN001')
+  }
+
+  t.teardown(() => {
+    process.removeListener('warning', onWarning)
+    warning.emitted.set('FSTWRN001', false)
+  })
+
+  fastify.post('/:id', {
     handler: echoParams,
     schema: {
-      querystring: undefined
+      params: undefined
     }
   })
 
-  fastify.ready(err => {
-    t.equal(err.code, 'FST_ERR_SCH_VALIDATION_BUILD')
-    t.equal(err.message, 'Failed building the validation schema for GET: /:id, due to error querystring schema is undefined')
+  fastify.inject({
+    method: 'POST',
+    url: '/123'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 200)
   })
 })
 
-test('Should throw if the schema query is undefined', t => {
-  t.plan(2)
+test('Should emit a warning for every route with undefined schema', t => {
+  t.plan(16)
   const fastify = Fastify()
 
-  fastify.get('/:id', {
+  let runs = 0
+  const expectedWarningEmitted = [0, 1, 2, 3]
+  // It emits 4 warnings:
+  // - 2 - GET and HEAD for /undefinedParams/:id
+  // - 2 - GET and HEAD for /undefinedBody/:id
+  // => 3 x 4 assertions = 12 assertions
+  function onWarning (warning) {
+    t.equal(warning.name, 'FastifyWarning')
+    t.equal(warning.code, 'FSTWRN001')
+    t.equal(runs++, expectedWarningEmitted.shift())
+  }
+
+  process.on('warning', onWarning)
+  t.teardown(() => {
+    process.removeListener('warning', onWarning)
+    warning.emitted.set('FSTWRN001', false)
+  })
+
+  fastify.get('/undefinedParams/:id', {
     handler: echoParams,
     schema: {
-      querystring: undefined
+      params: undefined
     }
   })
 
-  fastify.ready(err => {
-    t.equal(err.code, 'FST_ERR_SCH_VALIDATION_BUILD')
-    t.equal(err.message, 'Failed building the validation schema for GET: /:id, due to error querystring schema is undefined')
+  fastify.get('/undefinedBody/:id', {
+    handler: echoParams,
+    schema: {
+      body: undefined
+    }
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/undefinedParams/123'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 200)
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/undefinedBody/123'
+  }, (error, res) => {
+    t.error(error)
+    t.equal(res.statusCode, 200)
   })
 })