fastify 4.12.0 → 4.13.0

package/test/client-timeout.test.js

@@ -0,0 +1,38 @@
+'use strict'
+
+const { test } = require('tap')
+const fastify = require('..')({ requestTimeout: 5, http: { connectionsCheckingInterval: 1000 } })
+const { connect } = require('net')
+
+test('requestTimeout should return 408', t => {
+  t.plan(1)
+
+  t.teardown(() => {
+    fastify.close()
+  })
+
+  fastify.post('/', async function (req, reply) {
+    await new Promise(resolve => setTimeout(resolve, 100))
+    return reply.send({ hello: 'world' })
+  })
+
+  fastify.listen({ port: 0 }, err => {
+    if (err) {
+      throw err
+    }
+
+    let data = Buffer.alloc(0)
+    const socket = connect(fastify.server.address().port)
+
+    socket.write('POST / HTTP/1.1\r\nHost: example.com\r\nConnection-Length: 1\r\n')
+
+    socket.on('data', c => (data = Buffer.concat([data, c])))
+    socket.on('end', () => {
+      t.equal(
+        data.toString('utf-8'),
+        'HTTP/1.1 408 Request Timeout\r\nContent-Length: 71\r\nContent-Type: application/json\r\n\r\n{"error":"Request Timeout","message":"Client Timeout","statusCode":408}'
+      )
+      t.end()
+    })
+  })
+})

package/test/close.test.js

@@ -165,7 +165,7 @@ test('Should return error while closing (promise) - injection', t => {
         url: '/'
       }).catch(err => {
         t.ok(err)
-        t.equal(err.message, 'Server is closed')
+        t.equal(err.code, 'FST_ERR_REOPENED_CLOSE_SERVER')
       })
     }, 100)
   })
@@ -197,7 +197,7 @@ test('Should return error while closing (callback) - injection', t => {
         url: '/'
       }, (err, res) => {
         t.ok(err)
-        t.equal(err.message, 'Server is closed')
+        t.equal(err.code, 'FST_ERR_REOPENED_CLOSE_SERVER')
       })
     }, 100)
   })
@@ -220,13 +220,13 @@ t.test('Current opened connection should continue to work after closing and retu
 
     const port = fastify.server.address().port
     const client = net.createConnection({ port }, () => {
-      client.write('GET / HTTP/1.1\r\n\r\n')
+      client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
       client.once('data', data => {
         t.match(data.toString(), /Connection:\s*keep-alive/i)
         t.match(data.toString(), /200 OK/i)
 
-        client.write('GET / HTTP/1.1\r\n\r\n')
+        client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
         client.once('data', data => {
           t.match(data.toString(), /Connection:\s*close/i)
@@ -259,7 +259,7 @@ t.test('Current opened connection should NOT continue to work after closing and
 
     const port = fastify.server.address().port
     const client = net.createConnection({ port }, () => {
-      client.write('GET / HTTP/1.1\r\n\r\n')
+      client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
       client.on('error', function () {
         // Dependending on the Operating System
@@ -275,7 +275,7 @@ t.test('Current opened connection should NOT continue to work after closing and
         t.match(data.toString(), /Connection:\s*keep-alive/i)
         t.match(data.toString(), /200 OK/i)
 
-        client.write('GET / HTTP/1.1\r\n\r\n')
+        client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
       })
     })
   })

package/test/content-parser.test.js

@@ -256,27 +256,25 @@ test('Error thrown 415 from content type is null and make post request to server
 
 test('remove', t => {
   test('should remove default parser', t => {
-    t.plan(2)
+    t.plan(3)
 
     const fastify = Fastify()
     const contentTypeParser = fastify[keys.kContentTypeParser]
 
-    contentTypeParser.remove('application/json')
-
+    t.ok(contentTypeParser.remove('application/json'))
     t.notOk(contentTypeParser.customParsers['application/json'])
     t.notOk(contentTypeParser.parserList.find(parser => parser === 'application/json'))
   })
 
   test('should remove RegExp parser', t => {
-    t.plan(2)
+    t.plan(3)
 
     const fastify = Fastify()
     fastify.addContentTypeParser(/^text\/*/, first)
 
     const contentTypeParser = fastify[keys.kContentTypeParser]
 
-    contentTypeParser.remove(/^text\/*/)
-
+    t.ok(contentTypeParser.remove(/^text\/*/))
     t.notOk(contentTypeParser.customParsers[/^text\/*/])
     t.notOk(contentTypeParser.parserRegExpList.find(parser => parser.toString() === /^text\/*/.toString()))
   })
@@ -289,23 +287,22 @@ test('remove', t => {
     t.throws(() => fastify[keys.kContentTypeParser].remove(12), FST_ERR_CTP_INVALID_TYPE)
   })
 
-  test('should not throw error if content type does not exist', t => {
+  test('should return false if content type does not exist', t => {
     t.plan(1)
 
     const fastify = Fastify()
 
-    t.doesNotThrow(() => fastify[keys.kContentTypeParser].remove('image/png'))
+    t.notOk(fastify[keys.kContentTypeParser].remove('image/png'))
   })
 
   test('should not remove any content type parser if content type does not exist', t => {
-    t.plan(1)
+    t.plan(2)
 
     const fastify = Fastify()
 
     const contentTypeParser = fastify[keys.kContentTypeParser]
 
-    contentTypeParser.remove('image/png')
-
+    t.notOk(contentTypeParser.remove('image/png'))
     t.same(contentTypeParser.customParsers.size, 2)
   })
 

package/test/hooks.on-ready.test.js

@@ -372,3 +372,16 @@ t.test('ready return registered', t => {
     .then(instance => { t.same(instance, fastify) })
     .catch(err => { t.fail(err) })
 })
+
+t.test('do not crash with error in follow up onReady hook', async t => {
+  const fastify = Fastify()
+
+  fastify.addHook('onReady', async function () {
+  })
+
+  fastify.addHook('onReady', function () {
+    throw new Error('kaboom')
+  })
+
+  await t.rejects(fastify.ready())
+})

package/test/hooks.test.js

@@ -10,6 +10,7 @@ const fs = require('fs')
 const split = require('split2')
 const symbols = require('../lib/symbols.js')
 const payload = { hello: 'world' }
+const proxyquire = require('proxyquire')
 
 process.removeAllListeners('warning')
 
@@ -1269,7 +1270,14 @@ test('clear payload', t => {
 })
 
 test('onSend hook throws', t => {
-  t.plan(9)
+  t.plan(11)
+  const Fastify = proxyquire('..', {
+    './lib/schemas.js': {
+      getSchemaSerializer: (param1, param2, param3) => {
+        t.equal(param3, 'application/json; charset=utf-8', 'param3 should be "application/json; charset=utf-8"')
+      }
+    }
+  })
   const fastify = Fastify()
   fastify.addHook('onSend', function (request, reply, payload, done) {
     if (request.raw.method === 'DELETE') {
@@ -1281,6 +1289,10 @@ test('onSend hook throws', t => {
       throw new Error('some error')
     }
 
+    if (request.raw.method === 'POST') {
+      throw new Error('some error')
+    }
+
     done()
   })
 
@@ -1288,6 +1300,26 @@ test('onSend hook throws', t => {
     reply.send({ hello: 'world' })
   })
 
+  fastify.post('/', {
+    schema: {
+      response: {
+        200: {
+          content: {
+            'application/json': {
+              schema: {
+                name: { type: 'string' },
+                image: { type: 'string' },
+                address: { type: 'string' }
+              }
+            }
+          }
+        }
+      }
+    }
+  }, (req, reply) => {
+    reply.send({ hello: 'world' })
+  })
+
   fastify.delete('/', (req, reply) => {
     reply.send({ hello: 'world' })
   })
@@ -1309,6 +1341,13 @@ test('onSend hook throws', t => {
       t.equal(response.headers['content-length'], '' + body.length)
       t.same(JSON.parse(body), { hello: 'world' })
     })
+    sget({
+      method: 'POST',
+      url: 'http://localhost:' + fastify.server.address().port
+    }, (err, response, body) => {
+      t.error(err)
+      t.equal(response.statusCode, 500)
+    })
     sget({
       method: 'DELETE',
       url: 'http://localhost:' + fastify.server.address().port

package/test/http2/unknown-http-method.test.js

@@ -27,6 +27,7 @@ fastify.listen({ port: 0 }, err => {
     t.equal(res.headers[':status'], 404)
     t.same(JSON.parse(res.body), {
       statusCode: 404,
+      code: 'FST_ERR_NOT_FOUND',
       error: 'Not Found',
       message: 'Not Found'
     })

package/test/internals/reply.test.js

@@ -1740,7 +1740,7 @@ test('cannot set the replySerializer when the server is running', t => {
       fastify.setReplySerializer(() => {})
       t.fail('this serializer should not be setup')
     } catch (e) {
-      t.equal(e.message, 'Cannot call "setReplySerializer" when fastify instance is already started!')
+      t.equal(e.code, 'FST_ERR_INSTANCE_ALREADY_LISTENING')
     }
   })
 })

package/test/maxRequestsPerSocket.test.js

@@ -22,20 +22,20 @@ test('maxRequestsPerSocket on node version >= 16.10.0', { skip }, t => {
 
     const port = fastify.server.address().port
     const client = net.createConnection({ port }, () => {
-      client.write('GET / HTTP/1.1\r\n\r\n')
+      client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
       client.once('data', data => {
         t.match(data.toString(), /Connection:\s*keep-alive/i)
         t.match(data.toString(), /Keep-Alive:\s*timeout=\d+/i)
         t.match(data.toString(), /200 OK/i)
 
-        client.write('GET / HTTP/1.1\r\n\r\n')
+        client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
         client.once('data', data => {
           t.match(data.toString(), /Connection:\s*close/i)
           t.match(data.toString(), /200 OK/i)
 
-          client.write('GET / HTTP/1.1\r\n\r\n')
+          client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
           client.once('data', data => {
             t.match(data.toString(), /Connection:\s*close/i)
@@ -63,21 +63,21 @@ test('maxRequestsPerSocket zero should behave same as null', { skip }, t => {
 
     const port = fastify.server.address().port
     const client = net.createConnection({ port }, () => {
-      client.write('GET / HTTP/1.1\r\n\r\n')
+      client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
       client.once('data', data => {
         t.match(data.toString(), /Connection:\s*keep-alive/i)
         t.match(data.toString(), /Keep-Alive:\s*timeout=\d+/i)
         t.match(data.toString(), /200 OK/i)
 
-        client.write('GET / HTTP/1.1\r\n\r\n')
+        client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
         client.once('data', data => {
           t.match(data.toString(), /Connection:\s*keep-alive/i)
           t.match(data.toString(), /Keep-Alive:\s*timeout=\d+/i)
           t.match(data.toString(), /200 OK/i)
 
-          client.write('GET / HTTP/1.1\r\n\r\n')
+          client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
           client.once('data', data => {
             t.match(data.toString(), /Connection:\s*keep-alive/i)

package/test/skip-reply-send.test.js

@@ -204,7 +204,7 @@ function testHandlerOrBeforeHandlerHook (test, hookOrHandler) {
       app.listen({ port: 0 }, err => {
         t.error(err)
         const client = net.createConnection({ port: (app.server.address()).port }, () => {
-          client.write('GET / HTTP/1.1\r\n\r\n')
+          client.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n')
 
           let chunks = ''
           client.setEncoding('utf8')

package/test/types/fastify.test-d.ts

@@ -25,6 +25,7 @@ import { Socket } from 'net'
 // http server
 expectType<FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse> & PromiseLike<FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse>>>(fastify())
 expectType<FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse> & PromiseLike<FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse>>>(fastify({}))
+expectType<FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse> & PromiseLike<FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse>>>(fastify({ http: {} }))
 // https server
 expectType<FastifyInstance<https.Server, http.IncomingMessage, http.ServerResponse> & PromiseLike<FastifyInstance<https.Server, http.IncomingMessage, http.ServerResponse>>>(fastify({ https: {} }))
 expectType<FastifyInstance<https.Server, http.IncomingMessage, http.ServerResponse> & PromiseLike<FastifyInstance<https.Server, http.IncomingMessage, http.ServerResponse>>>(fastify({ https: null }))

package/test/types/instance.test-d.ts

@@ -326,6 +326,8 @@ const versionConstraintStrategy = {
 expectType<void>(server.addConstraintStrategy(versionConstraintStrategy))
 expectType<boolean>(server.hasConstraintStrategy(versionConstraintStrategy.name))
 
+expectType<boolean>(server.hasPlugin(''))
+
 expectAssignable<DefaultRoute<RawRequestDefaultExpression, RawReplyDefaultExpression>>(server.getDefaultRoute())
 
 expectType<FastifySchemaCompiler<any> | undefined>(server.validatorCompiler)

package/test/unsupported-httpversion.test.js

@@ -18,7 +18,7 @@ t.test('Will return 505 HTTP error if HTTP version (2.0 when server is 1.1) is n
 
     const port = fastify.server.address().port
     const client = net.createConnection({ port }, () => {
-      client.write('GET / HTTP/2.0\r\n\r\n')
+      client.write('GET / HTTP/2.0\r\nHost: example.com\r\n\r\n')
 
       client.once('data', data => {
         t.match(data.toString(), /505 HTTP Version Not Supported/i)

package/test/validation-error-handling.test.js

@@ -568,7 +568,7 @@ test('cannot create a fastify instance with wrong type of errorFormatter', t =>
       }
     })
   } catch (err) {
-    t.equal(err.message, 'schemaErrorFormatter option should not be an async function')
+    t.equal(err.code, 'FST_ERR_SCHEMA_ERROR_FORMATTER_NOT_FN')
   }
 
   try {
@@ -576,14 +576,14 @@ test('cannot create a fastify instance with wrong type of errorFormatter', t =>
       schemaErrorFormatter: 500
     })
   } catch (err) {
-    t.equal(err.message, 'schemaErrorFormatter option should be a function, instead got number')
+    t.equal(err.code, 'FST_ERR_SCHEMA_ERROR_FORMATTER_NOT_FN')
   }
 
   try {
     const fastify = Fastify()
     fastify.setSchemaErrorFormatter(500)
   } catch (err) {
-    t.equal(err.message, 'schemaErrorFormatter option should be a function, instead got number')
+    t.equal(err.code, 'FST_ERR_SCHEMA_ERROR_FORMATTER_NOT_FN')
   }
 })
 

package/types/errors.d.ts

@@ -49,5 +49,25 @@ export type FastifyErrorCodes = Record<
 'FST_ERR_PLUGIN_NOT_VALID' |
 'FST_ERR_ROOT_PLG_BOOTED' |
 'FST_ERR_PARENT_PLUGIN_BOOTED' |
-'FST_ERR_PLUGIN_TIMEOUT'
+'FST_ERR_PLUGIN_TIMEOUT' |
+'FST_ERR_OPTIONS_NOT_OBJ' |
+'FST_ERR_QSP_NOT_FN' |
+'FST_ERR_SCHEMA_CONTROLLER_BUCKET_OPT_NOT_FN' |
+'FST_ERR_SCHEMA_ERROR_FORMATTER_NOT_FN' |
+'FST_ERR_AJV_CUSTOM_OPTIONS_OPT_NOT_OBJ' |
+'FST_ERR_AJV_CUSTOM_OPTIONS_OPT_NOT_ARR' |
+'FST_ERR_VERSION_CONSTRAINT_NOT_STR' |
+'FST_ERR_CTP_INSTANCE_ALREADY_STARTED' |
+'FST_ERR_HOOK_NOT_SUPPORTED' |
+'FST_ERR_SCH_RESPONSE_SCHEMA_NOT_NESTED_2XX' |
+'FST_ERR_ROUTE_OPTIONS_NOT_OBJ' |
+'FST_ERR_ROUTE_DUPLICATED_HANDLER' |
+'FST_ERR_ROUTE_HANDLER_NOT_FN' |
+'FST_ERR_ROUTE_MISSING_HANDLER' |
+'FST_ERR_ROUTE_METHOD_NOT_SUPPORTED' |
+'FST_ERR_ROUTE_BODY_VALIDATION_SCHEMA_NOT_SUPPORTED' |
+'FST_ERR_ROUTE_BODY_LIMIT_OPTION_NOT_INT' |
+'FST_ERR_ROUTE_REWRITE_NOT_STR' |
+'FST_ERR_PLUGIN_NOT_PRESENT_IN_INSTANCE' |
+'FST_ERR_INSTANCE_ALREADY_LISTENING'
 , FastifyErrorConstructor>

package/types/instance.d.ts

@@ -131,6 +131,7 @@ export interface FastifyInstance<
   hasDecorator(decorator: string | symbol): boolean;
   hasRequestDecorator(decorator: string | symbol): boolean;
   hasReplyDecorator(decorator: string | symbol): boolean;
+  hasPlugin(name: string): boolean;
 
   addConstraintStrategy(strategy: ConstraintStrategy<FindMyWayVersion<RawServer>, unknown>): void;
   hasConstraintStrategy(strategyName: string): boolean;