fastify 4.0.0-alpha.1 → 4.0.0-alpha.2

package/test/hooks.test.js

@@ -138,7 +138,7 @@ test('hooks', t => {
     reply.code(200).send(payload)
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -261,7 +261,7 @@ test('onRequest hook should support encapsulation / 3', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -322,7 +322,7 @@ test('preHandler hook should support encapsulation / 5', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -733,7 +733,7 @@ test('onRoute hook should able to change the route url', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -918,7 +918,7 @@ test('onResponse hook should support encapsulation / 3', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -995,7 +995,7 @@ test('onSend hook should support encapsulation / 2', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -1259,7 +1259,7 @@ test('onSend hook throws', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -1381,7 +1381,7 @@ test('cannot add hook after binding', t => {
     reply.send({ hello: 'world' })
   })
 
-  instance.listen(0, err => {
+  instance.listen({ port: 0 }, err => {
     t.error(err)
     t.teardown(instance.server.close.bind(instance.server))
 
@@ -2389,7 +2389,7 @@ test('preValidation hook should support encapsulation / 3', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2536,7 +2536,7 @@ test('preParsing hook should run before parsing and be able to modify the payloa
     }
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2579,7 +2579,7 @@ test('preParsing hooks should run in the order in which they are defined', t =>
     }
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2629,7 +2629,7 @@ test('preParsing hooks should support encapsulation', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2750,7 +2750,7 @@ test('preParsing hook should support encapsulation / 3', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2812,7 +2812,7 @@ test('preSerialization hook should run before serialization and be able to modif
     }
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2863,7 +2863,7 @@ test('preSerialization hook should be able to throw errors which are validated a
     }
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2897,7 +2897,7 @@ test('preSerialization hook which returned error should still run onError hooks'
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2931,7 +2931,7 @@ test('preSerialization hooks should run in the order in which they are defined',
     reply.send(payload)
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -2975,7 +2975,7 @@ test('preSerialization hooks should support encapsulation', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -3162,7 +3162,7 @@ test('onTimeout should be triggered', t => {
     return reply
   })
 
-  fastify.listen(0, (err, address) => {
+  fastify.listen({ port: 0 }, (err, address) => {
     t.error(err)
     t.teardown(() => fastify.close())
 
@@ -3201,7 +3201,7 @@ test('onTimeout should be triggered and socket _meta is set', t => {
     return reply
   })
 
-  fastify.listen(0, (err, address) => {
+  fastify.listen({ port: 0 }, (err, address) => {
     t.error(err)
     t.teardown(() => fastify.close())
 

package/test/http2/closing.test.js

@@ -32,7 +32,7 @@ t.test('http/2 request while fastify closing', t => {
 
   fastify.get('/', () => Promise.resolve({}))
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -79,7 +79,7 @@ t.test('http/2 request while fastify closing - return503OnClosing: false', t =>
 
   fastify.get('/', () => Promise.resolve({}))
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -118,7 +118,7 @@ t.test('http/2 closes successfully with async await', async t => {
     http2: true
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   const url = getUrl(fastify)
   const session = await connect(url)
@@ -137,7 +137,7 @@ t.test('https/2 closes successfully with async await', async t => {
     }
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   const url = getUrl(fastify)
   const session = await connect(url)
@@ -160,7 +160,7 @@ t.test('http/2 server side session emits a timeout event', async t => {
     return {}
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   const url = getUrl(fastify)
   const session = await connect(url)

package/test/http2/constraint.test.js

@@ -46,7 +46,7 @@ test('A route supports host constraints under http2 protocol and secure connecti
     }
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 

package/test/http2/head.test.js

@@ -20,7 +20,7 @@ fastify.all('/', function (req, reply) {
   reply.code(200).send(msg)
 })
 
-fastify.listen(0, err => {
+fastify.listen({ port: 0 }, err => {
   t.error(err)
   fastify.server.unref()
 

package/test/http2/plain.test.js

@@ -24,7 +24,7 @@ fastify.get('/hostname', function (req, reply) {
   reply.code(200).send(req.hostname)
 })
 
-fastify.listen(0, err => {
+fastify.listen({ port: 0 }, err => {
   t.error(err)
   fastify.server.unref()
 

package/test/http2/secure-with-fallback.test.js

@@ -40,7 +40,7 @@ test('secure with fallback', (t) => {
     throw new Error('kaboom')
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 

package/test/http2/secure.test.js

@@ -33,7 +33,7 @@ test('secure', (t) => {
     reply.code(200).send({ proto: req.protocol })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 

package/test/http2/unknown-http-method.test.js

@@ -14,7 +14,7 @@ fastify.get('/', function (req, reply) {
   reply.code(200).send(msg)
 })
 
-fastify.listen(0, err => {
+fastify.listen({ port: 0 }, err => {
   t.error(err)
   fastify.server.unref()
 

package/test/https/custom-https-server.test.js

@@ -40,7 +40,7 @@ test('Should support a custom https server', async t => {
     reply.send({ hello: 'world' })
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   await new Promise((resolve, reject) => {
     sget({

package/test/https/https.test.js

@@ -32,7 +32,7 @@ test('https', (t) => {
     reply.code(200).send({ proto: req.protocol })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 

package/test/input-validation.js

@@ -134,7 +134,7 @@ module.exports.payloadMethod = function (method, t) {
     }
   })
 
-  fastify.listen(0, function (err) {
+  fastify.listen({ port: 0 }, function (err) {
     if (err) {
       t.error(err)
     }

package/test/internals/handleRequest.test.js

@@ -139,7 +139,7 @@ test('request should be defined in onSend Hook on post request with content type
   fastify.post('/', (request, reply) => {
     reply.send(200)
   })
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     fastify.server.unref()
     t.error(err)
     sget({
@@ -170,7 +170,7 @@ test('request should be defined in onSend Hook on post request with content type
   fastify.post('/', (request, reply) => {
     reply.send(200)
   })
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     fastify.server.unref()
     t.error(err)
     sget({
@@ -201,7 +201,7 @@ test('request should be defined in onSend Hook on options request with content t
   fastify.options('/', (request, reply) => {
     reply.send(200)
   })
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     fastify.server.unref()
     t.error(err)
     sget({

package/test/internals/initialConfig.test.js

@@ -308,7 +308,7 @@ test('Should not have issues when passing stream options to Pino.js', t => {
     })
   })
 
-  fastify.listen(0, localhost, err => {
+  fastify.listen({ port: 0, host: localhost }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -377,3 +377,11 @@ test('Fastify.initialConfig should accept the deprecated versioning option', t =
     t.end()
   })
 })
+
+test('pluginTimeout should be parsed correctly', t => {
+  const withDisabledTimeout = Fastify({ pluginTimeout: '0' })
+  t.equal(withDisabledTimeout.initialConfig.pluginTimeout, 0)
+  const withInvalidTimeout = Fastify({ pluginTimeout: undefined })
+  t.equal(withInvalidTimeout.initialConfig.pluginTimeout, 10000)
+  t.end()
+})

package/test/internals/logger.test.js

@@ -20,7 +20,7 @@ test('The logger should add a unique id for every request', t => {
     reply.send({ id: req.id })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     const queue = new Queue()
     for (let i = 0; i < 10; i++) {
@@ -53,7 +53,7 @@ test('The logger should reuse request id header for req.id', t => {
     reply.send({ id: req.id })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
 
     fastify.inject({

package/test/internals/reply.test.js

@@ -5,9 +5,8 @@ const test = t.test
 const sget = require('simple-get').concat
 const http = require('http')
 const NotFound = require('http-errors').NotFound
-const EventEmitter = require('events').EventEmitter
 const Reply = require('../../lib/reply')
-const { Writable } = require('stream')
+const { Readable, Writable } = require('stream')
 const {
   kReplyErrorHandlerCalled,
   kReplyHeaders,
@@ -55,30 +54,30 @@ test('Once called, Reply should return an object with methods', t => {
 test('reply.send will logStream error and destroy the stream', t => {
   t.plan(1)
   let destroyCalled
-  const payload = new EventEmitter()
+  const payload = new Readable({
+    read () {},
+    destroy (err, cb) {
+      destroyCalled = true
+      cb(err)
+    }
+  })
 
-  const response = {
+  const response = new Writable()
+  Object.assign(response, {
     setHeader: () => {},
     hasHeader: () => false,
     getHeader: () => undefined,
     writeHead: () => {},
-    end: () => {},
-    headersSent: true,
-    destroy: () => (destroyCalled = true),
-    on: () => {}
-  }
+    headersSent: true
+  })
 
   const log = {
     warn: () => {}
   }
 
-  Object.assign(payload, {
-    pipe: () => {},
-    destroy: () => {}
-  })
   const reply = new Reply(response, { context: { onSend: null } }, log)
   reply.send(payload)
-  payload.emit('error', new Error('stream error'))
+  payload.destroy(new Error('stream error'))
 
   t.equal(destroyCalled, true, 'Error not logged and not streamed')
 })
@@ -263,7 +262,7 @@ test('within an instance', t => {
     done()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -423,7 +422,7 @@ test('buffer without content type should send a application/octet-stream and raw
     reply.send(Buffer.alloc(1024))
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -448,7 +447,7 @@ test('buffer with content type should not send application/octet-stream', t => {
     reply.send(Buffer.alloc(1024))
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -476,7 +475,7 @@ test('stream with content type should not send application/octet-stream', t => {
     reply.header('Content-Type', 'text/plain').send(stream)
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -502,7 +501,7 @@ test('stream without content type should not send application/octet-stream', t =
     reply.send(stream)
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -537,7 +536,7 @@ test('stream using reply.raw.writeHead should return customize headers', t => {
     reply.send(stream)
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -561,7 +560,7 @@ test('plain string without content type should send a text/plain', t => {
     reply.send('hello world!')
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -585,7 +584,7 @@ test('plain string with content type should be sent unmodified', t => {
     reply.type('text/css').send('hello world!')
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -612,7 +611,7 @@ test('plain string with content type and custom serializer should be serialized'
       .send('hello world!')
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -636,7 +635,7 @@ test('plain string with content type application/json should NOT be serialized a
     reply.type('application/json').send('{"key": "hello world!"}')
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -689,7 +688,7 @@ test('plain string with custom json content type should NOT be serialized as jso
     })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -715,7 +714,7 @@ test('non-string with content type application/json SHOULD be serialized as json
     reply.type('application/json').send({ key: 'hello world!' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -764,7 +763,7 @@ test('non-string with custom json content type SHOULD be serialized as json', t
     })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -829,7 +828,7 @@ test('undefined payload should be sent as-is', t => {
     reply.code(204).send()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -874,7 +873,7 @@ test('for HEAD method, no body should be sent but content-length should be', t =
     reply.code(200).send(null)
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -921,7 +920,7 @@ test('reply.send(new NotFound()) should not invoke the 404 handler', t => {
     done()
   }, { prefix: '/prefixed' })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
 
     fastify.server.unref()
@@ -968,7 +967,7 @@ test('reply can set multiple instances of same header', t => {
       .send({})
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -995,7 +994,7 @@ test('reply.hasHeader returns correct values', t => {
     reply.send()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -1024,7 +1023,7 @@ test('reply.getHeader returns correct values', t => {
     reply.send()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -1094,7 +1093,7 @@ test('reply.removeHeader can remove the value', t => {
     reply.send()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -1121,7 +1120,7 @@ test('reply.header can reset the value', t => {
     reply.send()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -1150,7 +1149,7 @@ test('reply.hasHeader computes raw and fastify headers', t => {
     reply.send()
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
     sget({
@@ -1319,7 +1318,7 @@ test('reply.header setting multiple cookies as multiple Set-Cookie headers', t =
       .send({})
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -1692,7 +1691,7 @@ test('cannot set the replySerializer when the server is running', t => {
   const fastify = require('../..')()
   t.teardown(fastify.close.bind(fastify))
 
-  fastify.listen(err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     try {
       fastify.setReplySerializer(() => {})
@@ -1847,7 +1846,7 @@ test('redirect to an invalid URL should not crash the server', async t => {
     }
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   {
     const { response, body } = await doGet(`http://localhost:${fastify.server.address().port}/redirect?useCase=1`)
@@ -1893,7 +1892,7 @@ test('invalid response headers should not crash the server', async t => {
     }
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   const { response, body } = await doGet(`http://localhost:${fastify.server.address().port}/bad-headers`)
   t.equal(response.statusCode, 500)
@@ -1922,7 +1921,7 @@ test('invalid response headers when sending back an error', async t => {
     }
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   const { response, body } = await doGet(`http://localhost:${fastify.server.address().port}/bad-headers`)
   t.equal(response.statusCode, 500)
@@ -1956,7 +1955,7 @@ test('invalid response headers and custom error handler', async t => {
     reply.status(500).send({ ops: true })
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
 
   const { response, body } = await doGet(`http://localhost:${fastify.server.address().port}/bad-headers`)
   t.equal(response.statusCode, 500)