fastify 3.27.3 → 4.0.0-alpha.2

package/test/custom-querystring-parser.test.js

@@ -24,7 +24,7 @@ test('Custom querystring parser', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, (err, address) => {
+  fastify.listen({ port: 0 }, (err, address) => {
     t.error(err)
     t.teardown(() => fastify.close())
 
@@ -61,7 +61,7 @@ test('Custom querystring parser should be called also if there is nothing to par
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, (err, address) => {
+  fastify.listen({ port: 0 }, (err, address) => {
     t.error(err)
     t.teardown(() => fastify.close())
 
@@ -98,7 +98,7 @@ test('Querystring without value', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, (err, address) => {
+  fastify.listen({ port: 0 }, (err, address) => {
     t.error(err)
     t.teardown(() => fastify.close())
 

package/test/decorator.test.js

@@ -132,7 +132,7 @@ test('decorateReply inside register', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -180,7 +180,7 @@ test('decorateReply as plugin (inside .after)', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -228,7 +228,7 @@ test('decorateReply as plugin (outside .after)', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -274,7 +274,7 @@ test('decorateRequest inside register', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -322,7 +322,7 @@ test('decorateRequest as plugin (inside .after)', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -370,7 +370,7 @@ test('decorateRequest as plugin (outside .after)', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -764,7 +764,7 @@ test('decorate* should throw if called after ready', async t => {
     })
   })
 
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
   try {
     fastify.decorate('test', true)
     t.fail('should not decorate')
@@ -913,8 +913,7 @@ test('plugin required decorators', async t => {
       })
     },
     {
-      name: 'custom-plugin-one',
-      fastify: '3.x'
+      name: 'custom-plugin-one'
     }
   )
 
@@ -924,7 +923,6 @@ test('plugin required decorators', async t => {
     },
     {
       name: 'custom-plugin-two',
-      fastify: '3.x',
       dependencies: ['custom-plugin-one'],
       decorators: {
         request: ['someThing']
@@ -951,7 +949,7 @@ test('decorateRequest/decorateReply empty string', t => {
   })
   t.teardown(fastify.close.bind(fastify))
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -980,7 +978,7 @@ test('decorateRequest/decorateReply is undefined', t => {
   })
   t.teardown(fastify.close.bind(fastify))
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -1009,7 +1007,7 @@ test('decorateRequest/decorateReply is not set to a value', t => {
   })
   t.teardown(fastify.close.bind(fastify))
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 

package/test/delete.test.js

@@ -157,7 +157,7 @@ test('body - delete', t => {
   }
 })
 
-fastify.listen(0, err => {
+fastify.listen({ port: 0 }, err => {
   t.error(err)
   fastify.server.unref()
 
@@ -197,7 +197,7 @@ fastify.listen(0, err => {
       t.equal(response.statusCode, 400)
       t.same(JSON.parse(body), {
         error: 'Bad Request',
-        message: 'params.test should be integer',
+        message: 'params/test must be integer',
         statusCode: 400
       })
     })
@@ -232,7 +232,7 @@ fastify.listen(0, err => {
       t.equal(response.statusCode, 400)
       t.same(JSON.parse(body), {
         error: 'Bad Request',
-        message: "headers['x-test'] should be number",
+        message: 'headers/x-test must be number',
         statusCode: 400
       })
     })
@@ -261,7 +261,7 @@ fastify.listen(0, err => {
       t.equal(response.statusCode, 400)
       t.same(JSON.parse(body), {
         error: 'Bad Request',
-        message: 'querystring.hello should be integer',
+        message: 'querystring/hello must be integer',
         statusCode: 400
       })
     })
@@ -302,7 +302,7 @@ test('shorthand - delete with application/json Content-Type header and without b
   t.plan(4)
   const fastify = require('..')()
   fastify.delete('/', {}, (req, reply) => {
-    t.equal(req.body, null)
+    t.equal(req.body, undefined)
     reply.send(req.body)
   })
   fastify.inject({
@@ -313,6 +313,6 @@ test('shorthand - delete with application/json Content-Type header and without b
   }, (err, response) => {
     t.error(err)
     t.equal(response.statusCode, 200)
-    t.same(JSON.parse(response.payload), null)
+    t.same(response.payload.toString(), '')
   })
 })

package/test/encapsulated-error-handler.test.js

@@ -0,0 +1,50 @@
+'use strict'
+
+const { test } = require('tap')
+const Fastify = require('..')
+
+test('encapuslates an error handler', async t => {
+  t.plan(3)
+
+  const fastify = Fastify()
+  fastify.register(async function (fastify) {
+    fastify.setErrorHandler(async function a (err) {
+      t.equal(err.message, 'kaboom')
+      throw new Error('caught')
+    })
+    fastify.get('/encapsulated', async () => { throw new Error('kaboom') })
+  })
+
+  fastify.setErrorHandler(async function b (err) {
+    t.equal(err.message, 'caught')
+    throw new Error('wrapped')
+  })
+
+  const res = await fastify.inject('/encapsulated')
+  t.equal(res.json().message, 'wrapped')
+})
+
+test('onError hook nested', async t => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  fastify.register(async function (fastify) {
+    fastify.setErrorHandler(async function a (err) {
+      t.equal(err.message, 'kaboom')
+      throw new Error('caught')
+    })
+    fastify.get('/encapsulated', async () => { throw new Error('kaboom') })
+  })
+
+  fastify.setErrorHandler(async function b (err) {
+    t.equal(err.message, 'caught')
+    throw new Error('wrapped')
+  })
+
+  fastify.addHook('onError', async function (request, reply, err) {
+    t.equal(err.message, 'kaboom')
+  })
+
+  const res = await fastify.inject('/encapsulated')
+  t.equal(res.json().message, 'wrapped')
+})

package/test/esm/index.test.js

@@ -3,20 +3,6 @@
 const t = require('tap')
 const semver = require('semver')
 
-if (semver.lt(process.versions.node, '13.3.0')) {
-  t.skip('Skip esm because Node version <= 13.3.0')
-} else {
-  // Node v8 throw a `SyntaxError: Unexpected token import`
-  // even if this branch is never touch in the code,
-  // by using `eval` we can avoid this issue.
-  // eslint-disable-next-line
-  new Function('module', 'return import(module)')('./esm.mjs').catch((err) => {
-    process.nextTick(() => {
-      throw err
-    })
-  })
-}
-
 if (semver.lt(process.versions.node, '14.13.0')) {
   t.skip('Skip named exports because Node version < 14.13.0')
 } else {

package/test/fastify-instance.test.js

@@ -70,8 +70,8 @@ test('fastify instance get invalid ajv options.plugins', t => {
 test('fastify instance should contain default errorHandler', t => {
   t.plan(3)
   const fastify = Fastify()
-  t.ok(fastify[kErrorHandler] instanceof Function)
-  t.same(fastify.errorHandler, fastify[kErrorHandler])
+  t.ok(fastify[kErrorHandler].func instanceof Function)
+  t.same(fastify.errorHandler, fastify[kErrorHandler].func)
   t.same(Object.getOwnPropertyDescriptor(fastify, 'errorHandler').set, undefined)
 })
 
@@ -94,6 +94,6 @@ test('errorHandler in plugin should be separate from the external one', async t
 
   await fastify.ready()
 
-  t.ok(fastify[kErrorHandler] instanceof Function)
-  t.same(fastify.errorHandler, fastify[kErrorHandler])
+  t.ok(fastify[kErrorHandler].func instanceof Function)
+  t.same(fastify.errorHandler, fastify[kErrorHandler].func)
 })

package/test/fluent-schema.test.js

@@ -34,7 +34,7 @@ test('use fluent-json-schema object', t => {
   }, (err, res) => {
     t.error(err)
     t.equal(res.statusCode, 400)
-    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'params.id should be >= 42' })
+    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'params/id must be >= 42' })
   })
 
   // check header
@@ -47,7 +47,7 @@ test('use fluent-json-schema object', t => {
   }, (err, res) => {
     t.error(err)
     t.equal(res.statusCode, 400)
-    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'headers[\'x-custom\'] should match format "email"' })
+    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'headers/x-custom must match format "email"' })
   })
 
   // check query
@@ -60,7 +60,7 @@ test('use fluent-json-schema object', t => {
   }, (err, res) => {
     t.error(err)
     t.equal(res.statusCode, 400)
-    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'querystring should have required property \'surname\'' })
+    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'querystring must have required property \'surname\'' })
   })
 
   // check body
@@ -73,7 +73,7 @@ test('use fluent-json-schema object', t => {
   }, (err, res) => {
     t.error(err)
     t.equal(res.statusCode, 400)
-    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'body.name should be string' })
+    t.same(res.json(), { statusCode: 400, error: 'Bad Request', message: 'body/name must be string' })
   })
 
   // check response

package/test/genReqId.test.js

@@ -17,7 +17,7 @@ test('Should accept a custom genReqId function', t => {
     reply.send({ id: req.id })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.inject({
       method: 'GET',

package/test/get.test.js

@@ -203,7 +203,7 @@ test('send a falsy boolean', t => {
   }
 })
 
-fastify.listen(0, err => {
+fastify.listen({ port: 0 }, err => {
   t.error(err)
   fastify.server.unref()
 
@@ -243,7 +243,7 @@ fastify.listen(0, err => {
       t.equal(response.statusCode, 400)
       t.same(JSON.parse(body), {
         error: 'Bad Request',
-        message: 'params.test should be integer',
+        message: 'params/test must be integer',
         statusCode: 400
       })
     })
@@ -280,7 +280,7 @@ fastify.listen(0, err => {
       t.equal(response.statusCode, 400)
       t.same(JSON.parse(body), {
         error: 'Bad Request',
-        message: "headers['x-test'] should be number",
+        message: 'headers/x-test must be number',
         statusCode: 400
       })
     })
@@ -309,7 +309,7 @@ fastify.listen(0, err => {
       t.equal(response.statusCode, 400)
       t.same(JSON.parse(body), {
         error: 'Bad Request',
-        message: 'querystring.hello should be integer',
+        message: 'querystring/hello must be integer',
         statusCode: 400
       })
     })

package/test/handler-context.test.js

@@ -32,7 +32,7 @@ test('handlers receive correct `this` context', (t) => {
     reply.send()
   })
 
-  instance.listen(0, (err) => {
+  instance.listen({ port: 0 }, (err) => {
     instance.server.unref()
     if (err) t.threw(err)
     t.ok(instance.foo)
@@ -55,7 +55,7 @@ test('handlers have access to the internal context', (t) => {
     reply.send()
   })
 
-  instance.listen(0, (err) => {
+  instance.listen({ port: 0 }, (err) => {
     instance.server.unref()
     if (err) t.threw(err)
     http.get(getUrl(instance), () => {}).on('error', t.threw)

package/test/head.test.js

@@ -92,7 +92,7 @@ test('missing schema - head', t => {
   }
 })
 
-fastify.listen(0, err => {
+fastify.listen({ port: 0 }, err => {
   t.error(err)
   fastify.server.unref()
 

package/test/helper.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const sget = require('simple-get').concat
+const dns = require('dns').promises
 const stream = require('stream')
 const symbols = require('../lib/symbols')
 
@@ -16,7 +17,7 @@ module.exports.payloadMethod = function (method, t, isSetErrorHandler = false) {
   if (isSetErrorHandler) {
     fastify.setErrorHandler(function (err, request, reply) {
       t.type(request, 'object')
-      t.type(request, fastify[symbols.kRequest])
+      t.type(request, fastify[symbols.kRequest].parent)
       reply
         .code(err.statusCode)
         .type('application/json; charset=utf-8')
@@ -91,7 +92,7 @@ module.exports.payloadMethod = function (method, t, isSetErrorHandler = false) {
     }
   })
 
-  fastify.listen(0, function (err) {
+  fastify.listen({ port: 0 }, function (err) {
     if (err) {
       t.error(err)
       return
@@ -189,7 +190,7 @@ module.exports.payloadMethod = function (method, t, isSetErrorHandler = false) {
       }, (err, response, body) => {
         t.error(err)
         t.equal(response.statusCode, 200)
-        t.equal(JSON.parse(body.toString()), null)
+        t.equal(body.toString(), '')
       })
 
       // Must use inject to make a request without a Content-Length header
@@ -199,7 +200,7 @@ module.exports.payloadMethod = function (method, t, isSetErrorHandler = false) {
       }, (err, res) => {
         t.error(err)
         t.equal(res.statusCode, 200)
-        t.equal(JSON.parse(res.payload), null)
+        t.equal(res.payload.toString(), '')
       })
     })
 
@@ -419,3 +420,17 @@ module.exports.payloadMethod = function (method, t, isSetErrorHandler = false) {
     })
   })
 }
+
+module.exports.getLoopbackHost = async () => {
+  let localhostForURL
+
+  const lookup = await dns.lookup('localhost')
+  const localhost = lookup.address
+  if (lookup.family === 6) {
+    localhostForURL = `[${lookup.address}]`
+  } else {
+    localhostForURL = localhost
+  }
+
+  return [localhost, localhostForURL]
+}

package/test/hooks-async.test.js

@@ -13,7 +13,7 @@ process.removeAllListeners('warning')
 test('async hooks', t => {
   t.plan(21)
 
-  const fastify = Fastify()
+  const fastify = Fastify({ exposeHeadRoutes: false })
   fastify.addHook('onRequest', async function (request, reply) {
     await sleep(1)
     request.test = 'the request is coming'
@@ -56,7 +56,7 @@ test('async hooks', t => {
     reply.code(200).send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen({ port: 0 }, err => {
     t.error(err)
     fastify.server.unref()
 
@@ -132,7 +132,7 @@ test('onRequest hooks should be able to block a request', t => {
   const fastify = Fastify()
 
   fastify.addHook('onRequest', async (req, reply) => {
-    reply.send('hello')
+    await reply.send('hello')
   })
 
   fastify.addHook('onRequest', async (req, reply) => {
@@ -194,37 +194,6 @@ test('preParsing hooks should be able to modify the payload', t => {
   })
 })
 
-test('preParsing hooks can completely ignore the payload - deprecated syntax', t => {
-  t.plan(5)
-  const fastify = Fastify()
-
-  process.on('warning', onWarning)
-  function onWarning (warning) {
-    t.equal(warning.name, 'FastifyDeprecation')
-    t.equal(warning.code, 'FSTDEP004')
-  }
-
-  fastify.addHook('preParsing', async (req, reply) => {
-
-  })
-
-  fastify.post('/', function (request, reply) {
-    reply.send(request.body)
-  })
-
-  fastify.inject({
-    method: 'POST',
-    url: '/',
-    payload: { hello: 'world' }
-  }, (err, res) => {
-    t.error(err)
-    t.equal(res.statusCode, 200)
-    t.same(JSON.parse(res.payload), { hello: 'world' })
-
-    process.removeListener('warning', onWarning)
-  })
-})
-
 test('preParsing hooks should handle errors', t => {
   t.plan(3)
   const fastify = Fastify()
@@ -255,7 +224,7 @@ test('preHandler hooks should be able to block a request', t => {
   const fastify = Fastify()
 
   fastify.addHook('preHandler', async (req, reply) => {
-    reply.send('hello')
+    await reply.send('hello')
   })
 
   fastify.addHook('preHandler', async (req, reply) => {
@@ -289,7 +258,7 @@ test('preValidation hooks should be able to block a request', t => {
   const fastify = Fastify()
 
   fastify.addHook('preValidation', async (req, reply) => {
-    reply.send('hello')
+    await reply.send('hello')
   })
 
   fastify.addHook('preValidation', async (req, reply) => {
@@ -414,7 +383,7 @@ test('preValidation hooks should handle throwing null', t => {
 
   fastify.setErrorHandler(async (error, request, reply) => {
     t.ok(error instanceof Error)
-    reply.send(error)
+    await reply.send(error)
   })
 
   fastify.addHook('preValidation', async () => {
@@ -465,7 +434,7 @@ test('onRequest hooks should be able to block a request (last hook)', t => {
   const fastify = Fastify()
 
   fastify.addHook('onRequest', async (req, reply) => {
-    reply.send('hello')
+    await reply.send('hello')
   })
 
   fastify.addHook('preHandler', async (req, reply) => {
@@ -499,7 +468,7 @@ test('preHandler hooks should be able to block a request (last hook)', t => {
   const fastify = Fastify()
 
   fastify.addHook('preHandler', async (req, reply) => {
-    reply.send('hello')
+    await reply.send('hello')
   })
 
   fastify.addHook('onSend', async (req, reply, payload) => {
@@ -533,8 +502,9 @@ test('onRequest respond with a stream', t => {
       const stream = fs.createReadStream(process.cwd() + '/test/stream.test.js', 'utf8')
       // stream.pipe(res)
       // res.once('finish', resolve)
-      reply.send(stream)
-      reply.raw.once('finish', () => resolve())
+      reply.send(stream).then(() => {
+        reply.raw.once('finish', () => resolve())
+      })
     })
   })
 
@@ -580,14 +550,11 @@ test('preHandler respond with a stream', t => {
   const order = [1, 2]
 
   fastify.addHook('preHandler', async (req, reply) => {
-    return new Promise((resolve, reject) => {
-      const stream = fs.createReadStream(process.cwd() + '/test/stream.test.js', 'utf8')
-      reply.send(stream)
-      reply.raw.once('finish', () => {
-        t.equal(order.shift(), 2)
-        resolve()
-      })
+    const stream = fs.createReadStream(process.cwd() + '/test/stream.test.js', 'utf8')
+    reply.raw.once('finish', () => {
+      t.equal(order.shift(), 2)
     })
+    return reply.send(stream)
   })
 
   fastify.addHook('preHandler', async (req, reply) => {

package/test/hooks.on-ready.test.js

@@ -112,7 +112,7 @@ t.test('listen and onReady order', async t => {
 
   await fastify.ready()
   t.pass('trigger the onReady')
-  await fastify.listen(0)
+  await fastify.listen({ port: 0 })
   t.pass('do not trigger the onReady')
 
   await fastify.close()
@@ -268,7 +268,7 @@ t.test('onReady can not add decorators or application hooks', t => {
 })
 
 t.test('onReady cannot add lifecycle hooks', t => {
-  t.plan(4)
+  t.plan(5)
   const fastify = Fastify()
 
   fastify.addHook('onReady', function (done) {
@@ -277,7 +277,9 @@ t.test('onReady cannot add lifecycle hooks', t => {
       fastify.addHook('onRequest', (request, reply, done) => {})
     } catch (error) {
       t.ok(error)
-      t.equal(error.message, 'root plugin has already booted')
+      t.equal(error.message, 'Root plugin has already booted')
+      // TODO: look where the error pops up
+      t.equal(error.code, 'AVV_ERR_PLUGIN_NOT_VALID')
       done(error)
     }
   })
@@ -300,7 +302,7 @@ t.test('onReady throw loading error', t => {
 })
 
 t.test('onReady does not call done', t => {
-  t.plan(3)
+  t.plan(6)
   const fastify = Fastify({ pluginTimeout: 500 })
 
   fastify.addHook('onReady', function (done) {
@@ -310,7 +312,10 @@ t.test('onReady does not call done', t => {
 
   fastify.ready(err => {
     t.ok(err)
-    t.equal(err.code, 'ERR_AVVIO_READY_TIMEOUT')
+    t.equal(err.message, "A callback for 'onReady' hook timed out. You may have forgotten to call 'done' function or to resolve a Promise")
+    t.equal(err.code, 'FST_ERR_HOOK_TIMEOUT')
+    t.ok(err.cause)
+    t.equal(err.cause.code, 'AVV_ERR_READY_TIMEOUT')
   })
 })