fastify 3.26.0 → 4.0.0-alpha.1

package/test/http2/closing.test.js

@@ -3,7 +3,6 @@
 const t = require('tap')
 const Fastify = require('../..')
 const http2 = require('http2')
-const semver = require('semver')
 const { promisify } = require('util')
 const connect = promisify(http2.connect)
 const { once } = require('events')
@@ -37,8 +36,7 @@ t.test('http/2 request while fastify closing', t => {
     t.error(err)
     fastify.server.unref()
 
-    // Skipped because there is likely a bug on Node 8.
-    t.test('return 200', { skip: semver.lt(process.versions.node, '10.15.0') }, t => {
+    t.test('return 200', t => {
       const url = getUrl(fastify)
       const session = http2.connect(url, function () {
         this.request({
@@ -85,8 +83,7 @@ t.test('http/2 request while fastify closing - return503OnClosing: false', t =>
     t.error(err)
     fastify.server.unref()
 
-    // Skipped because there is likely a bug on Node 8.
-    t.test('return 200', { skip: semver.lt(process.versions.node, '10.15.0') }, t => {
+    t.test('return 200', t => {
       const url = getUrl(fastify)
       const session = http2.connect(url, function () {
         this.request({
@@ -115,8 +112,7 @@ t.test('http/2 request while fastify closing - return503OnClosing: false', t =>
   })
 })
 
-// Skipped because there is likely a bug on Node 8.
-t.test('http/2 closes successfully with async await', { skip: semver.lt(process.versions.node, '10.15.0') }, async t => {
+t.test('http/2 closes successfully with async await', async t => {
   const fastify = Fastify({
     http2SessionTimeout: 100,
     http2: true
@@ -131,8 +127,7 @@ t.test('http/2 closes successfully with async await', { skip: semver.lt(process.
   await fastify.close()
 })
 
-// Skipped because there is likely a bug on Node 8.
-t.test('https/2 closes successfully with async await', { skip: semver.lt(process.versions.node, '10.15.0') }, async t => {
+t.test('https/2 closes successfully with async await', async t => {
   const fastify = Fastify({
     http2SessionTimeout: 100,
     http2: true,
@@ -151,8 +146,7 @@ t.test('https/2 closes successfully with async await', { skip: semver.lt(process
   await fastify.close()
 })
 
-// Skipped because there is likely a bug on Node 8.
-t.test('http/2 server side session emits a timeout event', { skip: semver.lt(process.versions.node, '10.15.0') }, async t => {
+t.test('http/2 server side session emits a timeout event', async t => {
   let _resolve
   const p = new Promise((resolve) => { _resolve = resolve })
 

package/test/http2/unknown-http-method.test.js

@@ -6,15 +6,9 @@ const Fastify = require('../..')
 const h2url = require('h2url')
 const msg = { hello: 'world' }
 
-let fastify
-try {
-  fastify = Fastify({
-    http2: true
-  })
-  t.pass('http2 successfully loaded')
-} catch (e) {
-  t.fail('http2 loading failed', e)
-}
+const fastify = Fastify({
+  http2: true
+})
 
 fastify.get('/', function (req, reply) {
   reply.code(200).send(msg)

package/test/https/custom-https-server.test.js

@@ -5,15 +5,18 @@ const test = t.test
 const Fastify = require('../..')
 const https = require('https')
 const sget = require('simple-get').concat
+const dns = require('dns').promises
 
 const { buildCertificate } = require('../build-certificate')
 t.before(buildCertificate)
 
-test('Should support a custom https server', t => {
-  t.plan(6)
+test('Should support a custom https server', async t => {
+  const localAddresses = await dns.lookup('localhost', { all: true })
+
+  t.plan(localAddresses.length + 3)
 
   const serverFactory = (handler, opts) => {
-    t.ok(opts.serverFactory)
+    t.ok(opts.serverFactory, 'it is called twice for every HOST interface')
 
     const options = {
       key: global.context.key,
@@ -37,17 +40,20 @@ test('Should support a custom https server', t => {
     reply.send({ hello: 'world' })
   })
 
-  fastify.listen(0, err => {
-    t.error(err)
+  await fastify.listen(0)
 
+  await new Promise((resolve, reject) => {
     sget({
       method: 'GET',
       url: 'https://localhost:' + fastify.server.address().port,
       rejectUnauthorized: false
     }, (err, response, body) => {
-      t.error(err)
+      if (err) {
+        return reject(err)
+      }
       t.equal(response.statusCode, 200)
       t.same(JSON.parse(body), { hello: 'world' })
+      resolve()
     })
   })
 })

package/test/inject.test.js

@@ -186,7 +186,7 @@ test('inject post request', t => {
   fastify.inject({
     method: 'POST',
     url: '/',
-    payload: payload
+    payload
   }, (err, res) => {
     t.error(err)
     t.same(payload, JSON.parse(res.payload))

package/test/input-validation.js

@@ -3,7 +3,7 @@
 
 const sget = require('simple-get').concat
 const Ajv = require('ajv')
-const Joi = require('@hapi/joi')
+const Joi = require('joi')
 const yup = require('yup')
 
 module.exports.payloadMethod = function (method, t) {
@@ -182,7 +182,7 @@ module.exports.payloadMethod = function (method, t) {
         t.equal(response.statusCode, 400)
         t.same(body, {
           error: 'Bad Request',
-          message: 'body.hello should be integer',
+          message: 'body/hello must be integer',
           statusCode: 400
         })
       })

package/test/internals/all.test.js

@@ -19,7 +19,7 @@ test('fastify.all should add all the methods to the same url', t => {
   function injectRequest (method) {
     const options = {
       url: '/',
-      method: method
+      method
     }
 
     if (method === 'POST' || method === 'PUT' || method === 'PATCH') {
@@ -29,7 +29,7 @@ test('fastify.all should add all the methods to the same url', t => {
     fastify.inject(options, (err, res) => {
       t.error(err)
       const payload = JSON.parse(res.payload)
-      t.same(payload, { method: method })
+      t.same(payload, { method })
     })
   }
 })

package/test/internals/contentTypeParser.test.js

@@ -32,8 +32,8 @@ test('rawBody function', t => {
 
   res.log = { error: () => { }, info: () => { } }
   const context = {
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preHandler: [],
     onSend: [],
     _parserOptions: {
@@ -85,8 +85,8 @@ test('Should support Webpack and faux modules', t => {
 
   res.log = { error: () => { }, info: () => { } }
   const context = {
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preHandler: [],
     onSend: [],
     _parserOptions: {

package/test/internals/handleRequest.test.js

@@ -1,7 +1,6 @@
 'use strict'
 
 const { test } = require('tap')
-const semver = require('semver')
 const handleRequest = require('../../lib/handleRequest')
 const internals = require('../../lib/handleRequest')[Symbol.for('internals')]
 const Request = require('../../lib/request')
@@ -40,13 +39,8 @@ test('handleRequest function - invoke with error', t => {
 })
 
 test('handler function - invalid schema', t => {
-  t.plan(2)
+  t.plan(1)
   const res = {}
-  res.end = () => {
-    t.equal(res.statusCode, 400)
-    t.pass()
-  }
-  res.writeHead = () => {}
   res.log = { error: () => {}, info: () => {} }
   const context = {
     config: {
@@ -61,9 +55,10 @@ test('handler function - invalid schema', t => {
         }
       }
     },
+    errorHandler: { func: () => { t.pass('errorHandler called') } },
     handler: () => {},
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: [],
     preHandler: [],
     onSend: [],
@@ -93,8 +88,8 @@ test('handler function - reply', t => {
       reply.code(204)
       reply.send(undefined)
     },
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: [],
     preHandler: [],
     onSend: [],
@@ -108,39 +103,7 @@ test('handler function - preValidationCallback with finished response', t => {
   t.plan(0)
   const res = {}
   // Be sure to check only `writableEnded` where is available
-  if (semver.gte(process.versions.node, '12.9.0')) {
-    res.writableEnded = true
-  } else {
-    res.writable = false
-    res.finished = true
-  }
-  res.end = () => {
-    t.fail()
-  }
-  res.writeHead = () => {}
-  const context = {
-    handler: (req, reply) => {
-      t.fail()
-      reply.send(undefined)
-    },
-    Reply: Reply,
-    Request: Request,
-    preValidation: null,
-    preHandler: [],
-    onSend: [],
-    onError: []
-  }
-  buildSchema(context, schemaValidator)
-  internals.handler({}, new Reply(res, { context }))
-})
-
-test('handler function - preValidationCallback with finished response (< v12.9.0)', t => {
-  t.plan(0)
-  const res = {}
-  // Be sure to check only `writableEnded` where is available
-  res.writable = false
-  res.finished = true
-
+  res.writableEnded = true
   res.end = () => {
     t.fail()
   }
@@ -150,8 +113,8 @@ test('handler function - preValidationCallback with finished response (< v12.9.0
       t.fail()
       reply.send(undefined)
     },
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: null,
     preHandler: [],
     onSend: [],

package/test/internals/initialConfig.test.js

@@ -2,6 +2,7 @@
 
 const { test, before } = require('tap')
 const Fastify = require('../..')
+const helper = require('../helper')
 const http = require('http')
 const pino = require('pino')
 const split = require('split2')
@@ -9,10 +10,17 @@ const deepClone = require('rfdc')({ circles: true, proto: false })
 const { deepFreezeObject } = require('../../lib/initialConfigValidation').utils
 
 const { buildCertificate } = require('../build-certificate')
-before(buildCertificate)
 
 process.removeAllListeners('warning')
 
+let localhost
+let localhostForURL
+
+before(async function () {
+  await buildCertificate();
+  [localhost, localhostForURL] = await helper.getLoopbackHost()
+})
+
 test('Fastify.initialConfig is an object', t => {
   t.plan(1)
   t.type(Fastify().initialConfig, 'object')
@@ -23,7 +31,8 @@ test('without options passed to Fastify, initialConfig should expose default val
 
   const fastifyDefaultOptions = {
     connectionTimeout: 0,
-    keepAliveTimeout: 5000,
+    keepAliveTimeout: 72000,
+    forceCloseConnections: false,
     maxRequestsPerSocket: 0,
     requestTimeout: 0,
     bodyLimit: 1024 * 1024,
@@ -37,7 +46,8 @@ test('without options passed to Fastify, initialConfig should expose default val
     pluginTimeout: 10000,
     requestIdHeader: 'request-id',
     requestIdLogLabel: 'reqId',
-    http2SessionTimeout: 5000
+    http2SessionTimeout: 72000,
+    exposeHeadRoutes: true
   }
 
   t.same(Fastify().initialConfig, fastifyDefaultOptions)
@@ -81,7 +91,7 @@ test('Fastify.initialConfig should expose all options', t => {
     ignoreTrailingSlash: true,
     maxParamLength: 200,
     connectionTimeout: 0,
-    keepAliveTimeout: 5000,
+    keepAliveTimeout: 72000,
     bodyLimit: 1049600,
     onProtoPoisoning: 'remove',
     serverFactory,
@@ -103,11 +113,11 @@ test('Fastify.initialConfig should expose all options', t => {
 
   const fastify = Fastify(options)
   t.equal(fastify.initialConfig.http2, true)
-  t.equal(fastify.initialConfig.https, true)
+  t.equal(fastify.initialConfig.https, true, 'for security reason the key cert is hidden')
   t.equal(fastify.initialConfig.ignoreTrailingSlash, true)
   t.equal(fastify.initialConfig.maxParamLength, 200)
   t.equal(fastify.initialConfig.connectionTimeout, 0)
-  t.equal(fastify.initialConfig.keepAliveTimeout, 5000)
+  t.equal(fastify.initialConfig.keepAliveTimeout, 72000)
   t.equal(fastify.initialConfig.bodyLimit, 1049600)
   t.equal(fastify.initialConfig.onProtoPoisoning, 'remove')
   t.equal(fastify.initialConfig.caseSensitive, true)
@@ -157,10 +167,19 @@ test('We must avoid shallow freezing and ensure that the whole object is freezed
     t.type(error, TypeError)
     t.equal(error.message, "Cannot assign to read only property 'allowHTTP1' of object '#<Object>'")
     t.ok(error.stack)
-    t.pass()
+    t.same(fastify.initialConfig.https, {
+      allowHTTP1: true
+    }, 'key cert removed')
   }
 })
 
+test('https value check', t => {
+  t.plan(1)
+
+  const fastify = Fastify({})
+  t.notOk(fastify.initialConfig.https)
+})
+
 test('Return an error if options do not match the validation schema', t => {
   t.plan(6)
 
@@ -171,7 +190,7 @@ test('Return an error if options do not match the validation schema', t => {
   } catch (error) {
     t.type(error, Error)
     t.equal(error.name, 'FastifyError')
-    t.equal(error.message, 'Invalid initialization options: \'["should be boolean"]\'')
+    t.equal(error.message, 'Invalid initialization options: \'["must be boolean"]\'')
     t.equal(error.code, 'FST_ERR_INIT_OPTS_INVALID')
     t.ok(error.stack)
     t.pass()
@@ -241,7 +260,8 @@ test('Should not have issues when passing stream options to Pino.js', t => {
     t.type(fastify, 'object')
     t.same(fastify.initialConfig, {
       connectionTimeout: 0,
-      keepAliveTimeout: 5000,
+      keepAliveTimeout: 72000,
+      forceCloseConnections: false,
       maxRequestsPerSocket: 0,
       requestTimeout: 0,
       bodyLimit: 1024 * 1024,
@@ -255,7 +275,8 @@ test('Should not have issues when passing stream options to Pino.js', t => {
       pluginTimeout: 10000,
       requestIdHeader: 'request-id',
       requestIdLogLabel: 'reqId',
-      http2SessionTimeout: 5000
+      http2SessionTimeout: 72000,
+      exposeHeadRoutes: true
     })
   } catch (error) {
     t.fail()
@@ -287,11 +308,11 @@ test('Should not have issues when passing stream options to Pino.js', t => {
     })
   })
 
-  fastify.listen(0, err => {
+  fastify.listen(0, localhost, err => {
     t.error(err)
     fastify.server.unref()
 
-    http.get('http://localhost:' + fastify.server.address().port)
+    http.get(`http://${localhostForURL}:${fastify.server.address().port}`)
   })
 })
 

package/test/internals/logger.test.js

@@ -103,7 +103,7 @@ test('The logger should error if both stream and file destination are given', t
     Fastify({
       logger: {
         level: 'info',
-        stream: stream,
+        stream,
         file: '/test'
       }
     })