fastify 3.25.3 → 3.27.2

package/test/close.test.js

@@ -215,7 +215,7 @@ t.test('Current opened connection should continue to work after closing and retu
     t.error(err)
 
     const port = fastify.server.address().port
-    const client = net.createConnection({ port: port }, () => {
+    const client = net.createConnection({ port }, () => {
       client.write('GET / HTTP/1.1\r\n\r\n')
 
       client.once('data', data => {
@@ -291,3 +291,41 @@ test('Cannot be reopened the closed server has listen callback', async t => {
     t.ok(err)
   })
 })
+
+test('shutsdown while keep-alive connections are active (non-async)', t => {
+  t.plan(5)
+
+  const timeoutTime = 2 * 60 * 1000
+  const fastify = Fastify({ forceCloseConnections: true })
+
+  fastify.server.setTimeout(timeoutTime)
+  fastify.server.keepAliveTimeout = timeoutTime
+
+  fastify.get('/', (req, reply) => {
+    reply.send({ hello: 'world' })
+  })
+
+  fastify.listen(0, (err, address) => {
+    t.error(err)
+
+    const client = new Client(
+      'http://localhost:' + fastify.server.address().port,
+      { keepAliveTimeout: 1 * 60 * 1000 }
+    )
+    client.request({ path: '/', method: 'GET' }, (err, response) => {
+      t.error(err)
+      t.equal(client.closed, false)
+
+      fastify.close((err) => {
+        t.error(err)
+
+        // Due to the nature of the way we reap these keep-alive connections,
+        // there hasn't been enough time before the server fully closed in order
+        // for the client to have seen the socket get destroyed. The mere fact
+        // that we have reached this callback is enough indication that the
+        // feature being tested works as designed.
+        t.equal(client.closed, false)
+      })
+    })
+  })
+})

package/test/context-config.test.js

@@ -29,7 +29,7 @@ test('config', t => {
     method: 'GET',
     url: '/route',
     schema: schema.schema,
-    handler: handler,
+    handler,
     config: Object.assign({}, schema.config)
   })
 
@@ -37,7 +37,7 @@ test('config', t => {
     method: 'GET',
     url: '/no-config',
     schema: schema.schema,
-    handler: handler
+    handler
   })
 
   fastify.inject({
@@ -81,7 +81,7 @@ test('config with exposeHeadRoutes', t => {
     method: 'GET',
     url: '/route',
     schema: schema.schema,
-    handler: handler,
+    handler,
     config: Object.assign({}, schema.config)
   })
 
@@ -89,7 +89,7 @@ test('config with exposeHeadRoutes', t => {
     method: 'GET',
     url: '/no-config',
     schema: schema.schema,
-    handler: handler
+    handler
   })
 
   fastify.inject({

package/test/custom-parser.test.js

@@ -1314,9 +1314,10 @@ test('contentTypeParser should add a custom parser with RegExp value', t => {
   })
 })
 
-test('contentTypeParser should add multiple custom parsers with RegExp values', t => {
-  t.plan(10)
+test('contentTypeParser should add multiple custom parsers with RegExp values', async t => {
+  t.plan(6)
   const fastify = Fastify()
+  t.teardown(fastify.close.bind(fastify))
 
   fastify.post('/', (req, reply) => {
     reply.send(req.body)
@@ -1340,48 +1341,46 @@ test('contentTypeParser should add multiple custom parsers with RegExp values',
     })
   })
 
-  fastify.listen(0, err => {
-    t.error(err)
+  await fastify.ready()
 
-    sget({
+  {
+    const response = await fastify.inject({
       method: 'POST',
-      url: 'http://localhost:' + fastify.server.address().port,
-      body: '{"hello":"world"}',
+      path: '/',
+      payload: '{"hello":"world"}',
       headers: {
         'Content-Type': 'application/vnd.hello+json'
       }
-    }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.same(body.toString(), JSON.stringify({ hello: 'world' }))
     })
+    t.equal(response.statusCode, 200)
+    t.same(response.payload.toString(), '{"hello":"world"}')
+  }
 
-    sget({
+  {
+    const response = await fastify.inject({
       method: 'POST',
-      url: 'http://localhost:' + fastify.server.address().port,
-      body: '{"hello":"world"}',
+      path: '/',
+      payload: '{"hello":"world"}',
       headers: {
         'Content-Type': 'application/test+xml'
       }
-    }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.same(body.toString(), 'xml')
     })
+    t.equal(response.statusCode, 200)
+    t.same(response.payload.toString(), 'xml')
+  }
 
-    sget({
-      method: 'POST',
-      url: 'http://localhost:' + fastify.server.address().port,
-      body: 'abcdefg',
-      headers: {
-        'Content-Type': 'application/+myExtension'
-      }
-    }, (err, response, body) => {
-      t.error(err)
-      t.equal(response.statusCode, 200)
-      t.same(body.toString(), 'abcdefgmyExtension')
-      fastify.close()
-    })
+  await fastify.inject({
+    method: 'POST',
+    path: '/',
+    payload: 'abcdefg',
+    headers: {
+      'Content-Type': 'application/+myExtension'
+    }
+  }).then((response) => {
+    t.equal(response.statusCode, 200)
+    t.same(response.payload.toString(), 'abcdefgmyExtension')
+  }).catch((err) => {
+    t.error(err)
   })
 })
 

package/test/inject.test.js

@@ -186,7 +186,7 @@ test('inject post request', t => {
   fastify.inject({
     method: 'POST',
     url: '/',
-    payload: payload
+    payload
   }, (err, res) => {
     t.error(err)
     t.same(payload, JSON.parse(res.payload))

package/test/internals/all.test.js

@@ -19,7 +19,7 @@ test('fastify.all should add all the methods to the same url', t => {
   function injectRequest (method) {
     const options = {
       url: '/',
-      method: method
+      method
     }
 
     if (method === 'POST' || method === 'PUT' || method === 'PATCH') {
@@ -29,7 +29,7 @@ test('fastify.all should add all the methods to the same url', t => {
     fastify.inject(options, (err, res) => {
       t.error(err)
       const payload = JSON.parse(res.payload)
-      t.same(payload, { method: method })
+      t.same(payload, { method })
     })
   }
 })

package/test/internals/contentTypeParser.test.js

@@ -32,8 +32,8 @@ test('rawBody function', t => {
 
   res.log = { error: () => { }, info: () => { } }
   const context = {
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preHandler: [],
     onSend: [],
     _parserOptions: {
@@ -85,8 +85,8 @@ test('Should support Webpack and faux modules', t => {
 
   res.log = { error: () => { }, info: () => { } }
   const context = {
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preHandler: [],
     onSend: [],
     _parserOptions: {

package/test/internals/handleRequest.test.js

@@ -62,8 +62,8 @@ test('handler function - invalid schema', t => {
       }
     },
     handler: () => {},
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: [],
     preHandler: [],
     onSend: [],
@@ -93,8 +93,8 @@ test('handler function - reply', t => {
       reply.code(204)
       reply.send(undefined)
     },
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: [],
     preHandler: [],
     onSend: [],
@@ -123,8 +123,8 @@ test('handler function - preValidationCallback with finished response', t => {
       t.fail()
       reply.send(undefined)
     },
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: null,
     preHandler: [],
     onSend: [],
@@ -150,8 +150,8 @@ test('handler function - preValidationCallback with finished response (< v12.9.0
       t.fail()
       reply.send(undefined)
     },
-    Reply: Reply,
-    Request: Request,
+    Reply,
+    Request,
     preValidation: null,
     preHandler: [],
     onSend: [],

package/test/internals/logger.test.js

@@ -103,7 +103,7 @@ test('The logger should error if both stream and file destination are given', t
     Fastify({
       logger: {
         level: 'info',
-        stream: stream,
+        stream,
         file: '/test'
       }
     })

package/test/logger.test.js

@@ -37,7 +37,7 @@ test('defaults to info level', t => {
   try {
     fastify = Fastify({
       logger: {
-        stream: stream
+        stream
       }
     })
   } catch (e) {
@@ -85,7 +85,7 @@ test('test log stream', t => {
   try {
     fastify = Fastify({
       logger: {
-        stream: stream,
+        stream,
         level: 'info'
       }
     })
@@ -132,7 +132,7 @@ test('test error log stream', t => {
   try {
     fastify = Fastify({
       logger: {
-        stream: stream,
+        stream,
         level: 'info'
       }
     })
@@ -182,7 +182,7 @@ test('can use external logger instance', t => {
 
   const logger = require('pino')(splitStream)
 
-  const localFastify = Fastify({ logger: logger })
+  const localFastify = Fastify({ logger })
 
   localFastify.get('/foo', function (req, reply) {
     t.ok(req.log)
@@ -226,7 +226,7 @@ test('can use external logger instance with custom serializer', t => {
   }, splitStream)
 
   const localFastify = Fastify({
-    logger: logger
+    logger
   })
 
   localFastify.get('/foo', function (req, reply) {
@@ -253,7 +253,7 @@ test('expose the logger', t => {
   try {
     fastify = Fastify({
       logger: {
-        stream: stream,
+        stream,
         level: 'info'
       }
     })
@@ -271,7 +271,7 @@ test('The request id header key can be customized', t => {
 
   const stream = split(JSON.parse)
   const fastify = Fastify({
-    logger: { stream: stream, level: 'info' },
+    logger: { stream, level: 'info' },
     requestIdHeader: 'my-custom-request-id'
   })
   t.teardown(() => fastify.close())
@@ -316,7 +316,7 @@ test('The request id header key can be customized along with a custom id generat
 
   const stream = split(JSON.parse)
   const fastify = Fastify({
-    logger: { stream: stream, level: 'info' },
+    logger: { stream, level: 'info' },
     requestIdHeader: 'my-custom-request-id',
     genReqId (req) {
       return 'foo'
@@ -379,7 +379,7 @@ test('The request id log label can be changed', t => {
 
   const stream = split(JSON.parse)
   const fastify = Fastify({
-    logger: { stream: stream, level: 'info' },
+    logger: { stream, level: 'info' },
     requestIdHeader: 'my-custom-request-id',
     requestIdLogLabel: 'traceId'
   })
@@ -422,7 +422,7 @@ test('The logger should accept custom serializer', t => {
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info',
       serializers: {
         req: function (req) {
@@ -1151,7 +1151,7 @@ test('should serialize request and response', t => {
       const stream = split(JSON.parse)
       const fastify = Fastify({
         logger: {
-          stream: stream,
+          stream,
           level: 'info'
         }
       })
@@ -1173,7 +1173,7 @@ test('Do not wrap IPv4 address', t => {
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info'
     }
   })
@@ -1241,7 +1241,7 @@ test('should log the error if no error handler is defined', t => {
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info'
     }
   })
@@ -1275,7 +1275,7 @@ test('should log as info if error status code >= 400 and < 500 if no error handl
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info'
     }
   })
@@ -1313,7 +1313,7 @@ test('should log as error if error status code >= 500 if no error handler is def
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info'
     }
   })
@@ -1347,7 +1347,7 @@ test('should not log the error if error handler is defined', t => {
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info'
     }
   })
@@ -1381,7 +1381,7 @@ test('should not rely on raw request to log errors', t => {
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       level: 'info'
     }
   })
@@ -1412,7 +1412,7 @@ test('should redact the authorization header if so specified', t => {
   const stream = split(JSON.parse)
   const fastify = Fastify({
     logger: {
-      stream: stream,
+      stream,
       redact: ['req.headers.authorization'],
       level: 'info',
       serializers: {

package/test/maxRequestsPerSocket.test.js

@@ -21,7 +21,7 @@ test('maxRequestsPerSocket on node version >= 16.10.0', { skip }, t => {
     t.error(err)
 
     const port = fastify.server.address().port
-    const client = net.createConnection({ port: port }, () => {
+    const client = net.createConnection({ port }, () => {
       client.write('GET / HTTP/1.1\r\n\r\n')
 
       client.once('data', data => {
@@ -61,7 +61,7 @@ test('maxRequestsPerSocket zero should behave same as null', { skip }, t => {
     t.error(err)
 
     const port = fastify.server.address().port
-    const client = net.createConnection({ port: port }, () => {
+    const client = net.createConnection({ port }, () => {
       client.write('GET / HTTP/1.1\r\n\r\n')
 
       client.once('data', data => {

package/test/noop-set.test.js

@@ -0,0 +1,19 @@
+'use strict'
+
+const tap = require('tap')
+const noopSet = require('../lib/noop-set')
+
+tap.test('does a lot of nothing', async t => {
+  const aSet = noopSet()
+  t.type(aSet, 'object')
+
+  const item = {}
+  aSet.add(item)
+  aSet.add({ another: 'item' })
+  aSet.delete(item)
+  t.equal(aSet.has(item), true)
+
+  for (const i of aSet) {
+    t.fail('should not have any items', i)
+  }
+})

package/test/plugin.name.display.js

@@ -0,0 +1,10 @@
+'use strict'
+
+const assert = require('assert')
+
+module.exports = function (fastify, opts, done) {
+  assert.strictEqual(fastify.pluginName, 'test-plugin')
+  done()
+}
+
+module.exports[Symbol.for('fastify.display-name')] = 'test-plugin'

package/test/plugin.test.js

@@ -41,6 +41,24 @@ test('plugin metadata - ignore prefix', t => {
   }
 })
 
+test('plugin metadata - naming plugins', async t => {
+  t.plan(2)
+  const fastify = Fastify()
+
+  fastify.register(require('./plugin.name.display'))
+  fastify.register(function (fastify, opts, done) {
+    // one line
+    t.equal(fastify.pluginName, 'function (fastify, opts, done) { -- // one line')
+    done()
+  })
+  fastify.register(function fooBar (fastify, opts, done) {
+    t.equal(fastify.pluginName, 'fooBar')
+    done()
+  })
+
+  await fastify.ready()
+})
+
 test('fastify.register with fastify-plugin should not encapsulate his code', t => {
   t.plan(10)
   const fastify = Fastify()

package/test/route.test.js

@@ -8,6 +8,7 @@ const sget = require('simple-get').concat
 const joi = require('@hapi/joi')
 const Fastify = require('..')
 const proxyquire = require('proxyquire')
+const { FST_ERR_INVALID_URL } = require('../lib/errors')
 
 test('route', t => {
   t.plan(9)
@@ -1268,3 +1269,14 @@ test('Correct error message is produced if "path" option is used', t => {
     })
   }, new Error('Error Handler for POST:/test route, if defined, must be a function'))
 })
+
+test('invalid url attribute - non string URL', t => {
+  t.plan(1)
+  const fastify = Fastify()
+
+  try {
+    fastify.get(/^\/(donations|skills|blogs)/, () => {})
+  } catch (error) {
+    t.equal(error.code, FST_ERR_INVALID_URL().code)
+  }
+})

package/test/schema-serialization.test.js

@@ -670,3 +670,44 @@ test('error in custom schema serialize compiler, throw FST_ERR_SCH_SERIALIZATION
     t.equal(err.code, 'FST_ERR_SCH_SERIALIZATION_BUILD')
   })
 })
+
+test('Errors in searilizer sended to errorHandler', async t => {
+  let savedError
+
+  const fastify = Fastify()
+  fastify.get('/', {
+    schema: {
+      response: {
+        200: {
+          type: 'object',
+          properties: {
+            name: { type: 'string' },
+            power: { type: 'string' }
+          },
+          required: ['name']
+        }
+      }
+    }
+
+  }, function (req, reply) {
+    reply.code(200).send({ no: 'thing' })
+  })
+  fastify.setErrorHandler((error, request, reply) => {
+    savedError = error
+    reply.code(500).send(error)
+  })
+
+  const res = await fastify.inject('/')
+
+  t.equal(res.statusCode, 500)
+
+  // t.same(savedError, new Error('"name" is required!'));
+  t.same(res.json(), {
+    statusCode: 500,
+    error: 'Internal Server Error',
+    message: '"name" is required!'
+  })
+  t.ok(savedError, 'error presents')
+  t.ok(savedError.serialization, 'Serialization sign presents')
+  t.end()
+})

package/test/skip-reply-send.test.js

@@ -23,7 +23,7 @@ test('skip automatic reply.send() with reply.sent = true and a body', (t) => {
   const stream = split(JSON.parse)
   const app = Fastify({
     logger: {
-      stream: stream
+      stream
     }
   })
 
@@ -52,7 +52,7 @@ test('skip automatic reply.send() with reply.sent = true and no body', (t) => {
   const stream = split(JSON.parse)
   const app = Fastify({
     logger: {
-      stream: stream
+      stream
     }
   })
 
@@ -81,7 +81,7 @@ test('skip automatic reply.send() with reply.sent = true and an error', (t) => {
   const stream = split(JSON.parse)
   const app = Fastify({
     logger: {
-      stream: stream
+      stream
     }
   })
 
@@ -125,7 +125,7 @@ function testHandlerOrBeforeHandlerHook (test, hookOrHandler) {
       const stream = split(JSON.parse)
       const app = Fastify({
         logger: {
-          stream: stream
+          stream
         }
       })
 
@@ -170,7 +170,7 @@ function testHandlerOrBeforeHandlerHook (test, hookOrHandler) {
       const stream = split(JSON.parse)
       const app = Fastify({
         logger: {
-          stream: stream
+          stream
         }
       })
       t.teardown(() => app.close())
@@ -224,7 +224,7 @@ function testHandlerOrBeforeHandlerHook (test, hookOrHandler) {
       const stream = split(JSON.parse)
       const app = Fastify({
         logger: {
-          stream: stream
+          stream
         }
       })
       t.teardown(() => app.close())
@@ -274,7 +274,7 @@ function testHandlerOrBeforeHandlerHook (test, hookOrHandler) {
       const stream = split(JSON.parse)
       const app = Fastify({
         logger: {
-          stream: stream
+          stream
         }
       })
 

package/test/trust-proxy.test.js

@@ -16,7 +16,7 @@ const sgetForwardedRequest = (app, forHeader, path, protoHeader) => {
   }
   sget({
     method: 'GET',
-    headers: headers,
+    headers,
     url: 'http://localhost:' + app.server.address().port + path
   }, () => {})
 }