fastify 3.23.0 → 3.25.0

package/test/listen.test.js

@@ -3,15 +3,29 @@
 const os = require('os')
 const path = require('path')
 const fs = require('fs')
-const test = require('tap').test
+const { test, before } = require('tap')
 const Fastify = require('..')
+const dns = require('dns').promises
+
+let localhost
+let localhostForURL
+
+before(async function () {
+  const lookup = await dns.lookup('localhost')
+  localhost = lookup.address
+  if (lookup.family === 6) {
+    localhostForURL = `[${lookup.address}]`
+  } else {
+    localhostForURL = localhost
+  }
+})
 
 test('listen accepts a callback', t => {
   t.plan(2)
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
   fastify.listen((err) => {
-    t.equal(fastify.server.address().address, '127.0.0.1')
+    t.equal(fastify.server.address().address, localhost)
     t.error(err)
   })
 })
@@ -21,7 +35,7 @@ test('listen accepts a port and a callback', t => {
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0, (err) => {
-    t.equal(fastify.server.address().address, '127.0.0.1')
+    t.equal(fastify.server.address().address, localhost)
     t.error(err)
   })
 })
@@ -31,7 +45,7 @@ test('listen accepts a port and a callback with (err, address)', t => {
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0, (err, address) => {
-    t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+    t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     t.error(err)
   })
 })
@@ -40,7 +54,7 @@ test('listen accepts a port, address, and callback', t => {
   t.plan(1)
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
-  fastify.listen(0, '127.0.0.1', (err) => {
+  fastify.listen(0, localhost, (err) => {
     t.error(err)
   })
 })
@@ -78,8 +92,8 @@ test('listen accepts a port, address and a callback with (err, address)', t => {
   t.plan(2)
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
-  fastify.listen(0, '127.0.0.1', (err, address) => {
-    t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+  fastify.listen(0, localhost, (err, address) => {
+    t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     t.error(err)
   })
 })
@@ -88,7 +102,7 @@ test('listen accepts a port, address, backlog and callback', t => {
   t.plan(1)
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
-  fastify.listen(0, '127.0.0.1', 511, (err) => {
+  fastify.listen(0, localhost, 511, (err) => {
     t.error(err)
   })
 })
@@ -97,8 +111,8 @@ test('listen accepts a port, address, backlog and callback with (err, address)',
   t.plan(2)
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
-  fastify.listen(0, '127.0.0.1', 511, (err, address) => {
-    t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+  fastify.listen(0, localhost, 511, (err, address) => {
+    t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     t.error(err)
   })
 })
@@ -111,7 +125,7 @@ test('listen after Promise.resolve()', t => {
     .then(() => {
       f.listen(0, (err, address) => {
         f.server.unref()
-        t.equal(address, 'http://127.0.0.1:' + f.server.address().port)
+        t.equal(address, `http://${localhostForURL}:${f.server.address().port}`)
         t.error(err)
       })
     })
@@ -153,7 +167,7 @@ test('double listen errors callback with (err, address)', t => {
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0, (err1, address1) => {
-    t.equal(address1, 'http://127.0.0.1:' + fastify.server.address().port)
+    t.equal(address1, `http://${localhostForURL}:${fastify.server.address().port}`)
     t.error(err1)
     fastify.listen(fastify.server.address().port, (err2, address2) => {
       t.equal(address2, null)
@@ -167,7 +181,7 @@ test('listen twice on the same port', t => {
   const fastify = Fastify()
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0, (err1, address1) => {
-    t.equal(address1, 'http://127.0.0.1:' + fastify.server.address().port)
+    t.equal(address1, `http://${localhostForURL}:${fastify.server.address().port}`)
     t.error(err1)
     const s2 = Fastify()
     t.teardown(s2.close.bind(s2))
@@ -184,7 +198,7 @@ test('listen twice on the same port callback with (err, address)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0, (err1, address1) => {
     const _port = fastify.server.address().port
-    t.equal(address1, 'http://127.0.0.1:' + _port)
+    t.equal(address1, `http://${localhostForURL}:${_port}`)
     t.error(err1)
     const s2 = Fastify()
     t.teardown(s2.close.bind(s2))
@@ -221,7 +235,7 @@ test('listen without callback (port zero)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0)
     .then(() => {
-      t.equal(fastify.server.address().address, '127.0.0.1')
+      t.equal(fastify.server.address().address, localhost)
     })
 })
 
@@ -231,7 +245,7 @@ test('listen without callback (port not given)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen()
     .then(() => {
-      t.equal(fastify.server.address().address, '127.0.0.1')
+      t.equal(fastify.server.address().address, localhost)
     })
 })
 
@@ -241,7 +255,7 @@ test('listen null without callback with (address)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(null)
     .then(address => {
-      t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+      t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     })
 })
 
@@ -251,7 +265,7 @@ test('listen without port without callback with (address)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen()
     .then(address => {
-      t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+      t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     })
 })
 
@@ -261,7 +275,7 @@ test('listen with undefined without callback with (address)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(undefined)
     .then(address => {
-      t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+      t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     })
 })
 
@@ -271,7 +285,7 @@ test('listen without callback with (address)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0)
     .then(address => {
-      t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+      t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
     })
 })
 
@@ -295,7 +309,7 @@ test('double listen without callback with (address)', t => {
   t.teardown(fastify.close.bind(fastify))
   fastify.listen(0)
     .then(address => {
-      t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+      t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
       fastify.listen(0)
         .catch(err => {
           t.ok(err)
@@ -329,7 +343,7 @@ test('listen twice on the same port without callback rejects with (address)', t
     .then(address => {
       const s2 = Fastify()
       t.teardown(s2.close.bind(s2))
-      t.equal(address, 'http://127.0.0.1:' + fastify.server.address().port)
+      t.equal(address, `http://${localhostForURL}:${fastify.server.address().port}`)
       s2.listen(fastify.server.address().port)
         .catch(err => {
           t.ok(err)

package/test/logger.test.js

@@ -1516,3 +1516,19 @@ test('should create a default logger if provided one is invalid', t => {
 
   t.pass()
 })
+
+test('should not throw error when serializing custom req', t => {
+  t.plan(1)
+
+  const lines = []
+  const dest = new stream.Writable({
+    write: function (chunk, enc, cb) {
+      lines.push(JSON.parse(chunk))
+      cb()
+    }
+  })
+  const fastify = Fastify({ logger: { level: 'info', stream: dest } })
+  fastify.log.info({ req: {} })
+
+  t.same(lines[0].req, {})
+})

package/test/maxRequestsPerSocket.test.js

@@ -102,3 +102,13 @@ test('maxRequestsPerSocket should 0', async (t) => {
   const initialConfig = Fastify().initialConfig
   t.same(initialConfig.maxRequestsPerSocket, 0)
 })
+
+test('requestTimeout passed to server', t => {
+  t.plan(2)
+
+  const httpServer = Fastify({ maxRequestsPerSocket: 5 }).server
+  t.equal(httpServer.maxRequestsPerSocket, 5)
+
+  const httpsServer = Fastify({ maxRequestsPerSocket: 5, https: true }).server
+  t.equal(httpsServer.maxRequestsPerSocket, 5)
+})

package/test/request-error.test.js

@@ -157,10 +157,7 @@ test('default clientError handler destroys sockets in writable state', t => {
 
   const fastify = Fastify({
     bodyLimit: 1,
-    keepAliveTimeout: 100,
-    logger: {
-      level: 'trace'
-    }
+    keepAliveTimeout: 100
   })
 
   fastify.server.emit('clientError', new Error(), {
@@ -181,10 +178,7 @@ test('default clientError handler destroys http sockets in non-writable state',
 
   const fastify = Fastify({
     bodyLimit: 1,
-    keepAliveTimeout: 100,
-    logger: {
-      level: 'trace'
-    }
+    keepAliveTimeout: 100
   })
 
   fastify.server.emit('clientError', new Error(), {

package/test/requestTimeout.test.js

@@ -5,7 +5,7 @@ const { test } = require('tap')
 const Fastify = require('../fastify')
 
 test('requestTimeout passed to server', t => {
-  t.plan(4)
+  t.plan(5)
 
   try {
     Fastify({ requestTimeout: 500.1 })
@@ -24,6 +24,9 @@ test('requestTimeout passed to server', t => {
   const httpServer = Fastify({ requestTimeout: 1000 }).server
   t.equal(httpServer.requestTimeout, 1000)
 
+  const httpsServer = Fastify({ requestTimeout: 1000, https: true }).server
+  t.equal(httpsServer.requestTimeout, 1000)
+
   const serverFactory = (handler, _) => {
     const server = http.createServer((req, res) => {
       handler(req, res)

package/test/route-hooks.test.js

@@ -2,6 +2,7 @@
 
 const { Readable } = require('stream')
 const test = require('tap').test
+const sget = require('simple-get').concat
 const Fastify = require('../')
 
 process.removeAllListeners('warning')
@@ -496,3 +497,57 @@ test('onRequest option should be called before preParsing', t => {
     t.same(payload, { hello: 'world' })
   })
 })
+
+test('onTimeout on route', t => {
+  t.plan(4)
+  const fastify = Fastify({ connectionTimeout: 500 })
+
+  fastify.get('/timeout', {
+    async  handler (request, reply) { },
+    onTimeout (request, reply, done) {
+      t.pass('onTimeout called')
+      done()
+    }
+  })
+
+  fastify.listen(0, (err, address) => {
+    t.error(err)
+    t.teardown(() => fastify.close())
+
+    sget({
+      method: 'GET',
+      url: `${address}/timeout`
+    }, (err, response, body) => {
+      t.type(err, Error)
+      t.equal(err.message, 'socket hang up')
+    })
+  })
+})
+
+test('onError on route', t => {
+  t.plan(3)
+
+  const fastify = Fastify()
+
+  const err = new Error('kaboom')
+
+  fastify.get('/',
+    {
+      onError (request, reply, error, done) {
+        t.match(error, err)
+        done()
+      }
+    },
+    (req, reply) => {
+      reply.send(err)
+    })
+
+  fastify.inject('/', (err, res) => {
+    t.error(err)
+    t.same(JSON.parse(res.payload), {
+      error: 'Internal Server Error',
+      message: 'kaboom',
+      statusCode: 500
+    })
+  })
+})

package/test/router-options.test.js

@@ -5,6 +5,15 @@ const sget = require('simple-get')
 const Fastify = require('../')
 const { FST_ERR_BAD_URL } = require('../lib/errors')
 
+function getUrl (app) {
+  const { address, port } = app.server.address()
+  if (address === '::1') {
+    return `http://[${address}]:${port}`
+  } else {
+    return `http://${address}:${port}`
+  }
+}
+
 test('Should honor ignoreTrailingSlash option', t => {
   t.plan(4)
   const fastify = Fastify({
@@ -19,7 +28,7 @@ test('Should honor ignoreTrailingSlash option', t => {
     fastify.server.unref()
     if (err) t.threw(err)
 
-    const baseUrl = 'http://127.0.0.1:' + fastify.server.address().port
+    const baseUrl = getUrl(fastify)
 
     sget.concat(baseUrl + '/test', (err, res, data) => {
       if (err) t.threw(err)