fastify 2.4.1 → 2.7.1

package/test/internals/validation.test.js

@@ -74,6 +74,37 @@ test('build schema - payload schema', t => {
   t.is(typeof opts[symbols.bodySchema], 'function')
 })
 
+test('build schema - query schema', t => {
+  t.plan(2)
+  const opts = {
+    schema: {
+      query: {
+        type: 'object',
+        properties: {
+          hello: { type: 'string' }
+        }
+      }
+    }
+  }
+  validation.build(opts, schema => ajv.compile(schema), new Schemas())
+  t.type(opts[symbols.querystringSchema].schema.type, 'string')
+  t.is(typeof opts[symbols.querystringSchema], 'function')
+})
+
+test('build schema - query schema abbreviated', t => {
+  t.plan(2)
+  const opts = {
+    schema: {
+      query: {
+        hello: { type: 'string' }
+      }
+    }
+  }
+  validation.build(opts, schema => ajv.compile(schema), new Schemas())
+  t.type(opts[symbols.querystringSchema].schema.type, 'string')
+  t.is(typeof opts[symbols.querystringSchema], 'function')
+})
+
 test('build schema - querystring schema', t => {
   t.plan(2)
   const opts = {
@@ -105,6 +136,32 @@ test('build schema - querystring schema abbreviated', t => {
   t.is(typeof opts[symbols.querystringSchema], 'function')
 })
 
+test('build schema - must throw if querystring and query schema exist', t => {
+  t.plan(2)
+  try {
+    const opts = {
+      schema: {
+        query: {
+          type: 'object',
+          properties: {
+            hello: { type: 'string' }
+          }
+        },
+        querystring: {
+          type: 'object',
+          properties: {
+            hello: { type: 'string' }
+          }
+        }
+      }
+    }
+    validation.build(opts, schema => ajv.compile(schema), new Schemas())
+  } catch (err) {
+    t.is(err.code, 'FST_ERR_SCH_DUPLICATE')
+    t.is(err.message, 'FST_ERR_SCH_DUPLICATE: Schema with \'querystring\' already present!')
+  }
+})
+
 test('build schema - params schema', t => {
   t.plan(1)
   const opts = {

package/test/logger.test.js

@@ -1072,6 +1072,38 @@ test('should not log the error if error handler is defined', t => {
   })
 })
 
+test('should not rely on raw request to log errors', t => {
+  t.plan(7)
+  const stream = split(JSON.parse)
+  const fastify = Fastify({
+    modifyCoreObjects: false,
+    logger: {
+      stream: stream,
+      level: 'info'
+    }
+  })
+  fastify.get('/error', function (req, reply) {
+    t.ok(req.log)
+    reply.status(415).send(new Error('something happened'))
+  })
+  fastify.listen(0, err => {
+    t.error(err)
+    fastify.server.unref()
+    http.get('http://localhost:' + fastify.server.address().port + '/error')
+    stream.once('data', listenAtLogLine => {
+      t.ok(listenAtLogLine, 'listen at log message is ok')
+      stream.once('data', line => {
+        t.equal(line.msg, 'incoming request', 'message is set')
+        stream.once('data', line => {
+          t.equal(line.level, 30, 'level is correct')
+          t.equal(line.msg, 'something happened', 'message is set')
+          t.deepEqual(line.res, { statusCode: 415 }, 'status code is set')
+        })
+      })
+    })
+  })
+})
+
 test('should redact the authorization header if so specified', t => {
   t.plan(7)
   const stream = split(JSON.parse)
@@ -1111,7 +1143,7 @@ test('should redact the authorization header if so specified', t => {
       method: 'GET',
       url: 'http://localhost:' + fastify.server.address().port,
       headers: {
-        'authorization': 'Bearer abcde'
+        authorization: 'Bearer abcde'
       }
     }, (err, response, body) => {
       t.error(err)

package/test/nullable-validation.test.js

@@ -0,0 +1,52 @@
+'use strict'
+
+const t = require('tap')
+const test = t.test
+const Fastify = require('..')
+
+test('nullable string', t => {
+  t.plan(3)
+  const fastify = Fastify()
+  fastify.route({
+    method: 'POST',
+    url: '/',
+    handler: (req, reply) => {
+      t.same(req.body.hello, null)
+      reply.code(200).send(req.body)
+    },
+    schema: {
+      body: {
+        type: 'object',
+        properties: {
+          hello: {
+            type: 'string',
+            format: 'email',
+            nullable: true
+          }
+        }
+      },
+      response: {
+        200: {
+          type: 'object',
+          properties: {
+            hello: {
+              type: 'string',
+              format: 'email',
+              nullable: true
+            }
+          }
+        }
+      }
+    }
+  })
+  fastify.inject({
+    method: 'POST',
+    url: '/',
+    body: {
+      hello: null
+    }
+  }, (err, res) => {
+    t.error(err)
+    t.same(res.payload.hello, null)
+  })
+})

package/test/plugin.test.js

@@ -1,5 +1,7 @@
 'use strict'
 
+/* eslint no-prototype-builtins: 0 */
+
 const t = require('tap')
 const test = t.test
 const Fastify = require('..')

package/test/register.test.js

@@ -1,5 +1,7 @@
 'use strict'
 
+/* eslint no-prototype-builtins: 0 */
+
 const t = require('tap')
 const test = t.test
 const sget = require('simple-get').concat

package/test/route-prefix.test.js

@@ -459,6 +459,37 @@ test('matches both /prefix and /prefix/  with a / route - prefixTrailingSlash: "
   })
 })
 
+test('returns 404 status code with /prefix/ and / route - prefixTrailingSlash: "both" (default), ignoreTrailingSlash: true', t => {
+  t.plan(2)
+  const fastify = Fastify({
+    ignoreTrailingSlash: true
+  })
+
+  fastify.register(function (fastify, opts, next) {
+    fastify.route({
+      method: 'GET',
+      url: '/',
+      handler: (req, reply) => {
+        reply.send({ hello: 'world' })
+      }
+    })
+
+    next()
+  }, { prefix: '/prefix/' })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/prefix//'
+  }, (err, res) => {
+    t.error(err)
+    t.same(JSON.parse(res.payload), {
+      error: 'Not Found',
+      message: 'Not Found',
+      statusCode: 404
+    })
+  })
+})
+
 test('matches only /prefix  with a / route - prefixTrailingSlash: "no-slash", ignoreTrailingSlash: false', t => {
   t.plan(4)
   const fastify = Fastify({

package/test/route.test.js

@@ -3,6 +3,7 @@
 const t = require('tap')
 const test = t.test
 const sget = require('simple-get').concat
+const joi = require('joi')
 const Fastify = require('..')
 
 test('route', t => {
@@ -255,3 +256,37 @@ test('handler function in options of shorthand route should works correctly', t
     t.deepEqual(JSON.parse(res.payload), { hello: 'world' })
   })
 })
+
+test('does not mutate joi schemas', t => {
+  t.plan(4)
+
+  const fastify = Fastify()
+  function schemaCompiler (schema) {
+    return function (data, opts) {
+      return joi.validate(data, schema)
+    }
+  }
+
+  fastify.setSchemaCompiler(schemaCompiler)
+
+  fastify.route({
+    path: '/foo/:an_id',
+    method: 'GET',
+    schema: {
+      params: { an_id: joi.number() }
+    },
+    handler (req, res) {
+      t.deepEqual(req.params, { an_id: 42 })
+      res.send({ hello: 'world' })
+    }
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/foo/42'
+  }, (err, result) => {
+    t.error(err)
+    t.strictEqual(result.statusCode, 200)
+    t.deepEqual(JSON.parse(result.payload), { hello: 'world' })
+  })
+})

package/test/shared-schemas.test.js

@@ -565,7 +565,7 @@ test('Use shared schema and $ref with $id ($ref to $id)', t => {
         $id: '#address',
         type: 'object',
         properties: {
-          city: { 'type': 'string' }
+          city: { type: 'string' }
         }
       }
     },
@@ -624,7 +624,7 @@ test('Use shared schema and $ref with $id in response ($ref to $id)', t => {
         $id: '#address',
         type: 'object',
         properties: {
-          city: { 'type': 'string' }
+          city: { type: 'string' }
         }
       }
     },
@@ -1089,7 +1089,7 @@ test('Use shared schema and $ref to /definitions', t => {
         $id: '#otherId',
         type: 'object',
         properties: {
-          city: { 'type': 'string' }
+          city: { type: 'string' }
         }
       }
     },

package/test/types/index.ts

@@ -58,11 +58,13 @@ const cors = require('cors')
 
   // other simple options
   const otherServer = fastify({
+    caseSensitive: false,
     ignoreTrailingSlash: true,
     bodyLimit: 1000,
     maxParamLength: 200,
     querystringParser: (str: string) => ({ str: str, strArray: [str] }),
-    modifyCoreObjects: true
+    modifyCoreObjects: true,
+    return503OnClosing: true
   })
 
   // custom types
@@ -188,7 +190,7 @@ const schema: fastify.RouteSchema = {
   }
 }
 
-const opts: fastify.RouteShorthandOptions<http2.Http2Server, http2.Http2ServerRequest, http2.Http2ServerResponse> = {
+const opts: fastify.RouteShorthandOptions<http2.Http2SecureServer, http2.Http2ServerRequest, http2.Http2ServerResponse> = {
   schema,
   preValidation: [
     (request, reply, next) => {
@@ -345,6 +347,10 @@ server
   .get('/deprecatedpath/*', (req, reply) => {
     reply.callNotFound()
   })
+  .get('/getResponseTime', function (req, reply) {
+    const milliseconds : number = reply.getResponseTime()
+    reply.send({ milliseconds })
+  })
 
 // Generics example
 interface Query {
@@ -440,6 +446,13 @@ server.setErrorHandler((err, request, reply) => {
   }
 })
 
+server.setReplySerializer((payload, statusCode) => {
+  if (statusCode === 201) {
+    return `Created ${payload}`
+  }
+  return JSON.stringify(payload)
+})
+
 server.listen(3000, err => {
   if (err) throw err
   const address = server.server.address()
@@ -604,3 +617,21 @@ const server2 = fastify()
 server2.close().then(() => {})
 const server3 = fastify()
 server3.close(() => {})
+
+{
+  // tests generics default values
+  const routeOptions: fastify.RouteOptions = {
+    method: 'GET',
+    url: '/',
+    handler: function (req, reply) { reply.send({}) }
+  }
+
+  const genericHandler: fastify.RequestHandler = (req, reply) => { reply.send(reply) }
+
+  const middleware: fastify.FastifyMiddleware = function middleware (req, reply, done) {
+    this.addHook('onClose', function (instance, done) {
+      done()
+    })
+    done()
+  }
+}

package/test/versioned-routes.test.js

@@ -445,7 +445,7 @@ test('Should register a versioned route with custome versioning strategy', t =>
     method: 'GET',
     url: '/',
     headers: {
-      'Accept': 'application/vnd.example.api+json;version=2'
+      Accept: 'application/vnd.example.api+json;version=2'
     }
   }, (err, res) => {
     t.error(err)
@@ -457,7 +457,7 @@ test('Should register a versioned route with custome versioning strategy', t =>
     method: 'GET',
     url: '/',
     headers: {
-      'Accept': 'application/vnd.example.api+json;version=3'
+      Accept: 'application/vnd.example.api+json;version=3'
     }
   }, (err, res) => {
     t.error(err)
@@ -469,7 +469,7 @@ test('Should register a versioned route with custome versioning strategy', t =>
     method: 'GET',
     url: '/',
     headers: {
-      'Accept': 'application/vnd.example.api+json;version=4'
+      Accept: 'application/vnd.example.api+json;version=4'
     }
   }, (err, res) => {
     t.error(err)