fast-xml-parser 4.0.0-beta.3 → 4.0.0-beta.7

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 Note: If you find missing information about particular minor version, that version must have been changed without any functional change in this library.
 
+** 4.0.0-beta.7 / 2021-12-09**
+* fix Validator bug when an attribute has no value but '=' only
+* XML Builder should suppress unpaired tags by default.
+* documents update for missing features
+* refactoring to use Object.assign
+* refactoring to remove repeated code
+
+** 4.0.0-beta.6 / 2021-12-05**
+* Support PI Tags processing
+* Support `suppressBooleanAttributes` by XML Builder for attributes with value `true`.
+
+** 4.0.0-beta.5 / 2021-12-04**
+* fix: when a tag with name "attributes"
+
+** 4.0.0-beta.4 / 2021-12-02**
+* Support HTML document parsing
+* skip stop nodes parsing when building the XML from JS object
+* Support external entites without DOCTYPE
+* update dev dependency: strnum v1.0.5 to fix long number issue
+
 ** 4.0.0-beta.3 / 2021-11-30**
 * support global stopNodes expression like "*.stop"
 * support self-closing and paired unpaired tags

package/README.md

@@ -29,6 +29,7 @@ Check [ThankYouBackers](https://github.com/NaturalIntelligence/ThankYouBackers)
 <a href="http://nasa.github.io/" title="NASA" > <img src="https://avatars0.githubusercontent.com/u/848102" width="60px" ></a>
 <a href="https://github.com/prettier" title="Prettier" > <img src="https://avatars0.githubusercontent.com/u/25822731" width="60px" ></a>
 <a href="http://brain.js.org/" title="brain.js" > <img src="https://avatars2.githubusercontent.com/u/23732838" width="60px" ></a>
+<a href="https://github.com/aws" title="AWS SDK" > <img src="https://avatars.githubusercontent.com/u/2232217" width="60px" ></a>
 <a href="#" title="NHS Connect" > <img src="https://avatars3.githubusercontent.com/u/20316669" width="60px" ></a>
 <a href="http://www.fda.gov/" title="Food and Drug Administration " > <img src="https://avatars2.githubusercontent.com/u/6471964" width="60px" ></a>
 <a href="http://www.magento.com/" title="Magento" > <img src="https://avatars2.githubusercontent.com/u/168457" width="60px" ></a>
@@ -54,6 +55,7 @@ Check the list of all known users [here](./USERs.md);
 * Supports comments
 * It can preserve Order of tags in JS object
 * You can control if a single tag should be parsed into array.
+* Supports parsing of PI (Processing Instruction) tags with XML declaration tags
 * And many more other features.
 
 ## How to use
@@ -106,7 +108,8 @@ In a HTML page
 3.  [XML Builder](./docs/v4/3.XMLBuilder.md)
 4.  [XML Validator](./docs/v4/4.XMLValidator.md)
 5.  [Entites](./docs/5.Entities.md)
-
+6.  [HTML Document Parsing](./docs/6.HTMLParsing.md)
+7. [PI Tag processing](./docs/7.PITags.md)
 ## Performance
 
 ### XML Parser

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fast-xml-parser",
-  "version": "4.0.0-beta.3",
+  "version": "4.0.0-beta.7",
   "description": "Validate XML, Parse XML, Build XML without C/C++ based libraries",
   "main": "./src/fxp.js",
   "scripts": {
@@ -47,14 +47,14 @@
     "@babel/preset-env": "^7.13.10",
     "@babel/register": "^7.13.8",
     "babel-loader": "^8.2.2",
-    "eslint": "^5.16.0",
+    "eslint": "^8.3.0",
     "he": "^1.2.0",
     "jasmine": "^3.6.4",
     "nyc": "^15.1.0",
     "prettier": "^1.19.1",
     "publish-please": "^5.5.2",
-    "webpack": "^4.46.0",
-    "webpack-cli": "^3.3.12"
+    "webpack": "^5.64.4",
+    "webpack-cli": "^4.9.1"
   },
   "typings": "src/fxp.d.ts",
   "funding": {
@@ -62,6 +62,6 @@
     "url": "https://paypal.me/naturalintelligence"
   },
   "dependencies": {
-    "strnum": "^1.0.4"
+    "strnum": "^1.0.5"
   }
 }

package/src/fxp.d.ts

@@ -44,8 +44,10 @@ type XmlBuilderOptions = {
   indentBy: string;
   arrayNodeName: string;
   suppressEmptyNode: boolean;
+  suppressBooleanAttributes: boolean;
   preserveOrder: boolean;
   unpairedTags: string[];
+  stopNodes: string[];
   tagValueProcessor: (name: string, value: string) => string;
   attributeValueProcessor: (name: string, value: string) => string;
   processEntities: boolean;
@@ -66,6 +68,12 @@ type ValidationError = {
 export class XMLParser {
   constructor(options?: X2jOptionsOptional);
   parse(xmlData: string | Buffer ,validationOptions?: validationOptionsOptional | boolean): any;
+  /**
+   * Add Entity which is not by default supported by this library
+   * @param entityIndentifier {string} Eg: 'ent' for &ent;
+   * @param entityValue {string} Eg: '\r'
+   */
+  addEntity(entityIndentifier: string, entityValue: string): void;
 }
 
 export class XMLValidator{

package/src/util.js

@@ -67,23 +67,6 @@ exports.getValue = function(v) {
 // const fakeCall = function(a) {return a;};
 // const fakeCallNoReturn = function() {};
 
-const buildOptions = function(options, defaultOptions, props) {
-  let newOptions = {};
-  if (!options) {
-    return defaultOptions; //if there are not options
-  }
-
-  for (let i = 0; i < props.length; i++) {
-    if (options[props[i]] !== undefined) {
-      newOptions[props[i]] = options[props[i]];
-    } else {
-      newOptions[props[i]] = defaultOptions[props[i]];
-    }
-  }
-  return newOptions;
-};
-
-exports.buildOptions = buildOptions;
 exports.isName = isName;
 exports.getAllMatches = getAllMatches;
 exports.nameRegexp = nameRegexp;

package/src/validator.js

@@ -7,14 +7,9 @@ const defaultOptions = {
   unpairedTags: []
 };
 
-const props = [
-  'allowBooleanAttributes',
-  'unpairedTags'
-];
-
 //const tagsPattern = new RegExp("<\\/?([\\w:\\-_\.]+)\\s*\/?>","g");
 exports.validate = function (xmlData, options) {
-  options = util.buildOptions(options, defaultOptions, props);
+  options = Object.assign({}, defaultOptions, options);
 
   //xmlData = xmlData.replace(/(\r\n|\n|\r)/gm,"");//make it single line
   //xmlData = xmlData.replace(/(^\s*<\?xml.*?\?>)/g,"");//Remove XML starting tag
@@ -331,6 +326,8 @@ function validateAttributeString(attrStr, options) {
     if (matches[i][1].length === 0) {
       //nospace before attribute name: a="sd"b="saf"
       return getErrorObject('InvalidAttr', "Attribute '"+matches[i][2]+"' has no space in starting.", getPositionFromMatch(matches[i]))
+    } else if (matches[i][3] !== undefined && matches[i][4] === undefined) {
+      return getErrorObject('InvalidAttr', "Attribute '"+matches[i][2]+"' is without value.", getPositionFromMatch(matches[i]));
     } else if (matches[i][3] === undefined && !options.allowBooleanAttributes) {
       //independent attribute: ab
       return getErrorObject('InvalidAttr', "boolean attribute '"+matches[i][2]+"' is not allowed.", getPositionFromMatch(matches[i]));

package/src/xmlbuilder/json2xml.js

@@ -1,6 +1,5 @@
 'use strict';
 //parse Empty Node as self closing node
-const buildOptions = require('../util').buildOptions;
 const buildFromOrderedJs = require('./orderedJs2Xml');
 
 const defaultOptions = {
@@ -12,6 +11,7 @@ const defaultOptions = {
   format: false,
   indentBy: '  ',
   suppressEmptyNode: false,
+  suppressBooleanAttributes: true,
   tagValueProcessor: function(key, a) {
     return a;
   },
@@ -27,31 +27,12 @@ const defaultOptions = {
     "sQuot" : { regex: new RegExp("\'", "g"), val: "'" },
     "dQuot" : { regex: new RegExp("\"", "g"), val: """ }
   },
-  processEntities: true
+  processEntities: true,
+  stopNodes: []
 };
 
-const props = [
-  'attributeNamePrefix',
-  'attributesGroupName',
-  'textNodeName',
-  'ignoreAttributes',
-  'cdataPropName',
-  'format',
-  'indentBy',
-  'suppressEmptyNode',
-  'tagValueProcessor',
-  'attributeValueProcessor',
-  'arrayNodeName', //when array as root
-  'preserveOrder',
-  "commentPropName",
-  "unpairedTags",
-  "entities",
-  "processEntities",
-  // 'rootNodeName', //when jsObject have multiple properties on root level
-];
-
 function Builder(options) {
-  this.options = buildOptions(options, defaultOptions, props);
+  this.options = Object.assign({}, defaultOptions, options);
   if (this.options.ignoreAttributes || this.options.attributesGroupName) {
     this.isAttribute = function(/*a*/) {
       return false;

package/src/xmlbuilder/orderedJs2Xml.js

@@ -7,10 +7,10 @@ const {EOL} = require('os');
  * @returns 
  */
 function toXml(jArray, options){
-    return arrToStr( jArray, options, 0);
+    return arrToStr( jArray, options, "", 0);
 }
 
-function arrToStr(arr, options, level){
+function arrToStr(arr, options, jPath, level){
     let xmlStr = "";
 
     let indentation = "";
@@ -21,10 +21,16 @@ function arrToStr(arr, options, level){
     for (let i = 0; i < arr.length; i++) {
         const tagObj = arr[i];
         const tagName = propName(tagObj);
+        let newJPath = "";
+        if(jPath.length === 0) newJPath = tagName
+        else newJPath = `${jPath}.${tagName}`;
 
         if(tagName === options.textNodeName){
-            let tagText = options.tagValueProcessor( tagName, tagObj[tagName]);
-            tagText = replaceEntitiesValue(tagText, options);
+            let tagText = tagObj[tagName];
+            if(!isStopNode(newJPath, options)){
+                tagText = options.tagValueProcessor( tagName, tagText);
+                tagText = replaceEntitiesValue(tagText, options);
+            }
             xmlStr += indentation + tagText;
             continue;
         }else if( tagName === options.cdataPropName){
@@ -33,16 +39,18 @@ function arrToStr(arr, options, level){
         }else if( tagName === options.commentPropName){
             xmlStr += indentation + `<!--${tagObj[tagName][0][options.textNodeName]}-->`;
             continue;
+        }else if( tagName[0] === "?"){
+            const attStr = attr_to_str(tagObj[":@"], options);
+            xmlStr += indentation + `<${tagName} ${tagObj[tagName][0][options.textNodeName]} ${attStr}?>`;
+            continue;
         }
-        const attStr = attr_to_str(tagObj.attributes, options);
+        const attStr = attr_to_str(tagObj[":@"], options);
         let tagStart =  indentation + `<${tagName}${attStr}`;
-        let tagValue = arrToStr(tagObj[tagName], options, level + 1);
-        if( (!tagValue || tagValue.length === 0) && options.suppressEmptyNode){ 
-            if(options.unpairedTags.indexOf(tagName) !== -1){
-                xmlStr += tagStart + ">"; 
-            }else{
-                xmlStr += tagStart + "/>"; 
-            }
+        let tagValue = arrToStr(tagObj[tagName], options, newJPath, level + 1);
+        if(options.unpairedTags.indexOf(tagName) !== -1){
+            xmlStr += tagStart + ">"; 
+        }else if( (!tagValue || tagValue.length === 0) && options.suppressEmptyNode){ 
+            xmlStr += tagStart + "/>"; 
         }else{ 
             //TODO: node with only text value should not parse the text value in next line
             xmlStr += tagStart + `>${tagValue}${indentation}</${tagName}>` ;
@@ -56,7 +64,7 @@ function propName(obj){
     const keys = Object.keys(obj);
     for (let i = 0; i < keys.length; i++) {
       const key = keys[i];
-      if(key !== "attributes") return key;
+      if(key !== ":@") return key;
     }
   }
 
@@ -66,12 +74,25 @@ function attr_to_str(attrMap, options){
         for( attr in attrMap){
             let attrVal = options.attributeValueProcessor(attr, attrMap[attr]);
             attrVal = replaceEntitiesValue(attrVal, options);
-            attrStr+= ` ${attr.substr(options.attributeNamePrefix.length)}="${attrVal}"`;
+            if(attrVal === true && options.suppressBooleanAttributes){
+                attrStr+= ` ${attr.substr(options.attributeNamePrefix.length)}`;
+            }else{
+                attrStr+= ` ${attr.substr(options.attributeNamePrefix.length)}="${attrVal}"`;
+            }
         }
     }
     return attrStr;
 }
 
+function isStopNode(jPath, options){
+    jPath = jPath.substr(0,jPath.length - options.textNodeName.length - 1);
+    let tagName = jPath.substr(jPath.lastIndexOf(".") + 1);
+    for(let index in options.stopNodes){
+        if(options.stopNodes[index] === jPath || options.stopNodes[index] === "*."+tagName) return true;
+    }
+    return false;
+}
+
 function replaceEntitiesValue(textValue, options){
     if(textValue && textValue.length > 0 && options.processEntities){
       for (const entityName in options.entities) {

package/src/xmlparser/OptionsBuilder.js

@@ -31,36 +31,9 @@ const defaultOptions = {
     htmlEntities: false,
 };
    
-const props = [
-    'preserveOrder',
-    'attributeNamePrefix',
-    'attributesGroupName',
-    'textNodeName',
-    'ignoreAttributes',
-    'removeNSPrefix',
-    'allowBooleanAttributes',
-    'parseTagValue',
-    'parseAttributeValue',
-    'trimValues',
-    'cdataPropName',
-    'tagValueProcessor',
-    'attributeValueProcessor',
-    'numberParseOptions',
-    'stopNodes',
-    'alwaysCreateTextNode',
-    'isArray',
-    'commentPropName',
-    'unpairedTags',
-    'processEntities',
-    'htmlEntities'
-];
-  
-const util = require('../util');
-
 const buildOptions = function(options) {
-    return util.buildOptions(options, defaultOptions, props);
+    return Object.assign({}, defaultOptions, options);
 };
 
 exports.buildOptions = buildOptions;
-exports.defaultOptions = defaultOptions;
-exports.props = props;
+exports.defaultOptions = defaultOptions;

package/src/xmlparser/OrderedObjParser.js

@@ -1,4 +1,5 @@
 'use strict';
+///@ts-check
 
 const util = require('../util');
 const xmlNode = require('./xmlNode');
@@ -40,18 +41,30 @@ class OrderedObjParser{
       "reg" : { regex: /&(reg|#174);/g, val: "®" },
       "inr" : { regex: /&(inr|#8377);/g, val: "₹" },
     };
+    this.addExternalEntities = addExternalEntities;
     this.parseXml = parseXml;
     this.parseTextData = parseTextData;
     this.resolveNameSpace = resolveNameSpace;
     this.buildAttributesMap = buildAttributesMap;
     this.isItStopNode = isItStopNode;
     this.replaceEntitiesValue = replaceEntitiesValue;
-    this.readTagExp = readTagExp;
     this.readStopNodeData = readStopNodeData;
+    this.saveTextToParentTag = saveTextToParentTag;
   }
 
 }
 
+function addExternalEntities(externalEntities){
+  const entKeys = Object.keys(externalEntities);
+  for (let i = 0; i < entKeys.length; i++) {
+    const ent = entKeys[i];
+    this.lastEntities[ent] = {
+       regex: new RegExp("&"+ent+";","g"),
+       val : externalEntities[ent]
+    }
+  }
+}
+
 /**
  * @param {string} val
  * @param {string} tagName
@@ -184,7 +197,7 @@ const parseXml = function(xmlData) {
             , currentNode.tagname
             , jPath
             ,false
-            , currentNode.attributes ? Object.keys(currentNode.attributes).length !== 0 : false
+            , currentNode[":@"] ? Object.keys(currentNode[":@"]).length !== 0 : false
             , Object.keys(currentNode.child).length === 0);
           if(textData !== undefined &&  textData !== "") currentNode.add(this.options.textNodeName, textData);
           textData = "";
@@ -196,24 +209,26 @@ const parseXml = function(xmlData) {
         textData = "";
         i = closeIndex;
       } else if( xmlData[i+1] === '?') {
-        i = findClosingIndex(xmlData, "?>", i, "Pi Tag is not closed.")
+        let tagData = readTagExp(xmlData,i, false, "?>");
+        if(!tagData) throw new Error("Pi Tag is not closed.");
+        textData = this.saveTextToParentTag(textData, currentNode, jPath);
+
+        const childNode = new xmlNode(tagData.tagName);
+        childNode.add(this.options.textNodeName, "");
+        
+        if(tagData.tagName !== tagData.tagExp && tagData.attrExpPresent){
+          childNode[":@"] = this.buildAttributesMap(tagData.tagExp, jPath);
+        }
+        currentNode.addChild(childNode);
+
+        i = tagData.closeIndex + 1;
       } else if(xmlData.substr(i + 1, 3) === '!--') {
         const endIndex = findClosingIndex(xmlData, "-->", i, "Comment is not closed.")
         if(this.options.commentPropName){
           const comment = xmlData.substring(i + 4, endIndex - 2);
 
-          //TODO: remove repeated code
-          if(textData){ //store previously collected data as textNode
-            textData = this.parseTextData(textData
-              , currentNode.tagname
-              , jPath
-              ,false
-              , currentNode.attributes ? Object.keys(currentNode.attributes).length !== 0 : false
-              , Object.keys(currentNode.child).length === 0);
-  
-            if(textData !== undefined &&  textData !== "") currentNode.add(this.options.textNodeName, textData);
-            textData = "";
-          }
+          textData = this.saveTextToParentTag(textData, currentNode, jPath);
+
           currentNode.add(this.options.commentPropName, [ { [this.options.textNodeName] : comment } ]);
         }
         i = endIndex;
@@ -225,17 +240,7 @@ const parseXml = function(xmlData) {
         const closeIndex = findClosingIndex(xmlData, "]]>", i, "CDATA is not closed.") - 2;
         const tagExp = xmlData.substring(i + 9,closeIndex);
 
-        if(textData){ //store previously collected data as textNode
-          textData = this.parseTextData(textData
-            , currentNode.tagname
-            , jPath
-            ,false
-            , currentNode.attributes ? Object.keys(currentNode.attributes).length !== 0 : false
-            , Object.keys(currentNode.child).length === 0);
-
-          if(textData !== undefined &&  textData !== "") currentNode.add(this.options.textNodeName, textData);
-          textData = "";
-        }
+        textData = this.saveTextToParentTag(textData, currentNode, jPath);
 
         //cdata should be set even if it is 0 length string
         if(this.options.cdataPropName){
@@ -251,7 +256,7 @@ const parseXml = function(xmlData) {
         i = closeIndex + 2;
       }else {//Opening tag
        
-        let result = this.readTagExp(xmlData,i);
+        let result = readTagExp(xmlData,i, this. options.removeNSPrefix);
         let tagName= result.tagName;
         let tagExp = result.tagExp;
         let attrExpPresent = result.attrExpPresent;
@@ -265,7 +270,7 @@ const parseXml = function(xmlData) {
               , currentNode.tagname
               , jPath
               , false
-              , currentNode.attributes ? Object.keys(currentNode.attributes).length !== 0 : false
+              , currentNode[":@"] ? Object.keys(currentNode[":@"]).length !== 0 : false
               , false);
             if(textData !== undefined &&  textData !== "") currentNode.add(this.options.textNodeName, textData);
             textData = "";
@@ -299,7 +304,7 @@ const parseXml = function(xmlData) {
 
           const childNode = new xmlNode(tagName);
           if(tagName !== tagExp && attrExpPresent){
-            childNode.attributes = this.buildAttributesMap(tagExp, jPath);
+            childNode[":@"] = this.buildAttributesMap(tagExp, jPath);
           }
           jPath = jPath.substr(0, jPath.lastIndexOf("."));
           childNode.add(this.options.textNodeName, tagContent);
@@ -318,7 +323,7 @@ const parseXml = function(xmlData) {
 
             const childNode = new xmlNode(tagName);
             if(tagName !== tagExp && attrExpPresent){
-              childNode.attributes = this.buildAttributesMap(tagExp, jPath);
+              childNode[":@"] = this.buildAttributesMap(tagExp, jPath);
             }
             jPath = jPath.substr(0, jPath.lastIndexOf("."));
             currentNode.addChild(childNode);
@@ -329,7 +334,7 @@ const parseXml = function(xmlData) {
             this.tagsNodeStack.push(currentNode);
             
             if(tagName !== tagExp && attrExpPresent){
-              childNode.attributes = this.buildAttributesMap(tagExp, jPath);
+              childNode[":@"] = this.buildAttributesMap(tagExp, jPath);
             }
             currentNode.addChild(childNode);
             currentNode = childNode;
@@ -364,6 +369,22 @@ const replaceEntitiesValue = function(val){
   }
   return val;
 }
+function saveTextToParentTag(textData, currentNode, jPath) {
+  if (textData) { //store previously collected data as textNode
+    textData = this.parseTextData(textData,
+      currentNode.tagname,
+      jPath,
+      false,
+      currentNode[":@"] ? Object.keys(currentNode[":@"]).length !== 0 : false,
+      Object.keys(currentNode.child).length === 0);
+
+    if (textData !== undefined && textData !== "")
+      currentNode.add(this.options.textNodeName, textData);
+    textData = "";
+  }
+  return textData;
+}
+
 //TODO: use jPath to simplify the logic
 /**
  * 
@@ -386,7 +407,7 @@ function isItStopNode(stopNodes, jPath, currentTagName){
  * @param {number} i starting index
  * @returns 
  */
-function tagExpWithClosingIndex(xmlData, i){
+function tagExpWithClosingIndex(xmlData, i, closingChar = ">"){
   let attrBoundary;
   let tagExp = "";
   for (let index = i; index < xmlData.length; index++) {
@@ -395,11 +416,20 @@ function tagExpWithClosingIndex(xmlData, i){
         if (ch === attrBoundary) attrBoundary = "";//reset
     } else if (ch === '"' || ch === "'") {
         attrBoundary = ch;
-    } else if (ch === '>') {
+    } else if (ch === closingChar[0]) {
+      if(closingChar[1]){
+        if(xmlData[index + 1] === closingChar[1]){
+          return {
+            data: tagExp,
+            index: index
+          }
+        }
+      }else{
         return {
           data: tagExp,
           index: index
         }
+      }
     } else if (ch === '\t') {
       ch = " "
     }
@@ -416,8 +446,9 @@ function findClosingIndex(xmlData, str, i, errMsg){
   }
 }
 
-function readTagExp(xmlData,i){
-  const result = tagExpWithClosingIndex(xmlData, i+1);
+function readTagExp(xmlData,i, removeNSPrefix, closingChar = ">"){
+  const result = tagExpWithClosingIndex(xmlData, i+1, closingChar);
+  if(!result) return;
   let tagExp = result.data;
   const closeIndex = result.index;
   const separatorIndex = tagExp.search(/\s/);
@@ -428,7 +459,7 @@ function readTagExp(xmlData,i){
     tagExp = tagExp.substr(separatorIndex + 1);
   }
 
-  if(this. options.removeNSPrefix){
+  if(removeNSPrefix){
     const colonIndex = tagName.indexOf(":");
     if(colonIndex !== -1){
       tagName = tagName.substr(colonIndex+1);

package/src/xmlparser/XMLParser.js

@@ -4,8 +4,11 @@ const { prettify} = require("./node2json");
 const validator = require('../validator');
 
 class XMLParser{
+    
     constructor(options){
+        this.externalEntities = {};
         this.options = buildOptions(options);
+        
     }
     /**
      * Parse XML dats to JS object 
@@ -28,10 +31,26 @@ class XMLParser{
             }
           }
         const orderedObjParser = new OrderedObjParser(this.options);
+        orderedObjParser.addExternalEntities(this.externalEntities);
         const orderedResult = orderedObjParser.parseXml(xmlData);
         if(this.options.preserveOrder || orderedResult === undefined) return orderedResult;
         else return prettify(orderedResult, this.options);
     }
+
+    /**
+     * Add Entity which is not by default supported by this library
+     * @param {string} key 
+     * @param {string} value 
+     */
+    addEntity(key, value){
+        if(value.indexOf("&") !== -1){
+            throw new Error("Entity value can't have '&'")
+        }else if(key.indexOf("&") !== -1 || key.indexOf(";") !== -1){
+            throw new Error("An entity must be set without '&' and ';'. Eg. use '#xD' for '
'")
+        }else{
+            this.externalEntities[key] = value;
+        }
+    }
 }
 
 module.exports = XMLParser;

package/src/xmlparser/node2json.js

@@ -37,8 +37,8 @@ function compress(arr, options, jPath){
       let val = compress(tagObj[property], options, newJpath);
       const isLeaf = isLeafTag(val, options);
 
-      if(tagObj.attributes){
-        assignAttributes( val, tagObj.attributes, newJpath, options);
+      if(tagObj[":@"]){
+        assignAttributes( val, tagObj[":@"], newJpath, options);
       }else if(Object.keys(val).length === 1 && val[options.textNodeName] !== undefined && !options.alwaysCreateTextNode){
         val = val[options.textNodeName];
       }else if(Object.keys(val).length === 0){
@@ -74,7 +74,7 @@ function propName(obj){
   const keys = Object.keys(obj);
   for (let i = 0; i < keys.length; i++) {
     const key = keys[i];
-    if(key !== "attributes") return key;
+    if(key !== ":@") return key;
   }
 }
 

package/src/xmlparser/xmlNode.js

@@ -4,15 +4,15 @@ class XmlNode{
   constructor(tagname) {
     this.tagname = tagname;
     this.child = []; //nested tags, text, cdata, comments in order
-    this.attributes = {}; //attributes map
+    this[":@"] = {}; //attributes map
   }
   add(key,val){
     // this.child.push( {name : key, val: val, isCdata: isCdata });
     this.child.push( {[key]: val });
   }
   addChild(node) {
-    if(node.attributes && Object.keys(node.attributes).length > 0){
-      this.child.push( { [node.tagname]: node.child, attributes: node.attributes });
+    if(node[":@"] && Object.keys(node[":@"]).length > 0){
+      this.child.push( { [node.tagname]: node.child, [":@"]: node[":@"] });
     }else{
       this.child.push( { [node.tagname]: node.child });
     }