npm - failproofai - Versions diffs - 1.0.1 → 1.0.2-beta.0 - Mend

failproofai 1.0.1 → 1.0.2-beta.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (389) hide show

package/.next/standalone/fp-cloud-cli/tests/test_v1_origin_diagnostic.py ADDED Viewed

@@ -0,0 +1,70 @@
+"""A 404 in key mode has two very different causes; the CLI must tell them apart.
+Pointing `--base-url` at a dashboard whose front door does not forward `/v1` is
+the likeliest first-run mistake. It used to arrive as a 3xx to `/login`, which
+`_raise_for_status` names explicitly — but a dashboard that correctly declines to
+auth-gate `/v1` (see `dashboard/proxy.ts`) returns its own 404 instead, and on
+the status code alone that is indistinguishable from "no such record".
+The tell is the content type: the API only ever answers JSON.
+"""
+import httpx
+import pytest
+import respx
+from fp_cli import client as api
+from fp_cli.client import AuthMode, ClientContext
+from fp_cli.errors import ApiError, NotFoundError
+BASE = "http://server.test"
+def key_ctx() -> ClientContext:
+    return ClientContext(base_url=BASE, api_key="ak_test", auth_mode=AuthMode.API_KEY)
+@respx.mock
+def test_html_404_names_the_routing_problem() -> None:
+    respx.get(f"{BASE}/v1/events").mock(
+        return_value=httpx.Response(
+            404,
+            text="<!DOCTYPE html><html>404</html>",
+            headers={"content-type": "text/html; charset=utf-8"},
+        )
+    )
+    with pytest.raises(ApiError) as excinfo:
+        api.list_events(key_ctx())
+    assert "not routed" in str(excinfo.value)
+    # Must NOT degrade to the ordinary not-found error, which would send the
+    # reader hunting for a missing record instead of a misconfigured base URL.
+    assert not isinstance(excinfo.value, NotFoundError)
+@respx.mock
+def test_json_404_is_still_an_ordinary_not_found() -> None:
+    """The other half.
+    Without this, the guard above could 'pass' by relabelling every 404 as a
+    routing problem — worse than the bug it fixes, because then a genuinely
+    missing record would send people to check their base URL forever.
+    """
+    respx.get(f"{BASE}/v1/events").mock(
+        return_value=httpx.Response(404, json={"error": "nope"})
+    )
+    with pytest.raises(NotFoundError):
+        api.list_events(key_ctx())
+@respx.mock
+def test_session_mode_html_404_is_untouched() -> None:
+    """Cookie mode keeps its existing behaviour — this diagnostic is key-mode only."""
+    respx.get(f"{BASE}/api/events").mock(
+        return_value=httpx.Response(
+            404,
+            text="<!DOCTYPE html><html>404</html>",
+            headers={"content-type": "text/html; charset=utf-8"},
+        )
+    )
+    with pytest.raises(NotFoundError):
+        api.list_events(ClientContext(base_url=BASE, token="tok"))

package/.next/standalone/fp-cloud-cli/tests/test_v1_routing.py ADDED Viewed

@@ -0,0 +1,214 @@
+"""Anti-drift guard for API-key mode's `/api/*` -> `/v1/*` translation.
+Why this test is shaped the way it is
+-------------------------------------
+The CLI already had an anti-drift test that stayed green through an 85 -> 0 collapse
+(`memory/2026-07-24-typer-026-vendored-click-breaks-cli-errors.md`): it walked the
+command tree with the *same* broken predicate the production code used, so it
+compared nothing to nothing and reported success. The lesson is not "write an
+anti-drift test", it is "get the expectation from a source the production code does
+not also consult".
+So each leg below sources its input independently of `client.py`'s own logic:
+1. The set of paths comes from an **AST scan of client.py's string literals**, not
+   from any registry the translator reads. Add a call site and it appears here
+   whether or not anyone remembered a list.
+2. The unsupported commands are driven through a **real CliRunner**, asserting the
+   exit code AND that zero HTTP calls happened — the "fails before any network
+   call" half is the part a return-value assertion cannot see.
+A third leg used to check every translated `/v1` path against the server router's
+own `.route()` literals, read out of an AgentEye checkout. The server now lives in
+a separate private repository, so that leg could only ever run when a checkout
+happened to be on disk and skipped everywhere else — including all of CI, where a
+skip reads as green. It was removed rather than left switched off. Nothing here
+verifies that a translated path is a route the server actually registers; a rename
+on the server side surfaces as a 404 at runtime.
+"""
+from __future__ import annotations
+import ast
+import pathlib
+import httpx
+import pytest
+import respx
+from fp_cli import client as api
+from fp_cli.app import app
+from fp_cli.errors import KeyModeUnsupportedError
+CLIENT_PY = pathlib.Path(api.__file__)
+BASE = "http://dash.test"
+KEY = "ak_live_abc123"
+# --- leg 1: every /api/ literal in client.py is classified -------------------
+def _api_path_literals(source: str) -> set:
+    """Every `/api/...` path the CLI can build, read straight out of the source.
+    f-strings are reconstructed as templates (`f"/api/keys/{key_id}/disable"` ->
+    `/api/keys/{}/disable`) so an interpolated id becomes a wildcard segment rather
+    than a fragment. The constant *pieces* of an f-string are skipped for exactly that
+    reason: `"/api/issues/"` on its own is not a path anyone requests.
+    """
+    tree = ast.parse(source)
+    inside_fstring = {
+        id(v)
+        for node in ast.walk(tree)
+        if isinstance(node, ast.JoinedStr)
+        for v in node.values
+    }
+    found = set()
+    for node in ast.walk(tree):
+        if isinstance(node, ast.JoinedStr):
+            text = "".join(
+                v.value if isinstance(v, ast.Constant) and isinstance(v.value, str) else "{}"
+                for v in node.values
+            )
+        elif (
+            isinstance(node, ast.Constant)
+            and isinstance(node.value, str)
+            and id(node) not in inside_fstring
+        ):
+            text = node.value
+        else:
+            continue
+        # `> len("/api/")` skips the `_API_PREFIX` constant itself: it is the rule, not
+        # a path, and no real request is ever made to a bare "/api/".
+        if text.startswith("/api/") and len(text) > len("/api/"):
+            found.add(text)
+    return found
+def _buckets(path: str) -> list:
+    """Which classification(s) `path` falls into, computed from the DATA in client.py
+    rather than by calling its classifier — a catch-all `else` in the translator must
+    not be able to make this test pass."""
+    kinds = []
+    if path in api._V1_RENAMED:
+        kinds.append("override")
+    else:
+        # The rename is an exact-match override of the family rule, so it is only
+        # checked when the path is not itself renamed; that keeps the three buckets
+        # genuinely disjoint instead of "exactly one, if you squint".
+        family = path[len("/api/") :].split("/", 1)[0]
+        if family in api._V1_NO_EQUIVALENT:
+            kinds.append("no-v1")
+        if family in api._V1_MECHANICAL_FAMILIES:
+            kinds.append("mechanical")
+    return kinds
+def test_every_api_literal_is_classified_exactly_once():
+    literals = _api_path_literals(CLIENT_PY.read_text())
+    assert literals, "the AST scan found no /api/ paths — it has stopped asking anything"
+    unclassified = sorted(p for p in literals if not _buckets(p))
+    assert not unclassified, (
+        "these /api/ paths have no /v1 classification — add the family to "
+        "_V1_MECHANICAL_FAMILIES, _V1_RENAMED or _V1_NO_EQUIVALENT in client.py "
+        f"(and check the server actually serves it): {unclassified}"
+    )
+    ambiguous = sorted(p for p in literals if len(_buckets(p)) > 1)
+    assert not ambiguous, f"/api paths matching more than one bucket: {ambiguous}"
+def test_no_v1_paths_raise_instead_of_being_requested():
+    literals = _api_path_literals(CLIENT_PY.read_text())
+    excluded = [p for p in literals if _buckets(p) == ["no-v1"]]
+    assert excluded, "the excluded families vanished from client.py — verify on purpose"
+    for path in excluded:
+        with pytest.raises(KeyModeUnsupportedError):
+            api._v1_path(path)
+def test_an_unknown_family_raises_loudly():
+    # The property the two lists above cannot prove about each other: a path in no
+    # bucket must fail, not pass through to a URL nobody chose.
+    with pytest.raises(Exception) as excinfo:
+        api._v1_path("/api/telepathy/read")
+    assert "/api/telepathy/read" in str(excinfo.value)
+def test_the_score_keys_rename_is_applied():
+    # Hyphen -> underscore. It exists only in the dashboard proxy
+    # (dashboard/app/api/evaluations/score-keys/route.ts), so a blind s|^/api|/v1|
+    # 404s and the CLI reports a cheerful "Not found."
+    assert api._v1_path("/api/evaluations/score-keys") == "/v1/evaluations/score_keys"
+    assert api._FACET_PATHS["score_filters"] == "/api/evaluations/score-keys"
+# --- leg 2: unsupported commands fail before any network call -----------------
+UNSUPPORTED = [
+    ["login"],
+    ["logout"],
+    ["orgs", "list"],
+    ["orgs", "switch", "acme"],
+    ["orgs", "current"],
+    ["orgs", "perms"],
+    ["agent", "health"],
+    ["agent", "models"],
+    ["agent", "chats"],
+    ["agent", "ask", "hello"],
+    ["agent", "show", "abc123"],
+    ["agent", "rename", "abc123", "--title", "x"],
+    ["agent", "delete", "abc123", "--yes"],
+    ["keys", "update", "ci-bot", "--add", "keys:read"],
+]
+@pytest.mark.parametrize("argv", UNSUPPORTED, ids=lambda a: " ".join(a[:2]))
+def test_unsupported_command_exits_2_with_zero_http_calls(logged_in, runner, argv):
+    # `logged_in` seeds a saved session deliberately: the failure must come from the
+    # key, not from having nothing else to fall back on.
+    with respx.mock(assert_all_called=False) as mock:
+        catch_all = mock.route().mock(return_value=httpx.Response(200, json={}))
+        result = runner.invoke(app, ["--base-url", BASE, "--api-key", KEY, *argv])
+    assert result.exit_code == 2, f"{argv} -> {result.exit_code}: {result.output}"
+    assert catch_all.call_count == 0, f"{argv} opened a connection before failing"
+def test_unsupported_command_says_why_and_what_to_do(logged_in, runner):
+    result = runner.invoke(app, ["--base-url", BASE, "--api-key", KEY, "--json", "orgs", "list"])
+    assert result.exit_code == 2, result.output
+    assert "API key" in result.stdout
+    assert "fp login" in result.stdout  # the hint rides in the JSON envelope
+def test_whoami_is_the_exception(logged_in, runner):
+    # Contractually "never errors" (cli/skill/SKILL.md leans on it as the pre-flight).
+    result = runner.invoke(app, ["--base-url", BASE, "--api-key", KEY, "whoami"])
+    assert result.exit_code == 0, result.output
+SUPPORTED = [
+    (["keys", "list"], "/v1/keys", []),
+    (["sessions"], "/v1/sessions", {"sessions": [], "next_cursor": None}),
+    (["events"], "/v1/events/summary", {"events": [], "next_cursor": None}),
+    (["issues", "list"], "/v1/issues", []),
+    (["list", "envs"], "/v1/events/environments", []),
+    (["list", "score_filters"], "/v1/evaluations/score_keys", []),
+    (["query", "list"], "/v1/queries", {"queries": []}),
+    (["users", "list"], "/v1/users", []),
+    (["settings", "list"], "/v1/settings", {"settings": []}),
+    (["alerts", "list"], "/v1/alerts", []),
+    (["audits", "list"], "/v1/audits", []),
+]
+@pytest.mark.parametrize("argv,path,body", SUPPORTED, ids=lambda a: " ".join(a[:2]) if isinstance(a, list) else "")
+def test_supported_commands_reach_their_v1_route(logged_in, runner, argv, path, body):
+    """The other half of leg 3: the guard must not have swallowed the working set, and
+    each command must land on the `/v1` route it is supposed to (only this exact URL is
+    mocked, so a wrong path is a connection error, not a quiet pass)."""
+    with respx.mock(assert_all_called=False) as mock:
+        route = mock.get(f"{BASE}{path}").mock(return_value=httpx.Response(200, json=body))
+        result = runner.invoke(app, ["--base-url", BASE, "--api-key", KEY, "--json", *argv])
+    assert result.exit_code == 0, f"{argv} -> {result.exit_code}: {result.output}"
+    assert route.called

package/.next/standalone/fp-cloud-cli/tests/test_whoami.py ADDED Viewed

@@ -0,0 +1,104 @@
+"""`whoami` (logged in): the identity header + permissions/orgs panels, and the
+permission grouping/coloring logic."""
+from __future__ import annotations
+import httpx
+import respx
+from fp_cli import theme
+from fp_cli.app import app
+from fp_cli.output import _group_permissions
+BASE = "http://dash.test"
+# --- permission grouping / coloring -----------------------------------------
+def test_group_permissions_orders_resources_and_actions_by_risk():
+    grouped = _group_permissions(
+        ["keys:delete", "keys:read", "keys:create", "dashboards:read", "agent:use"]
+    )
+    # resources follow the fixed priority order (dashboards < keys < agent)
+    assert [r for r, _ in grouped] == ["dashboards", "keys", "agent"]
+    by_res = dict(grouped)
+    # actions within a row ordered by risk: read → create → delete
+    assert [a for a, _ in by_res["keys"]] == ["read", "create", "delete"]
+    colors = dict(by_res["keys"])
+    assert colors["read"] == theme.PERM_READ
+    assert colors["create"] == theme.PERM_WRITE
+    assert colors["delete"] == theme.PERM_DANGER
+def test_group_permissions_unknown_action_falls_back_neutral():
+    grouped = _group_permissions(["weird:frobnicate"])
+    assert grouped == [("weird", [("frobnicate", theme.DEFAULT_PERM_COLOR)])]
+# --- human render ------------------------------------------------------------
+def _session(memberships):
+    return {
+        "id": "62230791-4811-4f04-b388-ae57bdcb422e",
+        "email": "admin@local.host",
+        "is_instance_admin": True,
+        "memberships": memberships,
+    }
+@respx.mock
+def test_whoami_human_renders_header_and_panels(logged_in, runner):
+    respx.get(f"{BASE}/api/auth/session").mock(
+        return_value=httpx.Response(200, json=_session([
+            {"org_id": "o1", "org_slug": "globex", "org_name": "Globex Corp", "permission_set": "admin",
+             "permissions": ["dashboards:read", "dashboards:write", "dashboards:delete", "keys:read", "agent:use"]},
+            {"org_id": "o2", "org_slug": "acme", "org_name": "Acme Corp", "permission_set": "admin",
+             "permissions": ["events:read"]},
+        ]))
+    )
+    result = runner.invoke(app, ["--org", "globex", "whoami"])
+    assert result.exit_code == 0, result.output
+    out = result.stdout
+    # identity header: email, instance role, FULL user id, active org
+    assert "admin@local.host" in out
+    assert "62230791-4811-4f04-b388-ae57bdcb422e" in out
+    assert "instance admin" in out
+    # permissions panel
+    assert "permissions" in out
+    assert "dashboards" in out and "read" in out and "write" in out and "delete" in out
+    # orgs panel + switch hint to the non-active org
+    assert "your orgs" in out
+    assert "globex" in out and "acme" in out
+    assert "Globex Corp" in out  # permissions title shows the active org NAME
+    assert "fp orgs switch <slug>" in out
+@respx.mock
+def test_whoami_single_org_has_no_switch_hint(logged_in, runner):
+    respx.get(f"{BASE}/api/auth/session").mock(
+        return_value=httpx.Response(200, json=_session([
+            {"org_id": "o", "org_slug": "acme", "org_name": "Acme", "permission_set": "admin",
+             "permissions": ["events:read"]},
+        ]))
+    )
+    result = runner.invoke(app, ["whoami"])
+    assert result.exit_code == 0, result.output
+    assert "your orgs" in result.stdout
+    assert "orgs switch" not in result.stdout  # only one org → no switch hint
+@respx.mock
+def test_whoami_no_color_marks_destructive_actions(logged_in, runner):
+    respx.get(f"{BASE}/api/auth/session").mock(
+        return_value=httpx.Response(200, json=_session([
+            {"org_id": "o", "org_slug": "acme", "org_name": "Acme", "permission_set": "admin",
+             "permissions": ["keys:read", "keys:delete", "keys:disable"]},
+        ]))
+    )
+    result = runner.invoke(app, ["whoami"], env={"NO_COLOR": "1"})
+    assert result.exit_code == 0, result.output
+    out = result.stdout
+    assert "delete*" in out and "disable*" in out  # destructive marked in plain text
+    assert "read" in out and "read*" not in out    # non-destructive unmarked