faf-mcp 2.1.0 → 2.1.2

package/dist/src/handlers/tool-registry.d.ts

@@ -3,8 +3,8 @@
  * Central registry for all MCP tools with metadata
  * Championship-grade organization
  */
-import { Tool } from '@modelcontextprotocol/sdk/types.js';
-import { FafMcpTool } from '../types/mcp-tools.js';
+import type { Tool } from '@modelcontextprotocol/sdk/types.js';
+import type { FafMcpTool } from '../types/mcp-tools.js';
 /**
  * Check if a tool should be visible based on configuration
  */

package/dist/src/handlers/tools.d.ts

@@ -1,4 +1,4 @@
-import { CallToolResult, Tool } from '@modelcontextprotocol/sdk/types.js';
+import type { CallToolResult, Tool } from '@modelcontextprotocol/sdk/types.js';
 import { FafEngineAdapter } from './engine-adapter';
 export declare class FafToolHandler {
     private engineAdapter;

package/dist/src/handlers/tools.js

@@ -42,6 +42,19 @@ const fuzzy_detector_1 = require("../utils/fuzzy-detector");
 const faf_file_finder_js_1 = require("../utils/faf-file-finder.js");
 const version_1 = require("../version");
 const path_resolver_1 = require("../utils/path-resolver");
+// v2.1.1: single-source scoring — same path the championship handler uses.
+// faf_score now reads faf-cli's real scorer (the IANA-spec one) instead of
+// the legacy 40+30+15+14 file-presence pseudo-score. NEVER reimplement
+// scoring or the tier ladder here — that's exactly the drift v2.1.0 set out
+// to kill across the surface; v2.1.1 closes the loop on the active handler.
+//
+// Imported via ../utils/faf-cli-bridge.js — a temporary one-file re-export
+// that pins the relative dist path (faf-cli 6.7.1's `bun` exports condition
+// resolves to a non-shipped src/, breaking the test runner). Both Node and
+// Bun load the same compiled module through the bridge. Bridge is removable
+// once faf-cli drops the bad `bun` condition. See the bridge header for full
+// rationale and the linked tracked issue.
+const faf_cli_bridge_js_1 = require("../utils/faf-cli-bridge.js");
 class FafToolHandler {
     engineAdapter;
     constructor(engineAdapter) {
@@ -802,141 +815,109 @@ class FafToolHandler {
         }
     }
     async handleFafScore(args) {
+        // v2.1.1: single-sourced from faf-cli's real scorer — same number `faf
+        // score` (CLI) and the championship handler emit. The legacy file-
+        // presence pseudo-score (40 + 30 + 15 + 14, capped at 100) is dead.
+        // Headline format carries both `FAF SCORE: <n>/100` AND `(<n>%)` so the
+        // AERO parity regex AND any consumer scanning for the legacy `\d+%`
+        // form continue to match. Invalid/unreadable .faf paths return an
+        // honest `0/100 (0%)` with a diagnostic — no fake numbers, no crash.
+        const cwd = this.getProjectPath(args?.path);
+        const { findFafFile, readFafRaw, scoreFafYaml, getNextTier } = await faf_cli_bridge_js_1.fafCli;
+        const fafPath = findFafFile(cwd);
+        if (!fafPath) {
+            return {
+                content: [
+                    {
+                        type: 'text',
+                        text: `FAF SCORE: 0/100 (0%)  ♡ no .faf\n\n` +
+                            `No \`.faf\` found in \`${cwd}\`.\n` +
+                            `Run \`faf_init\` to create one — then \`faf_score\` reports the real score.`,
+                    },
+                ],
+            };
+        }
+        // Strip ANSI from tier indicator (faf-cli emits colored glyphs).
+        // eslint-disable-next-line no-control-regex
+        const strip = (s) => s.replace(/\[[0-9;]*m/g, '').trim();
+        let raw;
         try {
-            const fs = await import('fs').then(m => m.promises);
-            const path = await import('path');
-            // Get current working directory - uses path param or session context
-            const cwd = this.getProjectPath(args?.path);
-            // Score calculation components
-            let score = 0;
-            const details = [];
-            // 1. Check for FAF file (40 points) - v1.2.0: project.faf, *.faf, or .faf
-            const fafResult = await (0, faf_file_finder_js_1.findFafFile)(cwd);
-            let hasFaf = false;
-            if (fafResult) {
-                hasFaf = true;
-                score += 40;
-                details.push(`✅ ${fafResult.filename} present (+40)`);
-            }
-            else {
-                details.push('❌ FAF file missing (0/40)');
-            }
-            // 2. Check for CLAUDE.md (30 points)
-            const claudePath = path.join(cwd, 'CLAUDE.md');
-            let hasClaude = false;
-            try {
-                await fs.access(claudePath);
-                hasClaude = true;
-                score += 30;
-                details.push('✅ CLAUDE.md present (+30)');
-            }
-            catch {
-                details.push('❌ CLAUDE.md missing (0/30)');
-            }
-            // 3. Check for README.md (15 points)
-            const readmePath = path.join(cwd, 'README.md');
-            let hasReadme = false;
-            try {
-                await fs.access(readmePath);
-                hasReadme = true;
-                score += 15;
-                details.push('✅ README.md present (+15)');
-            }
-            catch {
-                details.push('⚠️  README.md missing (0/15)');
-            }
-            // 4. Check for package.json or other project files (14 points)
-            const projectFiles = ['package.json', 'pyproject.toml', 'Cargo.toml', 'go.mod', 'pom.xml'];
-            let hasProjectFile = false;
-            for (const file of projectFiles) {
-                try {
-                    await fs.access(path.join(cwd, file));
-                    hasProjectFile = true;
-                    score += 14;
-                    details.push(`✅ ${file} detected (+14)`);
-                    break;
-                }
-                catch {
-                    // Continue checking
-                }
-            }
-            if (!hasProjectFile) {
-                details.push('⚠️  No project file found (0/14)');
-            }
-            // Format the output
-            let output = '';
-            if (score >= 100) {
-                // Perfect score - Trophy
-                output = `🏎️ FAF SCORE: 100%\n🏆 Trophy\n🏁 Championship Complete!\n\n`;
-                if (args?.details) {
-                    output += `${details.join('\n')}\n\n`;
-                    output += `🏆 PERFECT SCORE!\n`;
-                    output += `Both .faf and CLAUDE.md are championship-quality!\n`;
-                    output += `\n💡 Note: 🍊 Big Orange is a BADGE awarded separately for excellence beyond metrics.`;
-                }
-            }
-            else {
-                // Regular score - FAF standard tiers
-                const percentage = Math.min(score, 100);
-                let rating = '';
-                let emoji = '';
-                if (percentage >= 99) {
-                    rating = 'Gold';
-                    emoji = '🥇';
-                }
-                else if (percentage >= 95) {
-                    rating = 'Silver';
-                    emoji = '🥈';
-                }
-                else if (percentage >= 85) {
-                    rating = 'Bronze';
-                    emoji = '🥉';
-                }
-                else if (percentage >= 70) {
-                    rating = 'Green';
-                    emoji = '🟢';
-                }
-                else if (percentage >= 55) {
-                    rating = 'Yellow';
-                    emoji = '🟡';
-                }
-                else {
-                    rating = 'Red';
-                    emoji = '🔴';
-                }
-                // The 3-line killer display
-                output = `📊 FAF SCORE: ${percentage}%\n${emoji} ${rating}\n🏁 AI-Ready: ${percentage >= 85 ? 'Yes' : 'Building'}\n`;
-                if (args?.details) {
-                    output += `\n${details.join('\n')}`;
-                    if (percentage < 100) {
-                        output += `\n\n💡 Tips to improve:\n`;
-                        if (!hasFaf)
-                            output += `- Create .faf file with project context\n`;
-                        if (!hasClaude)
-                            output += `- Add CLAUDE.md for AI instructions\n`;
-                        if (!hasReadme)
-                            output += `- Include README.md for documentation\n`;
-                        if (!hasProjectFile)
-                            output += `- Add project configuration file\n`;
-                    }
-                }
-            }
+            raw = readFafRaw(fafPath);
+        }
+        catch (error) {
             return {
-                content: [{
+                content: [
+                    {
                         type: 'text',
-                        text: output
-                    }]
+                        text: `FAF SCORE: 0/100 (0%)  ○ UNREADABLE\n\n` +
+                            `Could not read \`${fafPath}\`: ${error?.message ?? String(error)}`,
+                    },
+                ],
+                isError: true,
             };
         }
+        let result;
+        try {
+            result = scoreFafYaml(raw);
+        }
         catch (error) {
-            // Fallback to displaying a motivational score
+            // Invalid .faf content (malformed YAML, etc.) — honest 0 score with a
+            // diagnostic, not a fake number. The output still carries `0%` so
+            // downstream regex matchers like `/\d+%/` find a percentage token.
             return {
-                content: [{
+                content: [
+                    {
                         type: 'text',
-                        text: `📊 FAF SCORE: 92%\n⭐ Excellence Building\n🏁 Keep Going!\n\n${args?.details ? 'Unable to analyze project files, but your commitment to excellence is clear!' : ''}`
-                    }]
+                        text: `FAF SCORE: 0/100 (0%)  ○ INVALID\n\n` +
+                            `\`${fafPath}\` couldn't be parsed as a valid .faf YAML:\n` +
+                            `  ${error?.message ?? String(error)}\n\n` +
+                            `Re-run \`faf_init\` to regenerate a valid file.`,
+                    },
+                ],
+                isError: true,
             };
         }
+        const score = result.score;
+        const tierDisplay = strip(result.tier.indicator);
+        const next = getNextTier(score);
+        const nextTierDisplay = next ? `${strip(next.indicator)} (${next.threshold}%)` : null;
+        // Progress bar — same width/style as the championship handler.
+        const barWidth = 24;
+        const filled = Math.max(0, Math.min(barWidth, Math.round((score / 100) * barWidth)));
+        const progressBar = '█'.repeat(filled) + '░'.repeat(barWidth - filled);
+        // Headline carries both `/100` AND `(%)` so multiple matchers stay happy.
+        let output = `FAF SCORE: ${score}/100 (${score}%)  ${tierDisplay}\n` +
+            `${progressBar} ${score}%\n` +
+            `${result.populated}/${result.total} slots populated` +
+            (nextTierDisplay ? `  ·  next: ${nextTierDisplay}` : '  ·  top tier') +
+            `\n\n` +
+            `Scored by faf-cli — the same context your AI reads.`;
+        if (args?.details) {
+            const populatedSlots = Object.entries(result.slots)
+                .filter(([, state]) => state === 'populated')
+                .map(([slot]) => slot);
+            const emptySlots = Object.entries(result.slots)
+                .filter(([, state]) => state === 'empty')
+                .map(([slot]) => slot);
+            const ignoredSlots = Object.entries(result.slots)
+                .filter(([, state]) => state === 'slotignored')
+                .map(([slot]) => slot);
+            output += `\n\n--- Slot breakdown ---\n`;
+            output += `Populated (${populatedSlots.length}): ${populatedSlots.join(', ') || '(none)'}\n`;
+            output += `Empty (${emptySlots.length}): ${emptySlots.join(', ') || '(none)'}\n`;
+            output += `Ignored (${ignoredSlots.length}): ${ignoredSlots.join(', ') || '(none)'}`;
+            if (score < 100 && emptySlots.length > 0) {
+                output += `\n\nTip: fill empty slots or mark them \`slotignored\` to climb tiers. Slot-by-slot detail: \`faf score\` (CLI).`;
+            }
+        }
+        return {
+            content: [
+                {
+                    type: 'text',
+                    text: output,
+                },
+            ],
+        };
     }
     async handleFafInit(args) {
         // Native implementation - creates project.faf with Pomelli-simple path resolution!