factory-factory 0.4.9 → 0.4.10

package/dist/src/backend/services/github/service/pr-fetch-coordinator.js

@@ -4,7 +4,10 @@ export class PRFetchCoordinator {
     lastFetchedAt = new Map();
     inFlightClaims = new Map();
     nextClaimToken = 0;
-    async coordinate(workspaceId, fetch, options) {
+    membership = new Map();
+    async coordinate(target, fetch, options) {
+        const workspaceId = typeof target === 'string' ? target : target.prId;
+        const owner = typeof target === 'string' ? target : target.workspaceId;
         const now = Date.now();
         this.pruneExpiredInFlight(now);
         if (this.inFlightClaims.has(workspaceId)) {
@@ -14,6 +17,7 @@ export class PRFetchCoordinator {
             return { status: 'skipped', reason: 'recently_fetched' };
         }
         const claimToken = this.claim(workspaceId, now);
+        this.membership.set(workspaceId, owner);
         try {
             const value = await fetch();
             if (options?.countsAsFetched?.(value) ?? true) {
@@ -31,8 +35,14 @@ export class PRFetchCoordinator {
     }
     removeWorkspace(workspaceId) {
         this.pruneExpiredInFlight(Date.now());
-        this.lastFetchedAt.delete(workspaceId);
-        this.inFlightClaims.delete(workspaceId);
+        for (const [key, owner] of this.membership) {
+            if (owner !== workspaceId) {
+                continue;
+            }
+            this.lastFetchedAt.delete(key);
+            this.inFlightClaims.delete(key);
+            this.membership.delete(key);
+        }
     }
     size() {
         this.pruneExpiredInFlight(Date.now());
@@ -44,6 +54,7 @@ export class PRFetchCoordinator {
     clear() {
         this.lastFetchedAt.clear();
         this.inFlightClaims.clear();
+        this.membership.clear();
     }
     isWithinCooldown(workspaceId, now, cooldownMs) {
         const lastFetch = this.lastFetchedAt.get(workspaceId);
@@ -62,6 +73,9 @@ export class PRFetchCoordinator {
     release(workspaceId, claimToken) {
         if (this.inFlightClaims.get(workspaceId)?.claimToken === claimToken) {
             this.inFlightClaims.delete(workspaceId);
+            if (!this.lastFetchedAt.has(workspaceId)) {
+                this.membership.delete(workspaceId);
+            }
         }
     }
     recordCompleted(workspaceId, claimToken) {
@@ -75,6 +89,9 @@ export class PRFetchCoordinator {
         for (const [workspaceId, claim] of this.inFlightClaims) {
             if (now - claim.startedAt >= SERVICE_CACHE_TTL_MS.workspacePrFetchInFlight) {
                 this.inFlightClaims.delete(workspaceId);
+                if (!this.lastFetchedAt.has(workspaceId)) {
+                    this.membership.delete(workspaceId);
+                }
             }
         }
     }
@@ -91,6 +108,7 @@ export class PRFetchCoordinator {
         if (oldestWorkspaceId !== undefined) {
             this.lastFetchedAt.delete(oldestWorkspaceId);
             this.inFlightClaims.delete(oldestWorkspaceId);
+            this.membership.delete(oldestWorkspaceId);
         }
     }
     oldestBy(entries, startedAt) {

package/dist/src/backend/services/github/service/pr-fetch-coordinator.js.map

@@ -1 +1 @@
-{"version":3,"file":"pr-fetch-coordinator.js","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-fetch-coordinator.ts"],"names":[],"mappings":"AAiCA,OAAO,EAAE,oBAAoB,EAAE,cAAc,EAAE,MAAM,8BAA8B,CAAC;AAEpF,MAAM,mBAAmB,GAAG,MAAM,CAAC;AAkCnC,MAAM,OAAO,kBAAkB;IAGZ,aAAa,GAAG,IAAI,GAAG,EAAkB,CAAC;IAC1C,cAAc,GAAG,IAAI,GAAG,EAA8B,CAAC;IAChE,cAAc,GAAG,CAAC,CAAC;IAM3B,KAAK,CAAC,UAAU,CACd,WAAmB,EACnB,KAAuB,EACvB,OAA8B;QAE9B,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,CAAC;QAE/B,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YACzC,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,kBAAkB,EAAE,CAAC;QAC3D,CAAC;QACD,IAAI,CAAC,OAAO,EAAE,cAAc,IAAI,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,GAAG,EAAE,OAAO,EAAE,UAAU,CAAC,EAAE,CAAC;YAC7F,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,kBAAkB,EAAE,CAAC;QAC3D,CAAC;QAED,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,WAAW,EAAE,GAAG,CAAC,CAAC;QAChD,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,MAAM,KAAK,EAAE,CAAC;YAC5B,IAAI,OAAO,EAAE,eAAe,EAAE,CAAC,KAAK,CAAC,IAAI,IAAI,EAAE,CAAC;gBAC9C,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;YAChD,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;YACxC,CAAC;YACD,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,KAAK,EAAE,CAAC;QACtC,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YAGf,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;YACtC,MAAM,KAAK,CAAC;QACd,CAAC;IACH,CAAC;IAKD,eAAe,CAAC,WAAmB;QACjC,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,GAAG,EAAE,CAAC,CAAC;QACtC,IAAI,CAAC,aAAa,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;QACvC,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;IAC1C,CAAC;IAKD,IAAI;QACF,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,GAAG,EAAE,CAAC,CAAC;QACtC,OAAO;YACL,SAAS,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI;YAClC,QAAQ,EAAE,IAAI,CAAC,cAAc,CAAC,IAAI;SACnC,CAAC;IACJ,CAAC;IAKD,KAAK;QACH,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,CAAC;QAC3B,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE,CAAC;IAC9B,CAAC;IAEO,gBAAgB,CAAC,WAAmB,EAAE,GAAW,EAAE,UAAmB;QAC5E,MAAM,SAAS,GAAG,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;QACtD,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC5B,OAAO,KAAK,CAAC;QACf,CAAC;QACD,OAAO,GAAG,GAAG,SAAS,GAAG,CAAC,UAAU,IAAI,mBAAmB,CAAC,CAAC;IAC/D,CAAC;IAEO,KAAK,CAAC,WAAmB,EAAE,GAAW;QAC5C,IAAI,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;QACpC,IAAI,CAAC,cAAc,IAAI,CAAC,CAAC;QACzB,MAAM,UAAU,GAAG,IAAI,CAAC,cAAc,CAAC;QACvC,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,EAAE,EAAE,SAAS,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;QACrE,OAAO,UAAU,CAAC;IACpB,CAAC;IAQO,OAAO,CAAC,WAAmB,EAAE,UAAkB;QACrD,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,UAAU,KAAK,UAAU,EAAE,CAAC;YACpE,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;QAC1C,CAAC;IACH,CAAC;IAEO,eAAe,CAAC,WAAmB,EAAE,UAAkB;QAC7D,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,UAAU,KAAK,UAAU,EAAE,CAAC;YACpE,OAAO;QACT,CAAC;QACD,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;QACxC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,CAAC,CAAC;IAClD,CAAC;IAEO,oBAAoB,CAAC,GAAW;QACtC,KAAK,MAAM,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YACvD,IAAI,GAAG,GAAG,KAAK,CAAC,SAAS,IAAI,oBAAoB,CAAC,wBAAwB,EAAE,CAAC;gBAC3E,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;YAC1C,CAAC;QACH,CAAC;IACH,CAAC;IAEO,iBAAiB,CAAC,WAAmB;QAC3C,IAAI,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YAChF,OAAO;QACT,CAAC;QAED,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,EAAE,GAAG,IAAI,CAAC,cAAc,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC5F,IAAI,YAAY,CAAC,IAAI,GAAG,cAAc,CAAC,8BAA8B,EAAE,CAAC;YACtE,OAAO;QACT,CAAC;QAOD,MAAM,iBAAiB,GACrB,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC;YAE3D,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,cAAc,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;QAEjE,IAAI,iBAAiB,KAAK,SAAS,EAAE,CAAC;YACpC,IAAI,CAAC,aAAa,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC;YAC7C,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC;QAChD,CAAC;IACH,CAAC;IAEO,QAAQ,CACd,OAAuB,EACvB,SAA+B;QAE/B,IAAI,iBAAqC,CAAC;QAC1C,IAAI,eAAe,GAAG,MAAM,CAAC,iBAAiB,CAAC;QAC/C,KAAK,MAAM,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,OAAO,EAAE,CAAC;YAC3C,MAAM,SAAS,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC;YACnC,IAAI,SAAS,GAAG,eAAe,EAAE,CAAC;gBAChC,iBAAiB,GAAG,WAAW,CAAC;gBAChC,eAAe,GAAG,SAAS,CAAC;YAC9B,CAAC;QACH,CAAC;QACD,OAAO,iBAAiB,CAAC;IAC3B,CAAC;CACF;AAED,MAAM,CAAC,MAAM,kBAAkB,GAAG,IAAI,kBAAkB,EAAE,CAAC"}
+{"version":3,"file":"pr-fetch-coordinator.js","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-fetch-coordinator.ts"],"names":[],"mappings":"AAiCA,OAAO,EAAE,oBAAoB,EAAE,cAAc,EAAE,MAAM,8BAA8B,CAAC;AAEpF,MAAM,mBAAmB,GAAG,MAAM,CAAC;AAkCnC,MAAM,OAAO,kBAAkB;IAGZ,aAAa,GAAG,IAAI,GAAG,EAAkB,CAAC;IAC1C,cAAc,GAAG,IAAI,GAAG,EAA8B,CAAC;IAChE,cAAc,GAAG,CAAC,CAAC;IACV,UAAU,GAAG,IAAI,GAAG,EAAkB,CAAC;IAMxD,KAAK,CAAC,UAAU,CACd,MAAsD,EACtD,KAAuB,EACvB,OAA8B;QAE9B,MAAM,WAAW,GAAG,OAAO,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC;QACtE,MAAM,KAAK,GAAG,OAAO,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,WAAW,CAAC;QACvE,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QACvB,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,CAAC;QAE/B,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YACzC,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,kBAAkB,EAAE,CAAC;QAC3D,CAAC;QACD,IAAI,CAAC,OAAO,EAAE,cAAc,IAAI,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,GAAG,EAAE,OAAO,EAAE,UAAU,CAAC,EAAE,CAAC;YAC7F,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,kBAAkB,EAAE,CAAC;QAC3D,CAAC;QAED,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,WAAW,EAAE,GAAG,CAAC,CAAC;QAChD,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC;QACxC,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,MAAM,KAAK,EAAE,CAAC;YAC5B,IAAI,OAAO,EAAE,eAAe,EAAE,CAAC,KAAK,CAAC,IAAI,IAAI,EAAE,CAAC;gBAC9C,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;YAChD,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;YACxC,CAAC;YACD,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,KAAK,EAAE,CAAC;QACtC,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YAGf,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;YACtC,MAAM,KAAK,CAAC;QACd,CAAC;IACH,CAAC;IAKD,eAAe,CAAC,WAAmB;QACjC,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,GAAG,EAAE,CAAC,CAAC;QACtC,KAAK,MAAM,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;YAC3C,IAAI,KAAK,KAAK,WAAW,EAAE,CAAC;gBAC1B,SAAS;YACX,CAAC;YACD,IAAI,CAAC,aAAa,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;YAC/B,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;YAChC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QAC9B,CAAC;IACH,CAAC;IAKD,IAAI;QACF,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,GAAG,EAAE,CAAC,CAAC;QACtC,OAAO;YACL,SAAS,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI;YAClC,QAAQ,EAAE,IAAI,CAAC,cAAc,CAAC,IAAI;SACnC,CAAC;IACJ,CAAC;IAKD,KAAK;QACH,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,CAAC;QAC3B,IAAI,CAAC,cAAc,CAAC,KAAK,EAAE,CAAC;QAC5B,IAAI,CAAC,UAAU,CAAC,KAAK,EAAE,CAAC;IAC1B,CAAC;IAEO,gBAAgB,CAAC,WAAmB,EAAE,GAAW,EAAE,UAAmB;QAC5E,MAAM,SAAS,GAAG,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;QACtD,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC5B,OAAO,KAAK,CAAC;QACf,CAAC;QACD,OAAO,GAAG,GAAG,SAAS,GAAG,CAAC,UAAU,IAAI,mBAAmB,CAAC,CAAC;IAC/D,CAAC;IAEO,KAAK,CAAC,WAAmB,EAAE,GAAW;QAC5C,IAAI,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;QACpC,IAAI,CAAC,cAAc,IAAI,CAAC,CAAC;QACzB,MAAM,UAAU,GAAG,IAAI,CAAC,cAAc,CAAC;QACvC,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,EAAE,EAAE,SAAS,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;QACrE,OAAO,UAAU,CAAC;IACpB,CAAC;IAQO,OAAO,CAAC,WAAmB,EAAE,UAAkB;QACrD,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,UAAU,KAAK,UAAU,EAAE,CAAC;YACpE,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;YACxC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;gBACzC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;YACtC,CAAC;QACH,CAAC;IACH,CAAC;IAEO,eAAe,CAAC,WAAmB,EAAE,UAAkB;QAC7D,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,UAAU,KAAK,UAAU,EAAE,CAAC;YACpE,OAAO;QACT,CAAC;QACD,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;QACxC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,CAAC,CAAC;IAClD,CAAC;IAEO,oBAAoB,CAAC,GAAW;QACtC,KAAK,MAAM,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YACvD,IAAI,GAAG,GAAG,KAAK,CAAC,SAAS,IAAI,oBAAoB,CAAC,wBAAwB,EAAE,CAAC;gBAC3E,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;gBACxC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;oBACzC,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;gBACtC,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAEO,iBAAiB,CAAC,WAAmB;QAC3C,IAAI,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YAChF,OAAO;QACT,CAAC;QAED,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC,CAAC,GAAG,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,EAAE,GAAG,IAAI,CAAC,cAAc,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;QAC5F,IAAI,YAAY,CAAC,IAAI,GAAG,cAAc,CAAC,8BAA8B,EAAE,CAAC;YACtE,OAAO;QACT,CAAC;QAOD,MAAM,iBAAiB,GACrB,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC;YAE3D,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,cAAc,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;QAEjE,IAAI,iBAAiB,KAAK,SAAS,EAAE,CAAC;YACpC,IAAI,CAAC,aAAa,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC;YAC7C,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC;YAC9C,IAAI,CAAC,UAAU,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC;QAC5C,CAAC;IACH,CAAC;IAEO,QAAQ,CACd,OAAuB,EACvB,SAA+B;QAE/B,IAAI,iBAAqC,CAAC;QAC1C,IAAI,eAAe,GAAG,MAAM,CAAC,iBAAiB,CAAC;QAC/C,KAAK,MAAM,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,OAAO,EAAE,CAAC;YAC3C,MAAM,SAAS,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC;YACnC,IAAI,SAAS,GAAG,eAAe,EAAE,CAAC;gBAChC,iBAAiB,GAAG,WAAW,CAAC;gBAChC,eAAe,GAAG,SAAS,CAAC;YAC9B,CAAC;QACH,CAAC;QACD,OAAO,iBAAiB,CAAC;IAC3B,CAAC;CACF;AAED,MAAM,CAAC,MAAM,kBAAkB,GAAG,IAAI,kBAAkB,EAAE,CAAC"}

package/dist/src/backend/services/github/service/pr-observation.service.d.ts

@@ -0,0 +1,19 @@
+import type { RatchetReviewTriggerMode } from '../../../../../prisma/generated/client.js';
+import type { PRObservation, PRTarget } from '../../../../shared/pr-monitoring.js';
+interface ObservationPorts {
+    findPR(target: PRTarget): Promise<{
+        url: string;
+    } | null>;
+    readPolicy(): Promise<{
+        reviewTriggerMode: RatchetReviewTriggerMode;
+    }>;
+}
+declare class PRObservationService {
+    private ports;
+    private username;
+    configure(ports: ObservationPorts): void;
+    fetch(target: PRTarget, signal?: AbortSignal): Promise<PRObservation>;
+}
+export declare const prObservationService: PRObservationService;
+export {};
+//# sourceMappingURL=pr-observation.service.d.ts.map

package/dist/src/backend/services/github/service/pr-observation.service.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"pr-observation.service.d.ts","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-observation.service.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,wBAAwB,EAAE,MAAM,oBAAoB,CAAC;AAEnE,OAAO,KAAK,EAAE,aAAa,EAAE,QAAQ,EAAE,MAAM,wBAAwB,CAAC;AAStE,UAAU,gBAAgB;IACxB,MAAM,CAAC,MAAM,EAAE,QAAQ,GAAG,OAAO,CAAC;QAAE,GAAG,EAAE,MAAM,CAAA;KAAE,GAAG,IAAI,CAAC,CAAC;IAC1D,UAAU,IAAI,OAAO,CAAC;QAAE,iBAAiB,EAAE,wBAAwB,CAAA;KAAE,CAAC,CAAC;CACxE;AAQD,cAAM,oBAAoB;IACxB,OAAO,CAAC,KAAK,CAAiC;IAC9C,OAAO,CAAC,QAAQ,CAA4D;IAC5E,SAAS,CAAC,KAAK,EAAE,gBAAgB,QAEhC;IACK,KAAK,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,CAAC,EAAE,WAAW,GAAG,OAAO,CAAC,aAAa,CAAC,CAmH1E;CACF;AACD,eAAO,MAAM,oBAAoB,sBAA6B,CAAC"}

package/dist/src/backend/services/github/service/pr-observation.service.js

@@ -0,0 +1,145 @@
+import { createHash } from 'node:crypto';
+import { deriveCiStatusFromCheckRollup, reduceCheckRollupToLatestRunAttempts } from '../../../../shared/core/index.js';
+import { prObservationSchema } from '../../../../shared/schemas/pr-event.schema.js';
+import { githubCLIService } from './github-cli.service.js';
+import { isIgnoredReviewAuthor, isOwnAdversarialReviewMarker, selectActionableReviews, } from './pr-actionable-review.js';
+function hash(value) {
+    return createHash('sha256').update(value).digest('hex');
+}
+function timestamp(value) {
+    const date = value ? new Date(value) : null;
+    return date && Number.isFinite(date.getTime()) ? date.toISOString() : null;
+}
+class PRObservationService {
+    ports = null;
+    username = null;
+    configure(ports) {
+        this.ports = ports;
+    }
+    async fetch(target, signal) {
+        if (!this.ports) {
+            throw new Error('PR observation service is not configured');
+        }
+        const association = await this.ports.findPR(target);
+        if (!association) {
+            throw new Error('PR association no longer exists');
+        }
+        const match = association.url.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)\/?$/);
+        if (!match) {
+            throw new Error('Invalid GitHub PR URL');
+        }
+        const repository = `${match[1]}/${match[2]}`;
+        const number = Number(match[3]);
+        const policy = await this.ports.readPolicy();
+        if (!this.username || this.username.expiresAt < Date.now()) {
+            this.username = {
+                value: await githubCLIService.getAuthenticatedUsername(signal),
+                expiresAt: Date.now() + 300_000,
+            };
+        }
+        const username = this.username.value;
+        let reviewsComplete = true;
+        const incomplete = () => {
+            reviewsComplete = false;
+        };
+        const [details, comments, resolved] = await Promise.all([
+            githubCLIService.getPRFullDetails(repository, number, signal),
+            githubCLIService.getReviewComments(repository, number, undefined, signal, incomplete),
+            githubCLIService
+                .getResolvedReviewCommentIds(repository, number, signal, incomplete)
+                .catch(() => {
+                signal?.throwIfAborted();
+                reviewsComplete = false;
+                return new Set();
+            }),
+        ]);
+        signal?.throwIfAborted();
+        if (!details.headRefOid) {
+            throw new Error('GitHub observation is missing head SHA');
+        }
+        const checks = reduceCheckRollupToLatestRunAttempts(details.statusCheckRollup)?.map((c) => ({
+            identity: c.detailsUrl || `${c.workflowName ?? ''}:${c.name ?? ''}`,
+            attempt: null,
+            name: c.name ?? '',
+            workflowName: c.workflowName ?? null,
+            status: c.status ?? 'UNKNOWN',
+            conclusion: c.conclusion ?? null,
+            detailsUrl: c.detailsUrl || null,
+            startedAt: timestamp(c.startedAt),
+            completedAt: timestamp(c.completedAt),
+        })) ?? [];
+        const actionableReviews = [
+            ...selectActionableReviews(details.reviews, username, policy.reviewTriggerMode).map((r) => ({
+                identity: `review:${r.id}`,
+                contentHash: hash(r.body ?? ''),
+                author: r.author.login,
+                body: r.body ?? '',
+                path: null,
+                line: null,
+                url: `${association.url}#pullrequestreview-${r.id}`,
+                activityAt: timestamp(r.submittedAt) ?? timestamp(details.updatedAt) ?? '1970-01-01T00:00:00.000Z',
+            })),
+            ...comments
+                .filter((c) => !(resolved.has(c.id) || isIgnoredReviewAuthor(c.author.login, username)))
+                .map((c) => ({
+                identity: `comment:${c.id}`,
+                contentHash: hash(c.body),
+                author: c.author.login,
+                body: c.body,
+                path: c.path,
+                line: c.line,
+                url: c.url,
+                activityAt: timestamp(c.updatedAt) ?? timestamp(c.createdAt) ?? '1970-01-01T00:00:00.000Z',
+            })),
+            ...details.comments
+                .filter((c) => isOwnAdversarialReviewMarker(c, username))
+                .map((c) => ({
+                identity: `conversation:${c.id}`,
+                contentHash: hash(c.body),
+                author: c.author.login,
+                body: c.body,
+                path: null,
+                line: null,
+                url: c.url,
+                activityAt: timestamp(c.updatedAt) ?? timestamp(c.createdAt) ?? '1970-01-01T00:00:00.000Z',
+            })),
+        ];
+        return prObservationSchema.parse({
+            url: association.url,
+            title: details.title,
+            repository,
+            number,
+            headSha: details.headRefOid,
+            headBranch: details.headRefName,
+            baseBranch: details.baseRefName,
+            observedAt: new Date().toISOString(),
+            prState: observationState(details),
+            ciStatus: details.statusCheckRollup === null
+                ? 'UNKNOWN'
+                : deriveCiStatusFromCheckRollup(details.statusCheckRollup),
+            reviewState: details.reviewDecision,
+            hasMergeConflict: details.mergeStateStatus === 'DIRTY',
+            checks,
+            actionableReviews,
+            reviewsComplete,
+            resolvedReviewIds: [...resolved].map((id) => `comment:${id}`),
+        });
+    }
+}
+export const prObservationService = new PRObservationService();
+function observationState(details) {
+    if (details.state !== 'OPEN') {
+        return details.state;
+    }
+    if (details.isDraft) {
+        return 'DRAFT';
+    }
+    if (details.reviewDecision === 'CHANGES_REQUESTED') {
+        return 'CHANGES_REQUESTED';
+    }
+    if (details.reviewDecision === 'APPROVED') {
+        return 'APPROVED';
+    }
+    return 'OPEN';
+}
+//# sourceMappingURL=pr-observation.service.js.map

package/dist/src/backend/services/github/service/pr-observation.service.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pr-observation.service.js","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-observation.service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAC;AAEzC,OAAO,EAAE,6BAA6B,EAAE,oCAAoC,EAAE,MAAM,eAAe,CAAC;AAEpG,OAAO,EAAE,mBAAmB,EAAE,MAAM,kCAAkC,CAAC;AACvE,OAAO,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,EACL,qBAAqB,EACrB,4BAA4B,EAC5B,uBAAuB,GACxB,MAAM,wBAAwB,CAAC;AAMhC,SAAS,IAAI,CAAC,KAAa;IACzB,OAAO,UAAU,CAAC,QAAQ,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;AAC1D,CAAC;AACD,SAAS,SAAS,CAAC,KAAgC;IACjD,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAC5C,OAAO,IAAI,IAAI,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;AAC7E,CAAC;AACD,MAAM,oBAAoB;IAChB,KAAK,GAA4B,IAAI,CAAC;IACtC,QAAQ,GAAuD,IAAI,CAAC;IAC5E,SAAS,CAAC,KAAuB;QAC/B,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;IACrB,CAAC;IACD,KAAK,CAAC,KAAK,CAAC,MAAgB,EAAE,MAAoB;QAChD,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,CAAC;YAChB,MAAM,IAAI,KAAK,CAAC,0CAA0C,CAAC,CAAC;QAC9D,CAAC;QACD,MAAM,WAAW,GAAG,MAAM,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QACpD,IAAI,CAAC,WAAW,EAAE,CAAC;YACjB,MAAM,IAAI,KAAK,CAAC,iCAAiC,CAAC,CAAC;QACrD,CAAC;QACD,MAAM,KAAK,GAAG,WAAW,CAAC,GAAG,CAAC,KAAK,CACjC,2DAA2D,CAC5D,CAAC;QACF,IAAI,CAAC,KAAK,EAAE,CAAC;YACX,MAAM,IAAI,KAAK,CAAC,uBAAuB,CAAC,CAAC;QAC3C,CAAC;QACD,MAAM,UAAU,GAAG,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;QAC7C,MAAM,MAAM,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,KAAK,CAAC,UAAU,EAAE,CAAC;QAC7C,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,EAAE,CAAC;YAC3D,IAAI,CAAC,QAAQ,GAAG;gBACd,KAAK,EAAE,MAAM,gBAAgB,CAAC,wBAAwB,CAAC,MAAM,CAAC;gBAC9D,SAAS,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,OAAO;aAChC,CAAC;QACJ,CAAC;QACD,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC;QACrC,IAAI,eAAe,GAAG,IAAI,CAAC;QAC3B,MAAM,UAAU,GAAG,GAAG,EAAE;YACtB,eAAe,GAAG,KAAK,CAAC;QAC1B,CAAC,CAAC;QACF,MAAM,CAAC,OAAO,EAAE,QAAQ,EAAE,QAAQ,CAAC,GAAG,MAAM,OAAO,CAAC,GAAG,CAAC;YACtD,gBAAgB,CAAC,gBAAgB,CAAC,UAAU,EAAE,MAAM,EAAE,MAAM,CAAC;YAC7D,gBAAgB,CAAC,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,UAAU,CAAC;YACrF,gBAAgB;iBACb,2BAA2B,CAAC,UAAU,EAAE,MAAM,EAAE,MAAM,EAAE,UAAU,CAAC;iBACnE,KAAK,CAAC,GAAG,EAAE;gBACV,MAAM,EAAE,cAAc,EAAE,CAAC;gBACzB,eAAe,GAAG,KAAK,CAAC;gBACxB,OAAO,IAAI,GAAG,EAAU,CAAC;YAC3B,CAAC,CAAC;SACL,CAAC,CAAC;QACH,MAAM,EAAE,cAAc,EAAE,CAAC;QACzB,IAAI,CAAC,OAAO,CAAC,UAAU,EAAE,CAAC;YACxB,MAAM,IAAI,KAAK,CAAC,wCAAwC,CAAC,CAAC;QAC5D,CAAC;QACD,MAAM,MAAM,GACV,oCAAoC,CAAC,OAAO,CAAC,iBAAiB,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC3E,QAAQ,EAAE,CAAC,CAAC,UAAU,IAAI,GAAG,CAAC,CAAC,YAAY,IAAI,EAAE,IAAI,CAAC,CAAC,IAAI,IAAI,EAAE,EAAE;YACnE,OAAO,EAAE,IAAI;YACb,IAAI,EAAE,CAAC,CAAC,IAAI,IAAI,EAAE;YAClB,YAAY,EAAE,CAAC,CAAC,YAAY,IAAI,IAAI;YACpC,MAAM,EAAE,CAAC,CAAC,MAAM,IAAI,SAAS;YAC7B,UAAU,EAAE,CAAC,CAAC,UAAU,IAAI,IAAI;YAChC,UAAU,EAAE,CAAC,CAAC,UAAU,IAAI,IAAI;YAChC,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC;YACjC,WAAW,EAAE,SAAS,CAAC,CAAC,CAAC,WAAW,CAAC;SACtC,CAAC,CAAC,IAAI,EAAE,CAAC;QACZ,MAAM,iBAAiB,GAAG;YACxB,GAAG,uBAAuB,CAAC,OAAO,CAAC,OAAO,EAAE,QAAQ,EAAE,MAAM,CAAC,iBAAiB,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;gBAC1F,QAAQ,EAAE,UAAU,CAAC,CAAC,EAAE,EAAE;gBAC1B,WAAW,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,IAAI,EAAE,CAAC;gBAC/B,MAAM,EAAE,CAAC,CAAC,MAAM,CAAC,KAAK;gBACtB,IAAI,EAAE,CAAC,CAAC,IAAI,IAAI,EAAE;gBAClB,IAAI,EAAE,IAAI;gBACV,IAAI,EAAE,IAAI;gBACV,GAAG,EAAE,GAAG,WAAW,CAAC,GAAG,sBAAsB,CAAC,CAAC,EAAE,EAAE;gBACnD,UAAU,EACR,SAAS,CAAC,CAAC,CAAC,WAAW,CAAC,IAAI,SAAS,CAAC,OAAO,CAAC,SAAS,CAAC,IAAI,0BAA0B;aACzF,CAAC,CAAC;YACH,GAAG,QAAQ;iBACR,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,qBAAqB,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,EAAE,QAAQ,CAAC,CAAC,CAAC;iBACvF,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;gBACX,QAAQ,EAAE,WAAW,CAAC,CAAC,EAAE,EAAE;gBAC3B,WAAW,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;gBACzB,MAAM,EAAE,CAAC,CAAC,MAAM,CAAC,KAAK;gBACtB,IAAI,EAAE,CAAC,CAAC,IAAI;gBACZ,IAAI,EAAE,CAAC,CAAC,IAAI;gBACZ,IAAI,EAAE,CAAC,CAAC,IAAI;gBACZ,GAAG,EAAE,CAAC,CAAC,GAAG;gBACV,UAAU,EACR,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,0BAA0B;aACjF,CAAC,CAAC;YACL,GAAG,OAAO,CAAC,QAAQ;iBAChB,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,4BAA4B,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC;iBACxD,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;gBACX,QAAQ,EAAE,gBAAgB,CAAC,CAAC,EAAE,EAAE;gBAChC,WAAW,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;gBACzB,MAAM,EAAE,CAAC,CAAC,MAAM,CAAC,KAAK;gBACtB,IAAI,EAAE,CAAC,CAAC,IAAI;gBACZ,IAAI,EAAE,IAAI;gBACV,IAAI,EAAE,IAAI;gBACV,GAAG,EAAE,CAAC,CAAC,GAAG;gBACV,UAAU,EACR,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,0BAA0B;aACjF,CAAC,CAAC;SACN,CAAC;QACF,OAAO,mBAAmB,CAAC,KAAK,CAAC;YAC/B,GAAG,EAAE,WAAW,CAAC,GAAG;YACpB,KAAK,EAAE,OAAO,CAAC,KAAK;YACpB,UAAU;YACV,MAAM;YACN,OAAO,EAAE,OAAO,CAAC,UAAU;YAC3B,UAAU,EAAE,OAAO,CAAC,WAAW;YAC/B,UAAU,EAAE,OAAO,CAAC,WAAW;YAC/B,UAAU,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;YACpC,OAAO,EAAE,gBAAgB,CAAC,OAAO,CAAC;YAClC,QAAQ,EACN,OAAO,CAAC,iBAAiB,KAAK,IAAI;gBAChC,CAAC,CAAC,SAAS;gBACX,CAAC,CAAC,6BAA6B,CAAC,OAAO,CAAC,iBAAiB,CAAC;YAC9D,WAAW,EAAE,OAAO,CAAC,cAAc;YACnC,gBAAgB,EAAE,OAAO,CAAC,gBAAgB,KAAK,OAAO;YACtD,MAAM;YACN,iBAAiB;YACjB,eAAe;YACf,iBAAiB,EAAE,CAAC,GAAG,QAAQ,CAAC,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC;SAC9D,CAAC,CAAC;IACL,CAAC;CACF;AACD,MAAM,CAAC,MAAM,oBAAoB,GAAG,IAAI,oBAAoB,EAAE,CAAC;AAE/D,SAAS,gBAAgB,CAAC,OAAsE;IAC9F,IAAI,OAAO,CAAC,KAAK,KAAK,MAAM,EAAE,CAAC;QAC7B,OAAO,OAAO,CAAC,KAAK,CAAC;IACvB,CAAC;IACD,IAAI,OAAO,CAAC,OAAO,EAAE,CAAC;QACpB,OAAO,OAAO,CAAC;IACjB,CAAC;IACD,IAAI,OAAO,CAAC,cAAc,KAAK,mBAAmB,EAAE,CAAC;QACnD,OAAO,mBAAmB,CAAC;IAC7B,CAAC;IACD,IAAI,OAAO,CAAC,cAAc,KAAK,UAAU,EAAE,CAAC;QAC1C,OAAO,UAAU,CAAC;IACpB,CAAC;IACD,OAAO,MAAM,CAAC;AAChB,CAAC"}

package/dist/src/backend/services/github/service/pr-observation.service.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=pr-observation.service.test.d.ts.map

package/dist/src/backend/services/github/service/pr-observation.service.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"pr-observation.service.test.d.ts","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-observation.service.test.ts"],"names":[],"mappings":""}

package/dist/src/backend/services/github/service/pr-observation.service.test.js

@@ -0,0 +1,166 @@
+import { expect, it, vi } from 'vitest';
+import { redObservation } from '../../../../shared/pr-monitoring.test-helpers.js';
+import { githubCLIService } from './github-cli.service.js';
+import { prObservationService } from './pr-observation.service.js';
+it('fetches the explicit association and rejects missing head metadata', async () => {
+    prObservationService.configure({
+        findPR: async () => ({ url: redObservation.url }),
+        readPolicy: async () => ({ reviewTriggerMode: 'CHANGES_REQUESTED' }),
+    });
+    vi.spyOn(githubCLIService, 'getAuthenticatedUsername').mockResolvedValue('me');
+    vi.spyOn(githubCLIService, 'getReviewComments').mockResolvedValue([]);
+    vi.spyOn(githubCLIService, 'getResolvedReviewCommentIds').mockResolvedValue(new Set());
+    const fetch = vi.spyOn(githubCLIService, 'getPRFullDetails').mockResolvedValue({
+        number: 1,
+        title: 'PR',
+        url: redObservation.url,
+        author: { login: 'me' },
+        repository: { name: 'repo', nameWithOwner: 'org/repo' },
+        createdAt: redObservation.observedAt,
+        updatedAt: redObservation.observedAt,
+        isDraft: false,
+        state: 'OPEN',
+        reviewDecision: null,
+        statusCheckRollup: null,
+        reviews: [],
+        comments: [],
+        labels: [],
+        additions: 0,
+        deletions: 0,
+        changedFiles: 0,
+        headRefName: 'feature',
+        baseRefName: 'main',
+        mergeStateStatus: 'UNKNOWN',
+    });
+    await expect(prObservationService.fetch({ workspaceId: 'w', prId: 'p' })).rejects.toThrow('head');
+    expect(fetch).toHaveBeenCalledWith('org/repo', 1, undefined);
+});
+it('preserves CI and conflicts when the auxiliary resolved-thread lookup fails', async () => {
+    prObservationService.configure({
+        findPR: async () => ({ url: redObservation.url }),
+        readPolicy: async () => ({ reviewTriggerMode: 'CHANGES_REQUESTED' }),
+    });
+    vi.spyOn(githubCLIService, 'getAuthenticatedUsername').mockResolvedValue('me');
+    vi.spyOn(githubCLIService, 'getReviewComments').mockResolvedValue([]);
+    vi.spyOn(githubCLIService, 'getResolvedReviewCommentIds').mockRejectedValue(new Error('auxiliary unavailable'));
+    vi.spyOn(githubCLIService, 'getPRFullDetails').mockResolvedValue({
+        number: 1,
+        title: 'PR',
+        url: redObservation.url,
+        author: { login: 'me' },
+        repository: { name: 'repo', nameWithOwner: 'org/repo' },
+        createdAt: redObservation.observedAt,
+        updatedAt: redObservation.observedAt,
+        isDraft: false,
+        state: 'OPEN',
+        reviewDecision: null,
+        statusCheckRollup: [
+            {
+                __typename: 'CheckRun',
+                name: 'test',
+                status: 'COMPLETED',
+                conclusion: 'FAILURE',
+                detailsUrl: 'https://github.com/org/repo/actions/runs/1',
+            },
+        ],
+        reviews: [],
+        comments: [],
+        labels: [],
+        additions: 0,
+        deletions: 0,
+        changedFiles: 0,
+        headRefName: 'feature',
+        headRefOid: 'sha',
+        baseRefName: 'main',
+        mergeStateStatus: 'DIRTY',
+    });
+    await expect(prObservationService.fetch({ workspaceId: 'w', prId: 'p' })).resolves.toMatchObject({
+        ciStatus: 'FAILURE',
+        hasMergeConflict: true,
+        reviewsComplete: false,
+        resolvedReviewIds: [],
+    });
+});
+it('carries resolved comment identities even when review comment pages are incomplete', async () => {
+    prObservationService.configure({
+        findPR: async () => ({ url: redObservation.url }),
+        readPolicy: async () => ({ reviewTriggerMode: 'CHANGES_REQUESTED' }),
+    });
+    vi.spyOn(githubCLIService, 'getAuthenticatedUsername').mockResolvedValue('me');
+    vi.spyOn(githubCLIService, 'getPRFullDetails').mockResolvedValue({
+        number: 1,
+        title: 'PR',
+        url: redObservation.url,
+        author: { login: 'me' },
+        repository: { name: 'repo', nameWithOwner: 'org/repo' },
+        createdAt: redObservation.observedAt,
+        updatedAt: redObservation.observedAt,
+        isDraft: false,
+        state: 'OPEN',
+        reviewDecision: null,
+        statusCheckRollup: [
+            {
+                __typename: 'CheckRun',
+                name: 'test',
+                status: 'COMPLETED',
+                conclusion: 'FAILURE',
+                detailsUrl: 'https://github.com/org/repo/actions/runs/1',
+            },
+        ],
+        reviews: [],
+        comments: [],
+        labels: [],
+        additions: 0,
+        deletions: 0,
+        changedFiles: 0,
+        headRefName: 'feature',
+        headRefOid: 'sha',
+        baseRefName: 'main',
+        mergeStateStatus: 'DIRTY',
+    });
+    vi.spyOn(githubCLIService, 'getReviewComments').mockImplementation((_repo, _number, _since, _signal, incomplete) => {
+        incomplete?.();
+        return Promise.resolve([]);
+    });
+    vi.spyOn(githubCLIService, 'getResolvedReviewCommentIds').mockResolvedValue(new Set([9]));
+    await expect(prObservationService.fetch({ workspaceId: 'w', prId: 'p' })).resolves.toMatchObject({
+        reviewsComplete: false,
+        resolvedReviewIds: ['comment:9'],
+    });
+});
+it('carries the GitHub title into the normalized monitoring observation', async () => {
+    prObservationService.configure({
+        findPR: async () => ({ url: redObservation.url }),
+        readPolicy: async () => ({ reviewTriggerMode: 'CHANGES_REQUESTED' }),
+    });
+    vi.spyOn(githubCLIService, 'getAuthenticatedUsername').mockResolvedValue('me');
+    vi.spyOn(githubCLIService, 'getReviewComments').mockResolvedValue([]);
+    vi.spyOn(githubCLIService, 'getResolvedReviewCommentIds').mockResolvedValue(new Set());
+    vi.spyOn(githubCLIService, 'getPRFullDetails').mockResolvedValue({
+        number: 1,
+        title: 'Update title from GitHub',
+        url: redObservation.url,
+        author: { login: 'me' },
+        repository: { name: 'repo', nameWithOwner: 'org/repo' },
+        createdAt: redObservation.observedAt,
+        updatedAt: redObservation.observedAt,
+        isDraft: false,
+        state: 'OPEN',
+        reviewDecision: null,
+        statusCheckRollup: null,
+        reviews: [],
+        comments: [],
+        labels: [],
+        additions: 0,
+        deletions: 0,
+        changedFiles: 0,
+        headRefName: 'feature',
+        headRefOid: 'sha',
+        baseRefName: 'main',
+        mergeStateStatus: 'UNKNOWN',
+    });
+    await expect(prObservationService.fetch({ workspaceId: 'w', prId: 'p' })).resolves.toMatchObject({
+        title: 'Update title from GitHub',
+    });
+});
+//# sourceMappingURL=pr-observation.service.test.js.map

package/dist/src/backend/services/github/service/pr-observation.service.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pr-observation.service.test.js","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-observation.service.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,cAAc,EAAE,MAAM,qCAAqC,CAAC;AACrE,OAAO,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,EAAE,oBAAoB,EAAE,MAAM,0BAA0B,CAAC;AAEhE,EAAE,CAAC,oEAAoE,EAAE,KAAK,IAAI,EAAE;IAClF,oBAAoB,CAAC,SAAS,CAAC;QAC7B,MAAM,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,GAAG,EAAE,cAAc,CAAC,GAAG,EAAE,CAAC;QACjD,UAAU,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,CAAC;KACrE,CAAC,CAAC;IACH,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,0BAA0B,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IAC/E,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,mBAAmB,CAAC,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;IACtE,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,6BAA6B,CAAC,CAAC,iBAAiB,CAAC,IAAI,GAAG,EAAE,CAAC,CAAC;IACvF,MAAM,KAAK,GAAG,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,kBAAkB,CAAC,CAAC,iBAAiB,CAAC;QAC7E,MAAM,EAAE,CAAC;QACT,KAAK,EAAE,IAAI;QACX,GAAG,EAAE,cAAc,CAAC,GAAG;QACvB,MAAM,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE;QACvB,UAAU,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,aAAa,EAAE,UAAU,EAAE;QACvD,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,OAAO,EAAE,KAAK;QACd,KAAK,EAAE,MAAM;QACb,cAAc,EAAE,IAAI;QACpB,iBAAiB,EAAE,IAAI;QACvB,OAAO,EAAE,EAAE;QACX,QAAQ,EAAE,EAAE;QACZ,MAAM,EAAE,EAAE;QACV,SAAS,EAAE,CAAC;QACZ,SAAS,EAAE,CAAC;QACZ,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,SAAS;QACtB,WAAW,EAAE,MAAM;QACnB,gBAAgB,EAAE,SAAS;KAC5B,CAAC,CAAC;IACH,MAAM,MAAM,CAAC,oBAAoB,CAAC,KAAK,CAAC,EAAE,WAAW,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;IAClG,MAAM,CAAC,KAAK,CAAC,CAAC,oBAAoB,CAAC,UAAU,EAAE,CAAC,EAAE,SAAS,CAAC,CAAC;AAC/D,CAAC,CAAC,CAAC;AACH,EAAE,CAAC,4EAA4E,EAAE,KAAK,IAAI,EAAE;IAC1F,oBAAoB,CAAC,SAAS,CAAC;QAC7B,MAAM,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,GAAG,EAAE,cAAc,CAAC,GAAG,EAAE,CAAC;QACjD,UAAU,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,CAAC;KACrE,CAAC,CAAC;IACH,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,0BAA0B,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IAC/E,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,mBAAmB,CAAC,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;IACtE,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,6BAA6B,CAAC,CAAC,iBAAiB,CACzE,IAAI,KAAK,CAAC,uBAAuB,CAAC,CACnC,CAAC;IACF,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,kBAAkB,CAAC,CAAC,iBAAiB,CAAC;QAC/D,MAAM,EAAE,CAAC;QACT,KAAK,EAAE,IAAI;QACX,GAAG,EAAE,cAAc,CAAC,GAAG;QACvB,MAAM,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE;QACvB,UAAU,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,aAAa,EAAE,UAAU,EAAE;QACvD,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,OAAO,EAAE,KAAK;QACd,KAAK,EAAE,MAAM;QACb,cAAc,EAAE,IAAI;QACpB,iBAAiB,EAAE;YACjB;gBACE,UAAU,EAAE,UAAU;gBACtB,IAAI,EAAE,MAAM;gBACZ,MAAM,EAAE,WAAW;gBACnB,UAAU,EAAE,SAAS;gBACrB,UAAU,EAAE,4CAA4C;aACzD;SACF;QACD,OAAO,EAAE,EAAE;QACX,QAAQ,EAAE,EAAE;QACZ,MAAM,EAAE,EAAE;QACV,SAAS,EAAE,CAAC;QACZ,SAAS,EAAE,CAAC;QACZ,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,SAAS;QACtB,UAAU,EAAE,KAAK;QACjB,WAAW,EAAE,MAAM;QACnB,gBAAgB,EAAE,OAAO;KAC1B,CAAC,CAAC;IACH,MAAM,MAAM,CAAC,oBAAoB,CAAC,KAAK,CAAC,EAAE,WAAW,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,CAAC;QAC/F,QAAQ,EAAE,SAAS;QACnB,gBAAgB,EAAE,IAAI;QACtB,eAAe,EAAE,KAAK;QACtB,iBAAiB,EAAE,EAAE;KACtB,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AACH,EAAE,CAAC,mFAAmF,EAAE,KAAK,IAAI,EAAE;IACjG,oBAAoB,CAAC,SAAS,CAAC;QAC7B,MAAM,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,GAAG,EAAE,cAAc,CAAC,GAAG,EAAE,CAAC;QACjD,UAAU,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,CAAC;KACrE,CAAC,CAAC;IACH,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,0BAA0B,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IAE/E,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,kBAAkB,CAAC,CAAC,iBAAiB,CAAC;QAC/D,MAAM,EAAE,CAAC;QACT,KAAK,EAAE,IAAI;QACX,GAAG,EAAE,cAAc,CAAC,GAAG;QACvB,MAAM,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE;QACvB,UAAU,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,aAAa,EAAE,UAAU,EAAE;QACvD,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,OAAO,EAAE,KAAK;QACd,KAAK,EAAE,MAAM;QACb,cAAc,EAAE,IAAI;QACpB,iBAAiB,EAAE;YACjB;gBACE,UAAU,EAAE,UAAU;gBACtB,IAAI,EAAE,MAAM;gBACZ,MAAM,EAAE,WAAW;gBACnB,UAAU,EAAE,SAAS;gBACrB,UAAU,EAAE,4CAA4C;aACzD;SACF;QACD,OAAO,EAAE,EAAE;QACX,QAAQ,EAAE,EAAE;QACZ,MAAM,EAAE,EAAE;QACV,SAAS,EAAE,CAAC;QACZ,SAAS,EAAE,CAAC;QACZ,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,SAAS;QACtB,UAAU,EAAE,KAAK;QACjB,WAAW,EAAE,MAAM;QACnB,gBAAgB,EAAE,OAAO;KAC1B,CAAC,CAAC;IACH,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,mBAAmB,CAAC,CAAC,kBAAkB,CAChE,CAAC,KAAK,EAAE,OAAO,EAAE,MAAM,EAAE,OAAO,EAAE,UAAU,EAAE,EAAE;QAC9C,UAAU,EAAE,EAAE,CAAC;QACf,OAAO,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC7B,CAAC,CACF,CAAC;IACF,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,6BAA6B,CAAC,CAAC,iBAAiB,CAAC,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IAC1F,MAAM,MAAM,CAAC,oBAAoB,CAAC,KAAK,CAAC,EAAE,WAAW,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,CAAC;QAC/F,eAAe,EAAE,KAAK;QACtB,iBAAiB,EAAE,CAAC,WAAW,CAAC;KACjC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,EAAE,CAAC,qEAAqE,EAAE,KAAK,IAAI,EAAE;IACnF,oBAAoB,CAAC,SAAS,CAAC;QAC7B,MAAM,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,GAAG,EAAE,cAAc,CAAC,GAAG,EAAE,CAAC;QACjD,UAAU,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,CAAC;KACrE,CAAC,CAAC;IACH,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,0BAA0B,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IAC/E,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,mBAAmB,CAAC,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;IACtE,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,6BAA6B,CAAC,CAAC,iBAAiB,CAAC,IAAI,GAAG,EAAE,CAAC,CAAC;IACvF,EAAE,CAAC,KAAK,CAAC,gBAAgB,EAAE,kBAAkB,CAAC,CAAC,iBAAiB,CAAC;QAC/D,MAAM,EAAE,CAAC;QACT,KAAK,EAAE,0BAA0B;QACjC,GAAG,EAAE,cAAc,CAAC,GAAG;QACvB,MAAM,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE;QACvB,UAAU,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,aAAa,EAAE,UAAU,EAAE;QACvD,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,SAAS,EAAE,cAAc,CAAC,UAAU;QACpC,OAAO,EAAE,KAAK;QACd,KAAK,EAAE,MAAM;QACb,cAAc,EAAE,IAAI;QACpB,iBAAiB,EAAE,IAAI;QACvB,OAAO,EAAE,EAAE;QACX,QAAQ,EAAE,EAAE;QACZ,MAAM,EAAE,EAAE;QACV,SAAS,EAAE,CAAC;QACZ,SAAS,EAAE,CAAC;QACZ,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,SAAS;QACtB,UAAU,EAAE,KAAK;QACjB,WAAW,EAAE,MAAM;QACnB,gBAAgB,EAAE,SAAS;KAC5B,CAAC,CAAC;IACH,MAAM,MAAM,CAAC,oBAAoB,CAAC,KAAK,CAAC,EAAE,WAAW,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,CAAC;QAC/F,KAAK,EAAE,0BAA0B;KAClC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/src/backend/services/github/service/pr-snapshot-collection.service.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=pr-snapshot-collection.service.test.d.ts.map

package/dist/src/backend/services/github/service/pr-snapshot-collection.service.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"pr-snapshot-collection.service.test.d.ts","sourceRoot":"","sources":["../../../../../../src/backend/services/github/service/pr-snapshot-collection.service.test.ts"],"names":[],"mappings":""}