factory-factory 0.2.6 → 0.2.7

package/dist/src/backend/domains/ratchet/ratchet.service.test.js

@@ -0,0 +1,873 @@
+import { CIStatus, RatchetState, SessionStatus } from '../../../../prisma/generated/client.js';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { unsafeCoerce } from '../../../test-utils/unsafe-coerce.js';
+vi.mock('@/backend/resource_accessors/workspace.accessor', () => ({
+    workspaceAccessor: {
+        findWithPRsForRatchet: vi.fn(),
+        findForRatchetById: vi.fn(),
+        update: vi.fn(),
+    },
+}));
+vi.mock('@/backend/resource_accessors/claude-session.accessor', () => ({
+    claudeSessionAccessor: {
+        findById: vi.fn(),
+        findByWorkspaceId: vi.fn(),
+    },
+}));
+vi.mock('./fixer-session.service', () => ({
+    fixerSessionService: {
+        acquireAndDispatch: vi.fn(),
+    },
+}));
+vi.mock('@/backend/services/logger.service', () => ({
+    createLogger: () => ({
+        debug: vi.fn(),
+        info: vi.fn(),
+        warn: vi.fn(),
+        error: vi.fn(),
+    }),
+}));
+import { claudeSessionAccessor } from '../../../backend/resource_accessors/claude-session.accessor.js';
+import { workspaceAccessor } from '../../../backend/resource_accessors/workspace.accessor.js';
+import { fixerSessionService } from './fixer-session.service.js';
+import { ratchetService } from './ratchet.service.js';
+const mockSessionBridge = {
+    isSessionRunning: vi.fn(),
+    isSessionWorking: vi.fn(),
+    stopClaudeSession: vi.fn(),
+    startClaudeSession: vi.fn(),
+    getClient: vi.fn(),
+    injectCommittedUserMessage: vi.fn(),
+};
+const mockGitHubBridge = {
+    extractPRInfo: vi.fn(),
+    getPRFullDetails: vi.fn(),
+    getReviewComments: vi.fn(),
+    computeCIStatus: vi.fn(),
+    getAuthenticatedUsername: vi.fn(),
+    fetchAndComputePRState: vi.fn(),
+};
+describe('ratchet service (state-change + idle dispatch)', () => {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        unsafeCoerce(ratchetService).isShuttingDown = false;
+        ratchetService.configure({ session: mockSessionBridge, github: mockGitHubBridge });
+        vi.mocked(mockGitHubBridge.getAuthenticatedUsername).mockResolvedValue(null);
+        vi.mocked(mockSessionBridge.isSessionWorking).mockReturnValue(false);
+    });
+    it('checks workspaces and processes each', async () => {
+        vi.mocked(workspaceAccessor.findWithPRsForRatchet).mockResolvedValue([
+            {
+                id: 'ws-1',
+                prUrl: 'https://github.com/example/repo/pull/1',
+                prNumber: 1,
+                prState: 'OPEN',
+                prCiStatus: CIStatus.UNKNOWN,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.IDLE,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            },
+        ]);
+        vi.spyOn(unsafeCoerce(ratchetService), 'processWorkspace').mockResolvedValue({
+            workspaceId: 'ws-1',
+            previousState: RatchetState.IDLE,
+            newState: RatchetState.IDLE,
+            action: { type: 'WAITING', reason: 'noop' },
+        });
+        const result = await ratchetService.checkAllWorkspaces();
+        expect(result.checked).toBe(1);
+    });
+    it('does not dispatch when workspace ratcheting is disabled', async () => {
+        const workspace = {
+            id: 'ws-disabled',
+            prUrl: 'https://github.com/example/repo/pull/2',
+            prNumber: 2,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: false,
+            ratchetState: RatchetState.IDLE,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: null,
+            prReviewLastCheckedAt: null,
+        };
+        const fetchPRStateSpy = vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState');
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        const triggerSpy = vi.spyOn(unsafeCoerce(ratchetService), 'triggerFixer');
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(fetchPRStateSpy).not.toHaveBeenCalled();
+        expect(triggerSpy).not.toHaveBeenCalled();
+        expect(result).toMatchObject({
+            action: { type: 'DISABLED', reason: 'Workspace ratcheting disabled' },
+            newState: RatchetState.IDLE,
+        });
+    });
+    it('does not dispatch when workspace is not idle', async () => {
+        const workspace = {
+            id: 'ws-busy',
+            prUrl: 'https://github.com/example/repo/pull/3',
+            prNumber: 3,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.IDLE,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: null,
+            prReviewLastCheckedAt: new Date('2026-01-01T00:00:00Z'),
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.SUCCESS,
+            snapshotKey: '2026-01-02T00:00:00Z',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: new Date('2026-01-02T00:00:00Z').getTime(),
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 3,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([
+            {
+                id: 'chat-1',
+                workflow: 'default-followup',
+                status: 'RUNNING',
+            },
+        ]);
+        vi.mocked(mockSessionBridge.isSessionWorking).mockReturnValue(true);
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(result).toMatchObject({
+            action: {
+                type: 'WAITING',
+                reason: 'Workspace is not idle (active session)',
+            },
+        });
+    });
+    it('dispatches when PR state changed since last ratchet', async () => {
+        const workspace = {
+            id: 'ws-change',
+            prUrl: 'https://github.com/example/repo/pull/4',
+            prNumber: 4,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.IDLE,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: '2026-01-01T00:00:00Z',
+            prReviewLastCheckedAt: new Date('2026-01-01T00:00:00Z'),
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.FAILURE,
+            snapshotKey: '2026-01-02T00:00:00Z',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: null,
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 4,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([]);
+        vi.mocked(fixerSessionService.acquireAndDispatch).mockResolvedValue({
+            status: 'started',
+            sessionId: 'ratchet-session',
+            promptSent: true,
+        });
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(result).toMatchObject({
+            action: { type: 'TRIGGERED_FIXER' },
+        });
+        const finalUpdatePayload = vi.mocked(workspaceAccessor.update).mock.calls.at(-1)?.[1];
+        expect(finalUpdatePayload.ratchetLastCiRunId).toBe('2026-01-02T00:00:00Z');
+        expect(finalUpdatePayload).toHaveProperty('prReviewLastCheckedAt');
+    });
+    it('does dispatch when session is running but idle', async () => {
+        const workspace = {
+            id: 'ws-idle-session',
+            prUrl: 'https://github.com/example/repo/pull/44',
+            prNumber: 44,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.IDLE,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: '2026-01-01T00:00:00Z',
+            prReviewLastCheckedAt: new Date('2026-01-01T00:00:00Z'),
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.FAILURE,
+            snapshotKey: '2026-01-02T00:00:00Z',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: null,
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 44,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([
+            {
+                id: 'chat-idle-1',
+                workflow: 'default-followup',
+                status: 'RUNNING',
+            },
+        ]);
+        vi.mocked(mockSessionBridge.isSessionWorking).mockReturnValue(false);
+        vi.mocked(fixerSessionService.acquireAndDispatch).mockResolvedValue({
+            status: 'started',
+            sessionId: 'ratchet-session-idle-ok',
+            promptSent: true,
+        });
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(result).toMatchObject({
+            action: { type: 'TRIGGERED_FIXER', sessionId: 'ratchet-session-idle-ok' },
+        });
+    });
+    it('does not dispatch when PR state unchanged since last dispatch', async () => {
+        const workspace = {
+            id: 'ws-unchanged',
+            prUrl: 'https://github.com/example/repo/pull/5',
+            prNumber: 5,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.READY,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: '2026-01-02T00:00:00Z',
+            prReviewLastCheckedAt: new Date('2026-01-02T00:00:00Z'),
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.FAILURE,
+            snapshotKey: '2026-01-02T00:00:00Z',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: null,
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 5,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([]);
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(result).toMatchObject({
+            action: {
+                type: 'WAITING',
+                reason: 'PR state unchanged since last ratchet dispatch',
+            },
+        });
+        expect(claudeSessionAccessor.findByWorkspaceId).not.toHaveBeenCalled();
+    });
+    it('does not dispatch repeatedly for unchanged CHANGES_REQUESTED state', async () => {
+        const workspace = {
+            id: 'ws-review-unchanged',
+            prUrl: 'https://github.com/example/repo/pull/55',
+            prNumber: 55,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.REVIEW_PENDING,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: 'ci:SUCCESS|changes-requested:1735776000000',
+            prReviewLastCheckedAt: new Date('2026-01-02T00:00:00Z'),
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.SUCCESS,
+            snapshotKey: 'ci:SUCCESS|changes-requested:1735776000000',
+            hasChangesRequested: true,
+            latestReviewActivityAtMs: new Date('2026-01-02T00:00:00Z').getTime(),
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 55,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([]);
+        const triggerSpy = vi.spyOn(unsafeCoerce(ratchetService), 'triggerFixer');
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(triggerSpy).not.toHaveBeenCalled();
+        expect(result).toMatchObject({
+            action: {
+                type: 'WAITING',
+                reason: 'PR state unchanged since last ratchet dispatch',
+            },
+        });
+        expect(claudeSessionAccessor.findByWorkspaceId).not.toHaveBeenCalled();
+    });
+    it('treats closed PR as IDLE and does not dispatch', () => {
+        const state = unsafeCoerce(ratchetService).determineRatchetState({
+            ciStatus: CIStatus.SUCCESS,
+            snapshotKey: '2026-01-02T00:00:00Z',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: null,
+            prState: 'CLOSED',
+            prNumber: 6,
+        });
+        expect(state).toBe(RatchetState.IDLE);
+    });
+    it('handles prompt delivery failure by clearing active session and stopping runner', async () => {
+        const workspace = {
+            id: 'ws-prompt-fail',
+            prUrl: 'https://github.com/example/repo/pull/7',
+            prNumber: 7,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.IDLE,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: null,
+            prReviewLastCheckedAt: null,
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.SUCCESS,
+            snapshotKey: '2026-01-02T00:00:00Z',
+            hasChangesRequested: true,
+            latestReviewActivityAtMs: new Date('2026-01-02T00:00:00Z').getTime(),
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 7,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([]);
+        vi.mocked(fixerSessionService.acquireAndDispatch).mockResolvedValue({
+            status: 'started',
+            sessionId: 'ratchet-session',
+            promptSent: false,
+        });
+        vi.mocked(mockSessionBridge.isSessionRunning).mockReturnValue(true);
+        vi.mocked(mockSessionBridge.stopClaudeSession).mockResolvedValue();
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(result).toMatchObject({
+            action: { type: 'ERROR', error: 'Failed to deliver initial ratchet prompt' },
+        });
+        expect(workspaceAccessor.update).toHaveBeenCalledWith(workspace.id, {
+            ratchetActiveSessionId: null,
+        });
+        expect(mockSessionBridge.stopClaudeSession).toHaveBeenCalledWith('ratchet-session');
+    });
+    it('does not dispatch on a clean PR with no new review activity', async () => {
+        const workspace = {
+            id: 'ws-clean',
+            prUrl: 'https://github.com/example/repo/pull/8',
+            prNumber: 8,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.READY,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: '2026-01-01T00:00:00Z',
+            prReviewLastCheckedAt: new Date('2026-01-02T00:00:00Z'),
+        };
+        vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue({
+            ciStatus: CIStatus.SUCCESS,
+            snapshotKey: '2026-01-03T00:00:00Z',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: new Date('2026-01-02T00:00:00Z').getTime(),
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 8,
+        });
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        vi.mocked(claudeSessionAccessor.findByWorkspaceId).mockResolvedValue([]);
+        const triggerSpy = vi.spyOn(unsafeCoerce(ratchetService), 'triggerFixer');
+        const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+        expect(triggerSpy).not.toHaveBeenCalled();
+        expect(result).toMatchObject({
+            action: {
+                type: 'WAITING',
+                reason: 'PR is clean (green CI and no new review activity)',
+            },
+        });
+    });
+    it('clears active ratchet session immediately when runtime is not running', async () => {
+        const workspace = {
+            id: 'ws-stale-active',
+            prUrl: 'https://github.com/example/repo/pull/9',
+            prNumber: 9,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.CI_FAILED,
+            ratchetActiveSessionId: 'ratchet-session',
+            ratchetLastCiRunId: null,
+            prReviewLastCheckedAt: null,
+        };
+        vi.mocked(claudeSessionAccessor.findById).mockResolvedValue({
+            id: 'ratchet-session',
+            status: SessionStatus.RUNNING,
+        });
+        vi.mocked(mockSessionBridge.isSessionRunning).mockReturnValue(false);
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        const action = await unsafeCoerce(ratchetService).getActiveRatchetSession(workspace);
+        expect(action).toBeNull();
+        expect(workspaceAccessor.update).toHaveBeenCalledWith(workspace.id, {
+            ratchetActiveSessionId: null,
+        });
+    });
+    it('stops and clears active ratchet session when runtime is idle', async () => {
+        const workspace = {
+            id: 'ws-idle-active',
+            prUrl: 'https://github.com/example/repo/pull/11',
+            prNumber: 11,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.CI_FAILED,
+            ratchetActiveSessionId: 'ratchet-session',
+            ratchetLastCiRunId: null,
+            prReviewLastCheckedAt: null,
+        };
+        vi.mocked(claudeSessionAccessor.findById).mockResolvedValue({
+            id: 'ratchet-session',
+            status: SessionStatus.RUNNING,
+        });
+        vi.mocked(mockSessionBridge.isSessionRunning).mockReturnValue(true);
+        vi.mocked(mockSessionBridge.isSessionWorking).mockReturnValue(false);
+        vi.mocked(mockSessionBridge.stopClaudeSession).mockResolvedValue();
+        vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+        const action = await unsafeCoerce(ratchetService).getActiveRatchetSession(workspace);
+        expect(action).toBeNull();
+        expect(workspaceAccessor.update).toHaveBeenCalledWith(workspace.id, {
+            ratchetActiveSessionId: null,
+        });
+        expect(mockSessionBridge.stopClaudeSession).toHaveBeenCalledWith('ratchet-session');
+    });
+    it('decides to trigger fixer when context is actionable', () => {
+        const decision = unsafeCoerce(ratchetService).decideRatchetAction({
+            workspace: { ratchetEnabled: true },
+            prStateInfo: { prState: 'OPEN', ciStatus: CIStatus.FAILURE },
+            isCleanPrWithNoNewReviewActivity: false,
+            activeRatchetSession: null,
+            hasStateChangedSinceLastDispatch: true,
+            hasOtherActiveSession: false,
+        });
+        expect(decision).toEqual({ type: 'TRIGGER_FIXER' });
+    });
+    it('waits when CI is not in terminal state (PENDING)', () => {
+        const decision = unsafeCoerce(ratchetService).decideRatchetAction({
+            workspace: { ratchetEnabled: true },
+            prStateInfo: { prState: 'OPEN', ciStatus: CIStatus.PENDING },
+            isCleanPrWithNoNewReviewActivity: false,
+            activeRatchetSession: null,
+            hasStateChangedSinceLastDispatch: true,
+            hasOtherActiveSession: false,
+        });
+        expect(decision).toEqual({
+            type: 'RETURN_ACTION',
+            action: { type: 'WAITING', reason: 'Waiting for CI to complete (not in terminal state)' },
+        });
+    });
+    it('waits when CI is not in terminal state (UNKNOWN)', () => {
+        const decision = unsafeCoerce(ratchetService).decideRatchetAction({
+            workspace: { ratchetEnabled: true },
+            prStateInfo: { prState: 'OPEN', ciStatus: CIStatus.UNKNOWN },
+            isCleanPrWithNoNewReviewActivity: false,
+            activeRatchetSession: null,
+            hasStateChangedSinceLastDispatch: true,
+            hasOtherActiveSession: false,
+        });
+        expect(decision).toEqual({
+            type: 'RETURN_ACTION',
+            action: { type: 'WAITING', reason: 'Waiting for CI to complete (not in terminal state)' },
+        });
+    });
+    it('prefers precomputed review-activity diagnostics from decision context', () => {
+        const workspace = {
+            id: 'ws-log-diag',
+            prUrl: 'https://github.com/example/repo/pull/10',
+            prNumber: 10,
+            prState: 'OPEN',
+            prCiStatus: CIStatus.UNKNOWN,
+            ratchetEnabled: true,
+            ratchetState: RatchetState.READY,
+            ratchetActiveSessionId: null,
+            ratchetLastCiRunId: 'prev-snapshot',
+            prReviewLastCheckedAt: null,
+        };
+        const prStateInfo = {
+            ciStatus: CIStatus.SUCCESS,
+            snapshotKey: 'next-snapshot',
+            hasChangesRequested: false,
+            latestReviewActivityAtMs: null,
+            statusCheckRollup: null,
+            prState: 'OPEN',
+            prNumber: 10,
+        };
+        const logContext = unsafeCoerce(ratchetService).buildRatchetingLogContext(workspace, RatchetState.READY, RatchetState.READY, { type: 'WAITING', reason: 'noop' }, prStateInfo, 10, { hasNewReviewActivitySinceLastDispatch: true });
+        expect(logContext.reviewTimestampComparison.hasNewReviewActivitySinceLastDispatch).toBe(true);
+    });
+    it('ignores review activity authored by the authenticated user', () => {
+        const latestActivity = unsafeCoerce(ratchetService).computeLatestReviewActivityAtMs({
+            reviews: [
+                { submittedAt: '2026-01-02T00:00:00Z', author: { login: 'ratchet-bot' } },
+                { submittedAt: '2026-01-01T00:00:00Z', author: { login: 'reviewer' } },
+            ],
+            comments: [{ updatedAt: '2026-01-02T01:00:00Z', author: { login: 'ratchet-bot' } }],
+        }, [{ updatedAt: '2026-01-01T02:00:00Z', author: { login: 'reviewer2' } }], 'ratchet-bot');
+        expect(latestActivity).toBe(new Date('2026-01-01T02:00:00Z').getTime());
+    });
+    describe('determineRatchetState', () => {
+        const callDetermineRatchetState = (pr) => unsafeCoerce(ratchetService).determineRatchetState(pr);
+        it('returns MERGED for merged PR', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.SUCCESS,
+                prState: 'MERGED',
+                hasChangesRequested: false,
+            })).toBe(RatchetState.MERGED);
+        });
+        it('returns IDLE for closed (non-merged) PR', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.SUCCESS,
+                prState: 'CLOSED',
+                hasChangesRequested: false,
+            })).toBe(RatchetState.IDLE);
+        });
+        it('returns CI_RUNNING for PENDING CI on open PR', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.PENDING,
+                prState: 'OPEN',
+                hasChangesRequested: false,
+            })).toBe(RatchetState.CI_RUNNING);
+        });
+        it('returns CI_RUNNING for UNKNOWN CI on open PR', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.UNKNOWN,
+                prState: 'OPEN',
+                hasChangesRequested: false,
+            })).toBe(RatchetState.CI_RUNNING);
+        });
+        it('returns CI_FAILED for FAILURE CI on open PR', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.FAILURE,
+                prState: 'OPEN',
+                hasChangesRequested: false,
+            })).toBe(RatchetState.CI_FAILED);
+        });
+        it('returns REVIEW_PENDING when changes requested on open PR with passing CI', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.SUCCESS,
+                prState: 'OPEN',
+                hasChangesRequested: true,
+            })).toBe(RatchetState.REVIEW_PENDING);
+        });
+        it('returns READY when open PR with passing CI and no changes requested', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.SUCCESS,
+                prState: 'OPEN',
+                hasChangesRequested: false,
+            })).toBe(RatchetState.READY);
+        });
+        it('returns CI_FAILED even when changes are requested if CI is failing', () => {
+            expect(callDetermineRatchetState({
+                ciStatus: CIStatus.FAILURE,
+                prState: 'OPEN',
+                hasChangesRequested: true,
+            })).toBe(RatchetState.CI_FAILED);
+        });
+    });
+    describe('computeDispatchSnapshotKey', () => {
+        const callComputeSnapshotKey = (ciStatus, hasChangesRequested, latestReviewActivityAtMs, statusChecks) => unsafeCoerce(ratchetService).computeDispatchSnapshotKey(ciStatus, hasChangesRequested, latestReviewActivityAtMs, statusChecks);
+        it('includes CI status in key for non-failure states', () => {
+            const key = callComputeSnapshotKey(CIStatus.SUCCESS, false, null, null);
+            expect(key).toContain('ci:SUCCESS');
+            expect(key).toContain('no-changes-requested');
+            expect(key).toContain('none');
+        });
+        it('includes failed check details in key for FAILURE status', () => {
+            const key = callComputeSnapshotKey(CIStatus.FAILURE, false, null, [
+                {
+                    name: 'test',
+                    conclusion: 'FAILURE',
+                    detailsUrl: 'https://github.com/o/r/actions/runs/12345',
+                },
+            ]);
+            expect(key).toContain('ci:FAILURE');
+            expect(key).toContain('test:FAILURE:12345');
+        });
+        it('sorts failed checks for stable key generation', () => {
+            const key = callComputeSnapshotKey(CIStatus.FAILURE, false, null, [
+                {
+                    name: 'ztest',
+                    conclusion: 'FAILURE',
+                    detailsUrl: 'https://github.com/o/r/actions/runs/2',
+                },
+                {
+                    name: 'atest',
+                    conclusion: 'FAILURE',
+                    detailsUrl: 'https://github.com/o/r/actions/runs/1',
+                },
+            ]);
+            expect(key.indexOf('atest')).toBeLessThan(key.indexOf('ztest'));
+        });
+        it('uses unknown for FAILURE with empty check array', () => {
+            const key = callComputeSnapshotKey(CIStatus.FAILURE, false, null, []);
+            expect(key).toContain('ci:FAILURE:unknown');
+        });
+        it('includes review activity timestamp in key', () => {
+            const ts = 1_735_776_000_000;
+            const key = callComputeSnapshotKey(CIStatus.SUCCESS, true, ts, null);
+            expect(key).toContain(`changes-requested:${ts}`);
+        });
+    });
+    describe('computeLatestReviewActivityAtMs edge cases', () => {
+        const callCompute = (prDetails, reviewComments, authenticatedUsername) => unsafeCoerce(ratchetService).computeLatestReviewActivityAtMs(prDetails, reviewComments, authenticatedUsername);
+        it('returns null when there are no reviews or comments', () => {
+            expect(callCompute({ reviews: [], comments: [] }, [], null)).toBeNull();
+        });
+        it('returns null when all activity is from the authenticated user', () => {
+            expect(callCompute({
+                reviews: [{ submittedAt: '2026-01-01T00:00:00Z', author: { login: 'me' } }],
+                comments: [{ updatedAt: '2026-01-02T00:00:00Z', author: { login: 'me' } }],
+            }, [{ updatedAt: '2026-01-03T00:00:00Z', author: { login: 'me' } }], 'me')).toBeNull();
+        });
+        it('does not filter when authenticatedUsername is null', () => {
+            const result = callCompute({
+                reviews: [{ submittedAt: '2026-01-01T00:00:00Z', author: { login: 'bot' } }],
+                comments: [],
+            }, [], null);
+            expect(result).toBe(new Date('2026-01-01T00:00:00Z').getTime());
+        });
+        it('returns the latest timestamp across all sources', () => {
+            const result = callCompute({
+                reviews: [{ submittedAt: '2026-01-01T00:00:00Z', author: { login: 'a' } }],
+                comments: [{ updatedAt: '2026-01-03T00:00:00Z', author: { login: 'b' } }],
+            }, [{ updatedAt: '2026-01-02T00:00:00Z', author: { login: 'c' } }], null);
+            expect(result).toBe(new Date('2026-01-03T00:00:00Z').getTime());
+        });
+    });
+    describe('processWorkspace error handling', () => {
+        it('returns ERROR action when fetchPRState returns null', async () => {
+            const workspace = {
+                id: 'ws-fetch-err',
+                prUrl: 'https://github.com/example/repo/pull/99',
+                prNumber: 99,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.IDLE,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            };
+            vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockResolvedValue(null);
+            vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+            const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+            expect(result).toMatchObject({
+                action: { type: 'ERROR', error: 'Failed to fetch PR state' },
+                newState: RatchetState.IDLE,
+            });
+        });
+        it('returns WAITING when shutting down', async () => {
+            unsafeCoerce(ratchetService).isShuttingDown = true;
+            const workspace = {
+                id: 'ws-shutdown',
+                prUrl: 'https://github.com/example/repo/pull/1',
+                prNumber: 1,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.CI_FAILED,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            };
+            const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+            expect(result).toMatchObject({
+                action: { type: 'WAITING', reason: 'Shutting down' },
+                previousState: RatchetState.CI_FAILED,
+                newState: RatchetState.CI_FAILED,
+            });
+        });
+        it('returns ERROR and preserves state when processWorkspace throws', async () => {
+            const workspace = {
+                id: 'ws-throw',
+                prUrl: 'https://github.com/example/repo/pull/50',
+                prNumber: 50,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.CI_FAILED,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            };
+            vi.spyOn(unsafeCoerce(ratchetService), 'fetchPRState').mockRejectedValue(new Error('Unexpected explosion'));
+            const result = await unsafeCoerce(ratchetService).processWorkspace(workspace);
+            expect(result).toMatchObject({
+                action: { type: 'ERROR', error: 'Unexpected explosion' },
+                previousState: RatchetState.CI_FAILED,
+                newState: RatchetState.CI_FAILED,
+            });
+        });
+    });
+    describe('checkAllWorkspaces', () => {
+        it('returns zero counts when shutting down', async () => {
+            unsafeCoerce(ratchetService).isShuttingDown = true;
+            const result = await ratchetService.checkAllWorkspaces();
+            expect(result).toEqual({ checked: 0, stateChanges: 0, actionsTriggered: 0, results: [] });
+        });
+        it('returns zero counts when no workspaces have PRs', async () => {
+            vi.mocked(workspaceAccessor.findWithPRsForRatchet).mockResolvedValue([]);
+            const result = await ratchetService.checkAllWorkspaces();
+            expect(result).toEqual({ checked: 0, stateChanges: 0, actionsTriggered: 0, results: [] });
+        });
+    });
+    describe('checkWorkspaceById', () => {
+        it('returns null when shutting down', async () => {
+            unsafeCoerce(ratchetService).isShuttingDown = true;
+            const result = await ratchetService.checkWorkspaceById('ws-1');
+            expect(result).toBeNull();
+        });
+        it('returns null when workspace not found', async () => {
+            unsafeCoerce(ratchetService).isShuttingDown = false;
+            vi.mocked(workspaceAccessor.findForRatchetById).mockResolvedValue(null);
+            const result = await ratchetService.checkWorkspaceById('ws-nonexistent');
+            expect(result).toBeNull();
+        });
+    });
+    describe('decideRatchetAction edge cases', () => {
+        const callDecide = (context) => unsafeCoerce(ratchetService).decideRatchetAction(context);
+        it('returns COMPLETED for merged PR', () => {
+            expect(callDecide({
+                workspace: { ratchetEnabled: true },
+                prStateInfo: { prState: 'MERGED', ciStatus: CIStatus.SUCCESS },
+                isCleanPrWithNoNewReviewActivity: false,
+                activeRatchetSession: null,
+                hasStateChangedSinceLastDispatch: true,
+                hasOtherActiveSession: false,
+            })).toEqual({ type: 'RETURN_ACTION', action: { type: 'COMPLETED' } });
+        });
+        it('returns WAITING for non-open PR', () => {
+            const result = callDecide({
+                workspace: { ratchetEnabled: true },
+                prStateInfo: { prState: 'CLOSED', ciStatus: CIStatus.SUCCESS },
+                isCleanPrWithNoNewReviewActivity: false,
+                activeRatchetSession: null,
+                hasStateChangedSinceLastDispatch: true,
+                hasOtherActiveSession: false,
+            });
+            expect(result.action?.reason).toBe('PR is not open');
+        });
+        it('returns active session when one exists', () => {
+            const activeSession = { type: 'FIXER_ACTIVE', sessionId: 's-1' };
+            const result = callDecide({
+                workspace: { ratchetEnabled: true },
+                prStateInfo: { prState: 'OPEN', ciStatus: CIStatus.FAILURE },
+                isCleanPrWithNoNewReviewActivity: false,
+                activeRatchetSession: activeSession,
+                hasStateChangedSinceLastDispatch: true,
+                hasOtherActiveSession: false,
+            });
+            expect(result.action).toEqual(activeSession);
+        });
+        it('returns WAITING when other active session blocks dispatch', () => {
+            const result = callDecide({
+                workspace: { ratchetEnabled: true },
+                prStateInfo: { prState: 'OPEN', ciStatus: CIStatus.FAILURE },
+                isCleanPrWithNoNewReviewActivity: false,
+                activeRatchetSession: null,
+                hasStateChangedSinceLastDispatch: true,
+                hasOtherActiveSession: true,
+            });
+            expect(result.action?.reason).toBe('Workspace is not idle (active session)');
+        });
+    });
+    describe('getActiveRatchetSession edge cases', () => {
+        const callGetActiveRatchetSession = (workspace) => unsafeCoerce(ratchetService).getActiveRatchetSession(workspace);
+        it('returns null when ratchetActiveSessionId is null', async () => {
+            const result = await callGetActiveRatchetSession({
+                id: 'ws-1',
+                ratchetActiveSessionId: null,
+            });
+            expect(result).toBeNull();
+        });
+        it('returns null and clears when session DB record is missing', async () => {
+            vi.mocked(claudeSessionAccessor.findById).mockResolvedValue(null);
+            vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+            const result = await callGetActiveRatchetSession({
+                id: 'ws-2',
+                ratchetActiveSessionId: 'gone-session',
+            });
+            expect(result).toBeNull();
+            expect(workspaceAccessor.update).toHaveBeenCalledWith('ws-2', {
+                ratchetActiveSessionId: null,
+            });
+        });
+        it('returns null and clears when session is not RUNNING', async () => {
+            vi.mocked(claudeSessionAccessor.findById).mockResolvedValue({
+                id: 'completed-session',
+                status: SessionStatus.IDLE,
+            });
+            vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+            const result = await callGetActiveRatchetSession({
+                id: 'ws-3',
+                ratchetActiveSessionId: 'completed-session',
+            });
+            expect(result).toBeNull();
+            expect(workspaceAccessor.update).toHaveBeenCalledWith('ws-3', {
+                ratchetActiveSessionId: null,
+            });
+        });
+    });
+    describe('triggerFixer error handling', () => {
+        it('handles acquireAndDispatch throwing an error', async () => {
+            const workspace = {
+                id: 'ws-trigger-fail',
+                prUrl: 'https://github.com/example/repo/pull/20',
+                prNumber: 20,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.CI_FAILED,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            };
+            vi.mocked(fixerSessionService.acquireAndDispatch).mockRejectedValue(new Error('Session creation failed'));
+            const result = await unsafeCoerce(ratchetService).triggerFixer(workspace, {
+                ciStatus: CIStatus.FAILURE,
+                prNumber: 20,
+            });
+            expect(result).toMatchObject({
+                type: 'ERROR',
+                error: 'Session creation failed',
+            });
+        });
+        it('handles already_active result from acquireAndDispatch', async () => {
+            const workspace = {
+                id: 'ws-already-active',
+                prUrl: 'https://github.com/example/repo/pull/21',
+                prNumber: 21,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.CI_FAILED,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            };
+            vi.mocked(fixerSessionService.acquireAndDispatch).mockResolvedValue({
+                status: 'already_active',
+                sessionId: 'existing-session',
+            });
+            vi.mocked(workspaceAccessor.update).mockResolvedValue({});
+            const result = await unsafeCoerce(ratchetService).triggerFixer(workspace, {
+                ciStatus: CIStatus.FAILURE,
+                prNumber: 21,
+            });
+            expect(result).toMatchObject({
+                type: 'FIXER_ACTIVE',
+                sessionId: 'existing-session',
+            });
+        });
+        it('handles skipped result from acquireAndDispatch', async () => {
+            const workspace = {
+                id: 'ws-skipped',
+                prUrl: 'https://github.com/example/repo/pull/22',
+                prNumber: 22,
+                ratchetEnabled: true,
+                ratchetState: RatchetState.CI_FAILED,
+                ratchetActiveSessionId: null,
+                ratchetLastCiRunId: null,
+                prReviewLastCheckedAt: null,
+            };
+            vi.mocked(fixerSessionService.acquireAndDispatch).mockResolvedValue({
+                status: 'skipped',
+                reason: 'No worktree path',
+            });
+            const result = await unsafeCoerce(ratchetService).triggerFixer(workspace, {
+                ciStatus: CIStatus.FAILURE,
+                prNumber: 22,
+            });
+            expect(result).toMatchObject({
+                type: 'ERROR',
+                error: 'No worktree path',
+            });
+        });
+    });
+});
+//# sourceMappingURL=ratchet.service.test.js.map