extension-develop 4.1.35 → 4.1.37-canary.1793139187.ed2d765e

package/dist/363~0.mjs

@@ -1189,6 +1189,9 @@ function contentScriptEntryDroppedForBrowser(index, browser, prefixedKeys) {
     if (prefixedKeys.length > 0) lines.push(`${prefixedKeys.map((key)=>pintor.yellow(key)).join(', ')} ${1 === prefixedKeys.length ? 'applies' : 'apply'} to another browser. Add ${pintor.yellow(`${browser}:js`)} or a plain ${pintor.yellow('js')} to keep the entry here.`);
     return lines.join('\n');
 }
+function edgeEmbeddedOptionsDialog() {
+    return `${messaging_prefix('warn')} Edge shows an embedded settings page in a dialog at most 400px wide (368px for the page), so a wider settings page is clipped on Edge.\nAdd ${pintor.yellow('edge:options_ui')} with ${pintor.yellow('"open_in_tab": true')} to open settings in a tab on Edge only.`;
+}
 function webkitUnsupportedKeysDropped(browser, dropped) {
     const count = dropped.length;
     const lines = [];
@@ -1197,6 +1200,19 @@ function webkitUnsupportedKeysDropped(browser, dropped) {
     lines.push(`Every key above is inert on Safari, so the built app lost nothing it could have run. Declare a Safari-only replacement with the ${pintor.yellow('safari:')} prefix if you have one.`);
     return lines.join('\n');
 }
+function edgeEmbedsOptionsPage(manifest, browser) {
+    if ('edge' !== String(browser)) return false;
+    const optionsUi = manifest.options_ui;
+    if (!optionsUi || 'object' != typeof optionsUi || Array.isArray(optionsUi)) return false;
+    const { page, open_in_tab: openInTab } = optionsUi;
+    return 'string' == typeof page && page.length > 0 && true !== openInTab;
+}
+let reported = false;
+function reportEdgeEmbeddedOptions(manifest, browser) {
+    if (reported || !edgeEmbedsOptionsPage(manifest, browser)) return;
+    reported = true;
+    humanLine(edgeEmbeddedOptionsDialog());
+}
 const UNSUPPORTED_TOP_LEVEL_KEYS = {
     side_panel: 'Safari has no side panel surface',
     sidebar_action: 'Safari has no sidebar surface',
@@ -1426,6 +1442,7 @@ function buildCanonicalManifestWithOverrides(manifestPath, manifest, browser, pr
     const translated = foldActionIntoBrowserAction(foldSidebarKeyForBrowser(canonical, browser));
     const webkit = dropWebkitUnsupportedKeys(translated, browser);
     reportWebkitDroppedKeys(webkit.dropped, browser);
+    reportEdgeEmbeddedOptions(webkit.manifest, browser);
     return {
         manifest: webkit.manifest,
         overrides

package/dist/469~0.mjs

@@ -320,11 +320,16 @@ function anotherDevSessionActive(browser, pid, runId) {
 function buildOutDirInvalid(value) {
     return `${getLoggingPrefix('error')} ${fmt.code('--out-dir')} needs a folder path other than the project root, got ${fmt.code(value || '(empty)')}.\nPass a folder such as ${fmt.code('--out-dir build')}, and the build writes ${fmt.code('build/<browser>')}.`;
 }
-function buildSharesDevDist(browser, distDisplay, pid) {
-    return `${getLoggingPrefix('warn')} A dev session (PID ${pid}) is serving ${distDisplay}, and this build replaces its files.\nPass ${fmt.code('--out-dir <path>')} to write the ${browser} build next to it and keep the dev session as it is.`;
+function productionLoopbackOrigins(origins) {
+    const list = origins.map((origin)=>`  ${fmt.code(origin.pattern)} in ${origin.where}`).join('\n');
+    return `${getLoggingPrefix('warn')} The production manifest reaches the local machine:\n${list}\nStore reviewers read a loopback origin as host access with no purpose in a published extension. Keep it to development with an ${fmt.code('$EXTENSION_PUBLIC_*')} placeholder in the manifest and its value in ${fmt.code('.env.development')}.`;
+}
+function productionLoopbackOriginsText(origins) {
+    const list = origins.map((origin)=>`${origin.pattern} in ${origin.where}`).join(', ');
+    return `the production manifest reaches the local machine (${list}). Keep loopback origins to development with an $EXTENSION_PUBLIC_* placeholder and a .env.development value.`;
 }
-function buildSharesDevDistText(distDisplay, pid) {
-    return `a dev session (PID ${pid}) is serving ${distDisplay}, so this build replaces its files unless it runs with --out-dir <path>.`;
+function buildSharesDevDist(browser, distDisplay, pid) {
+    return `${getLoggingPrefix('error')} A dev session (PID ${pid}) owns ${distDisplay}, so this build was not written.\nStop that session, or pass ${fmt.code('--out-dir <path>')} to write the ${browser} build next to it and keep the dev session as it is.`;
 }
 function anotherDevSessionRefused(browser, pid, port) {
     const where = port ? ` on port ${port}` : '';
@@ -349,6 +354,10 @@ function buildComplete(browser, distDisplayPath, totalBytes, mode) {
     const size = 'number' == typeof totalBytes && totalBytes > 0 ? ` (${getHumanSize(totalBytes)})` : '';
     return `${getLoggingPrefix('success')} ${noun} ${builtFor} ${pintor.underline(distDisplayPath)}${size}.`;
 }
+function buildToolchain(toolchain) {
+    const packageManager = toolchain.package_manager ? ` and ${toolchain.package_manager.name} ${toolchain.package_manager.version}` : '';
+    return `${getLoggingPrefix('info')} Built with Node ${toolchain.node}${packageManager}. A reviewer note that names them lets a rebuild match this one.`;
+}
 function operaBuildUnminified() {
     return `${getLoggingPrefix('info')} Opera Add-ons reviews readable source, so this build does not minify first-party code. Pass ${pintor.blue('--minify')} to minify it anyway.`;
 }
@@ -376,6 +385,12 @@ function addonLintDependencyAttribution(packages, onlyDependencies) {
     const rest = packages.length > 3 ? `, +${packages.length - 3} more` : '';
     return onlyDependencies ? `- this file is bundled dependency code (${named}${rest}), not yours` : `- this file also bundles ${named}${rest}, so the finding may be theirs`;
 }
+function addonLintUnsupportedApiFix(browser) {
+    return `- this names a browser API, so it is your code, not a library's: guard it with a build-time check of process.env.EXTENSION_PUBLIC_BROWSER (return early when it reads "${browser}") and the production build drops the branch from the ${browser} bundle`;
+}
+function addonLintReviewerNote(noteDisplay) {
+    return `${getLoggingPrefix('info')} Notes to reviewer for addons.mozilla.org are at ${pintor.underline(noteDisplay)} (paste its bundled libraries section into the submission, the author findings are yours to fix)`;
+}
 function addonLintMore(hiddenCount, distDisplay) {
     return `${getLoggingPrefix('info')} ${pluralize(hiddenCount, 'more finding')} not shown. Run ${pintor.blue(`npx addons-linter ${distDisplay}`)} for the full report.`;
 }
@@ -1278,4 +1293,4 @@ function resolveProjectStructureSync(projectPath, options = {}) {
         } : {}
     };
 }
-export { addonLintDependencyAttribution, addonLintFailed, addonLintFailedDebug, addonLintFinding, addonLintMore, addonLintNotInstalled, addonLintSummary, anotherDevSessionActive, anotherDevSessionRefused, asAbsolute, authorInstallNotice, browserLaunchFailed, buildAssetsTree, buildCommandFailed, buildComplete, buildFailed, buildOutDirInvalid, buildShareHint, buildSharesDevDist, buildSharesDevDistText, buildWarningsDetails, codedError, collapseHomeDir, computePreviewOutputPath, configBrowserOrThrow, configLoadingError, configResolvedChangeIgnored, configUnknownKeys, configWrongShape, debugBrowser, debugContextPath, debugDirs, debugExtensionsToLoad, debugOutputPath, debugPreviewOutput, debugSplitChunksNarrowed, devCommandFailed, devtoolsEngineFor, displayPath, downloadingText, extensionLoadRecovered, extensionLoadStillRefused, failedToDownloadOrWriteZIPFileError, failedToWriteZIPFileError, getBuildDistPath, getDirs, getDistPath, getProjectStructure, invalidRemoteZip, isUsingExperimentalConfig, listOutputFiles, localZipNotFound, localZipUnreadable, managedDependencyCopyWarning, manifestInvalidJson, needsInstall, noCompanionExtensionsResolved, normalizeBrowser, notAZipArchive, operaBuildUnminified, packagingDistributionFiles, packagingSourceFiles, previewHasNothingToRun, previewing, previewingCustomOutput, previewingSourceFallback, productionControlOpen, projectInstallFallbackToNpm, projectInstallInWorkspaceRoot, projectInstallScriptsDisabled, relativeToDir, remoteArchiveCacheRoot, remoteSourceDestinationTaken, remoteZipAccessRefused, remoteZipDamaged, resolveProjectStructureSync, reusingDownloadedProject, runtimeChunkKeptInline, safariBuildOutputNotFound, safariInvalidBundleId, sessionStateIgnoreAdded, starting, toPosixPath, tokenExpiry, treeWithDistFilesBrowser, treeWithSourceAndDistFiles, treeWithSourceFiles, unpackagedSuccessfully, unpackagingExtension, updatingTypeDefinitions, writingTypeDefinitions, writingTypeDefinitionsError, zipArtifactNotCreated, zipArtifactReady, zipEntryOutsideFolder, zipSkippedSymlinks };
+export { addonLintDependencyAttribution, addonLintFailed, addonLintFailedDebug, addonLintFinding, addonLintMore, addonLintNotInstalled, addonLintReviewerNote, addonLintSummary, addonLintUnsupportedApiFix, anotherDevSessionActive, anotherDevSessionRefused, asAbsolute, authorInstallNotice, browserLaunchFailed, buildAssetsTree, buildCommandFailed, buildComplete, buildFailed, buildOutDirInvalid, buildShareHint, buildSharesDevDist, buildToolchain, buildWarningsDetails, codedError, collapseHomeDir, computePreviewOutputPath, configBrowserOrThrow, configLoadingError, configResolvedChangeIgnored, configUnknownKeys, configWrongShape, debugBrowser, debugContextPath, debugDirs, debugExtensionsToLoad, debugOutputPath, debugPreviewOutput, debugSplitChunksNarrowed, devCommandFailed, devtoolsEngineFor, displayPath, downloadingText, extensionLoadRecovered, extensionLoadStillRefused, failedToDownloadOrWriteZIPFileError, failedToWriteZIPFileError, getBuildDistPath, getDirs, getDistPath, getProjectStructure, invalidRemoteZip, isUsingExperimentalConfig, listOutputFiles, localZipNotFound, localZipUnreadable, managedDependencyCopyWarning, manifestInvalidJson, needsInstall, noCompanionExtensionsResolved, normalizeBrowser, notAZipArchive, operaBuildUnminified, packagingDistributionFiles, packagingSourceFiles, previewHasNothingToRun, previewing, previewingCustomOutput, previewingSourceFallback, productionControlOpen, productionLoopbackOrigins, productionLoopbackOriginsText, projectInstallFallbackToNpm, projectInstallInWorkspaceRoot, projectInstallScriptsDisabled, relativeToDir, remoteArchiveCacheRoot, remoteSourceDestinationTaken, remoteZipAccessRefused, remoteZipDamaged, resolveProjectStructureSync, reusingDownloadedProject, runtimeChunkKeptInline, safariBuildOutputNotFound, safariInvalidBundleId, sessionStateIgnoreAdded, starting, toPosixPath, tokenExpiry, treeWithDistFilesBrowser, treeWithSourceAndDistFiles, treeWithSourceFiles, unpackagedSuccessfully, unpackagingExtension, updatingTypeDefinitions, writingTypeDefinitions, writingTypeDefinitionsError, zipArtifactNotCreated, zipArtifactReady, zipEntryOutsideFolder, zipSkippedSymlinks };