express-rate-limit 8.3.1 → 8.4.0

package/dist/index.cjs

@@ -840,6 +840,9 @@ var rateLimit = (passedOptions) => {
   if (typeof config.store.init === "function") config.store.init(options);
   const middleware = handleAsyncErrors(
     async (request, response, next) => {
+      const closePromise = config.skipFailedRequests && new Promise((resolve) => response.once("close", resolve));
+      const finishPromise = (config.skipFailedRequests || config.skipSuccessfulRequests) && new Promise((resolve) => response.once("finish", resolve));
+      const errorPromise = config.skipFailedRequests && new Promise((resolve) => response.once("error", resolve));
       const skip = await config.skip(request, response);
       if (skip) {
         next();
@@ -918,22 +921,30 @@ var rateLimit = (passedOptions) => {
           }
         };
         if (config.skipFailedRequests) {
-          response.on("finish", async () => {
-            if (!await config.requestWasSuccessful(request, response))
+          if (finishPromise) {
+            void finishPromise.then(async () => {
+              if (!await config.requestWasSuccessful(request, response))
+                await decrementKey();
+            });
+          }
+          if (closePromise) {
+            void closePromise.then(async () => {
+              if (!response.writableEnded) await decrementKey();
+            });
+          }
+          if (errorPromise) {
+            void errorPromise.then(async () => {
               await decrementKey();
-          });
-          response.on("close", async () => {
-            if (!response.writableEnded) await decrementKey();
-          });
-          response.on("error", async () => {
-            await decrementKey();
-          });
+            });
+          }
         }
         if (config.skipSuccessfulRequests) {
-          response.on("finish", async () => {
-            if (await config.requestWasSuccessful(request, response))
-              await decrementKey();
-          });
+          if (finishPromise) {
+            void finishPromise.then(async () => {
+              if (await config.requestWasSuccessful(request, response))
+                await decrementKey();
+            });
+          }
         }
       }
       config.validations.disable();

package/dist/index.mjs

@@ -811,6 +811,9 @@ var rateLimit = (passedOptions) => {
   if (typeof config.store.init === "function") config.store.init(options);
   const middleware = handleAsyncErrors(
     async (request, response, next) => {
+      const closePromise = config.skipFailedRequests && new Promise((resolve) => response.once("close", resolve));
+      const finishPromise = (config.skipFailedRequests || config.skipSuccessfulRequests) && new Promise((resolve) => response.once("finish", resolve));
+      const errorPromise = config.skipFailedRequests && new Promise((resolve) => response.once("error", resolve));
       const skip = await config.skip(request, response);
       if (skip) {
         next();
@@ -889,22 +892,30 @@ var rateLimit = (passedOptions) => {
           }
         };
         if (config.skipFailedRequests) {
-          response.on("finish", async () => {
-            if (!await config.requestWasSuccessful(request, response))
+          if (finishPromise) {
+            void finishPromise.then(async () => {
+              if (!await config.requestWasSuccessful(request, response))
+                await decrementKey();
+            });
+          }
+          if (closePromise) {
+            void closePromise.then(async () => {
+              if (!response.writableEnded) await decrementKey();
+            });
+          }
+          if (errorPromise) {
+            void errorPromise.then(async () => {
               await decrementKey();
-          });
-          response.on("close", async () => {
-            if (!response.writableEnded) await decrementKey();
-          });
-          response.on("error", async () => {
-            await decrementKey();
-          });
+            });
+          }
         }
         if (config.skipSuccessfulRequests) {
-          response.on("finish", async () => {
-            if (await config.requestWasSuccessful(request, response))
-              await decrementKey();
-          });
+          if (finishPromise) {
+            void finishPromise.then(async () => {
+              if (await config.requestWasSuccessful(request, response))
+                await decrementKey();
+            });
+          }
         }
       }
       config.validations.disable();

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "express-rate-limit",
-	"version": "8.3.1",
+	"version": "8.4.0",
 	"description": "Basic IP rate-limiting middleware for Express. Use to limit repeated requests to public APIs and/or endpoints such as password reset.",
 	"author": {
 		"name": "Nathan Friedly",
@@ -83,19 +83,19 @@
 		"@biomejs/biome": "2.4.6",
 		"@express-rate-limit/prettier": "1.1.1",
 		"@express-rate-limit/tsconfig": "1.0.2",
-		"@jest/globals": "30.2.0",
+		"@jest/globals": "30.3.0",
 		"@types/express": "5.0.6",
 		"@types/jest": "30.0.0",
-		"@types/node": "25.3.3",
+		"@types/node": "25.5.0",
 		"@types/supertest": "7.2.0",
 		"del-cli": "7.0.0",
 		"dts-bundle-generator": "8.1.2",
-		"esbuild": "0.27.3",
+		"esbuild": "0.27.4",
 		"express": "5.2.1",
 		"husky": "9.1.7",
-		"jest": "30.2.0",
-		"lint-staged": "16.3.2",
-		"mintlify": "4.2.392",
+		"jest": "30.3.0",
+		"lint-staged": "16.4.0",
+		"mintlify": "4.2.446",
 		"npm-run-all": "4.1.5",
 		"prettier": "3.8.1",
 		"ratelimit-header-parser": "0.1.0",

package/readme.md

@@ -66,24 +66,10 @@ default values.
 | [`skipFailedRequests`]     | `boolean`                                 | Uncount 4xx/5xx responses.                                                                      |
 | [`requestWasSuccessful`]   | `function`                                | Used by `skipSuccessfulRequests` and `skipFailedRequests`.                                      |
 | [`validate`]               | `boolean` \| `object`                     | Enable or disable built-in validation checks.                                                   |
+| [`logger`]                 | `Logger`                                  | Custom logger                                                                                   |
 
 ## Thank You
 
-Sponsored by [Zuplo](https://zuplo.link/express-rate-limit) a fully-managed API
-Gateway for developers. Add
-[dynamic rate-limiting](https://zuplo.link/dynamic-rate-limiting),
-authentication and more to any API in minutes. Learn more at
-[zuplo.com](https://zuplo.link/express-rate-limit)
-
-<p align="center">
-<a href="https://zuplo.link/express-rate-limit">
-<picture width="322">
-  <source media="(prefers-color-scheme: dark)" srcset="https://github.com/express-rate-limit/express-rate-limit/assets/114976/cd2f6fa7-eae1-4fbb-be7d-b17df4c6f383">
-  <img alt="zuplo-logo" src="https://github.com/express-rate-limit/express-rate-limit/assets/114976/66fd75fa-b39e-4a8c-8d7a-52369bf244dc" width="322">
-</picture>
-</a>
-</p>
-
 ---
 
 Thanks to Mintlify for hosting the documentation at
@@ -97,7 +83,7 @@ Thanks to Mintlify for hosting the documentation at
 
 ---
 
-Finally, thank you to everyone who's contributed to this project in any way! 🫶
+And thank you to everyone who's contributed to this project in any way! 🫶
 
 ## Issues and Contributing
 
@@ -149,3 +135,5 @@ MIT © [Nathan Friedly](http://nfriedly.com/),
 	https://express-rate-limit.mintlify.app/reference/configuration#requestwassuccessful
 [`validate`]:
 	https://express-rate-limit.mintlify.app/reference/configuration#validate
+[`logger`]:
+	https://express-rate-limit.mintlify.app/reference/configuration#logger