express-rate-limit 5.2.3 → 5.2.5

package/README.md

@@ -9,12 +9,11 @@ Basic rate-limiting middleware for Express. Use to limit repeated requests to pu
 
 Plays nice with [express-slow-down](https://www.npmjs.com/package/express-slow-down).
 
-Note: this module does not share state with other processes/servers by default.
-If you need a more robust solution, I recommend using an external store:
+Note: this module does not share state with other processes/servers by default. It also buckets all requests to an internal clock rather than starting a new timer for each end-user. It's fine for abuse-prevention but might not produce the desired effect when attempting to strictly enforce API rate-limits or similar. If you need a more robust solution, I recommend using an external store:
 
 ### Stores
 
-- Memory Store _(default, built-in)_ - stores hits in-memory in the Node.js process. Does not share state with other servers or processes.
+- Memory Store _(default, built-in)_ - stores hits in-memory in the Node.js process. Does not share state with other servers or processes, and does not start a separate timer for each end user.
 - [Redis Store](https://npmjs.com/package/rate-limit-redis)
 - [Memcached Store](https://npmjs.org/package/rate-limit-memcached)
 - [Mongo Store](https://www.npmjs.com/package/rate-limit-mongo)

package/lib/express-rate-limit.js

@@ -152,9 +152,13 @@ function RateLimit(options) {
               }
 
               next();
+
+              return null;
             })
             .catch(next);
         });
+
+        return null;
       })
       .catch(next);
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "express-rate-limit",
-  "version": "5.2.3",
+  "version": "5.2.5",
   "description": "Basic IP rate-limiting middleware for Express. Use to limit repeated requests to public APIs and/or endpoints such as password reset.",
   "homepage": "https://github.com/nfriedly/express-rate-limit",
   "author": {
@@ -31,17 +31,17 @@
     "brute-force",
     "attack"
   ],
-  "dependencies": {},
   "devDependencies": {
-    "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.10.1",
-    "eslint-plugin-prettier": "^3.1.2",
+    "bluebird": "^3.7.2",
+    "eslint": "^7.19.0",
+    "eslint-config-prettier": "^7.2.0",
+    "eslint-plugin-prettier": "^3.3.1",
     "express": "^4.17.1",
-    "husky": "^4.2.3",
-    "mocha": "^7.1.1",
-    "prettier": "^2.0.4",
-    "pretty-quick": "^2.0.1",
-    "supertest": "^4.0.2"
+    "husky": "^4.3.8",
+    "mocha": "^8.2.1",
+    "prettier": "^2.2.1",
+    "pretty-quick": "^3.1.0",
+    "supertest": "^6.1.3"
   },
   "scripts": {
     "lint": "eslint .",