expo 56.0.7 → 56.0.8

package/android/build.gradle

@@ -10,7 +10,7 @@ buildscript {
 }
 
 group = 'host.exp.exponent'
-version = '56.0.7'
+version = '56.0.8'
 
 expoModule {
   // We can't prebuild the module because it depends on the generated files.
@@ -21,7 +21,7 @@ android {
   namespace "expo.core"
   defaultConfig {
     versionCode 1
-    versionName "56.0.7"
+    versionName "56.0.8"
     consumerProguardFiles("proguard-rules.pro")
   }
   testOptions {

package/android/src/main/java/expo/modules/fetch/ExpoFetchModule.kt

@@ -26,7 +26,7 @@ class ExpoFetchModule : Module() {
     OkHttpClientProvider.createClient(reactContext)
       .newBuilder()
       .addInterceptor(OkHttpFileUrlInterceptor(reactContext))
-      .addInterceptor(CompressionInterceptor)
+      .addInterceptor(TransparentCompressionInterceptor)
       .build()
   }
   private val cookieHandler by lazy { ForwardingCookieHandler(reactContext) }

package/android/src/main/java/expo/modules/fetch/{CompressionInterceptor.kt → TransparentCompressionInterceptor.kt}

@@ -34,23 +34,26 @@ import org.brotli.dec.BrotliInputStream
  * header, and decompresses (and strips `Content-Encoding`/`Content-Length` from) responses
  * encoded with any of the three.
  *
- * Modeled after `okhttp3.brotli.BrotliInterceptor`; this replaces the transparent gzip
- * compression in okhttp's `BridgeInterceptor`. Callers who set their own `Accept-Encoding`
- * opt out of automatic decompression.
+ * Unlike OkHttp, which disables transparent decompression when `Accept-Encoding` is explicitly set by the caller,
+ * this interceptor continues to decompress responses to match the behavior of the Fetch API, iOS `URLSession`,
+ * and [React Native fetch](https://github.com/facebook/react-native/blob/622941d9dca684ecfc8f5086eb42c8178c3062d1/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.kt#L656-L691).
+ *
+ * The `Content-Encoding` and `Content-Length` headers are removed after
+ * decompression.
  */
-object CompressionInterceptor : Interceptor {
-  override fun intercept(chain: Interceptor.Chain): Response =
-    if (chain.request().header("Accept-Encoding") == null) {
-      val request = chain.request().newBuilder()
-        .header("Accept-Encoding", "zstd, br, gzip")
-        .build()
-
-      val response = chain.proceed(request)
+object TransparentCompressionInterceptor : Interceptor {
+  override fun intercept(chain: Interceptor.Chain): Response {
+    val request = chain.request()
 
-      uncompress(response)
-    } else {
-      chain.proceed(chain.request())
-    }
+    return uncompress(
+      chain.proceed(
+        when (request.header("Accept-Encoding")) {
+          null -> request.newBuilder().header("Accept-Encoding", "zstd, br, gzip").build()
+          else -> request
+        }
+      )
+    )
+  }
 
   internal fun uncompress(response: Response): Response {
     if (!response.promisesBody()) {

package/android/src/test/java/expo/modules/fetch/{CompressionInterceptorTest.kt → TransparentCompressionInterceptorTest.kt}

@@ -17,7 +17,7 @@ import okio.GzipSink
 import okio.buffer
 import org.junit.Test
 
-class CompressionInterceptorTest {
+class TransparentCompressionInterceptorTest {
   // brotli of "hello world" produced offline with `printf 'hello world' | brotli`.
   // Avoids pulling in a brotli encoder just for this test; the decoder side is what we exercise.
   private val brotliHelloWorld = hexToBytes("0f058068656c6c6f20776f726c6403")
@@ -32,12 +32,41 @@ class CompressionInterceptorTest {
   }
 
   @Test
-  fun `should pass through unchanged when caller sets Accept-Encoding`() {
+  fun `should leave caller-set Accept-Encoding header untouched`() {
     val capturedRequest = interceptAndCapture(initialAcceptEncoding = "gzip")
 
     assertThat(capturedRequest.header("Accept-Encoding")).isEqualTo("gzip")
   }
 
+  @Test
+  fun `should still decompress response when caller set Accept-Encoding`() {
+    val payload = "hello world"
+
+    val request = Request.Builder()
+      .url("https://example.test/")
+      .header("Accept-Encoding", "gzip")
+      .build()
+
+    val chain = mockk<Interceptor.Chain>()
+
+    every { chain.request() } returns request
+    every { chain.proceed(any()) } answers {
+      Response.Builder()
+        .request(request)
+        .protocol(Protocol.HTTP_1_1)
+        .code(200)
+        .message("OK")
+        .header("Content-Encoding", "gzip")
+        .body(payload.toByteArray().gzipCompressed().toResponseBody("application/octet-stream".toMediaType()))
+        .build()
+    }
+
+    val response = TransparentCompressionInterceptor.intercept(chain)
+
+    assertThat(response.body!!.string()).isEqualTo(payload)
+    assertThat(response.header("Content-Encoding")).isNull()
+  }
+
   // endregion
 
   // region uncompress() — decompression
@@ -47,7 +76,7 @@ class CompressionInterceptorTest {
     val payload = "hello world"
     val response = encodedResponse(payload.toByteArray().gzipCompressed(), "gzip")
 
-    val uncompressed = CompressionInterceptor.uncompress(response)
+    val uncompressed = TransparentCompressionInterceptor.uncompress(response)
 
     assertThat(uncompressed.body!!.string()).isEqualTo(payload)
     assertThat(uncompressed.header("Content-Encoding")).isNull()
@@ -58,7 +87,7 @@ class CompressionInterceptorTest {
   fun `should decompress br response and strip Content-Encoding and Content-Length headers`() {
     val response = encodedResponse(brotliHelloWorld, "br")
 
-    val uncompressed = CompressionInterceptor.uncompress(response)
+    val uncompressed = TransparentCompressionInterceptor.uncompress(response)
 
     assertThat(uncompressed.body!!.string()).isEqualTo("hello world")
     assertThat(uncompressed.header("Content-Encoding")).isNull()
@@ -70,7 +99,7 @@ class CompressionInterceptorTest {
     val payload = "hello world"
     val response = encodedResponse(payload.toByteArray().gzipCompressed(), "GZIP")
 
-    val uncompressed = CompressionInterceptor.uncompress(response)
+    val uncompressed = TransparentCompressionInterceptor.uncompress(response)
 
     assertThat(uncompressed.body!!.string()).isEqualTo(payload)
   }
@@ -85,7 +114,7 @@ class CompressionInterceptorTest {
       .body("plain".toResponseBody("text/plain".toMediaType()))
       .build()
 
-    val result = CompressionInterceptor.uncompress(response)
+    val result = TransparentCompressionInterceptor.uncompress(response)
 
     assertThat(result).isSameInstanceAs(response)
   }
@@ -94,7 +123,7 @@ class CompressionInterceptorTest {
   fun `should leave response unchanged when Content-Encoding is unknown`() {
     val response = encodedResponse("noop".toByteArray(), "lz4")
 
-    val result = CompressionInterceptor.uncompress(response)
+    val result = TransparentCompressionInterceptor.uncompress(response)
 
     assertThat(result).isSameInstanceAs(response)
   }
@@ -108,7 +137,7 @@ class CompressionInterceptorTest {
       .header("Content-Encoding", "gzip")
       .build()
 
-    val result = CompressionInterceptor.uncompress(response)
+    val result = TransparentCompressionInterceptor.uncompress(response)
 
     assertThat(result).isSameInstanceAs(response)
   }
@@ -138,7 +167,7 @@ class CompressionInterceptorTest {
         .build()
     }
 
-    CompressionInterceptor.intercept(chain)
+    TransparentCompressionInterceptor.intercept(chain)
     return captured.captured
   }
 

package/build/winter/fetch/FetchResponse.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"FetchResponse.d.ts","sourceRoot":"","sources":["../../../src/winter/fetch/FetchResponse.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,iBAAiB,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEzE,QAAA,MAAM,sBAAsB,EAAqC,OAAO,cAAc,CAAC;AACvF,MAAM,MAAM,gCAAgC,GAAG,MAAM,IAAI,CAAC;AAI1D,KAAK,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC,UAAU,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC;AACvE,KAAK,iBAAiB,GAAG,UAAU,CAAC,QAAQ,GAAG,UAAU,CAAC;AAW1D,QAAA,MAAM,QAAQ,eAAgC,CAAC;AAkH/C;;GAEG;AACH,qBAAa,aAAc,SAAQ,sBAAuB,YAAW,QAAQ;IAM/D,OAAO,CAAC,QAAQ,CAAC,oBAAoB;IALjD,OAAO,CAAC,CAAC,QAAQ,CAAC,CAGhB;gBAE2B,oBAAoB,EAAE,gCAAgC;IAQnF,IAAa,WAAW,IAAI,iBAAiB,CAE5C;IAED,IAAa,MAAM,IAAI,MAAM,CAE5B;IAED,IAAa,UAAU,IAAI,MAAM,CAEhC;IAED,IAAa,GAAG,IAAI,MAAM,CAEzB;IAED,IAAa,UAAU,IAAI,OAAO,CAEjC;IAED,IAAI,IAAI,IAAI,SAAS,CAEpB;IAED,IAAI,IAAI,IAAI,cAAc,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,GAAG,IAAI,CAoEzD;IAED,IAAa,QAAQ,IAAI,OAAO,CAE/B;IAED,IAAI,OAAO,IAAI,OAAO,CAErB;IAED,IAAI,EAAE,IAAI,OAAO,CAEhB;IAED;;OAEG;IACG,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAMrB,QAAQ,IAAI,OAAO,CAAC,iBAAiB,CAAC;IAgBtC,IAAI,IAAI,OAAO,CAAC,GAAG,CAAC;IAMpB,KAAK,IAAI,OAAO,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC;IAKhC,WAAW,IAAI,OAAO,CAAC,WAAW,CAAC;IAanC,IAAI,IAAI,OAAO,CAAC,MAAM,CAAC;IAatC,QAAQ,IAAI,MAAM;IAIlB,MAAM,IAAI,MAAM;IAShB,KAAK,IAAI,aAAa;IAsCtB,OAAO,CAAC,kBAAkB;IAU1B,OAAO,CAAC,QAAQ,CAQd;CACH"}
+{"version":3,"file":"FetchResponse.d.ts","sourceRoot":"","sources":["../../../src/winter/fetch/FetchResponse.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,iBAAiB,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEzE,QAAA,MAAM,sBAAsB,EAAqC,OAAO,cAAc,CAAC;AACvF,MAAM,MAAM,gCAAgC,GAAG,MAAM,IAAI,CAAC;AAI1D,KAAK,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC,UAAU,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC;AACvE,KAAK,iBAAiB,GAAG,UAAU,CAAC,QAAQ,GAAG,UAAU,CAAC;AAW1D,QAAA,MAAM,QAAQ,eAAgC,CAAC;AAqI/C;;GAEG;AACH,qBAAa,aAAc,SAAQ,sBAAuB,YAAW,QAAQ;IAM/D,OAAO,CAAC,QAAQ,CAAC,oBAAoB;IALjD,OAAO,CAAC,CAAC,QAAQ,CAAC,CAGhB;gBAE2B,oBAAoB,EAAE,gCAAgC;IAQnF,IAAa,WAAW,IAAI,iBAAiB,CAE5C;IAED,IAAa,MAAM,IAAI,MAAM,CAE5B;IAED,IAAa,UAAU,IAAI,MAAM,CAEhC;IAED,IAAa,GAAG,IAAI,MAAM,CAEzB;IAED,IAAa,UAAU,IAAI,OAAO,CAEjC;IAED,IAAI,IAAI,IAAI,SAAS,CAEpB;IAED,IAAI,IAAI,IAAI,cAAc,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,GAAG,IAAI,CA0EzD;IAED,IAAa,QAAQ,IAAI,OAAO,CAE/B;IAED,IAAI,OAAO,IAAI,OAAO,CAErB;IAED,IAAI,EAAE,IAAI,OAAO,CAEhB;IAED;;OAEG;IACG,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAMrB,QAAQ,IAAI,OAAO,CAAC,iBAAiB,CAAC;IAgBtC,IAAI,IAAI,OAAO,CAAC,GAAG,CAAC;IAMpB,KAAK,IAAI,OAAO,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC;IAKhC,WAAW,IAAI,OAAO,CAAC,WAAW,CAAC;IAanC,IAAI,IAAI,OAAO,CAAC,MAAM,CAAC;IAatC,QAAQ,IAAI,MAAM;IAIlB,MAAM,IAAI,MAAM;IAShB,KAAK,IAAI,aAAa;IAgDtB,OAAO,CAAC,kBAAkB;IAU1B,OAAO,CAAC,QAAQ,CAQd;CACH"}

package/bundledNativeModules.json

@@ -16,19 +16,19 @@
   "expo-analytics-amplitude": "~11.3.0",
   "expo-app-auth": "~11.1.0",
   "expo-app-loader-provider": "~8.0.0",
-  "expo-app-metrics": "~56.0.15",
+  "expo-app-metrics": "~56.0.16",
   "expo-apple-authentication": "~56.0.4",
   "expo-application": "~56.0.3",
   "expo-asset": "~56.0.15",
   "expo-audio": "~56.0.11",
   "expo-auth-session": "~56.0.13",
-  "expo-background-fetch": "~56.0.15",
-  "expo-background-task": "~56.0.15",
+  "expo-background-fetch": "~56.0.16",
+  "expo-background-task": "~56.0.16",
   "expo-battery": "~56.0.4",
   "expo-blur": "~56.0.3",
   "expo-brightness": "~56.0.5",
-  "expo-brownfield": "~56.0.16",
-  "expo-build-properties": "~56.0.15",
+  "expo-brownfield": "~56.0.17",
+  "expo-build-properties": "~56.0.16",
   "expo-calendar": "~56.0.8",
   "expo-camera": "~56.0.7",
   "expo-cellular": "~56.0.5",
@@ -37,7 +37,7 @@
   "expo-constants": "~56.0.16",
   "expo-contacts": "~56.0.7",
   "expo-crypto": "~56.0.4",
-  "expo-dev-client": "~56.0.17",
+  "expo-dev-client": "~56.0.18",
   "expo-device": "~56.0.4",
   "expo-document-picker": "~56.0.4",
   "expo-file-system": "~56.0.7",
@@ -48,16 +48,16 @@
   "expo-haptics": "~56.0.3",
   "expo-image": "~56.0.9",
   "expo-image-loader": "~56.0.3",
-  "expo-image-manipulator": "~56.0.15",
-  "expo-image-picker": "~56.0.14",
+  "expo-image-manipulator": "~56.0.16",
+  "expo-image-picker": "~56.0.15",
   "expo-intent-launcher": "~56.0.4",
-  "expo-insights": "~56.0.14",
+  "expo-insights": "~56.0.15",
   "expo-keep-awake": "~56.0.3",
   "expo-linear-gradient": "~56.0.4",
   "expo-linking": "~56.0.13",
   "expo-local-authentication": "~56.0.4",
   "expo-localization": "~56.0.6",
-  "expo-location": "~56.0.14",
+  "expo-location": "~56.0.15",
   "expo-mail-composer": "~56.0.4",
   "expo-manifests": "~56.0.4",
   "expo-maps": "~56.0.6",
@@ -68,8 +68,8 @@
   "expo-modules-core": "~56.0.14",
   "expo-navigation-bar": "~56.0.3",
   "expo-network": "~56.0.4",
-  "expo-notifications": "~56.0.14",
-  "expo-observe": "~56.0.17",
+  "expo-notifications": "~56.0.15",
+  "expo-observe": "~56.0.18",
   "expo-print": "~56.0.3",
   "expo-live-photo": "~56.0.3",
   "expo-router": "~56.2.8",
@@ -78,7 +78,7 @@
   "expo-secure-store": "~56.0.4",
   "expo-sensors": "~56.0.5",
   "expo-server": "~56.0.4",
-  "expo-sharing": "~56.0.14",
+  "expo-sharing": "~56.0.15",
   "expo-sms": "~56.0.3",
   "expo-speech": "~56.0.3",
   "expo-splash-screen": "~56.0.10",
@@ -87,7 +87,7 @@
   "expo-store-review": "~56.0.3",
   "expo-symbols": "~56.0.5",
   "expo-system-ui": "~56.0.5",
-  "expo-task-manager": "~56.0.15",
+  "expo-task-manager": "~56.0.16",
   "expo-tracking-transparency": "~56.0.5",
   "expo-updates": "~56.0.17",
   "expo-video-thumbnails": "~56.0.3",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo",
-  "version": "56.0.7",
+  "version": "56.0.8",
   "description": "The Expo SDK",
   "main": "src/Expo.ts",
   "module": "src/Expo.ts",
@@ -79,7 +79,7 @@
     "@expo/metro": "~56.0.0",
     "@expo/metro-config": "~56.0.13",
     "@ungap/structured-clone": "^1.3.0",
-    "babel-preset-expo": "~56.0.13",
+    "babel-preset-expo": "~56.0.14",
     "expo-asset": "~56.0.15",
     "expo-constants": "~56.0.16",
     "expo-file-system": "~56.0.7",
@@ -101,8 +101,8 @@
     "rimraf": "^6.1.2",
     "web-streams-polyfill": "^3.3.2",
     "@expo/dom-webview": "56.0.5",
-    "@expo/metro-runtime": "56.0.13",
-    "expo-updates": "56.0.17"
+    "expo-updates": "56.0.17",
+    "@expo/metro-runtime": "56.0.13"
   },
   "peerDependencies": {
     "@expo/dom-webview": "*",
@@ -139,7 +139,7 @@
       "scripts/resolveAppEntry.js"
     ]
   },
-  "gitHead": "a7adc95c1747db1e92655feba56d0e62660098db",
+  "gitHead": "7df487c3b35d509e8988c87c0abcf8a7d76aa202",
   "scripts": {
     "build": "tsc",
     "clean": "rimraf build",

package/src/winter/fetch/FetchResponse.ts

@@ -20,17 +20,25 @@ interface ResponseMetadata {
 
 const stateKey = Symbol('FetchResponse.state');
 
+interface ConsumptionWrapper {
+  stream: ReadableStream<Uint8Array<ArrayBuffer>>;
+  // Stops the wrapper from marking its body as consumed. Called by clone()
+  // when reads start coming through tee internals instead of from the user.
+  detach: () => void;
+}
+
 function wrapWithConsumption(
   source: ReadableStream<Uint8Array<ArrayBuffer>>,
   body: Body
-): ReadableStream<Uint8Array<ArrayBuffer>> {
+): ConsumptionWrapper {
   const reader = source.getReader();
   let markedConsumed = false;
+  let markedDetached = false;
 
-  return new ReadableStream(
+  const stream = new ReadableStream(
     {
       async pull(controller) {
-        if (!markedConsumed) {
+        if (!markedConsumed && !markedDetached) {
           markedConsumed = true;
           body.consumed = true;
         }
@@ -50,7 +58,7 @@ function wrapWithConsumption(
         }
       },
       cancel(reason) {
-        if (!markedConsumed) {
+        if (!markedConsumed && !markedDetached) {
           markedConsumed = true;
           body.consumed = true;
         }
@@ -67,6 +75,13 @@ function wrapWithConsumption(
       highWaterMark: 0,
     }
   );
+
+  return {
+    stream,
+    detach: () => {
+      markedDetached = true;
+    },
+  };
 }
 
 // JS-side body state. Held behind the stateKey symbol slot.
@@ -76,6 +91,10 @@ class Body {
   cloned: boolean;
   consumed = false;
 
+  // Detach fn for the wrapper currently held in `stream`. Null until the
+  // first clone wraps the native stream.
+  detach: (() => void) | null = null;
+
   constructor({ cloned }: { cloned: boolean }) {
     this.cloned = cloned;
   }
@@ -196,13 +215,19 @@ export class FetchResponse extends ConcreteNativeResponse implements Response {
             });
 
             this.addListener('didComplete', () => {
-              controller.close();
+              if (isControllerClosed) {
+                return;
+              }
               isControllerClosed = true;
+              controller.close();
             });
 
             this.addListener('didFailWithError', (error: string) => {
-              controller.error(new Error(error));
+              if (isControllerClosed) {
+                return;
+              }
               isControllerClosed = true;
+              controller.error(new Error(error));
             });
           },
 
@@ -358,9 +383,19 @@ export class FetchResponse extends ConcreteNativeResponse implements Response {
     // Tee so both responses can be read independently. Each branch is wrapped
     // so the first read flips the right consumed flag (otherwise bodyUsed lies).
     if (this.body != null) {
+      // Detach the existing wrapper so reads via the new tee don't flip
+      // this body's consumed flag through it.
+      state.body.detach?.();
+
       const [stream1, stream2] = this.body.tee();
-      state.body.stream = wrapWithConsumption(stream1, state.body);
-      cloneState.body.stream = wrapWithConsumption(stream2, cloneState.body);
+      const own = wrapWithConsumption(stream1, state.body);
+      const sibling = wrapWithConsumption(stream2, cloneState.body);
+
+      state.body.stream = own.stream;
+      state.body.detach = own.detach;
+
+      cloneState.body.stream = sibling.stream;
+      cloneState.body.detach = sibling.detach;
     }
 
     state.body.cloned = true;

package/src/winter/fetch/__tests__/FetchResponse-test.ts

@@ -13,6 +13,7 @@ jest.mock('../ExpoFetchModule', () => {
   const helloWorld = new TextEncoder().encode('hello world');
 
   class StubNativeResponse {
+    private listeners = new Map<string, Set<(...args: any[]) => void>>();
     private _bodyUsed = false;
 
     // Getters on the prototype, like the real native binding, so super.x works.
@@ -36,9 +37,31 @@ jest.mock('../ExpoFetchModule', () => {
       return this._bodyUsed;
     }
 
-    addListener() {}
-    removeListener() {}
-    removeAllListeners() {}
+    addListener(event: string, listener: (...args: any[]) => void) {
+      if (!this.listeners.has(event)) {
+        this.listeners.set(event, new Set());
+      }
+      this.listeners.get(event)!.add(listener);
+    }
+
+    removeListener(event: string, listener: (...args: any[]) => void) {
+      this.listeners.get(event)?.delete(listener);
+    }
+
+    removeAllListeners(event: string) {
+      this.listeners.delete(event);
+    }
+
+    emit(event: string, ...args: any[]) {
+      const listeners = this.listeners.get(event);
+      if (!listeners) {
+        return;
+      }
+
+      for (const listener of listeners) {
+        listener(...args);
+      }
+    }
 
     async arrayBuffer(): Promise<ArrayBuffer> {
       this._bodyUsed = true;
@@ -79,6 +102,41 @@ describe('FetchResponse', () => {
     expect(Object.prototype.toString.call(FetchResponse.prototype)).toBe('[object Response]');
   });
 
+  it('does not throw when native emits didComplete after the stream was canceled', async () => {
+    // Repros expo/expo#34804: native can deliver didComplete after the JS
+    // consumer has already canceled the stream. Before the fix this would
+    // call controller.close() on an already-closed controller and throw
+    // "The stream is not in a state that permits close" out of the event
+    // listener, surfacing as a fatal unhandled error.
+    const response = makeResponse();
+    const body = response.body!;
+    const reader = body.getReader();
+
+    await reader.cancel('consumer canceled');
+    expect(() => (response as any).emit('didComplete')).not.toThrow();
+  });
+
+  it('does not throw when native emits didFailWithError after the stream was canceled', async () => {
+    const response = makeResponse();
+    const body = response.body!;
+    const reader = body.getReader();
+
+    await reader.cancel('consumer canceled');
+    expect(() => (response as any).emit('didFailWithError', 'late error')).not.toThrow();
+  });
+
+  it('does not throw when native emits didComplete twice', async () => {
+    const response = makeResponse();
+    const body = response.body!;
+    const reader = body.getReader();
+    const readPromise = reader.read();
+
+    (response as any).emit('didComplete');
+    expect(() => (response as any).emit('didComplete')).not.toThrow();
+
+    await readPromise;
+  });
+
   describe('clone()', () => {
     it('returns a Response that exposes the same metadata', () => {
       const response = makeResponse();
@@ -116,6 +174,25 @@ describe('FetchResponse', () => {
       expect(bytes.byteLength).toBe(11);
     });
 
+    it('does not flip bodyUsed on siblings when a second clone is read', async () => {
+      const response = makeResponse();
+      const second = response.clone();
+      const third = response.clone();
+
+      await third.json().catch(() => {});
+
+      expect(response.bodyUsed).toBe(false);
+      expect(second.bodyUsed).toBe(false);
+      expect(third.bodyUsed).toBe(true);
+    });
+
+    it('lets the original be read after being cloned twice', async () => {
+      const response = makeResponse();
+      response.clone();
+      response.clone();
+      expect((await response.arrayBuffer()).byteLength).toBe(11);
+    });
+
     it('throws a TypeError if the body has already been read', async () => {
       const response = makeResponse();
       await response.arrayBuffer();