expo-video 2.0.2 → 2.0.3

package/CHANGELOG.md

@@ -10,6 +10,13 @@
 
 ### 💡 Others
 
+## 2.0.3 — 2024-12-19
+
+### 🐛 Bug fixes
+
+- [iOS] Fix empty notification showing on iOS when `showNowPlayingNotification` is set to false. ([#33698](https://github.com/expo/expo/pull/33698) by [@behenate](https://github.com/behenate))
+- [iOS] Dispatch current player item changes on main queue to fix KVO-related crashes. ([#33123](https://github.com/expo/expo/pull/33123) by [@behenate](https://github.com/behenate))
+
 ## 2.0.2 — 2024-11-29
 
 _This version does not introduce any user-facing changes._

package/android/build.gradle

@@ -1,7 +1,7 @@
 apply plugin: 'com.android.library'
 
 group = 'host.exp.exponent'
-version = '2.0.2'
+version = '2.0.3'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 apply from: expoModulesCorePlugin
@@ -14,7 +14,7 @@ android {
   namespace "expo.modules.video"
   defaultConfig {
     versionCode 1
-    versionName '2.0.2'
+    versionName '2.0.3'
   }
 }
 

package/ios/NowPlayingManager.swift

@@ -84,6 +84,10 @@ class NowPlayingManager: VideoPlayerObserverDelegate {
 
     removeExistingTargets(commandCenter: commandCenter)
 
+    guard self.mostRecentInteractionPlayer != nil else {
+      return
+    }
+
     playTarget = commandCenter.playCommand.addTarget { [weak self] _ in
       guard let self, let player = self.mostRecentInteractionPlayer else {
         return .commandFailed

package/ios/VideoPlayer.swift

@@ -135,12 +135,7 @@ internal final class VideoPlayer: SharedRef<AVPlayer>, Hashable, VideoPlayerObse
     NowPlayingManager.shared.unregisterPlayer(self)
     VideoManager.shared.unregister(videoPlayer: self)
 
-    // The current item has to be replaced with nil from the main thread. When replacing from the SharedObjectRegistry queue
-    // sometimes the KVOs used by AVPlayerViewController would try to deliver updates about the item being changed to nil after the
-    // player was deallocated, which caused crashes.
-    DispatchQueue.main.async { [pointer] in
-      pointer.replaceCurrentItem(with: nil)
-    }
+    try? self.replaceCurrentItem(with: nil)
   }
 
   func replaceCurrentItem(with videoSource: VideoSource?) throws {
@@ -148,7 +143,9 @@ internal final class VideoPlayer: SharedRef<AVPlayer>, Hashable, VideoPlayerObse
       let videoSource = videoSource,
       let url = videoSource.uri
     else {
-      pointer.replaceCurrentItem(with: nil)
+      DispatchQueue.main.async { [weak self] in
+        self?.pointer.replaceCurrentItem(with: nil)
+      }
       return
     }
 
@@ -166,7 +163,13 @@ internal final class VideoPlayer: SharedRef<AVPlayer>, Hashable, VideoPlayerObse
 
     playerItem.audioTimePitchAlgorithm = preservesPitch ? .spectral : .varispeed
     playerItem.preferredForwardBufferDuration = bufferOptions.preferredForwardBufferDuration
-    pointer.replaceCurrentItem(with: playerItem)
+
+    // The current item has to be replaced from the main thread. When replacing from other queues
+    // sometimes the KVOs will try to deliver updates after the item has been changed or player deallocated,
+    // which causes crashes.
+    DispatchQueue.main.async { [weak self] in
+      self?.pointer.replaceCurrentItem(with: playerItem)
+    }
   }
 
   /**

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "expo-video",
   "title": "Expo Video",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "A cross-platform, performant video component for React Native and Expo with Web support",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -38,5 +38,5 @@
     "react": "*",
     "react-native": "*"
   },
-  "gitHead": "728158f99d680cf64fb06f08301d3806c18c6f63"
+  "gitHead": "a246df22c427d8c6c905de0915ed50f721fdf062"
 }