expo-video-subtitle 0.1.2 → 0.2.0

package/.gitattributes

@@ -0,0 +1,17 @@
+# Keep the working copy at LF on every platform. Git already stores these files with LF, but a
+# Windows checkout with core.autocrlf=true rewrites them to CRLF, and the Prettier rule that
+# `npm run lint` enforces wants LF — which produced thousands of "Delete `␍`" warnings that buried
+# every real finding.
+* text=auto eol=lf
+
+# Binary assets must never be line-ending converted.
+*.png binary
+*.jpg binary
+*.jpeg binary
+*.gif binary
+*.ttf binary
+*.otf binary
+*.aar binary
+*.jar binary
+*.keystore binary
+*.tgz binary

package/CHANGELOG.md

@@ -1,70 +1,120 @@
-# Changelog
-
-All notable changes to this package are documented here.
-
-This package is a fork of [`expo-video`](https://github.com/expo/expo/tree/main/packages/expo-video).
-Changes inherited from the upstream base version are not repeated here — see the
-[upstream changelog](https://github.com/expo/expo/blob/main/packages/expo-video/CHANGELOG.md)
-for the history of everything that isn't subtitle related.
-
-## 0.1.2
-
-### Fixed
-
-- **Android:** subtitles that are on screen at the same time are now stacked as one block instead of
-  being drawn on top of each other. `.srt` files legitimately contain overlapping timestamps (two
-  speakers, dialogue over on-screen text), but SubRip carries no positioning, so Media3 pinned every
-  cue to the same spot and rendered them one over the other — Media3 does the stacking in its WebVTT
-  *parser* (`line = -1 - i`) and has no equivalent pass for SubRip. A `SubtitleParser` for SubRip now
-  splits the cue timeline at every boundary and merges the cues active in each slice into a single
-  multi-line cue, ordered like WebVTT: the cue that started earliest sits at the bottom. This also
-  makes Android match the iOS output, which already stacked because sideloaded SRT is converted to
-  WebVTT there. Cues with explicit `{\anN}` positioning are left untouched.
-- **Android:** selecting a `subtitleTrack` whose id is not among the available tracks no longer
-  leaves the previously selected track on screen. The cleared track-selection parameters were only
-  applied when a matching track was found, so an unmatched assignment silently did nothing; the
-  selection is now cleared and a warning is logged.
-- **Android:** `subtitleStyle.bottomOffset` is reset to the default when it is omitted, instead of
-  keeping the value from a previously applied style.
-
-## 0.1.1
-
-### Fixed
-
-- **Android:** `subtitleStyle.fontFamily` now resolves custom fonts bundled with the app, the same way
-  React Native resolves a `<Text>` component's `fontFamily`. It is looked up as an Android font
-  resource (`res/font`, where `expo-font`'s config plugin puts fonts) and then through React Native's
-  font manager, which covers the `assets/fonts/<name>.ttf` convention and fonts registered at runtime.
-  Previously only the built-in system families worked: `Typeface.create` silently fell back to the
-  default typeface for any bundled font, so `fontFamily` appeared to do nothing on Android while
-  working on iOS.
-
-### Documentation
-
-- Document font support and the silent-fallback behaviour for unresolved family names.
-
-## 0.1.0
-
-Initial release. Based on `expo-video` **56.1.4** (Expo SDK 56).
-
-### Added
-
-- **External (sideloaded) subtitles** via `VideoSource.subtitleTracks`. Attach WebVTT or SubRip
-  subtitle files (local or remote) to any source — most importantly progressive **MP4**, which,
-  unlike HLS/DASH manifests, cannot advertise its own subtitle renditions. Sideloaded tracks are
-  merged into the media and surface through `availableSubtitleTracks`, so they are selected with
-  `subtitleTrack` exactly like embedded tracks.
-  - Android: merged with `MediaItem.SubtitleConfiguration` (Media3 wraps them in a `MergingMediaSource`).
-  - iOS: merged into an `AVMutableComposition` as a `.text` track. SRT is converted to WebVTT, remote
-    files are cached locally first, and per-track time ranges are clamped to the video duration.
-    Applies to progressive, non-DRM sources on the asynchronous loading path.
-- **Custom subtitle styling** via the `VideoView` `subtitleStyle` prop: `textColor`, `backgroundColor`,
-  `windowColor`, `fontSize`, `fontFamily`, `bold`, `edgeType`, `edgeColor`, and `bottomOffset`.
-  Applies to embedded and sideloaded tracks alike.
-  - Android: `CaptionStyleCompat` on the `PlayerView` subtitle view.
-  - iOS: `AVPlayerItem.textStyleRules`.
-
-### Changed
-
-- The Android `publication` block and the iOS prebuild artifacts are removed, so the modified
-  Kotlin and Swift are compiled from source instead of resolving a precompiled AAR/XCFramework.
+# Changelog
+
+All notable changes to this package are documented here.
+
+This package is a fork of [`expo-video`](https://github.com/expo/expo/tree/main/packages/expo-video).
+Changes inherited from the upstream base version are not repeated here — see the
+[upstream changelog](https://github.com/expo/expo/blob/main/packages/expo-video/CHANGELOG.md)
+for the history of everything that isn't subtitle related.
+
+## 0.2.0
+
+### Added
+
+- **Android:** `subtitleStyle.applyEmbeddedStyles` keeps the inline formatting a subtitle track
+  carries instead of discarding it. Subtitle formats bring styling of their own — SubRip's `<b>`,
+  `<i>`, `<u>` and `<font color>` tags, and the richer per-cue styling of embedded WebVTT/TTML — and
+  until now every bit of it was thrown away so that `subtitleStyle` was the only thing deciding how
+  captions looked. `SubtitleView.setApplyEmbeddedStyles(false)` was hardcoded, and Media3 implements
+  that by removing every span from every cue, so an `.srt` written with `<i>` rendered upright.
+  Defaults to `false`, so nothing changes until you opt in. The rest of `subtitleStyle` still applies
+  underneath and `fontSize` still overrides any size the track asks for; the trade-off is that a cue
+  specifying its own colours overrides `textColor` and `windowColor` for that cue. There is no iOS
+  equivalent: `AVPlayerItem.textStyleRules` always composes with what the WebVTT cue declares.
+
+### Fixed
+
+- **Android:** a subtitle no longer drops down a line when the subtitle *below* it ends. Cues that
+  are on screen together are drawn as one block anchored at its bottom, so the moment the lower cue
+  expired the upper one fell into its place — moving the text at exactly the spot the viewer is
+  reading. Every cue now keeps the same line for its whole time on screen: the line a finished cue
+  leaves behind is held empty, and the next cue to start reclaims the lowest empty line rather than
+  stacking on top, which is what keeps the block from creeping upwards. An empty line can therefore
+  sit below — or between — the cues still on screen, and the stack resets once nothing is left on
+  screen. Cues with explicit `{\anN}` positioning are still passed through untouched.
+- **Android:** merging simultaneous SubRip cues no longer flattens their text. The cues were joined
+  through `toString()`, which erases the spans Media3's SubRip parser produces from inline tags. This
+  changed nothing on screen at the time, because the renderer stripped those spans anyway, but it
+  would have silently defeated the new `applyEmbeddedStyles` option for any overlapping cue.
+
+### Changed
+
+- Repository tooling, with no effect on the published runtime: `npm run lint` runs again. The repo
+  had no `eslint.config.js` — `expo-module configure` treats it as an optional template and never
+  creates one — while the `oxlint.config.mjs` it did have re-exported a module that
+  `expo-module-scripts@56` does not ship, so the lint step in `FORK.md` §5 had never actually
+  executed. A `.gitattributes` now pins the working copy to LF, which stops the Prettier rule from
+  reporting nearly every line of every file on a Windows checkout. The single lint error this
+  uncovered, a non-simple expression in a `useMemo` dependency list in `VideoPlayer.web.tsx`, is
+  fixed by hoisting it into a variable; the value and its identity semantics are unchanged.
+
+## 0.1.3
+
+### Documentation
+
+- Document how subtitles that are on screen at the same time are stacked, which shipped in 0.1.2 but
+  was only described in the changelog.
+- Add a release procedure to `FORK.md`, including the rule that every version bump carries a
+  changelog entry.
+
+## 0.1.2
+
+### Fixed
+
+- **Android:** subtitles that are on screen at the same time are now stacked as one block instead of
+  being drawn on top of each other. `.srt` files legitimately contain overlapping timestamps (two
+  speakers, dialogue over on-screen text), but SubRip carries no positioning, so Media3 pinned every
+  cue to the same spot and rendered them one over the other — Media3 does the stacking in its WebVTT
+  *parser* (`line = -1 - i`) and has no equivalent pass for SubRip. A `SubtitleParser` for SubRip now
+  splits the cue timeline at every boundary and merges the cues active in each slice into a single
+  multi-line cue, ordered like WebVTT: the cue that started earliest sits at the bottom. This also
+  makes Android match the iOS output, which already stacked because sideloaded SRT is converted to
+  WebVTT there. Cues with explicit `{\anN}` positioning are left untouched.
+- **Android:** selecting a `subtitleTrack` whose id is not among the available tracks no longer
+  leaves the previously selected track on screen. The cleared track-selection parameters were only
+  applied when a matching track was found, so an unmatched assignment silently did nothing; the
+  selection is now cleared and a warning is logged.
+- **Android:** `subtitleStyle.bottomOffset` is reset to the default when it is omitted, instead of
+  keeping the value from a previously applied style.
+
+## 0.1.1
+
+### Fixed
+
+- **Android:** `subtitleStyle.fontFamily` now resolves custom fonts bundled with the app, the same way
+  React Native resolves a `<Text>` component's `fontFamily`. It is looked up as an Android font
+  resource (`res/font`, where `expo-font`'s config plugin puts fonts) and then through React Native's
+  font manager, which covers the `assets/fonts/<name>.ttf` convention and fonts registered at runtime.
+  Previously only the built-in system families worked: `Typeface.create` silently fell back to the
+  default typeface for any bundled font, so `fontFamily` appeared to do nothing on Android while
+  working on iOS.
+
+### Documentation
+
+- Document font support and the silent-fallback behaviour for unresolved family names.
+
+## 0.1.0
+
+Initial release. Based on `expo-video` **56.1.4** (Expo SDK 56).
+
+### Added
+
+- **External (sideloaded) subtitles** via `VideoSource.subtitleTracks`. Attach WebVTT or SubRip
+  subtitle files (local or remote) to any source — most importantly progressive **MP4**, which,
+  unlike HLS/DASH manifests, cannot advertise its own subtitle renditions. Sideloaded tracks are
+  merged into the media and surface through `availableSubtitleTracks`, so they are selected with
+  `subtitleTrack` exactly like embedded tracks.
+  - Android: merged with `MediaItem.SubtitleConfiguration` (Media3 wraps them in a `MergingMediaSource`).
+  - iOS: merged into an `AVMutableComposition` as a `.text` track. SRT is converted to WebVTT, remote
+    files are cached locally first, and per-track time ranges are clamped to the video duration.
+    Applies to progressive, non-DRM sources on the asynchronous loading path.
+- **Custom subtitle styling** via the `VideoView` `subtitleStyle` prop: `textColor`, `backgroundColor`,
+  `windowColor`, `fontSize`, `fontFamily`, `bold`, `edgeType`, `edgeColor`, and `bottomOffset`.
+  Applies to embedded and sideloaded tracks alike.
+  - Android: `CaptionStyleCompat` on the `PlayerView` subtitle view.
+  - iOS: `AVPlayerItem.textStyleRules`.
+
+### Changed
+
+- The Android `publication` block and the iOS prebuild artifacts are removed, so the modified
+  Kotlin and Swift are compiled from source instead of resolving a precompiled AAR/XCFramework.

package/FORK.md

@@ -23,17 +23,20 @@ Measured against the published `expo-video@56.1.4` tarball. `+`/`-` are added/re
 | `ios/Records/SubtitleStyle.swift` | 118 | Record for caption styling; hex→ARGB parsing; builds `[AVTextStyleRule]`. |
 | `ios/VideoPlayerSubtitleSideload.swift` | 203 | Builds the `AVMutableComposition`, downloads remote subs, SRT→WebVTT converter. |
 | `android/…/records/SubtitleSource.kt` | 54 | Record → `MediaItem.SubtitleConfiguration` + MIME resolution. |
-| `android/…/records/SubtitleStyle.kt` | 129 | Record → `CaptionStyleCompat`; hex colour parsing; font-family resolution (`res/font` → `ReactFontManager`). |
-| `android/…/utils/StackingSubtitleParser.kt` | 214 | `SubtitleParser` for SubRip that segments the cue timeline and merges simultaneous cues into one stacked block, plus the `SubtitleParser.Factory` that routes SubRip to it. |
+| `android/…/records/SubtitleStyle.kt` | 137 | Record → `CaptionStyleCompat`; hex colour parsing; font-family resolution (`res/font` → `ReactFontManager`); the `applyEmbeddedStyles` flag, which `SubtitleUtils` reads directly rather than `toCaptionStyle`. |
+| `android/…/utils/StackingSubtitleParser.kt` | 297 | `SubtitleParser` for SubRip that segments the cue timeline and merges simultaneous cues into one stacked block, plus the `SubtitleParser.Factory` that routes SubRip to it. Assigns each cue a vertical slot it keeps for its whole time on screen — a finished cue's line is held blank (`\u200B`) so the cues above it do not drop. Merges through a `SpannableStringBuilder` so cue spans survive. |
 | `FORK.md`, `LICENSE` | — | This guide; MIT licence (upstream copyright preserved). |
+| `eslint.config.js` | 4 | Verbatim copy of `expo-module-scripts/templates/eslint.config.js`. **Recreate it if a sync drops it** — `expo-module configure` treats it as an *optional* template and only syncs it when it already exists, so without this file `npm run lint` dies with "ESLint couldn't find an eslint.config.js". |
+| `.gitattributes` | 21 | Pins the working copy to LF. Git stores these files with LF, but a Windows checkout rewrites them to CRLF and the Prettier rule `npm run lint` enforces wants LF, which drowned the output in ~2800 "Delete `␍`" warnings. |
 
 ### Modified — upstream files carrying fork edits (re-apply these after a sync)
 
 | File | Δ | What to re-apply |
 | --- | --- | --- |
 | `src/VideoPlayer.types.ts` | +59 | `subtitleTracks?: SubtitleSource[]` on `VideoSourceObject`; the exported `SubtitleSource` type. |
-| `src/VideoView.types.ts` | +94 | `subtitleStyle?: SubtitleStyle` on `VideoViewProps`; `SubtitleStyle` + `SubtitleEdgeType` types. |
+| `src/VideoView.types.ts` | +114 | `subtitleStyle?: SubtitleStyle` on `VideoViewProps`; `SubtitleStyle` + `SubtitleEdgeType` types. |
 | `src/index.ts` | +2 | Export `SubtitleStyle`, `SubtitleEdgeType` (`SubtitleSource` rides on `export type *`). |
+| `src/VideoPlayer.web.tsx` | +5 / −1 | Hoist `JSON.stringify(source)` out of the `useMemo` dependency list into a `sourceKey` const. No behaviour change — it was already recomputed every render — but `react-hooks/use-memo` rejects non-simple expressions in a dependency array, and it was the single lint **error** in the package. |
 | `src/ts-declarations/react-native-assets.d.ts` | +22 / −1 | Replace upstream's `../../../expo-asset/…` reference (monorepo-only) with standalone `declare module` shims. **Always needed outside the Expo monorepo.** |
 | `ios/Records/VideoSource.swift` | +3 | `@Field var subtitleTracks: [SubtitleSource]?`. |
 | `ios/VideoPlayerItem.swift` | +17 / −2 | In the **async** init: hoist `isHls` to a local, and build the sideload composition for non-HLS/non-DRM sources before `super.init(asset:)`. |
@@ -41,7 +44,7 @@ Measured against the published `expo-video@56.1.4` tarball. `+`/`-` are added/re
 | `ios/VideoView.swift` | +8 | `subtitleStyle` property; forward it when `player` is (re)assigned. |
 | `ios/VideoModule.swift` | +4 | `Prop("subtitleStyle")`. |
 | `android/…/records/VideoSource.kt` | +9 / −2 | `subtitleTracks` field; `setSubtitleConfigurations(…)` in `toMediaItem()`; subtitle key in `toMediaId()`. |
-| `android/…/utils/SubtitleUtils.kt` | +27 / −16 | `configureSubtitleView(…, customStyle)` overload and a `styleProvider` on the captioning listener. Keeps the original behaviour when no custom style is set. Passes `context` to `toCaptionStyle` for font lookup. |
+| `android/…/utils/SubtitleUtils.kt` | +33 / −17 | `configureSubtitleView(…, customStyle)` overload and a `styleProvider` on the captioning listener. Keeps the original behaviour when no custom style is set. Passes `context` to `toCaptionStyle` for font lookup. Drives `setApplyEmbeddedStyles` from `customStyle.applyEmbeddedStyles` (upstream hardcodes `false`). |
 | `android/…/VideoView.kt` | +12 / −5 | `subtitleStyle` property; pass it at all 4 `configureSubtitleView` call sites + the captioning listener. |
 | `android/…/VideoModule.kt` | +4 | `Prop("subtitleStyle")`. |
 | `android/…/utils/DataSourceUtils.kt` | +5 | `setSubtitleParserFactory(ExpoVideoSubtitleParserFactory())` on the `DefaultMediaSourceFactory`. Note this file declares `package expo.modules.video` despite living in `utils/`, so the factory needs an explicit import. |
@@ -58,10 +61,11 @@ Measured against the published `expo-video@56.1.4` tarball. `+`/`-` are added/re
 | `local-maven-repo/` (Android AAR) | Upstream ships a **precompiled** `expo.modules.video` AAR. If present, Gradle resolves it and **silently ignores the modified Kotlin**. |
 | `prebuilds/` (iOS XCFramework) | Same trap on iOS: CocoaPods links the prebuilt `ExpoVideo.xcframework` instead of compiling the modified Swift. |
 | `spm.config.json` | Swift Package Manager prebuild config; meaningless once we build from source. |
+| `oxlint.config.mjs` | Re-exported `expo-module-scripts/oxlint.config.base`, which does not exist in `expo-module-scripts@56` — that package lints with ESLint and ships no oxlint base. A dead file that only misled readers into thinking oxlint was the configured linter. |
 
 > **This is the single most important thing to preserve.** If a sync re-introduces the `publication`
 > block, `local-maven-repo/` or `prebuilds/`, the app keeps building — it just runs **upstream's**
-> video module, and every subtitle feature silently disappears. Verify with §4.
+> video module, and every subtitle feature silently disappears. Verify with §5.
 
 ### External API coupling to watch
 
@@ -105,9 +109,12 @@ Then re-apply the fork:
    with real deletions are `SubtitleUtils.kt` (function rewritten), `VideoView.kt`/`FullscreenPlayerActivity.kt`
    (call-site signatures), `VideoPlayerItem.swift` (`isHls` hoist) and the ts-declarations shim.
 7. **Remove the Android `publication` block** from `expo-module.config.json`.
-8. **Restore the fork's `package.json`** (§3) and keep `README.md`, `CHANGELOG.md`, `LICENSE`, `FORK.md`.
+8. **Restore the fork's `package.json`** (§3) and keep `README.md`, `CHANGELOG.md`, `LICENSE`,
+   `FORK.md`, `eslint.config.js` and `.gitattributes`. Step 3 only replaces `src ios android plugin`,
+   so the root-level files survive on their own — but confirm it, because a missing `eslint.config.js`
+   breaks `npm run lint` in a way that reads like a tooling bug rather than a lost file.
 9. Update the baseline version in this file, the README, and add a `CHANGELOG.md` entry.
-10. Verify with §4, then commit.
+10. Verify with §5, then commit.
 
 ---
 
@@ -127,31 +134,125 @@ Upstream's `package.json` will overwrite these if copied blindly. Keep:
 
 ---
 
-## 4. Verification
+## 4. Releasing
 
-Run all four. The native ones are what actually prove the fork survived the sync.
+**Every version bump gets a `CHANGELOG.md` entry — no exceptions, including one-line fixes.**
+The changelog is the only place a consumer can see what changed between two installs, and this
+package ships native code, so a bump can silently change runtime behaviour on a device.
+
+For each release:
+
+1. Decide the version (semver against the *fork's* own API, not the upstream `expo-video` version):
+   - **patch** — bug fix, no API change.
+   - **minor** — new option/prop/field, or a behaviour change consumers may notice.
+   - **major** — anything that breaks an existing call site.
+2. Add a `## <version>` section at the top of `CHANGELOG.md`, above the previous release, grouped
+   under `### Added` / `### Fixed` / `### Changed` / `### Documentation`. Write it for someone who
+   does not know the codebase: what they will observe, and on which platform. Say *why* when the
+   cause is non-obvious — the entries for 0.1.1 and 0.1.2 are the reference for the level of detail.
+3. `npm version <version> --no-git-tag-version`.
+4. Update the docs the change touches — `README.md` for anything user-facing (a new option, a
+   changed rendering behaviour), and §1 of this file if files were added, removed or newly modified.
+5. Verify with §5, then commit and push.
+6. `npm publish` (its `prepublishOnly` cleans and rebuilds; never publish from a dirty tree).
+
+When a release syncs a new upstream `expo-video`, note the new baseline version in the changelog
+entry, in §1 of this file and in the README's intro line.
+
+## 5. Verification
+
+> **This package is standalone.** Nothing in this section may reach into an unrelated project's
+> checkout. Verifying by overlaying the package onto some other app's `node_modules` silently mutates
+> a repository that has nothing to do with this one, and couples a public npm package to a private
+> codebase. If a step needs a host app, create a throwaway one for that purpose.
+
+### Self-contained — run these on every change
 
 ```bash
 npm run typecheck        # must be clean
-npm run lint
+npm run lint             # must exit 0; warnings are tolerated, errors are not
 npm pack --dry-run       # expect build/, plugin/build/, LICENSE, native sources;
                          # NO node_modules, prebuilds, local-maven-repo
 ```
 
-**Native compile** — because both platforms default to precompiled artifacts, you must build from
-source inside a host app. Overlay this package into the app's `node_modules/expo-video`, then:
+`npm run lint` needs `eslint.config.js` at the repo root — `expo-module configure` will **not**
+create it (it is an optional template that only gets synced when it already exists), so a sync that
+loses the file silently breaks this step. See §1.
+
+### Android — compiling the parser without a host app
+
+`utils/StackingSubtitleParser.kt` imports only `android.text.*` and `androidx.media3.*`, so it
+compiles on its own. This is the file that carries almost all of the Android subtitle logic, and it
+is the one most likely to break when Media3 changes `SubtitleParser`, `CuesWithTiming` or `Cue`.
+
+In a scratch directory, with `<media3>` set to `androidxMedia3Version` from `android/build.gradle`
+and `<sdk>` to an installed Android platform:
+
+```kotlin
+// settings.gradle.kts -> rootProject.name = "kotlincheck"
+// build.gradle.kts:
+import java.util.zip.ZipFile
+
+plugins { kotlin("jvm") version "2.1.21" }
+repositories { google(); mavenCentral() }
+
+val media3: Configuration by configurations.creating
+dependencies {
+  media3("androidx.media3:media3-common:<media3>")
+  media3("androidx.media3:media3-extractor:<media3>")
+  media3("androidx.media3:media3-ui:<media3>")
+}
+
+// A plain JVM compile cannot read .aar, so pull classes.jar out of each one.
+val unpacked = layout.buildDirectory.dir("unpacked")
+val unpackAars by tasks.registering {
+  outputs.dir(unpacked)
+  doLast {
+    val out = unpacked.get().asFile.also { it.deleteRecursively(); it.mkdirs() }
+    media3.forEach { f ->
+      if (f.name.endsWith(".aar")) {
+        ZipFile(f).use { zip ->
+          zip.getEntry("classes.jar")?.let { e ->
+            zip.getInputStream(e).use { it.copyTo(File(out, f.name.removeSuffix(".aar") + ".jar").outputStream()) }
+          }
+        }
+      } else if (f.name.endsWith(".jar")) f.copyTo(File(out, f.name), overwrite = true)
+    }
+  }
+}
+
+tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
+  dependsOn(unpackAars)
+  libraries.from(fileTree(unpacked) { include("*.jar") }, files("<sdk>/platforms/android-36/android.jar"))
+}
+```
+
+Copy the file to `src/main/kotlin/expo/modules/video/utils/` and run `gradle compileKotlin` —
+expect `BUILD SUCCESSFUL`. Because the class implements Media3's `SubtitleParser`, a successful
+build also proves the three overrides still match that Media3 version's interface.
+
+The rest of the Android sources import `expo.modules.kotlin` and `com.facebook.react`, neither of
+which is on a public Maven repository, so they cannot be checked this way — a full build is the only
+option for them.
+
+### Full native build — needs a throwaway host app
+
+Both platforms default to precompiled artifacts, so a complete check means building from source in a
+host app. Create one for this purpose (`npx create-expo-app`), install this package into it, and
+confirm §1's "Removed" artifacts are absent from the installed copy:
 
 ```bash
 # Android — expect BUILD SUCCESSFUL
-cd <app>/android && ./gradlew :expo-video:compileDebugKotlin
+cd <scratch-app>/android && ./gradlew :expo-video-subtitle:compileDebugKotlin
 
 # iOS — expect BUILD SUCCEEDED
-cd <app>/ios && pod install
+cd <scratch-app>/ios && pod install
 xcodebuild -project Pods/Pods.xcodeproj -target ExpoVideo -sdk iphoneos \
   -configuration Debug build CODE_SIGNING_ALLOWED=NO
 ```
 
-Back up `node_modules/expo-video` first and restore it (plus `pod install`) afterwards.
+`npm pack` the fork and install the tarball rather than editing the app's `node_modules` in place,
+so the thing you compile is exactly what a consumer would receive.
 
 **Smoke test in the app:** an MP4 source with `subtitleTracks` must list the tracks in
 `player.availableSubtitleTracks`, render when selected via `player.subtitleTrack`, and visibly change

package/LICENSE

@@ -1,21 +1,21 @@
-The MIT License (MIT)
-
-Copyright (c) 2015-present 650 Industries, Inc. (aka Expo)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+The MIT License (MIT)
+
+Copyright (c) 2015-present 650 Industries, Inc. (aka Expo)
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.