expo-updates 0.25.26 → 0.25.27

package/CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### 💡 Others
 
+## 0.25.27 — 2024-10-08
+
+### 🐛 Bug fixes
+
+- [cli] Disable console during runtime and fingeprint evaluation ([#31874](https://github.com/expo/expo/pull/31874) by [@wschurman](https://github.com/wschurman))
+
 ## 0.25.26 — 2024-10-02
 
 ### 🐛 Bug fixes

package/android/build.gradle

@@ -2,7 +2,7 @@ apply plugin: 'com.android.library'
 apply plugin: 'kotlin-kapt'
 
 group = 'host.exp.exponent'
-version = '0.25.26'
+version = '0.25.27'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 apply from: expoModulesCorePlugin
@@ -49,7 +49,7 @@ android {
   namespace "expo.modules.updates"
   defaultConfig {
     versionCode 31
-    versionName '0.25.26'
+    versionName '0.25.27'
     consumerProguardFiles(rnVersion >= versionToNumber(0, 75, 0) ? 'proguard-rules-75.pro' : 'proguard-rules.pro')
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
 

package/cli/build/configureCodeSigning.js

@@ -59,7 +59,7 @@ Configure expo-updates code signing for this project and verify setup
     const certificateInput = (0, args_1.requireArg)(args, '--certificate-input-directory');
     const keyInput = (0, args_1.requireArg)(args, '--key-input-directory');
     const keyid = args['--keyid'];
-    return await configureCodeSigningAsync((0, args_1.getProjectRoot)(args), {
+    await configureCodeSigningAsync((0, args_1.getProjectRoot)(args), {
         certificateInput,
         keyInput,
         keyid,

package/cli/build/generateCodeSigning.js

@@ -63,7 +63,7 @@ Generate expo-updates private key, public key, and code signing certificate usin
     const certificateOutput = (0, args_1.requireArg)(args, '--certificate-output-directory');
     const certificateValidityDurationYears = (0, args_1.requireArg)(args, '--certificate-validity-duration-years');
     const certificateCommonName = (0, args_1.requireArg)(args, '--certificate-common-name');
-    return await generateCodeSigningAsync((0, args_1.getProjectRoot)(args), {
+    await generateCodeSigningAsync((0, args_1.getProjectRoot)(args), {
         certificateValidityDurationYears,
         keyOutput,
         certificateOutput,

package/cli/build/generateFingerprint.js

@@ -32,6 +32,7 @@ const chalk_1 = __importDefault(require("chalk"));
 const args_1 = require("./utils/args");
 const errors_1 = require("./utils/errors");
 const Log = __importStar(require("./utils/log"));
+const withConsoleDisabledAsync_1 = require("./utils/withConsoleDisabledAsync");
 const generateFingerprint = async (argv) => {
     const args = (0, args_1.assertArgs)({
         // Types
@@ -71,14 +72,18 @@ Generate fingerprint for use in expo-updates runtime version
     }
     const debug = args['--debug'];
     const projectRoot = (0, args_1.getProjectRoot)(args);
-    let result;
-    try {
-        const workflow = workflowArg ?? (await resolveWorkflowAsync(projectRoot, platform));
-        result = await createFingerprintAsync(projectRoot, platform, workflow, { silent: true, debug });
-    }
-    catch (e) {
-        throw new errors_1.CommandError(e.message);
-    }
+    const result = await (0, withConsoleDisabledAsync_1.withConsoleDisabledAsync)(async () => {
+        try {
+            const workflow = workflowArg ?? (await resolveWorkflowAsync(projectRoot, platform));
+            return await createFingerprintAsync(projectRoot, platform, workflow, {
+                silent: true,
+                debug,
+            });
+        }
+        catch (e) {
+            throw new errors_1.CommandError(e.message);
+        }
+    });
     console.log(JSON.stringify(result));
 };
 exports.generateFingerprint = generateFingerprint;

package/cli/build/resolveRuntimeVersion.js

@@ -32,6 +32,7 @@ const chalk_1 = __importDefault(require("chalk"));
 const args_1 = require("./utils/args");
 const errors_1 = require("./utils/errors");
 const Log = __importStar(require("./utils/log"));
+const withConsoleDisabledAsync_1 = require("./utils/withConsoleDisabledAsync");
 const resolveRuntimeVersion = async (argv) => {
     const args = (0, args_1.assertArgs)({
         // Types
@@ -67,18 +68,19 @@ Resolve expo-updates runtime version
         throw new errors_1.CommandError(`Invalid workflow argument: ${workflow}. Must be either 'managed' or 'generic'`);
     }
     const debug = args['--debug'];
-    let runtimeVersionInfo;
-    try {
-        runtimeVersionInfo = await resolveRuntimeVersionAsync((0, args_1.getProjectRoot)(args), platform, {
-            silent: true,
-            debug,
-        }, {
-            workflowOverride: workflow,
-        });
-    }
-    catch (e) {
-        throw new errors_1.CommandError(e.message);
-    }
+    const runtimeVersionInfo = await (0, withConsoleDisabledAsync_1.withConsoleDisabledAsync)(async () => {
+        try {
+            return await resolveRuntimeVersionAsync((0, args_1.getProjectRoot)(args), platform, {
+                silent: true,
+                debug,
+            }, {
+                workflowOverride: workflow,
+            });
+        }
+        catch (e) {
+            throw new errors_1.CommandError(e.message);
+        }
+    });
     console.log(JSON.stringify(runtimeVersionInfo));
 };
 exports.resolveRuntimeVersion = resolveRuntimeVersion;

package/cli/build/utils/withConsoleDisabledAsync.d.ts

@@ -0,0 +1 @@
+export declare function withConsoleDisabledAsync<T>(block: () => Promise<T>): Promise<T>;

package/cli/build/utils/withConsoleDisabledAsync.js

@@ -0,0 +1,24 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.withConsoleDisabledAsync = void 0;
+async function withConsoleDisabledAsync(block) {
+    const loggingFunctions = {
+        log: console.log,
+        warn: console.warn,
+        error: console.error,
+    };
+    // Disable logging for this command since the only thing printed to stdout should be the JSON output.
+    console.log = function () { };
+    console.warn = function () { };
+    console.error = function () { };
+    try {
+        return await block();
+    }
+    finally {
+        // Re-enable logging functions for testing.
+        console.log = loggingFunctions.log;
+        console.warn = loggingFunctions.warn;
+        console.error = loggingFunctions.error;
+    }
+}
+exports.withConsoleDisabledAsync = withConsoleDisabledAsync;

package/cli/src/configureCodeSigning.ts

@@ -43,7 +43,7 @@ Configure expo-updates code signing for this project and verify setup
   const keyInput = requireArg(args, '--key-input-directory');
   const keyid = args['--keyid'];
 
-  return await configureCodeSigningAsync(getProjectRoot(args), {
+  await configureCodeSigningAsync(getProjectRoot(args), {
     certificateInput,
     keyInput,
     keyid,

package/cli/src/generateCodeSigning.ts

@@ -50,7 +50,7 @@ Generate expo-updates private key, public key, and code signing certificate usin
   );
   const certificateCommonName = requireArg(args, '--certificate-common-name');
 
-  return await generateCodeSigningAsync(getProjectRoot(args), {
+  await generateCodeSigningAsync(getProjectRoot(args), {
     certificateValidityDurationYears,
     keyOutput,
     certificateOutput,

package/cli/src/generateFingerprint.ts

@@ -5,6 +5,7 @@ import { Command } from './cli';
 import { requireArg, assertArgs, getProjectRoot } from './utils/args';
 import { CommandError } from './utils/errors';
 import * as Log from './utils/log';
+import { withConsoleDisabledAsync } from './utils/withConsoleDisabledAsync';
 
 export const generateFingerprint: Command = async (argv) => {
   const args = assertArgs(
@@ -60,13 +61,17 @@ Generate fingerprint for use in expo-updates runtime version
 
   const projectRoot = getProjectRoot(args);
 
-  let result;
-  try {
-    const workflow = workflowArg ?? (await resolveWorkflowAsync(projectRoot, platform));
-    result = await createFingerprintAsync(projectRoot, platform, workflow, { silent: true, debug });
-  } catch (e: any) {
-    throw new CommandError(e.message);
-  }
+  const result = await withConsoleDisabledAsync(async () => {
+    try {
+      const workflow = workflowArg ?? (await resolveWorkflowAsync(projectRoot, platform));
+      return await createFingerprintAsync(projectRoot, platform, workflow, {
+        silent: true,
+        debug,
+      });
+    } catch (e: any) {
+      throw new CommandError(e.message);
+    }
+  });
 
   console.log(JSON.stringify(result));
 };

package/cli/src/resolveRuntimeVersion.ts

@@ -5,6 +5,7 @@ import { Command } from './cli';
 import { requireArg, assertArgs, getProjectRoot } from './utils/args';
 import { CommandError } from './utils/errors';
 import * as Log from './utils/log';
+import { withConsoleDisabledAsync } from './utils/withConsoleDisabledAsync';
 
 export const resolveRuntimeVersion: Command = async (argv) => {
   const args = assertArgs(
@@ -57,21 +58,23 @@ Resolve expo-updates runtime version
 
   const debug = args['--debug'];
 
-  let runtimeVersionInfo;
-  try {
-    runtimeVersionInfo = await resolveRuntimeVersionAsync(
-      getProjectRoot(args),
-      platform,
-      {
-        silent: true,
-        debug,
-      },
-      {
-        workflowOverride: workflow,
-      }
-    );
-  } catch (e: any) {
-    throw new CommandError(e.message);
-  }
+  const runtimeVersionInfo = await withConsoleDisabledAsync(async () => {
+    try {
+      return await resolveRuntimeVersionAsync(
+        getProjectRoot(args),
+        platform,
+        {
+          silent: true,
+          debug,
+        },
+        {
+          workflowOverride: workflow,
+        }
+      );
+    } catch (e: any) {
+      throw new CommandError(e.message);
+    }
+  });
+
   console.log(JSON.stringify(runtimeVersionInfo));
 };

package/cli/src/utils/withConsoleDisabledAsync.ts

@@ -0,0 +1,20 @@
+export async function withConsoleDisabledAsync<T>(block: () => Promise<T>): Promise<T> {
+  const loggingFunctions = {
+    log: console.log,
+    warn: console.warn,
+    error: console.error,
+  };
+  // Disable logging for this command since the only thing printed to stdout should be the JSON output.
+  console.log = function () {};
+  console.warn = function () {};
+  console.error = function () {};
+
+  try {
+    return await block();
+  } finally {
+    // Re-enable logging functions for testing.
+    console.log = loggingFunctions.log;
+    console.warn = loggingFunctions.warn;
+    console.error = loggingFunctions.error;
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-updates",
-  "version": "0.25.26",
+  "version": "0.25.27",
   "description": "Fetches and manages remotely-hosted assets and updates to your app's JS bundle.",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -67,5 +67,5 @@
   "peerDependencies": {
     "expo": "*"
   },
-  "gitHead": "c4e3aca2a633a6ece2ef3a970edec1d0a347e77b"
+  "gitHead": "826560298c428d3e57db0f06cb65306b824082b4"
 }