expo-updates 0.24.3 → 0.24.4

package/CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### 💡 Others
 
+## 0.24.4 — 2023-12-19
+
+### 🐛 Bug fixes
+
+- Add relaunch to disabled and dev client controllers. ([#25973](https://github.com/expo/expo/pull/25973) by [@wschurman](https://github.com/wschurman))
+
 ## 0.24.3 — 2023-12-15
 
 _This version does not introduce any user-facing changes._

package/android/build.gradle

@@ -4,7 +4,7 @@ apply plugin: 'kotlin-kapt'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '0.24.3'
+version = '0.24.4'
 
 def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
 if (expoModulesCorePlugin.exists()) {
@@ -122,7 +122,7 @@ android {
   namespace "expo.modules.updates"
   defaultConfig {
     versionCode 31
-    versionName '0.24.3'
+    versionName '0.24.4'
     consumerProguardFiles("proguard-rules.pro")
     testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
 

package/android/src/main/java/expo/modules/updates/DisabledUpdatesController.kt

@@ -1,20 +1,27 @@
+@file:Suppress("UnusedImport") // this needs to stay for versioning to work
+
 package expo.modules.updates
 
 import android.content.Context
 import android.os.Bundle
 import android.util.Log
+import com.facebook.react.ReactApplication
 import com.facebook.react.ReactInstanceManager
+import com.facebook.react.ReactNativeHost
+import com.facebook.react.bridge.WritableMap
 import expo.modules.kotlin.exception.CodedException
+import expo.modules.kotlin.exception.toCodedException
 import expo.modules.updates.UpdatesConfiguration.Companion.UPDATES_CONFIGURATION_RELEASE_CHANNEL_DEFAULT_VALUE
 import expo.modules.updates.launcher.Launcher
 import expo.modules.updates.launcher.NoDatabaseLauncher
+import expo.modules.updates.logging.UpdatesLogger
+import expo.modules.updates.procedures.RecreateReactContextProcedure
+import expo.modules.updates.statemachine.UpdatesStateChangeEventSender
 import expo.modules.updates.statemachine.UpdatesStateContext
+import expo.modules.updates.statemachine.UpdatesStateEventType
+import expo.modules.updates.statemachine.UpdatesStateMachine
 import java.io.File
-
-// this needs to stay for versioning to work
-/* ktlint-disable no-unused-imports */
-import expo.modules.updates.UpdatesConfiguration
-/* ktlint-enable no-unused-imports */
+import java.lang.ref.WeakReference
 
 /**
  * Updates controller for applications that either disable updates explicitly or have an error
@@ -27,7 +34,15 @@ class DisabledUpdatesController(
   private val context: Context,
   private val fatalException: Exception?,
   private val isMissingRuntimeVersion: Boolean
-) : IUpdatesController {
+) : IUpdatesController, UpdatesStateChangeEventSender {
+  private val reactNativeHost: WeakReference<ReactNativeHost>? = if (context is ReactApplication) {
+    WeakReference(context.reactNativeHost)
+  } else {
+    null
+  }
+  private val logger = UpdatesLogger(context)
+  private val stateMachine = UpdatesStateMachine(context, this)
+
   private var isStarted = false
   private var launcher: Launcher? = null
   private var isLoaderTaskFinished = false
@@ -82,15 +97,28 @@ class DisabledUpdatesController(
       requestHeaders = mapOf(),
       localAssetFiles = launcher?.localAssetFiles,
       isMissingRuntimeVersion = isMissingRuntimeVersion,
+      shouldDeferToNativeForAPIMethodAvailabilityInDevelopment = false
     )
   }
 
   override fun relaunchReactApplicationForModule(callback: IUpdatesController.ModuleCallback<Unit>) {
-    callback.onFailure(UpdatesDisabledException("You cannot reload when expo-updates is not enabled."))
+    val procedure = RecreateReactContextProcedure(
+      reactNativeHost,
+      object : Launcher.LauncherCallback {
+        override fun onFailure(e: Exception) {
+          callback.onFailure(e.toCodedException())
+        }
+
+        override fun onSuccess() {
+          callback.onSuccess(Unit)
+        }
+      }
+    )
+    stateMachine.queueExecution(procedure)
   }
 
   override fun getNativeStateMachineContext(callback: IUpdatesController.ModuleCallback<UpdatesStateContext>) {
-    callback.onFailure(UpdatesDisabledException("You cannot check for updates when expo-updates is not enabled."))
+    callback.onSuccess(stateMachine.context)
   }
 
   override fun checkForUpdate(
@@ -129,4 +157,15 @@ class DisabledUpdatesController(
   companion object {
     private val TAG = DisabledUpdatesController::class.java.simpleName
   }
+
+  override fun sendUpdateStateChangeEventToBridge(
+    eventType: UpdatesStateEventType,
+    context: UpdatesStateContext
+  ) {
+    sendEventToJS(EnabledUpdatesController.UPDATES_STATE_CHANGE_EVENT_NAME, eventType.type, context.writableMap)
+  }
+
+  private fun sendEventToJS(eventName: String, eventType: String, params: WritableMap?) {
+    UpdatesUtils.sendEventToReactNative(reactNativeHost, logger, eventName, eventType, params)
+  }
 }

package/android/src/main/java/expo/modules/updates/EnabledUpdatesController.kt

@@ -1,3 +1,5 @@
+@file:Suppress("UnusedImport") // this needs to stay for versioning to work
+
 package expo.modules.updates
 
 import android.content.Context
@@ -33,9 +35,6 @@ import java.io.File
 import java.lang.ref.WeakReference
 
 // this needs to stay for versioning to work
-/* ktlint-disable no-unused-imports */
-import expo.modules.updates.UpdatesConfiguration
-/* ktlint-enable no-unused-imports */
 
 /**
  * Updates controller for applications that have updates enabled and properly-configured.
@@ -45,7 +44,7 @@ class EnabledUpdatesController(
   private val updatesConfiguration: UpdatesConfiguration,
   override val updatesDirectory: File
 ) : IUpdatesController, UpdatesStateChangeEventSender {
-  private var reactNativeHost: WeakReference<ReactNativeHost>? = if (context is ReactApplication) {
+  private val reactNativeHost: WeakReference<ReactNativeHost>? = if (context is ReactApplication) {
     WeakReference(context.reactNativeHost)
   } else {
     null
@@ -198,6 +197,7 @@ class EnabledUpdatesController(
       requestHeaders = updatesConfiguration.requestHeaders,
       localAssetFiles = localAssetFiles,
       isMissingRuntimeVersion = false,
+      shouldDeferToNativeForAPIMethodAvailabilityInDevelopment = false
     )
   }
 
@@ -244,7 +244,7 @@ class EnabledUpdatesController(
       try {
         val result = ManifestMetadata.getExtraParams(
           databaseHolder.database,
-          updatesConfiguration,
+          updatesConfiguration
         )
         databaseHolder.releaseDatabase()
         val resultMap = when (result) {
@@ -290,7 +290,7 @@ class EnabledUpdatesController(
     private const val UPDATE_NO_UPDATE_AVAILABLE_EVENT = "noUpdateAvailable"
     private const val UPDATE_ERROR_EVENT = "error"
 
-    private const val UPDATES_EVENT_NAME = "Expo.nativeUpdatesEvent"
-    private const val UPDATES_STATE_CHANGE_EVENT_NAME = "Expo.nativeUpdatesStateChangeEvent"
+    const val UPDATES_EVENT_NAME = "Expo.nativeUpdatesEvent"
+    const val UPDATES_STATE_CHANGE_EVENT_NAME = "Expo.nativeUpdatesStateChangeEvent"
   }
 }

package/android/src/main/java/expo/modules/updates/IUpdatesController.kt

@@ -78,6 +78,15 @@ interface IUpdatesController {
      * updates will be disabled and a warning will be logged.
      */
     val isMissingRuntimeVersion: Boolean,
+
+    /**
+     * Whether the JS API methods should allow calling the native module methods and thus the methods
+     * on the controller in development. For non-expo development we want to throw
+     * at the JS layer since there isn't a controller set up. But for development within Expo Go
+     * or a Dev Client, which have their own controller/JS API implementations, we want the JS API
+     * calls to go through.
+     */
+    val shouldDeferToNativeForAPIMethodAvailabilityInDevelopment: Boolean
   )
   fun getConstantsForModule(): UpdatesModuleConstants
 

package/android/src/main/java/expo/modules/updates/UpdatesConfiguration.kt

@@ -40,7 +40,7 @@ data class UpdatesConfiguration(
   val codeSigningMetadata: Map<String, String>?,
   val codeSigningIncludeManifestResponseCertificateChain: Boolean,
   private val codeSigningAllowUnsignedManifests: Boolean,
-  val enableExpoUpdatesProtocolV0CompatibilityMode: Boolean, // used only in Expo Go to prevent loading rollbacks and other directives, which don't make much sense in the context of Expo Go
+  val enableExpoUpdatesProtocolV0CompatibilityMode: Boolean // used only in Expo Go to prevent loading rollbacks and other directives, which don't make much sense in the context of Expo Go
 ) {
   enum class CheckAutomaticallyConfiguration {
     NEVER {
@@ -55,6 +55,7 @@ data class UpdatesConfiguration(
     ALWAYS {
       override fun toJSString() = "ALWAYS"
     };
+
     open fun toJSString(): String {
       throw InvalidArgumentException("Unsupported CheckAutomaticallyConfiguration value")
     }
@@ -64,7 +65,7 @@ data class UpdatesConfiguration(
     expectsSignedManifest = overrideMap?.readValueCheckingType(UPDATES_CONFIGURATION_EXPECTS_EXPO_SIGNED_MANIFEST) ?: false,
     scopeKey = maybeGetDefaultScopeKey(
       overrideMap?.readValueCheckingType<String>(UPDATES_CONFIGURATION_SCOPE_KEY_KEY) ?: context?.getMetadataValue("expo.modules.updates.EXPO_SCOPE_KEY"),
-      updateUrl = getUpdatesUrl(context, overrideMap)!!,
+      updateUrl = getUpdatesUrl(context, overrideMap)!!
     ),
     updateUrl = getUpdatesUrl(context, overrideMap)!!,
     sdkVersion = getSDKVersion(context, overrideMap),
@@ -102,7 +103,7 @@ data class UpdatesConfiguration(
     codeSigningAllowUnsignedManifests = overrideMap?.readValueCheckingType<Boolean>(
       UPDATES_CONFIGURATION_CODE_SIGNING_ALLOW_UNSIGNED_MANIFESTS
     ) ?: context?.getMetadataValue("expo.modules.updates.CODE_SIGNING_ALLOW_UNSIGNED_MANIFESTS") ?: false,
-    enableExpoUpdatesProtocolV0CompatibilityMode = overrideMap?.readValueCheckingType<Boolean>(UPDATES_CONFIGURATION_ENABLE_EXPO_UPDATES_PROTOCOL_V0_COMPATIBILITY_MODE) ?: context?.getMetadataValue("expo.modules.updates.ENABLE_EXPO_UPDATES_PROTOCOL_V0_COMPATIBILITY_MODE") ?: false,
+    enableExpoUpdatesProtocolV0CompatibilityMode = overrideMap?.readValueCheckingType<Boolean>(UPDATES_CONFIGURATION_ENABLE_EXPO_UPDATES_PROTOCOL_V0_COMPATIBILITY_MODE) ?: context?.getMetadataValue("expo.modules.updates.ENABLE_EXPO_UPDATES_PROTOCOL_V0_COMPATIBILITY_MODE") ?: false
   )
 
   val codeSigningConfiguration: CodeSigningConfiguration? by lazy {

package/android/src/main/java/expo/modules/updates/UpdatesController.kt

@@ -6,6 +6,7 @@ import com.facebook.react.ReactNativeHost
 import expo.modules.updates.loader.LoaderTask
 import expo.modules.updates.logging.UpdatesErrorCode
 import expo.modules.updates.logging.UpdatesLogger
+import expo.modules.updatesinterface.UpdatesInterfaceCallbacks
 
 /**
  * Main entry point to expo-updates. Singleton that keeps track of updates state, holds references
@@ -22,6 +23,7 @@ import expo.modules.updates.logging.UpdatesLogger
 class UpdatesController {
   companion object {
     private var singletonInstance: IUpdatesController? = null
+
     @JvmStatic val instance: IUpdatesController
       get() {
         return checkNotNull(singletonInstance) { "UpdatesController.instance was called before the module was initialized" }
@@ -70,7 +72,7 @@ class UpdatesController {
       }
     }
 
-    @JvmStatic fun initializeAsDevLauncherWithoutStarting(context: Context): UpdatesDevLauncherController {
+    @JvmStatic fun initializeAsDevLauncherWithoutStarting(context: Context, callbacks: UpdatesInterfaceCallbacks): UpdatesDevLauncherController {
       check(singletonInstance == null) { "UpdatesController must not be initialized prior to calling initializeAsDevLauncherWithoutStarting" }
 
       var updatesDirectoryException: Exception? = null
@@ -91,7 +93,8 @@ class UpdatesController {
         initialUpdatesConfiguration,
         updatesDirectory,
         updatesDirectoryException,
-        UpdatesConfiguration.isMissingRuntimeVersion(context, null)
+        UpdatesConfiguration.isMissingRuntimeVersion(context, null),
+        callbacks
       )
       singletonInstance = instance
       return instance

package/android/src/main/java/expo/modules/updates/UpdatesDevLauncherController.kt

@@ -23,6 +23,7 @@ import expo.modules.updates.selectionpolicy.ReaperSelectionPolicyDevelopmentClie
 import expo.modules.updates.selectionpolicy.SelectionPolicy
 import expo.modules.updates.selectionpolicy.SelectionPolicyFactory
 import expo.modules.updates.statemachine.UpdatesStateContext
+import expo.modules.updatesinterface.UpdatesInterfaceCallbacks
 import expo.modules.updatesinterface.UpdatesInterface
 import org.json.JSONObject
 import java.io.File
@@ -42,7 +43,8 @@ class UpdatesDevLauncherController(
   initialUpdatesConfiguration: UpdatesConfiguration?,
   override val updatesDirectory: File?,
   private val updatesDirectoryException: Exception?,
-  private val isMissingRuntimeVersion: Boolean
+  private val isMissingRuntimeVersion: Boolean,
+  private val callbacks: UpdatesInterfaceCallbacks
 ) : IUpdatesController, UpdatesInterface {
   override val isEmergencyLaunch = updatesDirectoryException != null
 
@@ -224,7 +226,8 @@ class UpdatesDevLauncherController(
       selectionPolicy
     )
     launcher.launch(
-      databaseHolder.database, context,
+      databaseHolder.database,
+      context,
       object : Launcher.LauncherCallback {
         override fun onFailure(e: Exception) {
           databaseHolder.releaseDatabase()
@@ -287,13 +290,15 @@ class UpdatesDevLauncherController(
       requestHeaders = updatesConfiguration?.requestHeaders ?: mapOf(),
       localAssetFiles = localAssetFiles,
       isMissingRuntimeVersion = isMissingRuntimeVersion,
+      shouldDeferToNativeForAPIMethodAvailabilityInDevelopment = true
     )
   }
 
   override fun relaunchReactApplicationForModule(
     callback: IUpdatesController.ModuleCallback<Unit>
   ) {
-    callback.onFailure(NotAvailableInDevClientException("Cannot reload update in a development client. A non-development build should be used to test this functionality."))
+    callbacks.onRequestRelaunch()
+    callback.onSuccess(Unit)
   }
 
   override fun getNativeStateMachineContext(callback: IUpdatesController.ModuleCallback<UpdatesStateContext>) {

package/android/src/main/java/expo/modules/updates/UpdatesModule.kt

@@ -1,3 +1,5 @@
+@file:Suppress("UnusedImport") // this needs to stay for versioning to work
+
 package expo.modules.updates
 
 import android.content.Context
@@ -17,11 +19,6 @@ import expo.modules.updates.statemachine.UpdatesStateContext
 import java.util.Date
 
 // these unused imports must stay because of versioning
-/* ktlint-disable no-unused-imports */
-import expo.modules.updates.IUpdatesController
-import expo.modules.updates.UpdatesConfiguration
-import expo.modules.updates.UpdatesController
-/* ktlint-enable no-unused-imports */
 
 /**
  * Exported module which provides to the JS runtime information about the currently running update
@@ -56,7 +53,7 @@ class UpdatesModule : Module() {
         constants["runtimeVersion"] = constantsForModule.runtimeVersion ?: ""
         constants["checkAutomatically"] = constantsForModule.checkOnLaunch.toJSString()
         constants["channel"] = constantsForModule.requestHeaders["expo-channel-name"] ?: ""
-        constants["nativeDebug"] = BuildConfig.EX_UPDATES_NATIVE_DEBUG
+        constants["shouldDeferToNativeForAPIMethodAvailabilityInDevelopment"] = constantsForModule.shouldDeferToNativeForAPIMethodAvailabilityInDevelopment || BuildConfig.EX_UPDATES_NATIVE_DEBUG
 
         if (launchedUpdate != null) {
           constants["updateId"] = launchedUpdate.id.toString()
@@ -222,7 +219,8 @@ class UpdatesModule : Module() {
     AsyncFunction("setExtraParamAsync") { key: String, value: String?, promise: Promise ->
       logger.debug("Called setExtraParamAsync with key = $key, value = $value")
       UpdatesController.instance.setExtraParam(
-        key, value,
+        key,
+        value,
         object : IUpdatesController.ModuleCallback<Unit> {
           override fun onSuccess(result: Unit) {
             promise.resolve(null)

package/android/src/main/java/expo/modules/updates/UpdatesPackage.kt

@@ -1,3 +1,5 @@
+@file:Suppress("UnusedImport") // this needs to stay for versioning to work
+
 package expo.modules.updates
 
 import android.content.Context
@@ -18,9 +20,6 @@ import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 
 // these unused imports must stay because of versioning
-/* ktlint-disable no-unused-imports */
-import expo.modules.updates.UpdatesController
-/* ktlint-enable no-unused-imports */
 
 /**
  * Defines the internal and exported modules for expo-updates, as well as the auto-setup behavior in

package/android/src/main/java/expo/modules/updates/UpdatesUtils.kt

@@ -155,7 +155,9 @@ object UpdatesUtils {
     return if (asset.key == null) {
       // create a filename that's unlikely to collide with any other asset
       "asset-" + Date().time + "-" + Random().nextInt() + fileExtension
-    } else asset.key + fileExtension
+    } else {
+      asset.key + fileExtension
+    }
   }
 
   fun sendEventToReactNative(

package/android/src/main/java/expo/modules/updates/codesigning/CertificateChain.kt

@@ -64,7 +64,9 @@ class CertificateChain(private val certificateStrings: List<String>) {
       }?.let {
         if (it is DEROctetString) {
           it.octets.decodeToString()
-        } else null
+        } else {
+          null
+        }
       }?.let {
         val components = it.split(',').map { component -> component.trim() }
         if (components.size != 2) {

package/android/src/main/java/expo/modules/updates/codesigning/CodeSigningConfiguration.kt

@@ -56,7 +56,7 @@ class CodeSigningConfiguration(
     return validateSignatureInternal(
       SignatureHeaderInfo.parseSignatureHeader(signature),
       bodyBytes,
-      manifestResponseCertificateChain,
+      manifestResponseCertificateChain
     )
   }
 

package/android/src/main/java/expo/modules/updates/codesigning/SignatureHeaderInfo.kt

@@ -18,13 +18,19 @@ data class SignatureHeaderInfo(val signature: String, val keyId: String, val alg
 
       val signature = if (sigFieldValue is StringItem) {
         sigFieldValue.get()
-      } else throw Exception("Structured field $CODE_SIGNING_SIGNATURE_STRUCTURED_FIELD_KEY_SIGNATURE not found in expo-signature header")
+      } else {
+        throw Exception("Structured field $CODE_SIGNING_SIGNATURE_STRUCTURED_FIELD_KEY_SIGNATURE not found in expo-signature header")
+      }
       val keyId = if (keyIdFieldValue is StringItem) {
         keyIdFieldValue.get()
-      } else CODE_SIGNING_METADATA_DEFAULT_KEY_ID
+      } else {
+        CODE_SIGNING_METADATA_DEFAULT_KEY_ID
+      }
       val alg = if (algFieldValue is StringItem) {
         algFieldValue.get()
-      } else null
+      } else {
+        null
+      }
 
       return SignatureHeaderInfo(signature, keyId, CodeSigningAlgorithm.parseFromString(alg))
     }

package/android/src/main/java/expo/modules/updates/db/BuildData.kt

@@ -33,7 +33,7 @@ object BuildData {
 
   fun ensureBuildDataIsConsistent(
     updatesConfiguration: UpdatesConfiguration,
-    database: UpdatesDatabase,
+    database: UpdatesDatabase
   ) {
     val scopeKey = updatesConfiguration.scopeKey
     val buildJSON = getBuildDataFromDatabase(database, scopeKey)
@@ -78,7 +78,7 @@ object BuildData {
 
   fun setBuildDataInDatabase(
     database: UpdatesDatabase,
-    updatesConfiguration: UpdatesConfiguration,
+    updatesConfiguration: UpdatesConfiguration
   ) {
     val buildDataJSON = getBuildDataFromConfig(updatesConfiguration)
     database.jsonDataDao()?.setJSONStringForKey(

package/android/src/main/java/expo/modules/updates/db/dao/AssetDao.kt

@@ -87,7 +87,9 @@ abstract class AssetDao {
     val assets = _loadAssetWithKey(key)
     return if (assets.isNotEmpty()) {
       assets[0]
-    } else null
+    } else {
+      null
+    }
   }
 
   fun mergeAndUpdateAsset(existingEntity: AssetEntity, newEntity: AssetEntity) {

package/android/src/main/java/expo/modules/updates/db/dao/JSONDataDao.kt

@@ -33,7 +33,9 @@ abstract class JSONDataDao {
     val rows = _loadJSONDataForKey(key, scopeKey)
     return if (rows.isEmpty()) {
       null
-    } else rows[0].value
+    } else {
+      rows[0].value
+    }
   }
 
   @Transaction

package/android/src/main/java/expo/modules/updates/db/entity/UpdateEntity.kt

@@ -37,7 +37,7 @@ class UpdateEntity(
   @field:ColumnInfo(name = "commit_time") var commitTime: Date,
   @field:ColumnInfo(name = "runtime_version") var runtimeVersion: String,
   @field:ColumnInfo(name = "scope_key") var scopeKey: String,
-  @field:ColumnInfo(name = "manifest") var manifest: JSONObject,
+  @field:ColumnInfo(name = "manifest") var manifest: JSONObject
 ) {
   @ColumnInfo(name = "launch_asset_id")
   var launchAssetId: Long? = null

package/android/src/main/java/expo/modules/updates/db/enums/UpdateStatus.kt

@@ -9,11 +9,13 @@ enum class UpdateStatus {
    * The update has been fully downloaded and is ready to launch.
    */
   READY,
+
   /**
    * The update manifest has been download from the server but not all assets have finished
    * downloading successfully.
    */
   PENDING,
+
   /**
    * The update has been partially loaded (copied) from its location embedded in the app bundle, but
    * not all assets have been copied successfully. The update may be able to be launched directly
@@ -21,6 +23,7 @@ enum class UpdateStatus {
    * installed.
    */
   EMBEDDED,
+
   /**
    * The update manifest has been downloaded and indicates that the update is being served from a
    * developer tool. It can be launched by a host application that can run a development bundle.

package/android/src/main/java/expo/modules/updates/loader/EmbeddedLoader.kt

@@ -30,7 +30,11 @@ class EmbeddedLoader internal constructor(
   updatesDirectory: File,
   private val loaderFiles: LoaderFiles
 ) : Loader(
-  context, configuration, database, updatesDirectory, loaderFiles
+  context,
+  configuration,
+  database,
+  updatesDirectory,
+  loaderFiles
 ) {
 
   constructor(

package/android/src/main/java/expo/modules/updates/loader/FileDownloader.kt

@@ -105,7 +105,7 @@ open class FileDownloader(context: Context, private val client: OkHttpClient) {
       protocolVersionRaw = responseHeaders["expo-protocol-version"],
       manifestFiltersRaw = responseHeaders["expo-manifest-filters"],
       serverDefinedHeadersRaw = responseHeaders["expo-server-defined-headers"],
-      manifestSignature = responseHeaders["expo-manifest-signature"],
+      manifestSignature = responseHeaders["expo-manifest-signature"]
     )
     val responseBody = response.body
 
@@ -378,7 +378,7 @@ open class FileDownloader(context: Context, private val client: OkHttpClient) {
           val signatureValidationResult = codeSigningConfiguration.validateSignature(
             directiveResponsePartInfo.responsePartHeaderData.signature,
             body.toByteArray(),
-            certificateChainFromManifestResponse,
+            certificateChainFromManifestResponse
           )
           if (signatureValidationResult.validationResult == ValidationResult.INVALID) {
             throw IOException("Directive download was successful, but signature was incorrect")
@@ -658,7 +658,7 @@ open class FileDownloader(context: Context, private val client: OkHttpClient) {
           val signatureValidationResult = codeSigningConfiguration.validateSignature(
             responsePartHeaderData.signature,
             bodyString.toByteArray(),
-            certificateChainFromManifestResponse,
+            certificateChainFromManifestResponse
           )
           if (signatureValidationResult.validationResult == ValidationResult.INVALID) {
             throw IOException("Manifest download was successful, but signature was incorrect")
@@ -746,7 +746,7 @@ open class FileDownloader(context: Context, private val client: OkHttpClient) {
     internal fun createRequestForAsset(
       assetEntity: AssetEntity,
       configuration: UpdatesConfiguration,
-      context: Context,
+      context: Context
     ): Request {
       return Request.Builder()
         .url(assetEntity.url!!.toString())

package/android/src/main/java/expo/modules/updates/loader/LegacySignatureUtils.kt

@@ -95,7 +95,9 @@ private fun verifyPublicRSASignature(
   val signature = Signature.getInstance("SHA256withRSA")
   val decodedPublicKey = Base64.decode(publicKeyNoComments, Base64.DEFAULT)
   val publicKeySpec = X509EncodedKeySpec(decodedPublicKey)
-  @SuppressLint("InlinedApi") val keyFactory = KeyFactory.getInstance(KeyProperties.KEY_ALGORITHM_RSA)
+
+  @SuppressLint("InlinedApi")
+  val keyFactory = KeyFactory.getInstance(KeyProperties.KEY_ALGORITHM_RSA)
   val key = keyFactory.generatePublic(publicKeySpec)
   signature.initVerify(key)
   signature.update(plainText.toByteArray())

package/android/src/main/java/expo/modules/updates/loader/Loader.kt

@@ -97,7 +97,9 @@ abstract class Loader protected constructor(
     this.callback = callback
 
     loadRemoteUpdate(
-      context, database, configuration,
+      context,
+      database,
+      configuration,
       object : RemoteUpdateDownloadCallback {
         override fun onFailure(message: String, e: Exception) {
           finishWithError(message, e)
@@ -215,7 +217,9 @@ abstract class Loader protected constructor(
   }
 
   private enum class AssetLoadResult {
-    FINISHED, ALREADY_EXISTS, ERRORED
+    FINISHED,
+    ALREADY_EXISTS,
+    ERRORED
   }
 
   private fun downloadAllAssets(assetList: List<AssetEntity>) {
@@ -234,9 +238,9 @@ abstract class Loader protected constructor(
       // if we already have a local copy of this asset, don't try to download it again!
       if (assetEntity.relativePath != null && loaderFiles.fileExists(
           File(
-              updatesDirectory,
-              assetEntity.relativePath
-            )
+            updatesDirectory,
+            assetEntity.relativePath
+          )
         )
       ) {
         handleAssetDownloadCompleted(assetEntity, AssetLoadResult.ALREADY_EXISTS)
@@ -244,12 +248,19 @@ abstract class Loader protected constructor(
       }
 
       loadAsset(
-        context, assetEntity, updatesDirectory, configuration,
+        context,
+        assetEntity,
+        updatesDirectory,
+        configuration,
         object : AssetDownloadCallback {
           override fun onFailure(e: Exception, assetEntity: AssetEntity) {
-            val identifier = if (assetEntity.hash != null) "hash " + UpdatesUtils.bytesToHex(
-              assetEntity.hash!!
-            ) else "key " + assetEntity.key
+            val identifier = if (assetEntity.hash != null) {
+              "hash " + UpdatesUtils.bytesToHex(
+                assetEntity.hash!!
+              )
+            } else {
+              "key " + assetEntity.key
+            }
             Log.e(TAG, "Failed to download asset with $identifier", e)
             handleAssetDownloadCompleted(assetEntity, AssetLoadResult.ERRORED)
           }