expo-splash-screen 0.13.4 → 0.13.5

package/CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### 💡 Others
 
+## 0.13.5 — 2021-11-04
+
+### 🐛 Bug fixes
+
+- Fix `Cannot remove an observer <EXSplashScreenService> for the key path "rootViewController"` exception if applcation keyWindow changed. ([#14982](https://github.com/expo/expo/pull/14982) by [@kudo](https://github.com/kudo))
+
 ## 0.13.4 — 2021-10-22
 
 _This version does not introduce any user-facing changes._

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven'
 
 group = 'host.exp.exponent'
-version = '0.13.4'
+version = '0.13.5'
 
 buildscript {
   // Simple helper that allows the root project to override versions declared by this library.
@@ -57,7 +57,7 @@ android {
     minSdkVersion safeExtGet('minSdkVersion', 21)
     targetSdkVersion safeExtGet('targetSdkVersion', 30)
     versionCode 17
-    versionName '0.13.4'
+    versionName '0.13.5'
   }
   lintOptions {
     abortOnError false

package/ios/EXSplashScreen/EXSplashScreenService.m

@@ -167,7 +167,8 @@ EX_REGISTER_SINGLETON_MODULE(SplashScreen);
 {
   NSAssert([NSThread isMainThread], @"Method must be called on main thread");
   if (self.observingRootViewController != nil) {
-    [UIApplication.sharedApplication.keyWindow removeObserver:self forKeyPath:kRootViewController context:nil];
+    UIWindow *window = self.observingRootViewController.view.window;
+    [window removeObserver:self forKeyPath:kRootViewController context:nil];
     [self.observingRootViewController removeObserver:self forKeyPath:kView context:nil];
     self.observingRootViewController = nil;
   }

package/ios/EXSplashScreen.xcframework/Info.plist

@@ -6,30 +6,30 @@
 	<array>
 		<dict>
 			<key>LibraryIdentifier</key>
-			<string>ios-arm64</string>
+			<string>ios-arm64_x86_64-simulator</string>
 			<key>LibraryPath</key>
 			<string>EXSplashScreen.framework</string>
 			<key>SupportedArchitectures</key>
 			<array>
 				<string>arm64</string>
+				<string>x86_64</string>
 			</array>
 			<key>SupportedPlatform</key>
 			<string>ios</string>
+			<key>SupportedPlatformVariant</key>
+			<string>simulator</string>
 		</dict>
 		<dict>
 			<key>LibraryIdentifier</key>
-			<string>ios-arm64_x86_64-simulator</string>
+			<string>ios-arm64</string>
 			<key>LibraryPath</key>
 			<string>EXSplashScreen.framework</string>
 			<key>SupportedArchitectures</key>
 			<array>
 				<string>arm64</string>
-				<string>x86_64</string>
 			</array>
 			<key>SupportedPlatform</key>
 			<string>ios</string>
-			<key>SupportedPlatformVariant</key>
-			<string>simulator</string>
 		</dict>
 	</array>
 	<key>CFBundlePackageType</key>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-splash-screen",
-  "version": "0.13.4",
+  "version": "0.13.5",
   "description": "Provides a module to allow keeping the native Splash Screen visible until you choose to hide it.",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -39,10 +39,10 @@
   "dependencies": {
     "@expo/configure-splash-screen": "^0.6.0",
     "@expo/prebuild-config": "^3.0.6",
-    "expo-modules-core": "~0.4.4"
+    "expo-modules-core": "~0.4.7"
   },
   "devDependencies": {
     "expo-module-scripts": "^2.0.0"
   },
-  "gitHead": "33b6a1b7ac70e664ccbe5965e707c0df6d704549"
+  "gitHead": "1bc71c99227e4b6112e2de0961deea88341b9ba0"
 }

package/plugin/build/withSplashScreen.js

@@ -7,8 +7,8 @@ const pkg = require('expo-splash-screen/package.json');
 const withSplashScreen = (config) => {
     // For simplicity, we'll version the unversioned code in expo-splash-screen.
     // This adds more JS to the package overall, but the trade-off is less copying between expo-cli/expo.
-    config = withAndroidSplashScreen_1.withAndroidSplashScreen(config);
-    config = withIosSplashScreen_1.withIosSplashScreen(config);
+    config = (0, withAndroidSplashScreen_1.withAndroidSplashScreen)(config);
+    config = (0, withIosSplashScreen_1.withIosSplashScreen)(config);
     return config;
 };
-exports.default = config_plugins_1.createRunOncePlugin(withSplashScreen, pkg.name, pkg.version);
+exports.default = (0, config_plugins_1.createRunOncePlugin)(withSplashScreen, pkg.name, pkg.version);

package/.expo/tsconfig.jest.json

@@ -1,13 +0,0 @@
-{
-  "extends": "/Users/brentvatne/code/expo/packages/expo-splash-screen/tsconfig.json",
-  "compilerOptions": {
-    "module": "esnext",
-    "typeRoots": [
-      "./node_modules/@types",
-      "../node_modules/@types",
-      "../../node_modules/@types",
-      "../../../node_modules/@types",
-      "/Users/brentvatne/code/expo/packages/expo-module-scripts/ts-declarations"
-    ]
-  }
-}