expo-screen-orientation 6.0.4 → 6.0.5

package/CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### 💡 Others
 
+## 6.0.5 — 2023-07-25
+
+### 🐛 Bug fixes
+
+- Fix addOrientationChangeListener not working on iPadOS. ([#23656](https://github.com/expo/expo/pull/23656) by [@behenate](https://github.com/behenate))
+
 ## 6.0.4 — 2023-07-23
 
 ### 🐛 Bug fixes

package/android/build.gradle

@@ -3,7 +3,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'maven-publish'
 
 group = 'host.exp.exponent'
-version = '6.0.4'
+version = '6.0.5'
 
 buildscript {
   def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
@@ -67,7 +67,7 @@ android {
     minSdkVersion safeExtGet("minSdkVersion", 21)
     targetSdkVersion safeExtGet("targetSdkVersion", 33)
     versionCode 7
-    versionName '6.0.4'
+    versionName '6.0.5'
   }
   lintOptions {
     abortOnError false

package/ios/ScreenOrientationRegistry.swift

@@ -17,6 +17,7 @@ public class ScreenOrientationRegistry: NSObject, UIApplicationDelegate {
   public var currentScreenOrientation: UIInterfaceOrientation
   var orientationControllers: [ScreenOrientationController] = []
   var controllerInterfaceMasks: [ObjectIdentifier: UIInterfaceOrientationMask] = [:]
+  @objc
   public weak var currentTraitCollection: UITraitCollection?
   var lastOrientationMask: UIInterfaceOrientationMask
   var rootViewController: UIViewController? {
@@ -45,13 +46,6 @@ public class ScreenOrientationRegistry: NSObject, UIApplicationDelegate {
 
     super.init()
 
-    NotificationCenter.default.addObserver(
-      self,
-      selector: #selector(self.handleDeviceOrientationChange(notification:)),
-      name: UIDevice.orientationDidChangeNotification,
-      object: UIDevice.current
-    )
-
     // This is most likely already executed on the main thread, but we need to be sure
     RCTExecuteOnMainQueue {
       UIDevice.current.beginGeneratingDeviceOrientationNotifications()
@@ -143,56 +137,19 @@ public class ScreenOrientationRegistry: NSObject, UIApplicationDelegate {
 
   // MARK: - Events
 
-  /**
-   Called when the OS sends an OrientationDidChange notification.
-   */
-  @objc
-  func handleDeviceOrientationChange(notification: Notification) {
-    let newScreenOrientation = UIDevice.current.orientation.toInterfaceOrientation()
-
-    interfaceOrientationDidChange(newScreenOrientation)
-  }
-
-  /**
-   Called when the device is physically rotated. Checks if screen orientation should be changed after user rotated the device.
-   */
-  func interfaceOrientationDidChange(_ newScreenOrientation: UIInterfaceOrientation) {
-    if currentScreenOrientation == newScreenOrientation || newScreenOrientation == .unknown {
-      return
-    }
-
-    if currentOrientationMask.contains(newScreenOrientation) {
-      // when changing orientation without changing dimensions traitCollectionDidChange isn't triggered so the event has to be called manually
-      if (newScreenOrientation.isPortrait && currentScreenOrientation.isPortrait)
-        || (newScreenOrientation.isLandscape && currentScreenOrientation.isLandscape) {
-        screenOrientationDidChange(newScreenOrientation)
-        return
-      }
-
-      // on iPads, traitCollectionDidChange isn't triggered at all, so we have to call screenOrientationDidChange manually
-      if isPad()
-        && (newScreenOrientation.isPortrait && currentScreenOrientation.isLandscape
-        || newScreenOrientation.isLandscape && currentScreenOrientation.isPortrait) {
-        screenOrientationDidChange(newScreenOrientation)
-      }
-    }
-  }
-
   /**
    Called by ScreenOrientationViewController when the dimensions of the view change.
    Also used for Expo Go in EXAppViewController.
    */
   @objc
-  public func traitCollectionDidChange(to traitCollection: UITraitCollection) {
-    currentTraitCollection = traitCollection
-
+  public func viewDidTransition(toOrientation orientation: UIInterfaceOrientation) {
     let currentDeviceOrientation = UIDevice.current.orientation.toInterfaceOrientation()
     let currentOrientationMask = self.rootViewController?.supportedInterfaceOrientations ?? []
 
     var newScreenOrientation = UIInterfaceOrientation.unknown
 
     // We need to deduce what is the new screen orientaiton based on currentOrientationMask and new dimensions of the view
-    if traitCollection.isPortrait() {
+    if orientation.isPortrait {
       // From trait collection, we know that screen is in portrait or upside down orientation.
       let portraitMask = currentOrientationMask.intersection([.portrait, .portraitUpsideDown])
 
@@ -209,7 +166,7 @@ public class ScreenOrientationRegistry: NSObject, UIApplicationDelegate {
         // from device orientation.
         newScreenOrientation = currentDeviceOrientation
       }
-    } else if traitCollection.isLandscape() {
+    } else if orientation.isLandscape {
       // From trait collection, we know that screen is in landscape left or right orientation.
       let landscapeMask = currentOrientationMask.intersection(.landscape)
 
@@ -233,6 +190,11 @@ public class ScreenOrientationRegistry: NSObject, UIApplicationDelegate {
     screenOrientationDidChange(newScreenOrientation)
   }
 
+  @objc
+  public func traitCollectionDidChange(to traitCollection: UITraitCollection) {
+    currentTraitCollection = traitCollection
+  }
+
   /**
    Called at the end of the screen orientation change. Notifies the controllers about the orientation change.
    */

package/ios/ScreenOrientationViewController.swift

@@ -7,10 +7,20 @@ let ipadSupportedOrientationsKey = "UISupportedInterfaceOrientations~ipad"
 class ScreenOrientationViewController: UIViewController {
   let screenOrientationRegistry = ScreenOrientationRegistry.shared
   private var defaultOrientationMask: UIInterfaceOrientationMask
+  private var previousInterfaceOrientation: UIInterfaceOrientation = .unknown
+  private var windowInterfaceOrientation: UIInterfaceOrientation? {
+    return UIApplication.shared.windows.first?.windowScene?.interfaceOrientation
+  }
 
   init(defaultOrientationMask: UIInterfaceOrientationMask = doesDeviceHaveNotch ? .allButUpsideDown : .all) {
     self.defaultOrientationMask = defaultOrientationMask
     super.init(nibName: nil, bundle: nil)
+
+    // For iPads traitCollectionDidChange will not be called (it's always in the same size class). It is necessary
+    // to init it in here, so it's possible to return it in the didUpdateDimensionsEvent of the module
+    if self.screenOrientationRegistry.currentTraitCollection == nil {
+      self.screenOrientationRegistry.traitCollectionDidChange(to: self.traitCollection)
+    }
   }
 
   convenience init(defaultScreenOrientationFromPlist: Void) {
@@ -57,11 +67,23 @@ class ScreenOrientationViewController: UIViewController {
 
   override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
     super.traitCollectionDidChange(previousTraitCollection)
+    screenOrientationRegistry.traitCollectionDidChange(to: traitCollection)
+  }
 
-    if traitCollection.verticalSizeClass != previousTraitCollection?.verticalSizeClass ||
-      traitCollection.horizontalSizeClass != previousTraitCollection?.horizontalSizeClass {
-      screenOrientationRegistry.traitCollectionDidChange(to: traitCollection)
-    }
+  override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
+    super.viewWillTransition(to: size, with: coordinator)
+
+    // Update after the transition ends, this ensures that the trait collection passed to didUpdateDimensionsEvent is already updated
+    coordinator.animate(alongsideTransition: { [weak self] _ in
+      guard let self = self, let windowInterfaceOrientation = self.windowInterfaceOrientation else {
+        return
+      }
+
+      if windowInterfaceOrientation != self.previousInterfaceOrientation {
+        self.screenOrientationRegistry.viewDidTransition(toOrientation: windowInterfaceOrientation)
+      }
+      self.previousInterfaceOrientation = windowInterfaceOrientation
+    })
   }
 
   private func shouldUseRNScreenOrientation() -> Bool {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-screen-orientation",
-  "version": "6.0.4",
+  "version": "6.0.5",
   "description": "Expo universal module for managing device's screen orientation",
   "main": "build/ScreenOrientation.js",
   "types": "build/ScreenOrientation.d.ts",
@@ -41,5 +41,5 @@
   "peerDependencies": {
     "expo": "*"
   },
-  "gitHead": "c0d646e9295094bca877513e500d3c9f2e990c42"
+  "gitHead": "8c85313e05e38401d06dcac1addd8a0659ae37a3"
 }