expo-pro-video-editor 0.2.12 → 0.2.13

package/ios/src/features/photo-library/PhotoLibraryVideoExporter.swift

@@ -92,9 +92,8 @@ enum PhotoLibraryVideoExporter {
       // "audio plays, video is black" symptom this exists to fix. Use the same
       // atan2-based angle tolerance already used elsewhere in this package (see
       // VideoTranscoder.calculateOutputSize / VideoSequenceBuilder) instead.
-      let rotationAngle = atan2(transform.b, transform.a)
-      let absRotationAngle = abs(rotationAngle)
-      let isPortrait = absRotationAngle > .pi / 4 && absRotationAngle < 3 * .pi / 4
+      let rotationAngle = abs(atan2(transform.b, transform.a))
+      let isPortrait = rotationAngle > .pi / 4 && rotationAngle < 3 * .pi / 4
       let naturalSize = videoTrack.naturalSize
       let renderSize = isPortrait
         ? CGSize(width: naturalSize.height, height: naturalSize.width)
@@ -107,27 +106,30 @@ enum PhotoLibraryVideoExporter {
       let instruction = AVMutableVideoCompositionInstruction()
       instruction.timeRange = CMTimeRange(start: .zero, duration: sourceAsset.duration)
 
-      // `preferredTransform` alone rotates the frame about (0, 0) — for a 90°/270°
-      // rotated portrait source that lands the rotated bounding box almost entirely
-      // outside `renderSize`, producing a video track that composites to black while
-      // audio (untouched by this composition) plays fine. A translation back into the
-      // render bounds is required after the rotation, same as the working pattern in
-      // CompositionBuilder.calculateTransform. There's no scaling here (1:1 passthrough
-      // export), so this only needs the centering translation, with X/Y swapped for the
-      // 90°/270° case since translatedBy operates in the already-rotated coordinate space.
-      var finalTransform = transform
-      let isRotated90Or270 = abs(absRotationAngle - .pi / 2) < 0.01
-      if isRotated90Or270 {
-        let translateX = (renderSize.width - naturalSize.height) / 2
-        let translateY = (renderSize.height - naturalSize.width) / 2
-        finalTransform = finalTransform.translatedBy(x: translateY, y: translateX)
-      } else if isPortrait {
-        // Non-axis-aligned "portrait" angle (stabilization/lens-correction skew) — fall
-        // back to centering in the unrotated natural-size space.
-        let translateX = (renderSize.width - naturalSize.width) / 2
-        let translateY = (renderSize.height - naturalSize.height) / 2
-        finalTransform = finalTransform.translatedBy(x: translateX, y: translateY)
-      }
+      // `preferredTransform` alone rotates the frame about (0, 0) — the rotated bounding
+      // box can land anywhere relative to `renderSize` depending on the *actual* tx/ty
+      // baked into this specific asset's transform (not just its rotation angle). This
+      // was observed on a real device-recorded portrait asset whose preferredTransform's
+      // tx was 1088 — neither the natural width nor height — which put the rotated frame
+      // at x ∈ [512, 1088], entirely outside a 576-wide renderSize. A translation derived
+      // from naturalSize/renderSize assuming a "clean" rotation (as an earlier version of
+      // this fix did) computes zero correction in that case and leaves the frame
+      // off-canvas, producing a video track that composites to black while audio
+      // (untouched by this composition) plays fine.
+      //
+      // The robust fix doesn't assume anything about tx/ty: apply the raw transform to
+      // the track's actual corners, find the resulting bounding box, and translate that
+      // box's origin back to (0, 0) — this corrects the frame into `renderSize` no matter
+      // what translation the source transform happens to carry.
+      let corners = [
+        CGPoint(x: 0, y: 0),
+        CGPoint(x: naturalSize.width, y: 0),
+        CGPoint(x: 0, y: naturalSize.height),
+        CGPoint(x: naturalSize.width, y: naturalSize.height),
+      ].map { $0.applying(transform) }
+      let minX = corners.map(\.x).min() ?? 0
+      let minY = corners.map(\.y).min() ?? 0
+      let finalTransform = transform.concatenating(CGAffineTransform(translationX: -minX, y: -minY))
 
       let layerInstruction = AVMutableVideoCompositionLayerInstruction(assetTrack: videoTrack)
       layerInstruction.setTransform(finalTransform, at: .zero)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-pro-video-editor",
-  "version": "0.2.12",
+  "version": "0.2.13",
   "description": "Native video composition (trim, filters, text/image overlays, audio mixing) for Expo/React Native, adapted from pro_video_editor's AVFoundation and Media3 Transformer implementation.",
   "main": "build/index.js",
   "types": "build/index.d.ts",