expo-pro-video-editor 0.2.10 → 0.2.12

package/ios/src/features/photo-library/PhotoLibraryVideoExporter.swift

@@ -78,7 +78,23 @@ enum PhotoLibraryVideoExporter {
     let sourceAsset = exportSession.asset
     if let videoTrack = sourceAsset.tracks(withMediaType: .video).first {
       let transform = videoTrack.preferredTransform
-      let isPortrait = abs(transform.b) == 1 && abs(transform.c) == 1
+      // An exact `abs(transform.b) == 1` equality check is too brittle for this: a
+      // photo-library asset's preferredTransform routinely carries a rotation that
+      // is only approximately ±90°/±270° (stabilization/lens-correction adjustments,
+      // mirrored front-camera captures, Photos-applied edits even under `.original`),
+      // so `transform.b`/`transform.c` land at e.g. 0.9998 rather than exactly 1.0.
+      // That made `isPortrait` false for real portrait footage while the layer
+      // instruction below still applied the (near-90°) rotation unconditionally —
+      // the rotated frame then landed almost entirely outside the declared
+      // (unrotated, landscape) renderSize, and AVAssetExportSession "succeeds" with
+      // a video track that composites to black. Audio isn't touched by this video
+      // composition, so it played fine while the picture stayed dark — exactly the
+      // "audio plays, video is black" symptom this exists to fix. Use the same
+      // atan2-based angle tolerance already used elsewhere in this package (see
+      // VideoTranscoder.calculateOutputSize / VideoSequenceBuilder) instead.
+      let rotationAngle = atan2(transform.b, transform.a)
+      let absRotationAngle = abs(rotationAngle)
+      let isPortrait = absRotationAngle > .pi / 4 && absRotationAngle < 3 * .pi / 4
       let naturalSize = videoTrack.naturalSize
       let renderSize = isPortrait
         ? CGSize(width: naturalSize.height, height: naturalSize.width)
@@ -91,8 +107,30 @@ enum PhotoLibraryVideoExporter {
       let instruction = AVMutableVideoCompositionInstruction()
       instruction.timeRange = CMTimeRange(start: .zero, duration: sourceAsset.duration)
 
+      // `preferredTransform` alone rotates the frame about (0, 0) — for a 90°/270°
+      // rotated portrait source that lands the rotated bounding box almost entirely
+      // outside `renderSize`, producing a video track that composites to black while
+      // audio (untouched by this composition) plays fine. A translation back into the
+      // render bounds is required after the rotation, same as the working pattern in
+      // CompositionBuilder.calculateTransform. There's no scaling here (1:1 passthrough
+      // export), so this only needs the centering translation, with X/Y swapped for the
+      // 90°/270° case since translatedBy operates in the already-rotated coordinate space.
+      var finalTransform = transform
+      let isRotated90Or270 = abs(absRotationAngle - .pi / 2) < 0.01
+      if isRotated90Or270 {
+        let translateX = (renderSize.width - naturalSize.height) / 2
+        let translateY = (renderSize.height - naturalSize.width) / 2
+        finalTransform = finalTransform.translatedBy(x: translateY, y: translateX)
+      } else if isPortrait {
+        // Non-axis-aligned "portrait" angle (stabilization/lens-correction skew) — fall
+        // back to centering in the unrotated natural-size space.
+        let translateX = (renderSize.width - naturalSize.width) / 2
+        let translateY = (renderSize.height - naturalSize.height) / 2
+        finalTransform = finalTransform.translatedBy(x: translateX, y: translateY)
+      }
+
       let layerInstruction = AVMutableVideoCompositionLayerInstruction(assetTrack: videoTrack)
-      layerInstruction.setTransform(transform, at: .zero)
+      layerInstruction.setTransform(finalTransform, at: .zero)
       instruction.layerInstructions = [layerInstruction]
       composition.instructions = [instruction]
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-pro-video-editor",
-  "version": "0.2.10",
+  "version": "0.2.12",
   "description": "Native video composition (trim, filters, text/image overlays, audio mixing) for Expo/React Native, adapted from pro_video_editor's AVFoundation and Media3 Transformer implementation.",
   "main": "build/index.js",
   "types": "build/index.d.ts",