expo-modules-macros 0.30.0 → 0.32.0

package/apple/Sources/ExpoModulesMacrosCore/Macros/ViewPropsMacro.swift

@@ -11,6 +11,17 @@ import SwiftSyntaxMacros
 ///   name through the view's event emitter. No JS function object is ever decoded into it.
 /// - every other property is a **value prop**, decoded from the raw props Fabric delivers.
 ///
+/// An event must be spelled as a function type. The macro reads only the syntax, so a closure type
+/// behind a typealias (`var onTap: TapHandler`) is a value prop.
+///
+/// Core creates the props with `Self()` and resets a prop that React removes (sends as `null`) to its
+/// value there, so every value prop is a `var` with a default. When the type declares its own
+/// `init()`, that initializer sets the defaults, and the compiler checks that it sets every stored
+/// property. Otherwise each stored value prop needs an initial value, or a type written as `T?` or
+/// `T!`, which defaults to `nil` (`Optional<T>` doesn't), and so does each `private` or `fileprivate`
+/// stored property, which isn't a prop. The author's `init()` must be non-failable, non-throwing and
+/// synchronous, so that core can call it.
+///
 /// The macro synthesizes the identity surface the batched reaction model reads:
 ///
 /// - `PropName`: a `String`-backed `CaseIterable` enum, one case per value prop, whose raw value is
@@ -21,6 +32,22 @@ import SwiftSyntaxMacros
 ///   allocation and no hashing.
 /// - `_eventNames`: the event props' names, verbatim, for core to register at view creation.
 /// - `typealias Diff = PropsDiff<Self>`, the nested spelling of core's one generic diff.
+/// - a public `init()`, which `AnyViewProps` requires, when Swift's own can't satisfy it: when an
+///   event prop has no initial value, when the type is `public` or `package` (Swift's `init()` is
+///   `internal`), also through a `public` or `package` extension that contains it, or when the type
+///   declares other initializers (Swift then synthesizes no `init()`). It gives each
+///   event without an initial value an empty closure (`{}`, `{ _ in }`, ...) and leaves the value
+///   props at their initial values. It is never generated when the type declares its own `init()`.
+///   Like any initializer in the struct body, the generated one removes the memberwise initializer.
+///
+/// An event's function type must return `Void`, because JavaScript can't return a value to it.
+///
+/// The extension that conforms the type to `AnyViewProps` adds:
+///
+/// - `allProps`: every bit set, the changed set on the first application.
+/// - `propSet(for:)`: one name's bit, for folding raw changed keys into the mask.
+/// - `_decode(_:from:in:)`: assigns one value prop from a JavaScript value. `null` and `undefined`
+///   reset it to its value in `Self()`, and any other value decodes through `JavaScriptDecodable`.
 ///
 /// Author-facing shape — no conformance to spell out:
 ///
@@ -46,19 +73,23 @@ public struct ViewPropsMacro: MemberMacro, ExtensionMacro {
     conformingTo protocols: [TypeSyntax],
     in context: some MacroExpansionContext
   ) throws -> [DeclSyntax] {
-    let props = try validatedViewProps(of: declaration)
+    let props = try validatedViewProps(of: declaration, in: context.lexicalContext)
 
     var members: [DeclSyntax] = []
     members.append(propNameEnum(valueProps: props.valueProps))
     members.append(propSetStruct(valueProps: props.valueProps))
     members.append(eventNamesConstant(eventProps: props.eventProps))
     members.append(diffTypealias())
+    if let initializer = defaultInitializer(props: props) {
+      members.append(initializer)
+    }
     return members
   }
 
-  /// Auto-conforms the type to `AnyViewProps`, supplying the two requirements that can only be written
-  /// per-props: `allProps` (every bit set, the changed set on the first application) and
-  /// `propSet(for:)` (one name's bit, for folding raw changed keys into the mask).
+  /// Auto-conforms the type to `AnyViewProps`, supplying the requirements that can only be written
+  /// per-props: `allProps` (every bit set, the changed set on the first application),
+  /// `propSet(for:)` (one name's bit, for folding raw changed keys into the mask) and `_decode`
+  /// (one value prop assigned from a JavaScript value).
   ///
   /// A conformance the author already spelled out in the inheritance clause is not repeated.
   public static func expansion(
@@ -75,7 +106,7 @@ public struct ViewPropsMacro: MemberMacro, ExtensionMacro {
     // expansion runs each role independently, so throwing here too would surface every diagnostic
     // twice. When the model doesn't validate, the member macro has already emitted the error and
     // there is nothing to extend.
-    guard let props = try? validatedViewProps(of: declaration) else {
+    guard let props = try? validatedViewProps(of: declaration, in: context.lexicalContext) else {
       return []
     }
     let alreadyConforms = inheritsProtocol(named: viewPropsProtocolName, in: declaration)
@@ -89,8 +120,7 @@ public struct ViewPropsMacro: MemberMacro, ExtensionMacro {
       ? "0"
       : "0b" + String(repeating: "1", count: props.valueProps.count)
 
-    // With no value prop there's nothing to switch over, and an empty `switch` over an uninhabited
-    // enum doesn't compile — return the empty set instead.
+    // With no value prop there's nothing to switch over, so return the empty set.
     let propSetBody: String
     if props.valueProps.isEmpty {
       propSetBody = "    return []"
@@ -101,6 +131,8 @@ public struct ViewPropsMacro: MemberMacro, ExtensionMacro {
       propSetBody = "    switch name {\n\(cases)\n    }"
     }
 
+    let decodeBody = decodeFunctionBody(valueProps: props.valueProps)
+
     let conformanceClause = alreadyConforms ? "" : ": \(viewPropsProtocolName)"
     let ext: DeclSyntax = """
       extension \(type.trimmed)\(raw: conformanceClause) {
@@ -112,6 +144,10 @@ public struct ViewPropsMacro: MemberMacro, ExtensionMacro {
         public static func propSet(for name: PropName) -> PropSet {
       \(raw: propSetBody)
         }
+
+        @JavaScriptActor
+        public mutating func _decode(_ name: PropName, from value: borrowing JavaScriptUnownedValue, in runtime: borrowing JavaScriptRuntime) throws {\(raw: decodeBody)
+        }
       }
       """
     guard let extDecl = ext.as(ExtensionDeclSyntax.self) else {
@@ -134,7 +170,9 @@ private let maxValueProps = 64
 /// The error for a leftover `@Field`, attached to the attribute itself and carrying a fix-it that
 /// deletes it. `@ViewProps` treats every stored property as a prop, so the attribute has no meaning
 /// here; left in place it would wrap the value in `Field<T>` and the props type would decode against
-/// the wrong type.
+/// the wrong type. A `@Field` with arguments, such as `@Field(.keyed("borderColor"))`, gets no
+/// fix-it: they can set the prop name, which removing the attribute would change silently, so the
+/// message tells the author to rename the property.
 private func fieldAttributeDiagnostic(
   for attribute: AttributeSyntax,
   on varDecl: VariableDeclSyntax
@@ -173,11 +211,14 @@ private func fieldAttributeDiagnostic(
       )
     ]
   )
+  let hasArguments = attribute.arguments?.as(LabeledExprListSyntax.self)?.isEmpty == false
   let message = ViewPropsDiagnosticMessage(
-    "@Field is no longer used — @ViewProps treats every stored property as a prop. Remove the @Field attribute",
+    hasArguments
+      ? "@Field is no longer used: @ViewProps treats every stored property as a prop, named after the property. Remove the @Field attribute, and rename the property if its arguments set another prop name"
+      : "@Field is no longer used: @ViewProps treats every stored property as a prop. Remove the @Field attribute",
     id: "viewprops-field-attribute"
   )
-  return Diagnostic(node: attribute, message: message, fixIts: [fixIt])
+  return Diagnostic(node: attribute, message: message, fixIts: hasArguments ? [] : [fixIt])
 }
 
 /// Replaces the leading trivia of one token.
@@ -244,6 +285,178 @@ private func innerFunctionType(of type: TypeSyntax) -> TypeSyntax? {
   return only.type
 }
 
+/// The error for a `let` declaring value props, attached to the `let` keyword and carrying a fix-it
+/// that changes it to `var`. `_decode` assigns each value prop when React sets or removes it, which a
+/// constant doesn't allow. The fix-it changes every binding of the declaration, so the message names
+/// each value prop it declares.
+private func letValuePropDiagnostic(for varDecl: VariableDeclSyntax, names: [String]) -> Diagnostic {
+  let specifier = varDecl.bindingSpecifier
+  let fixIt = FixIt(
+    message: ViewPropsFixItMessage("Replace 'let' with 'var'", id: "viewprops-let-to-var"),
+    changes: [
+      .replace(
+        oldNode: Syntax(specifier),
+        newNode: Syntax(specifier.with(\.tokenKind, .keyword(.var)))
+      )
+    ]
+  )
+  let quoted = names.map { "'\(withoutBackticks($0))'" }
+  let text =
+    quoted.count == 1
+    ? "View prop \(quoted[0]) can't be a 'let' constant, because it's assigned whenever React sets or removes the prop. Declare it with 'var'"
+    : "View props \(quoted.dropLast().joined(separator: ", ")) and \(quoted[quoted.count - 1]) can't be 'let' constants, because they're assigned whenever React sets or removes the props. Declare them with 'var'"
+  return Diagnostic(
+    node: specifier,
+    message: ViewPropsDiagnosticMessage(text, id: "viewprops-let-prop"),
+    fixIts: [fixIt]
+  )
+}
+
+/// The error for an event prop whose function type returns something other than `Void`, attached to
+/// the return type and carrying a fix-it that changes it to `Void`. Core dispatches the event to
+/// JavaScript, which can't return a value to the caller, and the generated `init()` couldn't give the
+/// event an empty closure.
+private func eventReturnTypeDiagnostic(for returnType: TypeSyntax, name: String) -> Diagnostic {
+  let message = ViewPropsDiagnosticMessage(
+    "Event prop '\(withoutBackticks(name))' must return Void, because an event is sent to JavaScript, which can't return a value. Change the return type '\(returnType.trimmedDescription)' to 'Void'",
+    id: "viewprops-event-return-type"
+  )
+  let void = TypeSyntax(IdentifierTypeSyntax(name: .identifier("Void")))
+    .with(\.leadingTrivia, returnType.leadingTrivia)
+    .with(\.trailingTrivia, returnType.trailingTrivia)
+  let fixIt = FixIt(
+    message: ViewPropsFixItMessage("Change the return type to 'Void'", id: "viewprops-event-return-void"),
+    changes: [.replace(oldNode: Syntax(returnType), newNode: Syntax(void))]
+  )
+  return Diagnostic(node: returnType, message: message, fixIts: [fixIt])
+}
+
+/// The error for a value prop with no default, attached to the property name. A value prop starts
+/// from its value in `Self()` and returns to it when React removes the prop, so it needs an initial
+/// value, or a type written as `T?`, whose default is `nil`. There is no fix-it, since the default is
+/// the author's choice, except for a type written as `Optional<T>`: rewriting it as `T?` keeps the
+/// type and only adds the implicit `nil`.
+private func missingDefaultDiagnostic(
+  for pattern: IdentifierPatternSyntax,
+  name: String,
+  type: TypeSyntax?
+) -> Diagnostic {
+  if let type, let sugared = optionalSugar(for: type) {
+    let fixIt = FixIt(
+      message: ViewPropsFixItMessage(
+        "Write the type as '\(sugared.trimmedDescription)'",
+        id: "viewprops-optional-sugar"
+      ),
+      changes: [.replace(oldNode: Syntax(type), newNode: Syntax(sugared))]
+    )
+    let message = ViewPropsDiagnosticMessage(
+      "View prop '\(withoutBackticks(name))' needs an initial value, which is its default when React removes the prop. A type written as '\(type.trimmedDescription)' gets no implicit nil, so write it as '\(sugared.trimmedDescription)'",
+      id: "viewprops-missing-default"
+    )
+    return Diagnostic(node: pattern, message: message, fixIts: [fixIt])
+  }
+  let message = ViewPropsDiagnosticMessage(
+    "View prop '\(withoutBackticks(name))' needs an initial value, which is its default when React removes the prop. Give it one, or make its type optional with '?', which defaults to nil",
+    id: "viewprops-missing-default"
+  )
+  return Diagnostic(node: pattern, message: message)
+}
+
+/// `T?` for a type written as `Optional<T>`, with the trivia of the original, or `nil` for any other
+/// type. A wrapped `any P`, `some P` or `P & Q` keeps parentheses, since `any P?` would make only `P`
+/// optional.
+private func optionalSugar(for type: TypeSyntax) -> TypeSyntax? {
+  guard let identifier = type.as(IdentifierTypeSyntax.self), identifier.name.text == "Optional",
+    let wrapped = optionalWrappedType(type)
+  else {
+    return nil
+  }
+  var wrappedType = wrapped.trimmed
+  if wrappedType.is(SomeOrAnyTypeSyntax.self) || wrappedType.is(CompositionTypeSyntax.self) {
+    wrappedType = TypeSyntax(TupleTypeSyntax(elements: [TupleTypeElementSyntax(type: wrappedType)]))
+  }
+  return TypeSyntax(OptionalTypeSyntax(wrappedType: wrappedType))
+    .with(\.leadingTrivia, type.leadingTrivia)
+    .with(\.trailingTrivia, type.trailingTrivia)
+}
+
+/// The error for a `private` or `fileprivate` stored property without an initial value, attached to
+/// its name. `@ViewProps` leaves it out of the props, so the `init()` that core calls doesn't set it.
+/// There is no fix-it: the value is the author's choice.
+private func unsetPrivatePropertyDiagnostic(
+  for pattern: IdentifierPatternSyntax,
+  access: String
+) -> Diagnostic {
+  let message = ViewPropsDiagnosticMessage(
+    "@ViewProps leaves out the \(access) property '\(withoutBackticks(pattern.identifier.text))', so 'init()' doesn't set it. Give it an initial value, or remove '\(access)' to make it a prop",
+    id: "viewprops-unset-private-property"
+  )
+  return Diagnostic(node: pattern, message: message)
+}
+
+/// The errors for an `init()` that core can't call as `Self()`, one for each token that makes it
+/// unusable: the `?` or `!` of a failable initializer, `async`, and the `throws` clause. Each is
+/// attached to its token and carries a fix-it that removes it with its trailing space, so
+/// `init() async throws {` becomes `init() throws {`, and then `init() {`.
+private func unusableInitializerDiagnostics(for initializer: InitializerDeclSyntax) -> [Diagnostic] {
+  var diagnostics: [Diagnostic] = []
+  if let optionalMark = initializer.optionalMark {
+    diagnostics.append(
+      unusableInitializerDiagnostic(
+        on: Syntax(optionalMark),
+        removing: Syntax(optionalMark.with(\.presence, .missing)),
+        requirement: "non-failable",
+        fixItID: "viewprops-remove-failable"
+      )
+    )
+  }
+  let effectSpecifiers = initializer.signature.effectSpecifiers
+  if let asyncSpecifier = effectSpecifiers?.asyncSpecifier {
+    diagnostics.append(
+      unusableInitializerDiagnostic(
+        on: Syntax(asyncSpecifier),
+        removing: Syntax(asyncSpecifier.with(\.presence, .missing)),
+        requirement: "synchronous",
+        fixItID: "viewprops-remove-async"
+      )
+    )
+  }
+  if let throwsClause = effectSpecifiers?.throwsClause {
+    let missingClause = ThrowsClauseSyntax(
+      throwsSpecifier: throwsClause.throwsSpecifier.with(\.presence, .missing)
+    )
+    diagnostics.append(
+      unusableInitializerDiagnostic(
+        on: Syntax(throwsClause),
+        removing: Syntax(missingClause),
+        requirement: "non-throwing",
+        fixItID: "viewprops-remove-throws"
+      )
+    )
+  }
+  return diagnostics
+}
+
+/// One error of `unusableInitializerDiagnostics`. The fix-it replaces the node, together with its
+/// trivia, by a missing node, which prints as nothing.
+private func unusableInitializerDiagnostic(
+  on node: Syntax,
+  removing missingNode: Syntax,
+  requirement: String,
+  fixItID: String
+) -> Diagnostic {
+  let text = node.trimmedDescription
+  let fixIt = FixIt(
+    message: ViewPropsFixItMessage("Remove '\(text)'", id: fixItID),
+    changes: [.replace(oldNode: node, newNode: missingNode)]
+  )
+  let message = ViewPropsDiagnosticMessage(
+    "@ViewProps needs a \(requirement) 'init()', because core creates the props with 'Self()'. Remove '\(text)'",
+    id: "viewprops-unusable-init"
+  )
+  return Diagnostic(node: node, message: message, fixIts: [fixIt])
+}
+
 private struct ViewPropsDiagnosticMessage: DiagnosticMessage {
   let message: String
   let diagnosticID: MessageID
@@ -272,9 +485,12 @@ private struct ViewProp {
   /// The property name as written, backticks included for an escaped name. Every identifier position
   /// in the generated code uses this, since `case default` and `static let default` don't parse.
   let name: String
-  /// The property's declared type, verbatim. Retained for the decode surface, which lands with the
-  /// core props contract.
+  /// The property's declared type, verbatim, or the type of its literal initial value. `_decode`
+  /// doesn't spell it: the decoded type is inferred from the assignment.
   let type: String
+  /// Whether the prop is computed with a `mutating get`, which `_decode` can only read from a
+  /// mutable value.
+  let hasMutatingGetter: Bool
 
   /// The name with any escaping backticks removed: the JS-visible key, so the enum's raw value and
   /// `_eventNames` both read `"default"`, never `` "`default`" ``.
@@ -283,20 +499,41 @@ private struct ViewProp {
   }
 }
 
+/// An event prop declared without an initial value, which the generated `init()` assigns.
+private struct EventDefault {
+  /// The property name as written, backticks included.
+  let name: String
+  /// A closure literal that ignores its arguments and does nothing: `{}`, `{ _ in }`, `{ _, _ in }`
+  /// and so on, by the arity of the event's function type.
+  let emptyClosure: String
+}
+
 private struct ViewPropsModel {
   /// Value props, in declaration order. The order is the bit order, so it is part of the ABI
   /// between a compiled view and the runtime that fills the mask.
   let valueProps: [ViewProp]
   /// Event props, in declaration order.
   let eventProps: [ViewProp]
+  /// The event props without an initial value, in declaration order.
+  let eventDefaults: [EventDefault]
+  /// Whether the macro generates `init()`. See `needsGeneratedInitializer`.
+  let generatesInitializer: Bool
 }
 
 /// Reads and validates the props type's stored properties, splitting them into value props and events.
 ///
 /// Rejects what can't be expressed: a non-`struct` declaration (the class form is the SwiftUI path and
 /// needs the observable protocol, which is deferred), a leftover `@Field` attribute, an optional
-/// function type, a property with no determinable type, and more than 64 value props.
-private func validatedViewProps(of declaration: some DeclGroupSyntax) throws -> ViewPropsModel {
+/// function type, an event whose function type returns a value, a property with no determinable type,
+/// a value prop declared with `let` or without a default, a `private` stored property without an
+/// initial value, an `init()` that is failable, throwing or `async`, and more than 64 value props.
+///
+/// When the type declares a usable `init()`, that initializer is the default: it must set every
+/// stored property, which the compiler checks, so the props need no initial values.
+private func validatedViewProps(
+  of declaration: some DeclGroupSyntax,
+  in lexicalContext: [Syntax]
+) throws -> ViewPropsModel {
   guard let structDecl = declaration.as(StructDeclSyntax.self) else {
     throw MacroExpansionErrorMessage(
       "@ViewProps can only be applied to a struct — the class form (for SwiftUI views) is not supported yet"
@@ -311,23 +548,66 @@ private func validatedViewProps(of declaration: some DeclGroupSyntax) throws ->
     )
   }
 
+  // `@Field` is the v1 property wrapper and has no meaning here — every stored property is already
+  // part of the surface. Left in place it would wrap the value in `Field<T>`, so the props type
+  // would decode against the wrong type. Flag every one rather than emit code built on them, all at
+  // once, so a `@Field` without a fix-it doesn't hide the fix-its of the others.
+  let fieldDiagnostics = declaration.memberBlock.members.compactMap { member -> Diagnostic? in
+    guard let varDecl = member.decl.as(VariableDeclSyntax.self), !isExcludedByModifier(varDecl.modifiers),
+      let fieldAttribute = varDecl.attributes.firstAttribute(named: "Field")
+    else {
+      return nil
+    }
+    return fieldAttributeDiagnostic(for: fieldAttribute, on: varDecl)
+  }
+  if !fieldDiagnostics.isEmpty {
+    throw DiagnosticsError(diagnostics: fieldDiagnostics)
+  }
+
+  // A usable `init()` belongs to the author and sets the defaults. An `init()` that core can't call
+  // as `Self()` doesn't count, and is reported only when there is no usable one: Swift allows an
+  // `init() async` next to `init()`, and `Self()` in the synchronous `_decode` calls the latter.
+  var propDiagnostics: [Diagnostic] = []
+  var unusableInitializerDiagnosticsFound: [Diagnostic] = []
+  var declaresUsableInitializer = false
+  var declaresOtherInitializer = false
+  for member in flattenedMembers(declaration.memberBlock.members) {
+    guard let initializer = member.decl.as(InitializerDeclSyntax.self) else {
+      continue
+    }
+    guard initializer.signature.parameterClause.parameters.isEmpty else {
+      declaresOtherInitializer = true
+      continue
+    }
+    let unusableDiagnostics = unusableInitializerDiagnostics(for: initializer)
+    if unusableDiagnostics.isEmpty {
+      declaresUsableInitializer = true
+    } else {
+      unusableInitializerDiagnosticsFound += unusableDiagnostics
+    }
+  }
+  if !declaresUsableInitializer {
+    propDiagnostics += unusableInitializerDiagnosticsFound
+  }
+
   var valueProps: [ViewProp] = []
   var eventProps: [ViewProp] = []
+  var eventDefaults: [EventDefault] = []
 
   for member in declaration.memberBlock.members {
     guard let varDecl = member.decl.as(VariableDeclSyntax.self) else {
       continue
     }
     if isExcludedByModifier(varDecl.modifiers) {
+      if !declaresUsableInitializer {
+        propDiagnostics += unsetPrivatePropertyDiagnostics(of: varDecl)
+      }
       continue
     }
-    // `@Field` is the v1 property wrapper and has no meaning here — every stored property is already
-    // part of the surface. Left in place it would wrap the value in `Field<T>`, so the props type
-    // would decode against the wrong type. Flag it rather than emit code built on it.
-    if let fieldAttribute = varDecl.attributes.firstAttribute(named: "Field") {
-      throw DiagnosticsError(diagnostics: [fieldAttributeDiagnostic(for: fieldAttribute, on: varDecl)])
-    }
-
+    // One `let` can declare several props, but its diagnostic and fix-it belong to the keyword, so
+    // it comes before the diagnostics of the bindings, in source order.
+    var letValuePropNames: [String] = []
+    let letDiagnosticIndex = propDiagnostics.count
     for binding in varDecl.bindings {
       // A computed property is never a prop, but an accessor block alone doesn't mean computed:
       // `willSet`/`didSet` observers imply stored storage. `bindingIsSettable` draws exactly that
@@ -367,12 +647,12 @@ private func validatedViewProps(of declaration: some DeclGroupSyntax) throws ->
       // dynamic, but events are registered once at view creation from a static name list, so there
       // is no shape that could express "sometimes emitted".
       if let declaredType, isOptionalType(declaredType), underlyingFunctionType(of: declaredType) != nil {
-        throw DiagnosticsError(diagnostics: [
-          optionalEventDiagnostic(for: declaredType, name: name)
-        ])
+        propDiagnostics.append(optionalEventDiagnostic(for: declaredType, name: name))
+        continue
       }
 
-      let isEvent = declaredType.map { underlyingFunctionType(of: $0) != nil } ?? false
+      let eventFunctionType = declaredType.flatMap(underlyingFunctionType)
+      let isEvent = eventFunctionType != nil
       // `PropSet` stores its mask in `rawValue`, so a value prop of that name would emit a static
       // member shadowing it and the option set would not compile ("circular reference"). The error
       // would point at generated code, so catch it here and name the property.
@@ -381,21 +661,242 @@ private func validatedViewProps(of declaration: some DeclGroupSyntax) throws ->
           "'rawValue' can't be used as a prop name — it collides with the synthesized PropSet's storage. Rename the property"
         )
       }
-      let prop = ViewProp(name: name, type: resolvedType)
-      if isEvent {
+      // Only stored storage takes an initial value; a computed prop with a setter needs none.
+      let needsInitialValue =
+        binding.initializer == nil && isStoredBinding(binding) && !declaresUsableInitializer
+      let prop = ViewProp(name: name, type: resolvedType, hasMutatingGetter: hasMutatingGetter(binding))
+      if let eventFunctionType {
+        // An event is dispatched to JavaScript, which can't hand a value back to the caller.
+        if !returnsVoid(eventFunctionType) {
+          propDiagnostics.append(eventReturnTypeDiagnostic(for: eventFunctionType.returnClause.type, name: name))
+        }
+        if needsInitialValue {
+          eventDefaults.append(
+            EventDefault(name: name, emptyClosure: emptyClosure(arity: eventFunctionType.parameters.count))
+          )
+        }
         eventProps.append(prop)
-      } else {
-        valueProps.append(prop)
+        continue
+      }
+      // `_decode` assigns every value prop, so none can be a constant.
+      if varDecl.bindingSpecifier.tokenKind == .keyword(.let) {
+        letValuePropNames.append(name)
       }
+      // A removed prop is reset to its value in a fresh `Self()`, so every value prop needs a
+      // default: its initial value, or the `nil` that Swift gives an optional `var` without one.
+      if needsInitialValue && !(declaredType.map(hasImplicitNilDefault) ?? false) {
+        propDiagnostics.append(missingDefaultDiagnostic(for: ident, name: name, type: declaredType))
+      }
+      valueProps.append(prop)
+    }
+    if !letValuePropNames.isEmpty {
+      propDiagnostics.insert(letValuePropDiagnostic(for: varDecl, names: letValuePropNames), at: letDiagnosticIndex)
     }
   }
+  // Reported together, so one run names every prop that the generated code can't reset, assign or
+  // default.
+  if !propDiagnostics.isEmpty {
+    throw DiagnosticsError(diagnostics: propDiagnostics)
+  }
 
   guard valueProps.count <= maxValueProps else {
     throw MacroExpansionErrorMessage(
       "@ViewProps supports at most \(maxValueProps) value props (the changed-props mask is a UInt64), but this type declares \(valueProps.count); '\(valueProps[maxValueProps].name)' is the first over the limit. Event props don't count toward it"
     )
   }
-  return ViewPropsModel(valueProps: valueProps, eventProps: eventProps)
+  return ViewPropsModel(
+    valueProps: valueProps,
+    eventProps: eventProps,
+    eventDefaults: eventDefaults,
+    generatesInitializer: needsGeneratedInitializer(
+      structDecl,
+      in: lexicalContext,
+      eventDefaults: eventDefaults,
+      declaresUsableInitializer: declaresUsableInitializer,
+      declaresOtherInitializer: declaresOtherInitializer
+    )
+  )
+}
+
+/// The members of a type body in source order, with the members of every `#if` clause in place of
+/// the conditional declaration. The original conditions remain in the source; this is only for
+/// discovering declarations that exist in one or more compilation configurations.
+private func flattenedMembers(_ members: MemberBlockItemListSyntax) -> [MemberBlockItemSyntax] {
+  return members.flatMap { member -> [MemberBlockItemSyntax] in
+    guard let ifConfig = member.decl.as(IfConfigDeclSyntax.self) else {
+      return [member]
+    }
+    return ifConfig.clauses.flatMap { clause -> [MemberBlockItemSyntax] in
+      guard case .decls(let declarations) = clause.elements else {
+        return []
+      }
+      return flattenedMembers(declarations)
+    }
+  }
+}
+
+/// Whether Swift's own `init()` can't satisfy `AnyViewProps`, so the macro generates a public one.
+/// Swift synthesizes `init()` only when every stored property has a default and the type declares
+/// no initializer, and that `init()` is `internal`, which the conformance of a `public` or `package`
+/// type can't use. The author's usable `init()` always wins, so there is never a second one.
+private func needsGeneratedInitializer(
+  _ structDecl: StructDeclSyntax,
+  in lexicalContext: [Syntax],
+  eventDefaults: [EventDefault],
+  declaresUsableInitializer: Bool,
+  declaresOtherInitializer: Bool
+) -> Bool {
+  if declaresUsableInitializer {
+    return false
+  }
+  return !eventDefaults.isEmpty || isAboveInternal(structDecl, in: lexicalContext) || declaresOtherInitializer
+}
+
+/// True if the type's access is `public`, `open` or `package`: written on the type, or, when the type
+/// has no access modifier, taken from the extension that directly contains it
+/// (`public extension Outer { struct Props {} }`). Only that extension sets the default; an enclosing
+/// type doesn't, so a type nested in a `public` type without a modifier is `internal`.
+private func isAboveInternal(_ structDecl: StructDeclSyntax, in lexicalContext: [Syntax]) -> Bool {
+  if let access = accessLevelModifier(in: structDecl.modifiers) {
+    return isAboveInternal(access)
+  }
+  guard let enclosingExtension = lexicalContext.first?.as(ExtensionDeclSyntax.self),
+    let access = accessLevelModifier(in: enclosingExtension.modifiers)
+  else {
+    return false
+  }
+  return isAboveInternal(access)
+}
+
+/// The access level modifier of a declaration, without a `(set)` detail, which only limits a setter.
+private func accessLevelModifier(in modifiers: DeclModifierListSyntax) -> TokenKind? {
+  return modifiers.first { modifier in
+    guard modifier.detail == nil else {
+      return false
+    }
+    switch modifier.name.tokenKind {
+    case .keyword(.public), .keyword(.open), .keyword(.package), .keyword(.internal), .keyword(.fileprivate),
+      .keyword(.private):
+      return true
+    default:
+      return false
+    }
+  }?.name.tokenKind
+}
+
+private func isAboveInternal(_ access: TokenKind) -> Bool {
+  return access == .keyword(.public) || access == .keyword(.open) || access == .keyword(.package)
+}
+
+/// True if the binding has storage: no accessor block, or only `willSet`/`didSet` observers.
+private func isStoredBinding(_ binding: PatternBindingSyntax) -> Bool {
+  guard let accessorBlock = binding.accessorBlock else {
+    return true
+  }
+  guard case .accessors(let accessors) = accessorBlock.accessors else {
+    return false
+  }
+  return accessors.allSatisfy { accessor in
+    accessor.accessorSpecifier.tokenKind == .keyword(.willSet)
+      || accessor.accessorSpecifier.tokenKind == .keyword(.didSet)
+  }
+}
+
+/// The errors for the `private` and `fileprivate` stored properties of a declaration that have no
+/// initial value. `static`, `class` and `lazy` properties are exempt, and so is an optional `var`
+/// written as `T?` or `T!`, which defaults to `nil`.
+private func unsetPrivatePropertyDiagnostics(of varDecl: VariableDeclSyntax) -> [Diagnostic] {
+  guard
+    let access = varDecl.modifiers.first(where: {
+      $0.name.tokenKind == .keyword(.private) || $0.name.tokenKind == .keyword(.fileprivate)
+    }),
+    !varDecl.modifiers.contains(where: {
+      $0.name.tokenKind == .keyword(.static) || $0.name.tokenKind == .keyword(.class)
+        || $0.name.tokenKind == .keyword(.lazy)
+    })
+  else {
+    return []
+  }
+  let isVar = varDecl.bindingSpecifier.tokenKind == .keyword(.var)
+  return varDecl.bindings.compactMap { binding in
+    guard binding.initializer == nil, isStoredBinding(binding),
+      let ident = binding.pattern.as(IdentifierPatternSyntax.self),
+      !(isVar && resolvedTypeAnnotation(of: binding, in: varDecl).map { hasImplicitNilDefault($0.type) } == true)
+    else {
+      return nil
+    }
+    return unsetPrivatePropertyDiagnostic(for: ident, access: access.name.text)
+  }
+}
+
+/// The binding's own type annotation, or the trailing annotation shared with preceding bindings.
+private func resolvedTypeAnnotation(
+  of binding: PatternBindingSyntax,
+  in varDecl: VariableDeclSyntax
+) -> TypeAnnotationSyntax? {
+  if let typeAnnotation = binding.typeAnnotation {
+    return typeAnnotation
+  }
+  var foundBinding = false
+  for candidate in varDecl.bindings {
+    if foundBinding, let typeAnnotation = candidate.typeAnnotation {
+      return typeAnnotation
+    }
+    foundBinding = candidate.id == binding.id
+  }
+  return nil
+}
+
+/// True if the function type returns `Void`, written as `Void`, `Swift.Void` or `()`, in any number
+/// of enclosing parentheses, such as `(Void)` or `((()))`.
+private func returnsVoid(_ functionType: FunctionTypeSyntax) -> Bool {
+  return isVoidType(functionType.returnClause.type)
+}
+
+private func isVoidType(_ type: TypeSyntax) -> Bool {
+  let type = withoutParentheses(type)
+  if let tuple = type.as(TupleTypeSyntax.self) {
+    return tuple.elements.isEmpty
+  }
+  return ["Void", "Swift.Void"].contains(type.trimmedDescription)
+}
+
+/// The type inside any number of unlabeled one-element parentheses: `(T)` and `((T))` are `T`. A
+/// label would make it a tuple, which Swift rejects with a single element anyway.
+private func withoutParentheses(_ type: TypeSyntax) -> TypeSyntax {
+  guard let tuple = type.as(TupleTypeSyntax.self), tuple.elements.count == 1, let only = tuple.elements.first,
+    only.firstName == nil
+  else {
+    return type
+  }
+  return withoutParentheses(only.type)
+}
+
+/// True if the binding is computed with a `mutating get`.
+private func hasMutatingGetter(_ binding: PatternBindingSyntax) -> Bool {
+  guard case .accessors(let accessors) = binding.accessorBlock?.accessors else {
+    return false
+  }
+  return accessors.contains { accessor in
+    accessor.accessorSpecifier.tokenKind == .keyword(.get)
+      && accessor.modifiers.contains { $0.name.tokenKind == .keyword(.mutating) }
+  }
+}
+
+/// A closure literal that takes `arity` arguments, ignores them and does nothing.
+private func emptyClosure(arity: Int) -> String {
+  if arity == 0 {
+    return "{}"
+  }
+  return "{ \(Array(repeating: "_", count: arity).joined(separator: ", ")) in }"
+}
+
+/// True if Swift gives a `var` of this type an implicit `nil` initial value, so `Self()` can leave it
+/// out. Only the `T?` and `T!` sugar does, also in parentheses (`(T?)`): a property written as
+/// `Optional<T>` has no default.
+private func hasImplicitNilDefault(_ type: TypeSyntax) -> Bool {
+  let type = withoutParentheses(type)
+  return type.is(OptionalTypeSyntax.self) || type.is(ImplicitlyUnwrappedOptionalTypeSyntax.self)
 }
 
 /// The function type a props property declares, unwrapping any number of enclosing parentheses and an
@@ -433,8 +934,9 @@ private func underlyingFunctionType(of type: TypeSyntax) -> FunctionTypeSyntax?
 // MARK: - Synthesized members
 
 /// The `PropName` enum: one case per value prop, `String`-backed so the raw value is the wire key.
-/// Emitted even when empty (an uninhabited enum is legal and keeps the conformance's associated type
-/// satisfied), so a props type with only events still conforms.
+/// Emitted even when empty, so a props type with only events still conforms. An enum with no cases
+/// can't declare a raw type, so the empty one conforms to `RawRepresentable` by hand, with `String`
+/// as its `RawValue` like the others.
 private func propNameEnum(valueProps: [ViewProp]) -> DeclSyntax {
   // An escaped case takes its raw value from the bare identifier already, but spelling it out keeps
   // the wire key visible in the generated source and independent of that implicit rule.
@@ -448,7 +950,15 @@ private func propNameEnum(valueProps: [ViewProp]) -> DeclSyntax {
     .joined(separator: "\n")
   if valueProps.isEmpty {
     return """
-      public enum PropName: String, CaseIterable {
+      public enum PropName: RawRepresentable, CaseIterable {
+        public init?(rawValue: String) {
+          return nil
+        }
+
+        public var rawValue: String {
+          switch self {
+          }
+        }
       }
       """
   }
@@ -503,6 +1013,72 @@ private func eventNamesConstant(eventProps: [ViewProp]) -> DeclSyntax {
     """
 }
 
+/// The body of `_decode`, which core calls once per changed prop. React sends a removed prop as
+/// `null`, so `null` and `undefined` reset the prop to its value in a fresh `Self()`; any other value
+/// decodes through `JavaScriptDecodable`, with the type inferred from the assignment. The helper is a
+/// static member of `AnyViewProps`, reached through `Self.`, so a prop named `_decodeViewProp`
+/// doesn't shadow it. The checks run
+/// once, before the switch, so each case is a single assignment. Members are reached through `self.`
+/// so that a prop named like a parameter (`value`, `runtime`) isn't shadowed by it.
+///
+/// With no value prop the body is empty: `PropName` is uninhabited, so the function is never called.
+///
+/// `defaults` is a `var` only when a prop has a `mutating get`, which can't be read from a constant.
+/// Otherwise it's a `let`, so the common case gets no "never mutated" warning.
+private func decodeFunctionBody(valueProps: [ViewProp]) -> String {
+  if valueProps.isEmpty {
+    return ""
+  }
+  let defaultsSpecifier = valueProps.contains(where: \.hasMutatingGetter) ? "var" : "let"
+  let resetCases =
+    valueProps
+    .map { "      case .\($0.name):\n        self.\($0.name) = defaults.\($0.name)" }
+    .joined(separator: "\n")
+  let decodeCases =
+    valueProps
+    .map { "    case .\($0.name):\n      self.\($0.name) = try Self._decodeViewProp(value, in: runtime)" }
+    .joined(separator: "\n")
+  // Starts with a line break, so the empty body closes on the next line instead of leaving a blank
+  // one.
+  return """
+
+        if value.isNull() || value.isUndefined() {
+          \(defaultsSpecifier) defaults = Self()
+          switch name {
+    \(resetCases)
+          }
+          return
+        }
+        switch name {
+    \(decodeCases)
+        }
+    """
+}
+
+/// The public `init()` that `AnyViewProps` requires, when Swift's own can't satisfy it: it gives each
+/// event prop without an initial value an empty closure, and leaves the value props at their initial
+/// values. `nil` when the type declares a usable `init()`, or when Swift's `init()` is enough (see
+/// `needsGeneratedInitializer`).
+private func defaultInitializer(props: ViewPropsModel) -> DeclSyntax? {
+  if !props.generatesInitializer {
+    return nil
+  }
+  if props.eventDefaults.isEmpty {
+    return """
+      public init() {
+      }
+      """
+  }
+  let assignments = props.eventDefaults
+    .map { "  self.\($0.name) = \($0.emptyClosure)" }
+    .joined(separator: "\n")
+  return """
+    public init() {
+    \(raw: assignments)
+    }
+    """
+}
+
 /// The nested spelling of core's one generic diff, so a view writes `MyProps.Diff`.
 private func diffTypealias() -> DeclSyntax {
   return """