expo-modules-jsi 56.0.9 → 56.0.10

package/CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### 💡 Others
 
+## 56.0.10 — 2026-06-15
+
+### 🐛 Bug fixes
+
+- [iOS] Ignore already-settled promises. ([#46765](https://github.com/expo/expo/pull/46765) by [@jakex7](https://github.com/jakex7))
+
 ## 56.0.9 — 2026-06-10
 
 ### 🎉 New features

package/apple/Sources/ExpoModulesJSI/Runtime/Values/JavaScriptPromise.swift

@@ -75,15 +75,16 @@ public struct JavaScriptPromise: JavaScriptType, ~Copyable {
     guard let runtime else {
       return
     }
-    guard !resolveFunction.isEmpty else {
-      preconditionFailure("Cannot settle a promise more than once")
-    }
 
     // `resolve` is not isolated, so make sure to jump to JS thread.
     runtime.schedule(priority: .immediate) { [resolveFunction, rejectFunction] in
+      // If the promise is already settled, do nothing.
+      guard let resolver = resolveFunction.take() else {
+        return
+      }
       // Call the actual resolver given in the Promise setup.
       // This will also call `deferredPromise.resolve` in the `then` handler.
-      _ = try! resolveFunction.take().getFunction().call(arguments: value)
+      _ = try! resolver.getFunction().call(arguments: value)
 
       // Release the rejecter, we cannot call it anymore.
       rejectFunction.release()
@@ -94,19 +95,20 @@ public struct JavaScriptPromise: JavaScriptType, ~Copyable {
     guard let runtime else {
       return
     }
-    guard !rejectFunction.isEmpty else {
-      preconditionFailure("Cannot settle a promise more than once")
-    }
 
     // `reject` is not isolated, so make sure to jump to JS thread.
     runtime.schedule(priority: .immediate) { [resolveFunction, rejectFunction] in
+      // If the promise is already settled, do nothing.
+      guard let rejecter = rejectFunction.take() else {
+        return
+      }
       // Create a JS error from any (native) error.
       let errorMessage = String(describing: error)
       let errorValue = JavaScriptError(runtime, message: errorMessage).asValue()
 
       // Call the actual rejecter given in the Promise setup.
       // This will also call `deferredPromise.reject` in the `then` handler.
-      _ = try! rejectFunction.take().getFunction().call(arguments: errorValue)
+      _ = try! rejecter.getFunction().call(arguments: errorValue)
 
       // Release the resolver, we cannot call it anymore.
       resolveFunction.release()

package/apple/Tests/JavaScriptPromiseTests.swift

@@ -279,6 +279,23 @@ struct JavaScriptPromiseTests {
     #expect(result.getInt() == 99)
   }
 
+  @Test
+  func `settling promise more than once is ignored`() async throws {
+    struct TestError: Error, Sendable {}
+
+    let runtime = JavaScriptRuntime()
+    let promise = try JavaScriptPromise(runtime)
+
+    runtime.global().setProperty("testPromise", value: promise.asValue())
+    promise.resolve(42)
+    promise.reject(TestError())
+    promise.resolve(100)
+
+    let result = try await promise.await()
+
+    #expect(result.getInt() == 42)
+  }
+
   @Test
   func `promise all`() async throws {
     let runtime = JavaScriptRuntime()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-modules-jsi",
-  "version": "56.0.9",
+  "version": "56.0.10",
   "description": "The JavaScript Interface for Expo Modules",
   "main": "index.js",
   "sideEffects": [],
@@ -41,7 +41,7 @@
       "./apple/scripts/test.sh"
     ]
   },
-  "gitHead": "b1e94a5c1c5b19472a42ca25752a3533699bc46a",
+  "gitHead": "812dc007aefed0c432c0439fdfe05ee2f4f21da2",
   "scripts": {
     "build": "apple/scripts/build-xcframework.sh",
     "swift:format": "../../scripts/swift-format.sh",