expo-modules-core 3.0.19 → 3.0.20

package/CHANGELOG.md

@@ -10,6 +10,13 @@
 
 ### 💡 Others
 
+## 3.0.20 — 2025-10-01
+
+### 🐛 Bug fixes
+
+- [iOS] Fix NSURL to JSIString conversion returning nil. ([#39567](https://github.com/expo/expo/pull/39567) by [@behenate](https://github.com/behenate))
+- Fix SharedObject created with `useReleasingSharedObject` getting destroyed after a fast refresh caused by a change in its dependencies. ([#39753](https://github.com/expo/expo/pull/39753) by [@behenate](https://github.com/behenate))
+
 ## 3.0.19 — 2025-10-01
 
 ### 💡 Others

package/android/build.gradle

@@ -29,7 +29,7 @@ if (shouldIncludeCompose) {
 }
 
 group = 'host.exp.exponent'
-version = '3.0.19'
+version = '3.0.20'
 
 def isExpoModulesCoreTests = {
   Gradle gradle = getGradle()
@@ -79,7 +79,7 @@ android {
   defaultConfig {
     consumerProguardFiles 'proguard-rules.pro'
     versionCode 1
-    versionName "3.0.19"
+    versionName "3.0.20"
     buildConfigField "String", "EXPO_MODULES_CORE_VERSION", "\"${versionName}\""
     buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled.toString()
 

package/build/hooks/useReleasingSharedObject.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"useReleasingSharedObject.d.ts","sourceRoot":"","sources":["../../src/hooks/useReleasingSharedObject.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,cAAc,EAA8B,MAAM,OAAO,CAAC;AAEnE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iCAAiC,CAAC;AAEpE;;GAEG;AACH,wBAAgB,wBAAwB,CAAC,aAAa,SAAS,YAAY,EACzE,OAAO,EAAE,MAAM,aAAa,EAC5B,YAAY,EAAE,cAAc,GAC3B,aAAa,CAwCf"}
+{"version":3,"file":"useReleasingSharedObject.d.ts","sourceRoot":"","sources":["../../src/hooks/useReleasingSharedObject.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,cAAc,EAA8B,MAAM,OAAO,CAAC;AAEnE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iCAAiC,CAAC;AAEpE;;GAEG;AACH,wBAAgB,wBAAwB,CAAC,aAAa,SAAS,YAAY,EACzE,OAAO,EAAE,MAAM,aAAa,EAC5B,YAAY,EAAE,cAAc,GAC3B,aAAa,CA0Cf"}

package/ios/JSI/EXJSIConversions.h

@@ -24,6 +24,8 @@ namespace expo
 
     jsi::String convertNSStringToJSIString(jsi::Runtime &runtime, NSString *value);
 
+    jsi::String convertNSURLToJSIString(jsi::Runtime &runtime, NSURL *value);
+
     jsi::Object convertNSDictionaryToJSIObject(jsi::Runtime &runtime, NSDictionary *value);
 
     jsi::Array convertNSArrayToJSIArray(jsi::Runtime &runtime, NSArray *value);

package/ios/JSI/EXJSIConversions.mm

@@ -9,6 +9,7 @@
 #import <ExpoModulesCore/EXJavaScriptRuntime.h>
 #import <ExpoModulesCore/EXJavaScriptSharedObjectBinding.h>
 #import <ExpoModulesCore/EXStringUtils.h>
+#import <Foundation/NSURL.h>
 
 namespace expo {
 
@@ -41,6 +42,12 @@ jsi::String convertNSStringToJSIString(jsi::Runtime &runtime, NSString *value)
 #endif
 }
 
+jsi::String convertNSURLToJSIString(jsi::Runtime &runtime, NSURL *value)
+{
+  NSString *stringValue = [value absoluteString];
+  return convertNSStringToJSIString(runtime, stringValue);
+}
+
 jsi::Object convertNSDictionaryToJSIObject(jsi::Runtime &runtime, NSDictionary *value)
 {
   jsi::Object result = jsi::Object(runtime);
@@ -107,6 +114,8 @@ jsi::Value convertObjCObjectToJSIValue(jsi::Runtime &runtime, id value)
     return convertNSArrayToJSIArray(runtime, (NSArray *)value);
   } else if ([value isKindOfClass:[NSData class]]) {
     return createUint8Array(runtime, (NSData *)value);
+  } else if ([value isKindOfClass:[NSURL class]]) {
+    return convertNSURLToJSIString(runtime, (NSURL *)value);
   } else if (value == (id)kCFNull) {
     return jsi::Value::null();
   }

package/ios/Tests/FunctionSpec.swift

@@ -245,6 +245,17 @@ class FunctionSpec: ExpoSpec {
         @Field var property: String = "expo"
       }
 
+      struct TestURLRecord: Record {
+        static let defaultURLString = "https://expo.dev"
+        static let defaultURL = URL(string: defaultURLString)!
+
+        @Field var url: URL = defaultURL
+      }
+
+      afterEach {
+        try runtime.eval("globalThis.result = undefined")
+      }
+
       beforeSuite {
         appContext.moduleRegistry.register(holder: mockModuleHolder(appContext) {
           Name("TestModule")
@@ -286,10 +297,18 @@ class FunctionSpec: ExpoSpec {
             return "\(f.property)"
           }
 
+          Function("withURL") {
+            return TestURLRecord.defaultURL
+          }
+
+          Function("withNestedURL") {
+            return TestURLRecord()
+          }
+
           Function("withOptionalRecord") { (f: TestRecord?) in
             return "\(f?.property ?? "no value")"
           }
-          
+
           Function("withSharedObject") {
             return SharedString("Test")
           }
@@ -305,7 +324,15 @@ class FunctionSpec: ExpoSpec {
           AsyncFunction("withSharedObjectPromise") { (p: Promise) in
             p.resolve(SharedString("Test with Promise"))
           }
-          
+
+          AsyncFunction("withURLAsync") {
+            return TestURLRecord.defaultURL
+          }
+
+          AsyncFunction("withNestedURLAsync") {
+            return TestURLRecord()
+          }
+
           Class("Shared", SharedString.self) {
             Property("value") { shared in
               return shared.ref
@@ -360,7 +387,43 @@ class FunctionSpec: ExpoSpec {
       it("accepts optional record") {
         expect(try runtime.eval("expo.modules.TestModule.withOptionalRecord({property: \"123\"})").asString()) == "123"
       }
-      
+
+      it("returns URL (sync)") {
+        let result = try runtime.eval("globalThis.result = expo.modules.TestModule.withURL()")
+        expect(result.kind) == .string
+        expect(result.getString()) == TestURLRecord.defaultURLString
+      }
+
+      it("returns URL (async)") {
+        try runtime.eval("expo.modules.TestModule.withURLAsync().then((result) => { globalThis.result = result; })")
+        expect(safeBoolEval("!!globalThis.result")).toEventually(beTrue(), timeout: .milliseconds(2000))
+
+        let urlValue = try runtime.eval("url = globalThis.result")
+        expect(urlValue.kind) == .string
+        expect(urlValue.getString()) == TestURLRecord.defaultURLString
+      }
+
+      it("returns a record wit url (sync)") {
+        let object = try runtime.eval("globalThis.result = expo.modules.TestModule.withNestedURL()")
+        expect(object.kind) == .object
+        expect(object.getObject().hasProperty("url")) == true
+        expect(object.getObject().getProperty("url").getString()) == TestURLRecord.defaultURLString
+      }
+
+      it("returns a record with url (async)") {
+        try runtime.eval("expo.modules.TestModule.withNestedURLAsync().then((result) => { globalThis.result = result; })")
+
+        expect(safeBoolEval("!!globalThis.result.url")).toEventually(beTrue(), timeout: .milliseconds(2000))
+
+        let object = try runtime.eval("object = globalThis.result")
+        expect(object.kind) == .object
+        expect(object.getObject().hasProperty("url")) == true
+
+        let urlValue = try runtime.eval("object.url")
+        expect(urlValue.kind) == .string
+        expect(urlValue.getString()) == TestURLRecord.defaultURLString
+      }
+
       it("returns a SharedObject (sync)") {
         let object = try runtime.eval("expo.modules.TestModule.withSharedObject()")
         
@@ -385,7 +448,7 @@ class FunctionSpec: ExpoSpec {
         expect(result.kind) == .string
         expect(result.getString()) == "Test"
       }
-      
+
       it("returns an Array of SharedObjects (async)") {
         try runtime
           .eval(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-modules-core",
-  "version": "3.0.19",
+  "version": "3.0.20",
   "description": "The core of Expo Modules architecture",
   "main": "src/index.ts",
   "types": "build/index.d.ts",
@@ -65,5 +65,5 @@
     "@testing-library/react-native": "^13.2.0",
     "expo-module-scripts": "^5.0.7"
   },
-  "gitHead": "1ab3b9621b78b77b81049ebf06149753a1e0898c"
+  "gitHead": "73d9bc0ee4f1e28cfda349dc36ee53d16fad0c5d"
 }

package/src/hooks/useReleasingSharedObject.ts

@@ -26,18 +26,20 @@ export function useReleasingSharedObject<TSharedObject extends SharedObject>(
       dependencies.every((value, index) => value === previousDependencies.current[index]);
 
     // If the dependencies have changed, release the previous object and create a new one, otherwise this has been called
-    // because of a fast refresh, and we don't want to release the object.
+    // because of an unrelated fast refresh, and we don't want to release the object.
     if (!newObject || !dependenciesAreEqual) {
       objectRef.current?.release();
       newObject = factory();
       objectRef.current = newObject;
       previousDependencies.current = dependencies;
-    } else {
-      isFastRefresh.current = true;
     }
     return newObject;
   }, dependencies);
 
+  useMemo(() => {
+    isFastRefresh.current = true;
+  }, []);
+
   useEffect(() => {
     isFastRefresh.current = false;