expo-modules-core 3.0.18 → 3.0.20

package/CHANGELOG.md

@@ -10,6 +10,19 @@
 
 ### 💡 Others
 
+## 3.0.20 — 2025-10-01
+
+### 🐛 Bug fixes
+
+- [iOS] Fix NSURL to JSIString conversion returning nil. ([#39567](https://github.com/expo/expo/pull/39567) by [@behenate](https://github.com/behenate))
+- Fix SharedObject created with `useReleasingSharedObject` getting destroyed after a fast refresh caused by a change in its dependencies. ([#39753](https://github.com/expo/expo/pull/39753) by [@behenate](https://github.com/behenate))
+
+## 3.0.19 — 2025-10-01
+
+### 💡 Others
+
+- [ios] - Set host dimension synchronously on native ([#40017](https://github.com/expo/expo/pull/40017) by [@nishan](https://github.com/intergalacticspacehighway))
+
 ## 3.0.18 — 2025-09-22
 
 ### 🐛 Bug fixes
@@ -25,6 +38,7 @@ _This version does not introduce any user-facing changes._
 ### 🎉 New features
 
 - [Android] Starts using precompiled headers to improve build times. ([#39641](https://github.com/expo/expo/pull/39641) by [@lukmccall](https://github.com/lukmccall))
+- Remove `ExpoAppDelegate` inheritance requirement in ExpoReactNativeFactory ([#39844](https://github.com/expo/expo/pull/39844) by [@gabrieldonadel](https://github.com/gabrieldonadel))
 
 ### 🐛 Bug fixes
 

package/android/build.gradle

@@ -29,7 +29,7 @@ if (shouldIncludeCompose) {
 }
 
 group = 'host.exp.exponent'
-version = '3.0.18'
+version = '3.0.20'
 
 def isExpoModulesCoreTests = {
   Gradle gradle = getGradle()
@@ -79,7 +79,7 @@ android {
   defaultConfig {
     consumerProguardFiles 'proguard-rules.pro'
     versionCode 1
-    versionName "3.0.18"
+    versionName "3.0.20"
     buildConfigField "String", "EXPO_MODULES_CORE_VERSION", "\"${versionName}\""
     buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled.toString()
 

package/build/hooks/useReleasingSharedObject.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"useReleasingSharedObject.d.ts","sourceRoot":"","sources":["../../src/hooks/useReleasingSharedObject.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,cAAc,EAA8B,MAAM,OAAO,CAAC;AAEnE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iCAAiC,CAAC;AAEpE;;GAEG;AACH,wBAAgB,wBAAwB,CAAC,aAAa,SAAS,YAAY,EACzE,OAAO,EAAE,MAAM,aAAa,EAC5B,YAAY,EAAE,cAAc,GAC3B,aAAa,CAwCf"}
+{"version":3,"file":"useReleasingSharedObject.d.ts","sourceRoot":"","sources":["../../src/hooks/useReleasingSharedObject.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,cAAc,EAA8B,MAAM,OAAO,CAAC;AAEnE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iCAAiC,CAAC;AAEpE;;GAEG;AACH,wBAAgB,wBAAwB,CAAC,aAAa,SAAS,YAAY,EACzE,OAAO,EAAE,MAAM,aAAa,EAC5B,YAAY,EAAE,cAAc,GAC3B,aAAa,CA0Cf"}

package/common/cpp/fabric/ExpoViewComponentDescriptor.cpp

@@ -44,6 +44,34 @@ void ExpoViewComponentDescriptor::adopt(facebook::react::ShadowNode &shadowNode)
 
     snode->setSize({width, height});
   }
+  
+  // handle layout style prop update
+  auto styleWidth = state._styleWidth;
+  auto styleHeight = state._styleHeight;
+
+  if (!isnan(styleWidth) || !isnan(styleHeight)) {
+    auto const &props = *std::static_pointer_cast<const facebook::react::ViewProps>(snode->getProps());
+    
+    auto& style = const_cast<facebook::yoga::Style&>(props.yogaStyle);
+    bool changedStyle = false;
+    
+    if (!isnan(styleWidth)) {
+      style.setDimension(facebook::yoga::Dimension::Width, facebook::yoga::StyleSizeLength::points(styleWidth));
+      changedStyle = true;
+    }
+    
+    if (!isnan(styleHeight)) {
+      style.setDimension(facebook::yoga::Dimension::Height, facebook::yoga::StyleSizeLength::points(styleHeight));
+      changedStyle = true;
+    }
+    
+    // Update yoga props and dirty layout if we changed the style
+    if (changedStyle) {
+      auto* expoNode = const_cast<ExpoViewShadowNode*>(snode);
+      expoNode->updateYogaProps();
+      expoNode->dirtyLayout();
+    }
+  }
   ConcreteComponentDescriptor::adopt(shadowNode);
 }
 

package/common/cpp/fabric/ExpoViewState.h

@@ -28,11 +28,28 @@ public:
       _height = std::numeric_limits<float>::quiet_NaN();
     }
   };
+  
+  static ExpoViewState withStyleDimensions(float styleWidth, float styleHeight) {
+    ExpoViewState state;
+    if (styleWidth >= 0) {
+      state._styleWidth = styleWidth;
+    } else {
+      state._styleWidth = std::numeric_limits<float>::quiet_NaN();
+    }
+    if (styleHeight >= 0) {
+      state._styleHeight = styleHeight;
+    } else {
+      state._styleHeight = std::numeric_limits<float>::quiet_NaN();
+    }
+    return state;
+  }
 
 #ifdef ANDROID
   ExpoViewState(ExpoViewState const &previousState, folly::dynamic data)
   : _width((float)data["width"].getDouble()),
-    _height((float)data["height"].getDouble()){};
+    _height((float)data["height"].getDouble()),
+    _styleWidth(data.count("styleWidth") ? (float)data["styleWidth"].getDouble() : std::numeric_limits<float>::quiet_NaN()),
+    _styleHeight(data.count("styleHeight") ? (float)data["styleHeight"].getDouble() : std::numeric_limits<float>::quiet_NaN()){};
   folly::dynamic getDynamic() const {
     return {};
   };
@@ -44,6 +61,8 @@ public:
   
   float _width = std::numeric_limits<float>::quiet_NaN();
   float _height = std::numeric_limits<float>::quiet_NaN();
+  float _styleWidth = std::numeric_limits<float>::quiet_NaN();
+  float _styleHeight = std::numeric_limits<float>::quiet_NaN();
 
 };
 

package/ios/AppDelegates/ExpoReactNativeFactoryProtocol.swift

@@ -0,0 +1,12 @@
+public protocol ExpoReactNativeFactoryProtocol: AnyObject {
+  /**
+   To decouple RCTAppDelegate dependency from expo-modules-core,
+   expo-modules-core doesn't include the concrete `RCTReactNativeFactory` type and let the callsite to include the type
+   */
+  func recreateRootView(
+    withBundleURL: URL?,
+    moduleName: String?,
+    initialProps: [AnyHashable: Any]?,
+    launchOptions: [AnyHashable: Any]?
+  ) -> UIView
+}

package/ios/Core/Views/SwiftUI/SwiftUIHostingView.swift

@@ -81,6 +81,13 @@ extension ExpoSwiftUI {
         self.setViewSize(size)
         #endif
       }
+      
+      shadowNodeProxy.setStyleSize = { width, height in
+        #if RCT_NEW_ARCH_ENABLED
+        self.setStyleSize(width, height: height)
+        #endif
+      }
+      
       shadowNodeProxy.objectWillChange.send()
 
       #if os(iOS) || os(tvOS)
@@ -136,6 +143,12 @@ extension ExpoSwiftUI {
       return true
     }
 
+    public override func layoutSubviews() {
+      super.layoutSubviews()
+      // TODO: Use updateLayoutMetrics from RN. Add support in ExpoFabricView.
+      setupHostingViewConstraints()
+    }
+
 #if RCT_NEW_ARCH_ENABLED
     /**
      Fabric calls this function when mounting (attaching) a child component view.
@@ -187,14 +200,13 @@ extension ExpoSwiftUI {
       guard let view = hostingController.view as UIView? else {
         return
       }
-      view.translatesAutoresizingMaskIntoConstraints = false
-
-      NSLayoutConstraint.activate([
-        view.topAnchor.constraint(equalTo: topAnchor),
-        view.bottomAnchor.constraint(equalTo: bottomAnchor),
-        view.leftAnchor.constraint(equalTo: leftAnchor),
-        view.rightAnchor.constraint(equalTo: rightAnchor)
-      ])
+      let frame = self.bounds;
+      view.frame = frame;
+        #if os(iOS) || os(tvOS)
+        view.autoresizingMask = [.flexibleWidth, .flexibleHeight]
+        #elseif os(macOS)
+        view.autoresizingMask = [.width, .height]
+        #endif
     }
 
     // MARK: - UIView lifecycle

package/ios/Core/Views/SwiftUI/SwiftUIShadowNodeProxy.swift

@@ -10,5 +10,6 @@ extension ExpoSwiftUI {
     static let SHADOW_NODE_MOCK_PROXY = ShadowNodeProxy()
 
     public var setViewSize: ((CGSize) -> Void)?
+    public var setStyleSize: ((NSNumber?, NSNumber?) -> Void)?
   }
 }

package/ios/Core/Views/SwiftUI/SwiftUIVirtualViewObjC.h

@@ -21,6 +21,8 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)setShadowNodeSize:(float) width height:(float) height;
 
+- (void)setStyleSize:(nullable NSNumber *)width height:(nullable NSNumber *)height;
+
 - (BOOL)supportsPropWithName:(nonnull NSString *)name;
 
 /*

package/ios/Core/Views/SwiftUI/SwiftUIVirtualViewObjC.mm

@@ -357,6 +357,15 @@ static std::unordered_map<std::string, expo::ExpoViewComponentDescriptor::Flavor
   }
 }
 
+- (void)setStyleSize:(nullable NSNumber *)width height:(nullable NSNumber *)height
+{
+  if (_state) {
+    float widthValue = width ? [width floatValue] : std::numeric_limits<float>::quiet_NaN();
+    float heightValue = height ? [height floatValue] : std::numeric_limits<float>::quiet_NaN();
+    _state->updateState(expo::ExpoViewState::withStyleDimensions(widthValue, heightValue));
+  }
+}
+
 - (BOOL)supportsPropWithName:(nonnull NSString *)name
 {
   // Implemented in `SwiftUIVirtualView.swift`

package/ios/Fabric/ExpoFabricViewObjC.h

@@ -40,6 +40,8 @@
 
 - (void)setShadowNodeSize:(float)width height:(float)height;
 
+- (void)setStyleSize:(nullable NSNumber *)width height:(nullable NSNumber *)height;
+
 - (BOOL)supportsPropWithName:(nonnull NSString *)name;
 
 // MARK: - Derived from RCTComponentViewProtocol

package/ios/Fabric/ExpoFabricViewObjC.mm

@@ -179,6 +179,20 @@ static std::unordered_map<std::string, ExpoViewComponentDescriptor::Flavor> _com
   return NO;
 }
 
+- (void)setStyleSize:(nullable NSNumber *)width height:(nullable NSNumber *)height
+{
+  if (_state) {
+    float widthValue = width ? [width floatValue] : std::numeric_limits<float>::quiet_NaN();
+    float heightValue = height ? [height floatValue] : std::numeric_limits<float>::quiet_NaN();
+#if REACT_NATIVE_TARGET_VERSION >= 82
+    // synchronous update is only available in React Native 0.82 and above
+    _state->updateState(expo::ExpoViewState::withStyleDimensions(widthValue, heightValue), EventQueue::UpdateMode::unstable_Immediate);
+#else
+    _state->updateState(expo::ExpoViewState::withStyleDimensions(widthValue, heightValue));
+#endif
+  }
+}
+
 @end
 
 #endif // RCT_NEW_ARCH_ENABLED

package/ios/JSI/EXJSIConversions.h

@@ -24,6 +24,8 @@ namespace expo
 
     jsi::String convertNSStringToJSIString(jsi::Runtime &runtime, NSString *value);
 
+    jsi::String convertNSURLToJSIString(jsi::Runtime &runtime, NSURL *value);
+
     jsi::Object convertNSDictionaryToJSIObject(jsi::Runtime &runtime, NSDictionary *value);
 
     jsi::Array convertNSArrayToJSIArray(jsi::Runtime &runtime, NSArray *value);

package/ios/JSI/EXJSIConversions.mm

@@ -9,6 +9,7 @@
 #import <ExpoModulesCore/EXJavaScriptRuntime.h>
 #import <ExpoModulesCore/EXJavaScriptSharedObjectBinding.h>
 #import <ExpoModulesCore/EXStringUtils.h>
+#import <Foundation/NSURL.h>
 
 namespace expo {
 
@@ -41,6 +42,12 @@ jsi::String convertNSStringToJSIString(jsi::Runtime &runtime, NSString *value)
 #endif
 }
 
+jsi::String convertNSURLToJSIString(jsi::Runtime &runtime, NSURL *value)
+{
+  NSString *stringValue = [value absoluteString];
+  return convertNSStringToJSIString(runtime, stringValue);
+}
+
 jsi::Object convertNSDictionaryToJSIObject(jsi::Runtime &runtime, NSDictionary *value)
 {
   jsi::Object result = jsi::Object(runtime);
@@ -107,6 +114,8 @@ jsi::Value convertObjCObjectToJSIValue(jsi::Runtime &runtime, id value)
     return convertNSArrayToJSIArray(runtime, (NSArray *)value);
   } else if ([value isKindOfClass:[NSData class]]) {
     return createUint8Array(runtime, (NSData *)value);
+  } else if ([value isKindOfClass:[NSURL class]]) {
+    return convertNSURLToJSIString(runtime, (NSURL *)value);
   } else if (value == (id)kCFNull) {
     return jsi::Value::null();
   }

package/ios/ReactDelegates/ExpoReactDelegate.swift

@@ -6,9 +6,11 @@
 @objc(EXReactDelegate)
 public class ExpoReactDelegate: NSObject {
   private let handlers: [ExpoReactDelegateHandler]
+  public let reactNativeFactory: ExpoReactNativeFactoryProtocol
 
-  public init(handlers: [ExpoReactDelegateHandler]) {
+  public init(handlers: [ExpoReactDelegateHandler], reactNativeFactory: ExpoReactNativeFactoryProtocol) {
     self.handlers = handlers
+    self.reactNativeFactory = reactNativeFactory
   }
 
   @objc
@@ -23,7 +25,7 @@ public class ExpoReactDelegate: NSObject {
       ?? {
         guard let appDelegate = (UIApplication.shared.delegate as? (any ReactNativeFactoryProvider)) ??
           ((UIApplication.shared.delegate as? NSObject)?.value(forKey: "_expoAppDelegate") as? (any ReactNativeFactoryProvider)) else {
-          fatalError("`UIApplication.shared.delegate` must be an `ExpoAppDelegate` or `EXAppDelegateWrapper`")
+          return reactNativeFactory.recreateRootView(withBundleURL: nil, moduleName: moduleName, initialProps: initialProperties, launchOptions: launchOptions)
         }
 
         return appDelegate.recreateRootView(

package/ios/Tests/FunctionSpec.swift

@@ -245,6 +245,17 @@ class FunctionSpec: ExpoSpec {
         @Field var property: String = "expo"
       }
 
+      struct TestURLRecord: Record {
+        static let defaultURLString = "https://expo.dev"
+        static let defaultURL = URL(string: defaultURLString)!
+
+        @Field var url: URL = defaultURL
+      }
+
+      afterEach {
+        try runtime.eval("globalThis.result = undefined")
+      }
+
       beforeSuite {
         appContext.moduleRegistry.register(holder: mockModuleHolder(appContext) {
           Name("TestModule")
@@ -286,10 +297,18 @@ class FunctionSpec: ExpoSpec {
             return "\(f.property)"
           }
 
+          Function("withURL") {
+            return TestURLRecord.defaultURL
+          }
+
+          Function("withNestedURL") {
+            return TestURLRecord()
+          }
+
           Function("withOptionalRecord") { (f: TestRecord?) in
             return "\(f?.property ?? "no value")"
           }
-          
+
           Function("withSharedObject") {
             return SharedString("Test")
           }
@@ -305,7 +324,15 @@ class FunctionSpec: ExpoSpec {
           AsyncFunction("withSharedObjectPromise") { (p: Promise) in
             p.resolve(SharedString("Test with Promise"))
           }
-          
+
+          AsyncFunction("withURLAsync") {
+            return TestURLRecord.defaultURL
+          }
+
+          AsyncFunction("withNestedURLAsync") {
+            return TestURLRecord()
+          }
+
           Class("Shared", SharedString.self) {
             Property("value") { shared in
               return shared.ref
@@ -360,7 +387,43 @@ class FunctionSpec: ExpoSpec {
       it("accepts optional record") {
         expect(try runtime.eval("expo.modules.TestModule.withOptionalRecord({property: \"123\"})").asString()) == "123"
       }
-      
+
+      it("returns URL (sync)") {
+        let result = try runtime.eval("globalThis.result = expo.modules.TestModule.withURL()")
+        expect(result.kind) == .string
+        expect(result.getString()) == TestURLRecord.defaultURLString
+      }
+
+      it("returns URL (async)") {
+        try runtime.eval("expo.modules.TestModule.withURLAsync().then((result) => { globalThis.result = result; })")
+        expect(safeBoolEval("!!globalThis.result")).toEventually(beTrue(), timeout: .milliseconds(2000))
+
+        let urlValue = try runtime.eval("url = globalThis.result")
+        expect(urlValue.kind) == .string
+        expect(urlValue.getString()) == TestURLRecord.defaultURLString
+      }
+
+      it("returns a record wit url (sync)") {
+        let object = try runtime.eval("globalThis.result = expo.modules.TestModule.withNestedURL()")
+        expect(object.kind) == .object
+        expect(object.getObject().hasProperty("url")) == true
+        expect(object.getObject().getProperty("url").getString()) == TestURLRecord.defaultURLString
+      }
+
+      it("returns a record with url (async)") {
+        try runtime.eval("expo.modules.TestModule.withNestedURLAsync().then((result) => { globalThis.result = result; })")
+
+        expect(safeBoolEval("!!globalThis.result.url")).toEventually(beTrue(), timeout: .milliseconds(2000))
+
+        let object = try runtime.eval("object = globalThis.result")
+        expect(object.kind) == .object
+        expect(object.getObject().hasProperty("url")) == true
+
+        let urlValue = try runtime.eval("object.url")
+        expect(urlValue.kind) == .string
+        expect(urlValue.getString()) == TestURLRecord.defaultURLString
+      }
+
       it("returns a SharedObject (sync)") {
         let object = try runtime.eval("expo.modules.TestModule.withSharedObject()")
         
@@ -385,7 +448,7 @@ class FunctionSpec: ExpoSpec {
         expect(result.kind) == .string
         expect(result.getString()) == "Test"
       }
-      
+
       it("returns an Array of SharedObjects (async)") {
         try runtime
           .eval(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-modules-core",
-  "version": "3.0.18",
+  "version": "3.0.20",
   "description": "The core of Expo Modules architecture",
   "main": "src/index.ts",
   "types": "build/index.d.ts",
@@ -65,5 +65,5 @@
     "@testing-library/react-native": "^13.2.0",
     "expo-module-scripts": "^5.0.7"
   },
-  "gitHead": "6523053d0d997d2a21f580d2752b2f873c122038"
+  "gitHead": "73d9bc0ee4f1e28cfda349dc36ee53d16fad0c5d"
 }

package/src/hooks/useReleasingSharedObject.ts

@@ -26,18 +26,20 @@ export function useReleasingSharedObject<TSharedObject extends SharedObject>(
       dependencies.every((value, index) => value === previousDependencies.current[index]);
 
     // If the dependencies have changed, release the previous object and create a new one, otherwise this has been called
-    // because of a fast refresh, and we don't want to release the object.
+    // because of an unrelated fast refresh, and we don't want to release the object.
     if (!newObject || !dependenciesAreEqual) {
       objectRef.current?.release();
       newObject = factory();
       objectRef.current = newObject;
       previousDependencies.current = dependencies;
-    } else {
-      isFastRefresh.current = true;
     }
     return newObject;
   }, dependencies);
 
+  useMemo(() => {
+    isFastRefresh.current = true;
+  }, []);
+
   useEffect(() => {
     isFastRefresh.current = false;