expo-modules-core 1.2.6 → 1.2.7

package/CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### 💡 Others
 
+## 1.2.7 — 2023-05-03
+
+### 🐛 Bug fixes
+
+- [Android] Improve the initial loading speed of the native view. ([#22153](https://github.com/expo/expo/pull/22153) by [@lukmccall](https://github.com/lukmccall))
+
 ## 1.2.6 — 2023-03-20
 
 ### 🐛 Bug fixes

package/android/build.gradle

@@ -6,7 +6,7 @@ apply plugin: 'maven-publish'
 apply plugin: "de.undercouch.download"
 
 group = 'host.exp.exponent'
-version = '1.2.6'
+version = '1.2.7'
 
 buildscript {
   def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
@@ -173,7 +173,7 @@ android {
     targetSdkVersion safeExtGet("targetSdkVersion", 33)
     consumerProguardFiles 'proguard-rules.pro'
     versionCode 1
-    versionName "1.2.6"
+    versionName "1.2.7"
     buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled.toString()
 
     testInstrumentationRunner "expo.modules.TestRunner"

package/android/src/main/java/expo/modules/kotlin/AppContext.kt

@@ -68,6 +68,15 @@ class AppContext(
     .looper.let { Handler(it) }
     .asCoroutineDispatcher()
 
+  /**
+   * A scope used to dispatch all background work.
+   */
+  val backgroundCoroutineScope = CoroutineScope(
+    Dispatchers.IO +
+      SupervisorJob() +
+      CoroutineName("expo.modules.BackgroundCoroutineScope")
+  )
+
   /**
    * A queue used to dispatch all async methods that are called via JSI.
    */
@@ -265,6 +274,7 @@ class AppContext(
     registry.cleanUp()
     modulesQueue.cancel(ContextDestroyedException())
     mainQueue.cancel(ContextDestroyedException())
+    backgroundCoroutineScope.cancel(ContextDestroyedException())
     logger.info("✅ AppContext was destroyed")
   }
 

package/android/src/main/java/expo/modules/kotlin/ModuleHolder.kt

@@ -1,5 +1,6 @@
 package expo.modules.kotlin
 
+import android.view.View
 import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.ReadableArray
 import expo.modules.kotlin.events.BasicEventListener
@@ -12,6 +13,7 @@ import expo.modules.kotlin.exception.exceptionDecorator
 import expo.modules.kotlin.jni.JavaScriptModuleObject
 import expo.modules.kotlin.modules.Module
 import kotlinx.coroutines.launch
+import kotlin.reflect.KClass
 
 class ModuleHolder(val module: Module) {
   val definition = module.definition()
@@ -93,4 +95,8 @@ class ModuleHolder(val module: Module) {
   fun cleanUp() {
     module.cleanUp()
   }
+
+  fun viewClass(): KClass<out View>? {
+    return definition.viewManagerDefinition?.viewType?.kotlin
+  }
 }

package/android/src/main/java/expo/modules/kotlin/ModuleRegistry.kt

@@ -6,7 +6,9 @@ import kotlinx.coroutines.CoroutineName
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.SupervisorJob
+import kotlinx.coroutines.launch
 import java.lang.ref.WeakReference
+import kotlin.reflect.full.declaredMemberProperties
 
 class ModuleRegistry(
   private val appContext: WeakReference<AppContext>
@@ -26,6 +28,17 @@ class ModuleRegistry(
     }
     holder.post(EventName.MODULE_CREATE)
     holder.registerContracts()
+    // The initial invocation of `declaredMemberProperties` appears to be slow,
+    // as Kotlin must deserialize metadata internally.
+    // This is a known issue that may be resolved by the new K2 compiler in the future.
+    // However, until then, we must find a way to address this problem.
+    // Therefore, we have decided to dispatch a lambda
+    // that invokes `declaredMemberProperties` during module creation.
+    holder.viewClass()?.let { viewType ->
+      appContext.get()?.backgroundCoroutineScope?.launch {
+        viewType.declaredMemberProperties
+      }
+    }
     registry[holder.name] = holder
   }
 

package/android/src/main/java/expo/modules/kotlin/functions/AnyFunction.kt

@@ -1,7 +1,6 @@
 package expo.modules.kotlin.functions
 
 import com.facebook.react.bridge.ReadableArray
-import com.facebook.react.bridge.ReadableType
 import expo.modules.kotlin.AppContext
 import expo.modules.kotlin.exception.ArgumentCastException
 import expo.modules.kotlin.exception.CodedException

package/android/src/main/java/expo/modules/kotlin/views/ViewManagerDefinition.kt

@@ -16,7 +16,7 @@ import expo.modules.kotlin.recycle
 
 class ViewManagerDefinition(
   private val viewFactory: (Context, AppContext) -> View,
-  private val viewType: Class<out View>,
+  internal val viewType: Class<out View>,
   private val props: Map<String, AnyViewProp>,
   val onViewDestroys: ((View) -> Unit)? = null,
   val callbacksDefinition: CallbacksDefinition? = null,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "expo-modules-core",
-  "version": "1.2.6",
+  "version": "1.2.7",
   "description": "The core of Expo Modules architecture",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -42,5 +42,5 @@
     "@testing-library/react-hooks": "^7.0.1",
     "expo-module-scripts": "^3.0.0"
   },
-  "gitHead": "eaf0d87f56e17cb7162ccbd4f9ee29fb64dab810"
+  "gitHead": "f5076c4ff6cf352b5fd8e528533a377167fa4edb"
 }