npm - expo-modules-core - Versions diffs - 1.2.2 → 1.2.4 - Mend

@@ -10,6 +10,19 @@
 ### 💡 Others
+## 1.2.4 — 2023-03-03
+### 🐛 Bug fixes
+- [iOS] Fixed jsc import when using use_frameworks ([#21479](https://github.com/expo/expo/pull/21479) by [@gabrieldonadel](https://github.com/gabrieldonadel))
+## 1.2.3 — 2023-02-21
+### 🐛 Bug fixes
+- [iOS] Fixed URI with encoded `#` getting cut off. ([#21326](https://github.com/expo/expo/pull/21326) by [@lukmccall](https://github.com/lukmccall))
+- [Android] Fail gracefully when the view cannot be constructed due to the missing activity. ([#21328](https://github.com/expo/expo/pull/21328) by [@lukmccall](https://github.com/lukmccall))
 ## 1.2.2 — 2023-02-14
 ### 🐛 Bug fixes

@@ -6,7 +6,7 @@ apply plugin: 'maven-publish'
 apply plugin: "de.undercouch.download"
 group = 'host.exp.exponent'
-version = '1.2.2'
+version = '1.2.4'
 buildscript {
   def expoModulesCorePlugin = new File(project(":expo-modules-core").projectDir.absolutePath, "ExpoModulesCorePlugin.gradle")
@@ -173,7 +173,7 @@ android {
     targetSdkVersion safeExtGet("targetSdkVersion", 33)
     consumerProguardFiles 'proguard-rules.pro'
     versionCode 1
-    versionName "1.2.2"
+    versionName "1.2.4"
     buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled.toString()
     testInstrumentationRunner "expo.modules.TestRunner"

@@ -4,9 +4,12 @@
 package expo.modules.kotlin.views
 import android.content.Context
+import android.util.Log
 import android.view.View
 import android.view.ViewGroup
 import expo.modules.kotlin.AppContext
+import expo.modules.kotlin.exception.CodedException
+import expo.modules.kotlin.exception.UnexpectedException
 import expo.modules.kotlin.modules.DefinitionMarker
 import expo.modules.kotlin.types.toAnyType
 import kotlin.reflect.KClass
@@ -147,7 +150,11 @@ class ViewDefinitionBuilder<T : View>(@PublishedApi internal val viewType: KClas
     // Backward compatibility
     if (args.size == 1) {
-      return@viewFactory primaryConstructor.call(context)
+      return@viewFactory try {
+        primaryConstructor.call(context)
+      } catch (e: Throwable) {
+        handleFailureDuringViewCreation(context, appContext, e)
+      }
     }
     val secondArgType = args[1].type
@@ -159,7 +166,24 @@ class ViewDefinitionBuilder<T : View>(@PublishedApi internal val viewType: KClas
       throw IllegalStateException("Android view has more constructor arguments than expected.")
     }
-    return@viewFactory primaryConstructor.call(context, appContext)
+    return@viewFactory try {
+      primaryConstructor.call(context, appContext)
+    } catch (e: Throwable) {
+      handleFailureDuringViewCreation(context, appContext, e)
+    }
+  }
+  private fun handleFailureDuringViewCreation(context: Context, appContext: AppContext, e: Throwable): View {
+    Log.e("ExpoModulesCore", "Couldn't create view of type $viewType", e)
+    appContext.errorManager?.reportExceptionToLogBox(
+      if (e is CodedException) {
+        e
+      } else {
+        UnexpectedException(e)
+      }
+    )
+    return View(context)
   }
   private fun getPrimaryConstructor(): KFunction<T>? {

	@@ -0,0 +1 @@
1	+ o/jetified-expo-modules-core$android-annotation-1.1.1.jar

	@@ -0,0 +1 @@
1	+ /Users/kudo/01_Work/Repos/expo/expo/packages/expo-modules-core/android-annotation/build/classes/kotlin/main/expo/modules/annotation/Config.class:/Users/kudo/01_Work/Repos/expo/expo/packages/expo-modules-core/android-annotation/build/classes/kotlin/main/expo/modules/annotation/ConverterBinder.class

	@@ -0,0 +1 @@
1	+ o/empty

	@@ -0,0 +1 @@
1	+ o/empty

	@@ -0,0 +1 @@
1	+ o/main

	@@ -0,0 +1 @@
1	+ o/empty

expo-modules-core 1.2.2 → 1.2.4